What is _VC_CRT_NAJOR_VERSION? Is it misprint or a hack? Google gives zero
results.
-- Andrey Khalyavin
On Thu, Feb 16, 2017 at 6:47 PM, Saleem Abdulrasool via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: compnerd
> Date: Thu Feb 16 09:47:50 2017
> New Revision: 295330
>
> URL: htt
halyavin added a subscriber: halyavin.
Comment at: libcxx/include/atomic_support.h:1
@@ +1,2 @@
+//===--===
+//
Non-standard include files in the main include directory must start with __ to
halyavin added a comment.
False alarm. I figured out that only -Wattributes warnings ignore gcc
system_header pragma. So this -Wcast-qual and other warnings doesn't block us.
https://reviews.llvm.org/D23831
___
cfe-commits mailing list
cfe-commits@
halyavin added a comment.
> ! In https://reviews.llvm.org/D23831#528668, @EricWF wrote:
>
> Are you also compiling with `-D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER`?
No. Libc++ buildbots doesn't set this option either and we do see warnings
there. So the pragma doesn't help with compiling libc++
halyavin added a comment.
We have libc++ in our source tree and compile it as part of our build process.
All code in the source tree uses -Werror by default, so I am having compile
errors on gcc 4.9.
https://reviews.llvm.org/D23831
___
cfe-commits
halyavin added a comment.
Thank you for fixing most of warnings. Now it says "cc1plus: warning:
unrecognized command line option "-Wno-c++14-compat"" though.
https://reviews.llvm.org/D23831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
halyavin added a comment.
ping.
https://reviews.llvm.org/D23831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
halyavin created this revision.
halyavin added reviewers: cfe-commits, EricWF, mclow.lists.
C-style cast from const pointer to non-const pointer causes -Wcast-qual warning
in gcc. Fix the problem by casting away const with const_cast. Additionally,
replace C-style cast with appropriate C++-style
