This revision was automatically updated to reflect the committed changes.
Closed by commit rL312524: [AMDGPU] Implement infrastructure to set options in
AMDGPUToolChain (authored by kasaurov).
Changed prior to commit:
https://reviews.llvm.org/D37386?vs=113780&id=113825#toc
Repository:
rL LLV
kasaurov updated this revision to Diff 113780.
kasaurov added a comment.
Test added to check passing of -On/default
https://reviews.llvm.org/D37386
Files:
lib/Driver/ToolChains/AMDGPU.cpp
lib/Driver/ToolChains/AMDGPU.h
test/Driver/amdgpu-toolchain-opencl.cl
Index: test/Driver/amdgpu-tool
kasaurov added inline comments.
Comment at: lib/Driver/ToolChains/AMDGPU.h:60
bool IsIntegratedAssemblerDefault() const override { return true; }
+ llvm::opt::DerivedArgList *
+ TranslateArgs(const llvm::opt::DerivedArgList &Args, StringRef BoundArch,
emanko
kasaurov updated this revision to Diff 113767.
kasaurov added a comment.
Several requested changes:
- move map initialization out of header file -- visually it looks better in .h
file, but logically it should be in .cpp
- add assert() in getOptionDefault() -- check for unknown to OptionsDefault
kasaurov created this revision.
Herald added subscribers: t-tye, Anastasia, tpr, dstuttard, nhaehnle, wdng,
kzhuravl.
In current OpenCL implementation some options are set in OpenCL RT/Driver,
which causes discrepancy between online and offline paths.
Implement infrastructure to move options fr
