AndreyChurbanov added inline comments.
Comment at: openmp/runtime/src/dllexports:553
+omp_get_interop_ptr 761
+omp_get_interop_str 762
mstorsjo wrote:
> mstorsjo wrote:
> > jdoerfert wrote:
> > > Those values are
This revision was automatically updated to reflect the committed changes.
Closed by commit rG610fea65e296: [OpenMP] libomp: fixed implementation of OMP
5.1 inoutset task dependence type (authored by AndreyChurbanov).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
AndreyChurbanov updated this revision to Diff 352010.
AndreyChurbanov added a comment.
Fixed backwards compatibility problem introduced by previous version of the
patch.
That is restored the size of task dependence flag to 8 bits in clang, and
instead changed the size of the flag in the library
AndreyChurbanov added inline comments.
Comment at: openmp/runtime/src/kmp_taskdeps.cpp:418
if (dep_list[i].base_addr != 0) {
+ KMP_DEBUG_ASSERT(
+ dep_list[i].flag == KMP_DEP_IN || dep_list[i].flag == KMP_DEP_OUT ||
protze.joachim wrote:
> I hi
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa1f550e05254: [OpenMP] libomp: implement OpenMP 5.1 inoutset
task dependence type (authored by AndreyChurbanov).
Repository:
rG LLVM Github Monore
AndreyChurbanov added inline comments.
Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346
+// link node as successor of all nodes in the prev_set if any
+npredecessors +=
+__kmp_depnode_link_successor(gtid, thread, task, node, prev_set);
-
AndreyChurbanov added inline comments.
Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346
+// link node as successor of all nodes in the prev_set if any
+npredecessors +=
+__kmp_depnode_link_successor(gtid, thread, task, node, prev_set);
-
AndreyChurbanov updated this revision to Diff 346071.
AndreyChurbanov added a comment.
rebased
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97085/new/
https://reviews.llvm.org/D97085
Files:
clang/lib/CodeGen/CGOpenMPRuntime.cpp
clang/test/OpenMP/depobj_codegen.cpp
clang/test/Ope
AndreyChurbanov updated this revision to Diff 345173.
AndreyChurbanov added a comment.
Fixed one more codegen test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97085/new/
https://reviews.llvm.org/D97085
Files:
clang/lib/CodeGen/CGOpenMPRuntime
AndreyChurbanov updated this revision to Diff 344939.
AndreyChurbanov added a comment.
Addressed review comments.
Fixed tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97085/new/
https://reviews.llvm.org/D97085
Files:
clang/lib/CodeGen/CGOp
AndreyChurbanov updated this revision to Diff 329461.
AndreyChurbanov added a comment.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Changed the size of task dependences flags from 8 bit to 32 bit, so that
runtime does not get garbage data in unused bits of the structure,
AndreyChurbanov added inline comments.
Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100
th_counter[i] = 0;
-#pragma omp parallel num_threads(N)
+#pragma omp parallel // num_threads(N)
{
jhuber6 wrote:
> jhuber6 wrote:
> > jdoerfert
AndreyChurbanov added a comment.
In https://reviews.llvm.org/D51331#1216509, @ABataev wrote:
> When is ITT Notify used? Does it have some preconditions like debug info,
> some optimizations level etc.?
The libittnotify library is used by Intel tools (VTune Amplifier, Inspector,
Spatial Adviso
13 matches
Mail list logo