andreybokhanko added a comment.
Fix committed in
https://reviews.llvm.org/rG16501782c8d849bc1812d527dc8466574700663d. Thanks for
working on this!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81825/new/
https://reviews.llvm.org/D81825
This revision was automatically updated to reflect the committed changes.
Closed by commit rG16501782c8d8: [Clang] Add support for
-Wno-inline-namespace-reopened-noninline (authored by Elvina, committed by
andreybokhanko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:
andreybokhanko added a comment.
Hi Roger,
I'm very glad to see you started to work on this!
A somewhat obvious comment: no chance for this to be accepted without LIT
tests. I understand you have your doubts on the best approach to testing -- and
it's OK to ask either here or on llvm-dev -- but