[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

2021-12-15 Thread Andrew Smith via Phabricator via cfe-commits
Andrew-William-Smith added a comment. I'm going to assume that I don't have commit access to `main`, so that would be much appreciated. - Name: Andrew Smith - Email: aws awsmith us Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/new/ https

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

2021-12-15 Thread Andrew Smith via Phabricator via cfe-commits
Andrew-William-Smith updated this revision to Diff 394584. Andrew-William-Smith added a comment. Apologies, I undid the actual changes to `ClangFormat.cpp`. Still learning how to use `arc`... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115769/ne

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

2021-12-15 Thread Andrew Smith via Phabricator via cfe-commits
Andrew-William-Smith updated this revision to Diff 394582. Andrew-William-Smith added a comment. Added a test with formatting disabled. I had to port the updated logic from `ClangFormat.cpp` into `FormatTestJson::format` to show the desired effect; I also couldn't call `verifyFormat` as-is with

[PATCH] D115769: [clang-format] Remove spurious JSON binding when DisableFormat = true

2021-12-14 Thread Andrew Smith via Phabricator via cfe-commits
Andrew-William-Smith created this revision. Andrew-William-Smith added reviewers: MyDeveloperDay, HazardyKnusperkeks, jbcoe. Andrew-William-Smith edited the summary of this revision. Andrew-William-Smith added a project: clang-format. Andrew-William-Smith retitled this revision from "[clang-format]