Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-07-19 Thread Andrew Paprocki via cfe-commits
apaprocki updated this revision to Diff 64518. apaprocki added a comment. Increased context and removed accidental inclusion of Solaris change. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driv

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-07-18 Thread Andrew Paprocki via cfe-commits
apaprocki updated this revision to Diff 64376. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h tools/libclang/CIndexer.cpp Index: tools/libclang/CIndexer.cpp

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-07-18 Thread Andrew Paprocki via cfe-commits
apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > apaprocki wrote: > > majnemer wrote: > >

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-07-18 Thread Andrew Paprocki via cfe-commits
apaprocki added inline comments. Comment at: lib/Basic/Targets.cpp:718 @@ +717,3 @@ +Builder.defineMacro("_LONG_LONG"); +Builder.defineMacro("_ALL_SOURCE"); +Builder.defineMacro("_REENTRANT"); majnemer wrote: > Are we really supposed to define this mac

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-07-18 Thread Andrew Paprocki via cfe-commits
apaprocki added a comment. (I also re-based the patch on top of `trunk`) https://reviews.llvm.org/D18360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-07-18 Thread Andrew Paprocki via cfe-commits
apaprocki updated this revision to Diff 64328. apaprocki added a comment. Fixed `wchar_t` type. https://reviews.llvm.org/D18360 Files: lib/Basic/Targets.cpp lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp lib/Driver/Tools.h tools/libcla

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-03-22 Thread Andrew Paprocki via cfe-commits
apaprocki created this revision. apaprocki added a subscriber: cfe-commits. This patch adds Clang driver support for the AIX platform. This allows Clang to be used for compiling code / checking for errors, but does not allow for building executables, as AIX uses XCOFF and not ELF. After applyi