[PATCH] D59048: Add AIX Target Info

2019-03-06 Thread Andrew Paprocki via Phabricator via cfe-commits
apaprocki added inline comments. Comment at: clang/lib/Basic/Targets/OSTargets.h:626 + +// FIXME: Define AIX OS-Version Macros +Builder.defineMacro("_AIX"); hubert.reinterpretcast wrote: > Comments should be full sentences (with periods). Please updat

[PATCH] D58930: Add XCOFF triple object format type for AIX

2019-03-05 Thread Andrew Paprocki via Phabricator via cfe-commits
apaprocki added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2079 + if (log) +log->Printf("sorry: unimplemented for XCOFF"); + return false; No need to be `sorry:` :) This shou

[PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2019-02-21 Thread Andrew Paprocki via Phabricator via cfe-commits
apaprocki added a comment. @hubert.reinterpretcast Yes, this patch is available under the new license. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D18360/new/ https://reviews.llvm.org/D18360 ___ cfe-commits mailing list cfe-commits@lists.l