[PATCH] D142224: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b704d9db7e1: [Support] Emulate SIGPIPE handling in raw_fd_ostream write for Windows (authored by andrewng). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D142228: [clangd] Disable tests that are incompatible with Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG2493a7016416: [clangd] Disable tests that are incompatible with Windows (authored by andrewng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142228/new/ ht

[PATCH] D142228: [clangd] Disable tests that are incompatible with Windows

andrewng created this revision. andrewng added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. andrewng requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These tests e

[PATCH] D131665: [CMake] Support passing arguments to build tool (bootstrap).

andrewng resigned from this revision. andrewng added a comment. Resign as reviewer as I also work with Carlos and helped to author this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131665/new/ https://reviews.llvm.org/D131665 _

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

andrewng added a comment. In D118996#3712493 , @balazske wrote: > In D118996#3712218 , @RKSimon wrote: > >> @balazske This is failing on >> https://lab.llvm.org/buildbot/#/builders/139/builds/26335 - do you have

[PATCH] D124683: [analyzer] Fix return of llvm::StringRef to destroyed std::string

This revision was automatically updated to reflect the committed changes. Closed by commit rG57c55165ebe8: [analyzer] Fix return of llvm::StringRef to destroyed std::string (authored by andrewng). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

andrewng added a comment. In D77184#1960437 , @thakis wrote: > grimar, andrewng: You both have checkout and build on different drives too, > yes? Sorry for not replying earlier. Yes, for most of my setups I have the source checkout on one drive and bui

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

andrewng added a comment. The following patch fixes my issues on Windows, but I haven't tested that it doesn't break anything else: diff --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake index 91bec7d8081..f630af211fd 100644 --- a/llvm/cmake/modules/AddLLVM.cmake

[PATCH] D34853: Fix (benignly) incorrect GoogleTest specs in various lit configs.

andrewng added a comment. Hi, I believe that this "build mode" is intended for the Visual Studio MSVC build. This build is special in that it can produce builds for multiple configurations, e.g. Debug, Release & RelWithDebInfo, within the same top level build output directory. It is this confi