[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. Compiler infrastructure should not assume the existence of a Linux distribution. The portable way is simple and can easily be supported. One should be able to install `$prefix/lib/libzstd.a` and `$prefix/include/zstd.h`, then have that prefix searched as part of the st

[PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

andrewrk added a comment. if(LLVM_ENABLE_ZSTD) list(APPEND imported_libs zstd::libzstd_shared) endif() This hard codes shared linking which breaks the use case of static linking LLVM. Also LLVM needs to now include a Findzstd.cmake file or else we get this error: CMake Error at cmake/

[PATCH] D78658: [clang][Frontend] Add missing error handling

andrewrk accepted this revision. andrewrk added a comment. This revision is now accepted and ready to land. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commit

[PATCH] D67455: [Clang][CodeGen] support alias attribute w/ gnu_inline

andrewrk requested changes to this revision. andrewrk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/Decl.cpp:3352 + assert((doesThisDeclarationHaveABody() || willHaveBody()) || + hasAttr() && "Must be a function definitio

[PATCH] D58204: CMake: Fix stand-alone clang builds since r353268

andrewrk accepted this revision. andrewrk added a comment. I confirm this solves the issue. Comment at: llvm/cmake/modules/AddLLVM.cmake:1739 execute_process(COMMAND ${GIT_EXECUTABLE} rev-parse --git-dir WORKING_DIRECTORY ${path} RESULT_VARIABLE git_res

[PATCH] D51265: Headers: fix collisions with .h files of other projects

andrewrk marked an inline comment as done. andrewrk added a comment. In https://reviews.llvm.org/D51265#1215060, @efriedma wrote: > What is this change actually solving? Even if the typedef is actually > redundant, it shouldn't cause a compiler error: redundant typedefs are > allowed in the la

[PATCH] D51265: Headers: fix collisions with .h files of other projects

andrewrk updated this revision to Diff 162574. andrewrk added a comment. Addressed review feedback Repository: rC Clang https://reviews.llvm.org/D51265 Files: lib/Headers/stdarg.h lib/Headers/stddef.h Index: lib/Headers/stddef.h =

[PATCH] D51265: Headers: fix collisions with .h files of other projects

andrewrk created this revision. andrewrk added reviewers: eli.friedman, krememek, ddunbar, lattner. andrewrk added a project: clang. Herald added a subscriber: cfe-commits. stdarg.h: - va_list - macos _va_list.h was duplicately defining va_list. Fixed by this ifndef _VA_LIST_T - additionally def