[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/7] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-28 Thread Amr Hesham via cfe-commits
@@ -0,0 +1,11 @@ +// RUN: cir-opt %s -verify-diagnostics -split-input-file + +!s32i = !cir.int AmrDeveloper wrote: Nice, thats better, i think i will do this with Vector too in next PR's https://github.com/llvm/llvm-project/pull/141369 __

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/6] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/5] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-28 Thread Amr Hesham via cfe-commits
@@ -577,12 +577,31 @@ mlir::Attribute ConstantEmitter::tryEmitPrivate(const APValue &value, case APValue::Union: cgm.errorNYI("ConstExprEmitter::tryEmitPrivate struct or union"); return {}; - case APValue::FixedPoint: case APValue::ComplexInt: - case APValue::Co

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/14 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream ShuffleDynamicOp for VectorType (PR #141411)

2025-05-28 Thread Amr Hesham via cfe-commits
@@ -1548,6 +1548,20 @@ OpFoldResult cir::VecExtractOp::fold(FoldAdaptor adaptor) { return elements[index]; } +//===--===// +// VecShuffleDynamicOp +//===-

[clang] [CIR] Upstream ShuffleDynamicOp for VectorType (PR #141411)

2025-05-28 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141411 >From 12295ee3a5613d7473ab33a4579015a2217617a0 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sun, 25 May 2025 17:21:34 +0200 Subject: [PATCH 1/2] [CIR] Upstream ShuffleDynamicOp for VectorType --- cla

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-28 Thread Amr Hesham via cfe-commits
@@ -1427,13 +1427,13 @@ OpFoldResult cir::SelectOp::fold(FoldAdaptor adaptor) { //===--===// LogicalResult cir::ShiftOp::verify() { mlir::Operation *op = getOperation(); - mlir::Type resType = getResult().g

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-27 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/4] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-27 Thread Amr Hesham via cfe-commits
@@ -385,6 +385,13 @@ mlir::Type CIRGenTypes::convertType(QualType type) { break; } + case Type::Complex: { +const ComplexType *ct = cast(ty); +mlir::Type elementTy = convertType(ct->getElementType()); AmrDeveloper wrote: Thanks for your comment

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-25 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/3] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR] Upstream ShuffleDynamicOp for VectorType (PR #141411)

2025-05-25 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: There will be a follow-up PR for folding https://github.com/llvm/llvm-project/pull/141411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream ShuffleDynamicOp for VectorType (PR #141411)

2025-05-25 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/141411 This change adds support for the Dynamic Shuffle op for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 >From 12295ee3a5613d7473ab33a4579015a2217617a0 Mon Sep 17 00:00:00 2001 From: Amr

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-25 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/141369 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 Subject: [PATCH 1/2] [CIR] Upstream global initialization for ComplexType --

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-24 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/141369 This change adds support for zero and global init for ComplexType #141365 >From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 24 May 2025 14:18:06 +0200 S

[clang] [CIR] Upstream global initialization for ComplexType (PR #141369)

2025-05-24 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: - This PR has implementation for the global init Complex value. I will backport it to the incubator once it is merged. - Not totally sure if it's good idea or not to rename it to `ConstComplexAttr` similar to Const Array, Vector and Record, We can discuss it 馃憤馃徎 https://gi

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-24 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/14 >From 05ef5317602f61debe9a4d853e61a7e508a5a00d Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 22 May 2025 19:38:08 +0200 Subject: [PATCH 1/5] [CIR] Allow use different Int types together in Vec Shif

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-23 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/14 >From 875db6ee30e8075be50914f62a508511157e8a6f Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 22 May 2025 19:38:08 +0200 Subject: [PATCH 1/4] [CIR] Allow use different Int types together in Vec Shif

[clang] [CIR] Upstream comparison ops for VectorType (PR #140597)

2025-05-23 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/140597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-23 Thread Amr Hesham via cfe-commits
@@ -1427,13 +1427,13 @@ OpFoldResult cir::SelectOp::fold(FoldAdaptor adaptor) { //===--===// LogicalResult cir::ShiftOp::verify() { mlir::Operation *op = getOperation(); - mlir::Type resType = getResult().g

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-23 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/14 >From 2a56a5d8db006bd466db00989806d548ce042b37 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 22 May 2025 19:38:08 +0200 Subject: [PATCH 1/3] [CIR] Allow use different Int types together in Vec Shif

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-23 Thread Amr Hesham via cfe-commits
@@ -1427,13 +1427,13 @@ OpFoldResult cir::SelectOp::fold(FoldAdaptor adaptor) { //===--===// LogicalResult cir::ShiftOp::verify() { mlir::Operation *op = getOperation(); - mlir::Type resType = getResult().g

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-22 Thread Amr Hesham via cfe-commits
@@ -1427,12 +1427,12 @@ OpFoldResult cir::SelectOp::fold(FoldAdaptor adaptor) { //===--===// LogicalResult cir::ShiftOp::verify() { mlir::Operation *op = getOperation(); - mlir::Type resType = getResult().g

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-22 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/14 >From 2a56a5d8db006bd466db00989806d548ce042b37 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 22 May 2025 19:38:08 +0200 Subject: [PATCH 1/2] [CIR] Allow use different Int types together in Vec Shif

[clang] [CIR] Allow use different Int types together in Vec Shift Op (PR #141111)

2025-05-22 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/14 Update the verification of ShiftOp for Vector to allow performing shift op between signed and unsigned integers, similar to LLVM IR Issue https://github.com/llvm/llvm-project/issues/136487 >From 2a56a5d8d

[clang] [Clang] Improve testing of non std functions with name infinity (PR #123806)

2025-05-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/123806 >From 38031e9aed519f4fd3b21dff7e79c69a0150efd9 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 21 Jan 2025 20:11:21 +0100 Subject: [PATCH] [Clang] Improve testing of non std functions with name infi

[clang] [CIR][LLVMLowering] Upstream Bitcast lowering (PR #140774)

2025-05-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/140774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Fix an unused variable warning (PR #140783)

2025-05-21 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/140783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream comparison ops for VectorType (PR #140597)

2025-05-20 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: - Test cases for Unsigned and FP will be added after merging: https://github.com/llvm/llvm-project/pull/140774 - There will be a follow-up PR for folding https://github.com/llvm/llvm-project/pull/140597 ___ cfe-commits mailing list

[clang] [CIR] Upstream comparison ops for VectorType (PR #140597)

2025-05-20 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140597 >From e43d04b1eb1660dcf1a99d405858efd3a9647657 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sun, 18 May 2025 21:14:03 +0200 Subject: [PATCH 1/2] [CIR] Upstream comparion ops for VectorType --- clang/

[clang] [CIR][LLVMLowering] Upstream Bitcast lowering (PR #140774)

2025-05-20 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/140774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][LLVMLowering] Upstream Bitcast (PR #140774)

2025-05-20 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/140774 This change adds support for lowering BitCastOp >From 5e5676c1e3efe38bceb09ca90a4e4b7500cbb6e8 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Tue, 20 May 2025 19:29:32 +0200 Subject: [PATCH] [CIR][LL

[clang] [CIR] Upstream comparison ops for VectorType (PR #140597)

2025-05-20 Thread Amr Hesham via cfe-commits
@@ -587,3 +587,118 @@ void foo11() { // OGCG: %[[TMP_B:.*]] = load <4 x i32>, ptr %[[VEC_B]], align 16 // OGCG: %[[XOR:.*]] = xor <4 x i32> %[[TMP_A]], %[[TMP_B]] // OGCG: store <4 x i32> %[[XOR]], ptr {{.*}}, align 16 + +void foo12() { AmrDeveloper wrote: Uns

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-20 Thread Amr Hesham via cfe-commits
@@ -135,4 +135,38 @@ cir.func @vector_insert_element_test() { // CHECK:cir.return // CHECK: } +cir.func @vector_splat_test() { +%0 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["a", init] +%1 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["shl", init] +

[clang] [CIR] Upstream comparion ops for VectorType (PR #140597)

2025-05-19 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/140597 This change adds support for Cmp ops for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 >From e43d04b1eb1660dcf1a99d405858efd3a9647657 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-19 Thread Amr Hesham via cfe-commits
@@ -135,4 +135,38 @@ cir.func @vector_insert_element_test() { // CHECK:cir.return // CHECK: } +cir.func @vector_splat_test() { +%0 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["a", init] +%1 = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["shl", init] +

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-19 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/140099 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-19 Thread Amr Hesham via cfe-commits
@@ -2037,4 +2037,37 @@ def VecExtractOp : CIR_Op<"vec.extract", [Pure, let hasFolder = 1; } + +//===--===// +// VecSplat +//===--===// + +/

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-18 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140099 >From ab09038c757369b0ecc6c968bb50debdc024b1ce Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Wed, 14 May 2025 22:25:09 +0200 Subject: [PATCH 1/3] [CIR][LLVMLowering] Upstream binary operators for Vecto

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-18 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140099 >From ab09038c757369b0ecc6c968bb50debdc024b1ce Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Wed, 14 May 2025 22:25:09 +0200 Subject: [PATCH 1/3] [CIR][LLVMLowering] Upstream binary operators for Vecto

[clang] [CIR][LLVMLowering] Upstream unary operators for VectorType (PR #139444)

2025-05-18 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/139444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-16 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140099 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR] Fix using getElementType (PR #140177)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/140177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Fix using getElementType (PR #140177)

2025-05-15 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: I will quickly merge it as a fix for the previous elementTypeIfVector PR to make it buildable https://github.com/llvm/llvm-project/pull/140177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [CIR] Fix using getElementType (PR #140177)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/140177 Fix for elementTypeIfVector Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFon

[clang] [CIR][LLVMLowering] Upstream unary operators for VectorType (PR #139444)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/139444 >From 46d3b466df954eee87a5e5e7df5cb03802d468c7 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 10 May 2025 20:37:05 +0200 Subject: [PATCH 1/2] [CIR] Upstream unary operators for VectorType --- .../

[clang] [CIR] Upstream Vector support in elementTypeIfVector (PR #140125)

2025-05-15 Thread Amr Hesham via cfe-commits
@@ -54,10 +54,12 @@ namespace direct { namespace { /// If the given type is a vector type, return the vector's element type. /// Otherwise return the given type unchanged. -// TODO(cir): Return the vector element type once we have support for vectors -// instead of the identity

[clang] [CIR] Upstream Vector support in elementTypeIfVector (PR #140125)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140125 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR] Upstream Vector support in elementTypeIfVector (PR #140125)

2025-05-15 Thread Amr Hesham via cfe-commits
@@ -54,10 +54,12 @@ namespace direct { namespace { /// If the given type is a vector type, return the vector's element type. /// Otherwise return the given type unchanged. -// TODO(cir): Return the vector element type once we have support for vectors -// instead of the identity

[clang] [CIR] Upstream Vector support in elementTypeIfVector (PR #140125)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140125 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/140099 >From de3e5aa6af44a082060ad0edc8ba9bf213b0fba5 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Wed, 14 May 2025 22:25:09 +0200 Subject: [PATCH 1/2] [CIR][LLVMLowering] Upstream binary operators for Vecto

[clang] [CIR][LLVMLowering] Upstream unary operators for VectorType (PR #139444)

2025-05-15 Thread Amr Hesham via cfe-commits
@@ -1076,20 +1074,41 @@ mlir::LogicalResult CIRToLLVMUnaryOpLowering::matchAndRewrite( rewriter.replaceOp(op, adaptor.getInput()); return mlir::success(); case cir::UnaryOpKind::Minus: { - assert(!isVector && - "Add vector handling when vector

[clang] [CIR] Upstream Vector support in elementTypeIfVector (PR #140125)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/140125 Upstream vector support in the element type if vector as a required change for upstreaming other Vec Ops Issue https://github.com/llvm/llvm-project/issues/136487 >From b9f624e508db8349516f909f0c8e9cb85c04

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-15 Thread Amr Hesham via cfe-commits
@@ -400,4 +400,165 @@ void foo9() { // OGCG: %[[TMP_A:.*]] = load <4 x i32>, ptr %[[VEC_A]], align 16 // OGCG: %[[TMP_B:.*]] = load <4 x i32>, ptr %[[VEC_B]], align 16 // OGCG: %[[SHR:.*]] = ashr <4 x i32> %[[TMP_A]], %[[TMP_B]] -// OGCG: store <4 x i32> %[[SHR]], ptr %[[SHR_RE

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-15 Thread Amr Hesham via cfe-commits
@@ -57,7 +57,11 @@ namespace { // TODO(cir): Return the vector element type once we have support for vectors // instead of the identity type. mlir::Type elementTypeIfVector(mlir::Type type) { - assert(!cir::MissingFeatures::vectorType()); + if (auto vecType = mlir::dyn_cast(t

[clang] [CIR][LLVMLowering] Upstream binary operators for VectorType (PR #140099)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/140099 This change adds support for binary ops for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 Rate limit 路 GitHub body { background-color:

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-13 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: More test cases will be added when Bin and Comp operators are upstreamed for Vector https://github.com/llvm/llvm-project/pull/139827 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [CIR] Upstream splat op for VectorType (PR #139827)

2025-05-13 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/139827 This change adds support for splat op for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 >From e9b7f553f7ad8a9167a9aa4a11c86ccdb8472cdd Mon Sep 17 00:00:00 2001 From: AmrDeveloper Dat

[clang] [CIR][LLVMLowering] Upstream unary operators for VectorType (PR #139444)

2025-05-13 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/139444 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-13 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/139465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
@@ -1399,8 +1400,10 @@ mlir::LogicalResult CIRToLLVMShiftOpLowering::matchAndRewrite( if (op.getIsShiftleft()) { rewriter.replaceOpWithNewOp(op, llvmTy, val, amt); } else { -assert(!cir::MissingFeatures::vectorType()); -bool isUnsigned = !cirValTy.isSigned(); +

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/139465 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper deleted https://github.com/llvm/llvm-project/pull/139465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/139465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/139465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
@@ -1399,8 +1400,10 @@ mlir::LogicalResult CIRToLLVMShiftOpLowering::matchAndRewrite( if (op.getIsShiftleft()) { rewriter.replaceOpWithNewOp(op, llvmTy, val, amt); } else { -assert(!cir::MissingFeatures::vectorType()); -bool isUnsigned = !cirValTy.isSigned(); +

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/138592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
@@ -213,3 +213,68 @@ void foo4() { // OGCG: %[[TMP2:.*]] = load i32, ptr %[[IDX]], align 4 // OGCG: %[[ELE:.*]] = extractelement <4 x i32> %[[TMP1]], i32 %[[TMP2]] // OGCG: store i32 %[[ELE]], ptr %[[INIT]], align 4 + +void foo9() { AmrDeveloper wrote: Both of

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-12 Thread Amr Hesham via cfe-commits
@@ -1399,8 +1400,10 @@ mlir::LogicalResult CIRToLLVMShiftOpLowering::matchAndRewrite( if (op.getIsShiftleft()) { rewriter.replaceOpWithNewOp(op, llvmTy, val, amt); } else { -assert(!cir::MissingFeatures::vectorType()); -bool isUnsigned = !cirValTy.isSigned(); +

[clang] [CIR] Upstream insert op for VectorType (PR #139146)

2025-05-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/139146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-12 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138592 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR] Upstream shift operators for VectorType (PR #139465)

2025-05-11 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/139465 This change adds support for shift ops for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 Rate limit 路 GitHub body { background-color: #

[clang] [CIR] Upstream unary operators for VectorType (PR #139444)

2025-05-11 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/139444 This change adds support for unary ops for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 >From 9fd2f92f9122c8c79c4977e00dab93bfaa468787 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Da

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-10 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138592 >From 793bd974b779450a84c72d54237067ab56a59cdc Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Mon, 5 May 2025 23:01:02 +0200 Subject: [PATCH 1/5] [clang][OpenMP] Add error for large expr in collapse ---

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-10 Thread Amr Hesham via cfe-commits
@@ -15901,6 +15901,13 @@ ExprResult SemaOpenMP::VerifyPositiveIntegerConstantInClause( << E->getSourceRange(); return ExprError(); } + + if (!Result.isRepresentableByInt64()) { AmrDeveloper wrote: In our implementation, yes, because we const ev

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-10 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138592 >From 793bd974b779450a84c72d54237067ab56a59cdc Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Mon, 5 May 2025 23:01:02 +0200 Subject: [PATCH 1/4] [clang][OpenMP] Add error for large expr in collapse ---

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-09 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: > Thank you for the fix! I've added a few more reviewers. This is a pretty > general problem, so I think we may want additional test coverage for > basically any of the OpenMP clauses which accept an integer argument. For > example, this is another related issue: #139268 --

[clang] [CIR] Implement foldder for VecExtractOp (PR #139304)

2025-05-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/139304 This change adds a folder for the VecExtractOp Issue https://github.com/llvm/llvm-project/issues/136487 >From 6a21dc2a983094f61a54755454d12c45cf074c9d Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri

[clang] [CIR] Upstream insert op for VectorType (PR #139146)

2025-05-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/139146 >From 11de7d363ae9f06e98f15fc5c492e74a660693f8 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Thu, 8 May 2025 22:10:39 +0200 Subject: [PATCH 1/3] [CIR] Upstream insert op for VectorType --- clang/inclu

[clang] [CIR] Implement folder for VecExtractOp (PR #139304)

2025-05-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/139304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream insert op for VectorType (PR #139146)

2025-05-09 Thread Amr Hesham via cfe-commits
@@ -1969,6 +1969,43 @@ def VecCreateOp : CIR_Op<"vec.create", [Pure]> { let hasVerifier = 1; } +//===--===// +// VecInsertOp +//===--===//

[clang] [CIR] Upstream insert op for VectorType (PR #139146)

2025-05-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/139146 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR] Upstream insert op for VectorType (PR #139146)

2025-05-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/139146 This change adds an insert op for VectorType Issue https://github.com/llvm/llvm-project/issues/136487 Rate limit 路 GitHub body { background-color: #f6f8fa;

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-08 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: > In addition to the collapse clause, the ordered clause also seems to have the > same problem. For example, does your patch also fix the following crash? If > so, you also need tests regarding the ordered clause. > https://godbolt.org/z/96sa5jxff > > ```c++ > void f(void)

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-08 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138592 >From af3e49f1290c61d5856a5ddf600cfd19ef485e25 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Mon, 5 May 2025 23:01:02 +0200 Subject: [PATCH 1/3] [clang][OpenMP] Add error for large expr in collapse ---

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-07 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138592 Rate limit 路 GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-07 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: @bcardosolopes, I think we can finish this PR, and I will continue searching for a test case for folding without blocking upstreaming other Vector Ops. Also, I think the same idea can be applied to Arrays, what do you think? https://github.com/llvm/llvm-project/pull/138413

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-07 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: > > > Overall looks good. While here, can you please implement a folder for > > > this operation? It should kick-in if both idx and input vector are > > > constants. > > > > > > @bcardosolopes I implement it like this snippet > > ``` > > OpFoldResult cir::VecExtractOp::fol

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-07 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138413 >From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 3 May 2025 13:43:04 +0200 Subject: [PATCH 1/3] [CIR] Upstream extract op for VectorType --- clang/incl

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-06 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: > Overall looks good. While here, can you please implement a folder for this > operation? It should kick-in if both idx and input vector are constants. @bcardosolopes I implement it like this snippet ``` OpFoldResult cir::VecExtractOp::fold(FoldAdaptor adaptor) { const au

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/138592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add error for large expr in collapse clause (PR #138592)

2025-05-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper edited https://github.com/llvm/llvm-project/pull/138592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Add error for large expr in SIMD collapse (PR #138592)

2025-05-06 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138592 >From d39464b6a17dd1a2569ba8a899f59f2c577c7e82 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Mon, 5 May 2025 23:01:02 +0200 Subject: [PATCH] [clang][OpenMP] Add error for large expr in collapse --- cl

[clang] [clang][OpenMP] Add error for large expr in SIMD collapse (PR #138592)

2025-05-05 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/138592 Report error when OpenMP SIMD collapse clause has an expression that can't be represented in 64-bit Issue #138445 >From 3f484ebd84597ce803b6c9c82650ab7bf88449dd Mon Sep 17 00:00:00 2001 From: AmrDeveloper

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-05 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/138346 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream local VectorType with 0 init elements (PR #138346)

2025-05-05 Thread Amr Hesham via cfe-commits
@@ -70,12 +72,15 @@ void foo() { // CIR: %[[VEC_E:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["e", init] // CIR: %[[VEC_F:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["f", init] // CIR: %[[VEC_G:.*]] = cir.alloca !cir.vector<4 x !s32i>, !cir.ptr>, ["g", in

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138413 >From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 3 May 2025 13:43:04 +0200 Subject: [PATCH 1/2] [CIR] Upstream extract op for VectorType --- clang/incl

[clang] [CIR][NFC] Fix an unused variable warning (PR #138415)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/138415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream extract op for VectorType (PR #138413)

2025-05-03 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/138413 >From d0a6c4fa94d387d8c9afec10deae150d6bce54ee Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 3 May 2025 13:43:04 +0200 Subject: [PATCH 1/2] [CIR] Upstream extract op for VectorType --- clang/incl

  1   2   3   4   5   >