[PATCH] D143587: [Docs] Multilib design

amilendra added inline comments. Comment at: clang/docs/Multilib.rst:89 + the *last* matching multilib variant, or may use all matching variants, + thereby layering them. +#. Generate ``-isystem`` and ``-L`` arguments. Iterate in reverse order over What would

[PATCH] D143587: [Docs] Multilib design

amilendra added a comment. Thanks for the design docs. At a high-level this gives a good summary on what you intend the multilib feature to do. Couple of suggestions. Comment at: clang/docs/Multilib.rst:86-89 + a match. + If more than one variant matches then a toolchain m

[PATCH] D143590: [NFC] Simplify test from change D73904

amilendra accepted this revision. amilendra added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143590/new/ https://reviews.llvm.org/D143590

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121206/new/ https://reviews.llvm.org/D121206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon, FeatureSPE, FeatureFullFP16, FeatureDotProd]; list X1C = [HasV8_2aOps, FeatureCryp

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1, cortex-x1c, cortex-a77

amilendra accepted this revision. amilendra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/lib/Target/AArch64/AArch64.td:978 FeatureNEON, FeatureRCPC, FeaturePerfMon, Fea

[PATCH] D119166: [clang][ARM] Re-word PACBTI warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG424e850f1ebc: [clang][ARM] Re-word PACBTI warning. (authored by amilendra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119166/new/ https://reviews.llvm.o

[PATCH] D119166: [clang][ARM] Re-word PACBTI warning.

amilendra updated this revision to Diff 406780. amilendra added a comment. [clang][ARM] Re-word PACBTI warning. Fix grammar error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119166/new/ https://reviews.llvm.org/D119166 Files: clang/include/c

[PATCH] D119166: [clang][ARM] Re-word PACBTI warning.

amilendra created this revision. amilendra added reviewers: chill, stuij. Herald added a subscriber: kristof.beyls. amilendra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The original warning added in D115501

[PATCH] D119008: Add Cortex-X1C to Clang LLVM 14 release notes

amilendra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119008/new/ https://reviews.llvm.org/D119008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D118380: Add info on PACBTI-M to the Clang release notes

amilendra added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118380/new/ https://reviews.llvm.org/D118380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f08b0867412: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures (authored by amilendra). Repository: rG LLVM Github

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra added a comment. The CI errors seem unrelated. Failed Tests (9): libarcher :: races/critical-unrelated.c libarcher :: races/lock-nested-unrelated.c libarcher :: races/lock-unrelated.c libarcher :: races/parallel-simple.c libarcher :: races/task-dependency.c lib

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 403801. amilendra added a comment. Fix clang-format errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 402661. amilendra added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/inclu

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 402659. amilendra added a comment. Add new interface isArmMClass() to the Triple class. Use isArmT32() and isArmMClass() to emit PACBTI warnings for ARM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/ne

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 398901. amilendra added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Refactor the check conditions to a single function (isArmT32) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 396695. amilendra added a comment. Fix clang-format errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 396671. amilendra added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:391-392 + if (!Arch.empty() && !isBranchProtectionSupportedArch(Arch)) +return false; + chill wrote: > On empty `Arch` it'd continue down the function, but we'd like to return >

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 393918. amilendra added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/includ

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra updated this revision to Diff 393917. amilendra added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115501/new/ https://reviews.llvm.org/D115501 Files: clang/lib/Basic/Targets/ARM.cpp clang/lib/Code

[PATCH] D115501: [clang][ARM] Emit warnings when PACBTI-M is used with unsupported architectures

amilendra created this revision. amilendra added reviewers: chill, vhscampos. Herald added a subscriber: kristof.beyls. Herald added a reviewer: aaron.ballman. amilendra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Branch protection in M

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra closed this revision. amilendra added a comment. Commited the fix to LLVM Release 12.x branch. Rendering looks okay this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 _

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra requested review of this revision. amilendra added a comment. Sorry for the back-and-forth. Requesting re-review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 __

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra updated this revision to Diff 330345. amilendra added a comment. Add a newline before the sub-list to fix a rendering issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 Files: clang/docs/Rel

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra reopened this revision. amilendra added a comment. This revision is now accepted and ready to land. Reopening to add a missing empty line before starting the level-2 list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://r

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra closed this revision. amilendra added a comment. Commited to LLVM Release 12.x branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98277/new/ https://reviews.llvm.org/D98277 ___ cfe-commits ma

[PATCH] D98277: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra created this revision. amilendra added reviewers: willlovett, kristof.beyls, jgreenhalgh. amilendra requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98277 Files: c

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra abandoned this revision. amilendra added a comment. Herald added a subscriber: JDevlieghere. Abandoning this revision because I think I messed up something when using arcanist to fix pre-merge errors. https://buildkite.com/llvm-project/diff-checks/builds/32719 I'll submit a new review.

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra updated this revision to Diff 329380. amilendra added a comment. Herald added subscribers: llvm-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, jansvoboda11, frasercrmck, dexonsmith, ecnelises, wenlei, dang, jdoerfert, sstefan1, omjavaid, jvesely, phosek, kerbowa, lu

[PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra created this revision. amilendra added reviewers: willlovett, kristof.beyls, jgreenhalgh. amilendra added a project: clang. amilendra requested review of this revision. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98255 Files: