[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

bzcheeseman added a comment. In D131319#3709671 , @whisperity wrote: > In D131319#3708667 , @bzcheeseman > wrote: > >> This is great, thank you for doing this! I'm not a competent reviewer for >> the actual cla

[PATCH] D131319: [clang-tidy] Update llvm-prefer-isa-or-dyn-cast-in-conditionals with new syntax

bzcheeseman accepted this revision. bzcheeseman added a comment. This revision is now accepted and ready to land. This is great, thank you for doing this! I'm not a competent reviewer for the actual clang-tidy code changes but the +1 for the idea :) Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D126803: [llvm][analyzer][NFC] Introduce SFINAE for specializing FoldingSetTraits

bzcheeseman added inline comments. Comment at: llvm/include/llvm/ADT/FoldingSet.h:260 /// to FoldingSets that were not originally designed to have that behavior. -template struct FoldingSetTrait - : public DefaultFoldingSetTrait {}; +template +struct FoldingSetTrait : public D

[PATCH] D125749: [analyzer][NFC] Introduce SVal::isa

bzcheeseman added a comment. Not a qualified reviewer for anything other than the `llvm::isa` usage and that line looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125749/new/ https://reviews.llvm.org/D125749 ___

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

bzcheeseman accepted this revision. bzcheeseman added a comment. This revision is now accepted and ready to land. > In D125709#3519033 , @bzcheeseman > wrote: > >> In D125709#3518096 , @steakhal >> wrote: >> >>>

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

bzcheeseman added a comment. In D125709#3518096 , @steakhal wrote: > I had to fix the `doCast` to return `To` instead of `Optional` to make it > work. That's fine (or it should be!) but you can also just dereference the optional, right? Repository:

[PATCH] D125709: [analyzer][Casting] Support isa, cast, dyn_cast of SVals

bzcheeseman added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SVals.h:102 template T castAs() const { assert(T::classof(*this)); Is it worth refactoring this and getAs to use `cast` and `dyn_cast` as appropriate