tamur added a comment.
It seems that with this patch, llvm-ifs starts to depend on yaml2obj, which as
far as I know, was only used for testing purposes until now. Is this intended?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63978/new/
https://reviews.llvm.org/
tamur added a comment.
This patch seems to have broken the compilation. I get the following error on a
linux platform:
[12/14] Linking CXX executable bin/clangd
FAILED: bin/clangd
: && /usr/local/google/home/tamur/src/llvm/2018_nov_12/llvm/Stable/bin/clang++
-fPIC -fvisibility-inlines-hidden -
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344000: Introduce code_model macros (authored by tamur,
committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52920
Files:
cfe/trunk/include/clang/Ba
tamur added inline comments.
Comment at: lib/Basic/Targets/X86.cpp:865
+ if (CodeModel == "default")
+// When the user has not explicitly specified anything,
+// the default code model to use is small.
MaskRay wrote:
> I'm not sure if the comment is usef
tamur updated this revision to Diff 168700.
Repository:
rC Clang
https://reviews.llvm.org/D52920
Files:
include/clang/Basic/TargetOptions.h
lib/Basic/Targets/X86.cpp
lib/Frontend/CompilerInvocation.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
==
tamur updated this revision to Diff 168494.
Repository:
rC Clang
https://reviews.llvm.org/D52920
Files:
include/clang/Basic/TargetOptions.h
lib/Basic/Targets/X86.cpp
lib/Frontend/CompilerInvocation.cpp
test/Preprocessor/init.c
Index: test/Preprocessor/init.c
==
tamur created this revision.
tamur added reviewers: compnerd, MaskRay.
tamur added a project: clang.
Herald added a subscriber: cfe-commits.
gcc defines macros such as __code_model_small_ based on the user passed command
line flag -mcmodel. clang accepts a flag with the same name and similar
eff
