[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. In D144232#4137367 , @dim wrote: > In D144232#4136787 , @brad wrote: > >> I noticed this review. I have provided a more complete diff for review at >> D144321

[PATCH] D144232: [PowerPC] Correctly use ELFv2 ABI on FreeBSD/powerpc64

adalava added a comment. Nice catch! I'm not a LLVM maintainer but from FreeBSD PowerPC side I agree with the changes, only added two suggestions that could improve code readability Comment at: clang/lib/Basic/Targets/PPC.h:428 ABI = "elfv2"; +} else if (Triple.isO

[PATCH] D122377: [PowerPC] Support 16-byte lock free atomics on pwr8 and up

adalava added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:440 if (Triple.isOSAIX() || Triple.isOSLinux()) DataLayout += "-S128-v256:256:256-v512:512:512"; resetDataLayout(DataLayout); I don't understand what DataLayout does mean, b

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

adalava added a comment. In D113451#3124461 , @jsji wrote: > LGTM. Thanks for enabling this for FreeBSD. Thanks for reviewing it. If you and others with merge permissions think it's ready, please merge it (I don't have the permissions) Thanks!! Repo

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

adalava updated this revision to Diff 385985. adalava added a comment. fix style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113451/new/ https://reviews.llvm.org/D113451 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp cl

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

adalava updated this revision to Diff 385849. adalava retitled this revision from "[PowerPC] [Clang] Add MMX intrinsics support to FreeBSD" to "[PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD". adalava edited the summary of this revision. adalava added a comment. add more ppc_wrappe

[PATCH] D113451: [PowerPC] [Clang] Add MMX intrinsics support to FreeBSD

adalava created this revision. adalava added reviewers: PowerPC, qiucf, jsji, nemanjai. Herald added subscribers: shchenz, kbarton, krytarowski, arichardson, mgorny, emaste. adalava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava added a comment. In D71600#1868284 , @efriedma wrote: > On master, atomic.c is not built by default. It's only built if you > explicitly request it with something like the CMake flag > -DCOMPILER_RT_EXCLUDE_ATOMIC_BUILTIN=Off . If you're not do

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava added a comment. In D71600#1867135 , @efriedma wrote: > For the clang change, we should do something like D72579 > , not explicitly check for a specific target > in target-independent code. right, I'll retest ev

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava updated this revision to Diff 243520. adalava added a comment. fix typo found by @dim Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71600/new/ https://reviews.llvm.org/D71600 Files: clang/lib/AST/ExprConstant.cpp compiler-rt/lib/builti

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava updated this revision to Diff 239847. adalava added a comment. Updated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71600/new/ https://reviews.llvm.org/D71600 Files: clang/lib/AST/ExprConstant.cpp compiler-rt/lib/builtins/atom

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava added a comment. In D71600#1816160 , @MaskRay wrote: > I am still confused why you need the special rule for `__atomic_is_lock_free` > (GCC/clang) and `__c11_atomic_is_lock_free` (clang). > > https://github.com/gcc-mirror/gcc/blob/master/gcc/built

[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

adalava abandoned this revision. adalava added a comment. In D72306#1808613 , @MaskRay wrote: > Obsoleted by D72352 ? Sure, abandoning in favor of D72352 . Thank you! Repository: rG

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

adalava accepted this revision. adalava added a comment. This revision is now accepted and ready to land. LGTM. Just a comment regarding FreeBSD 11.x. Comment at: clang/test/Driver/ppc-abi.c:27 +// RUN: %clang -target powerpc64-unknown-freebsd12 %s -### 2>&1 | FileCheck --ch

[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

adalava marked an inline comment as done. adalava added a comment. In D72306#1807097 , @MaskRay wrote: > Are you still using -target powerpc64-unknown-freebsd12.0-elfv2 or -target > powerpc64-unknown-freebsd12.0-elfv1 added in > https://reviews.llvm.org/

[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

adalava created this revision. adalava added reviewers: dim, MaskRay. adalava added a project: PowerPC. Herald added subscribers: llvm-commits, cfe-commits, steven.zhang, shchenz, jsji, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald added projects: clang, LLVM. FreeBSD for

[PATCH] D71600: PowerPC 32-bit - forces 8 byte lock/lock_free decisions at compiled time

adalava created this revision. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, steven.zhang, shchenz, jsji, jfb, krytarowski, arichardson, nemanjai, emaste. Herald added a reviewer: jfb. Herald added projects: clang, Sanitizers, LLVM. adalava added a reviewer: dim. Herald added su

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked an inline comment as done. adalava added a comment. In D61950#1504169 , @MaskRay wrote: > Will FreeBSD 13 or future releases support ELFv1? If not, it may be cleaner > to not invent `-elfv2` `-elfv1` triples, but rather dispatch on the majo

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked 3 inline comments as done. adalava added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:217 case Triple::ppc64: -return PPCTargetMachine::PPC_ABI_ELFv1; +// if ELFv2 on target triple i.e. powerpc64-unknown-freebsd12.0-elfv2 +

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava updated this revision to Diff 199633. adalava added a comment. - remove redundant comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61950/new/ https://reviews.llvm.org/D61950 Files: clang/lib/Basic/Targets/PPC.h llvm/include/llvm/A

[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

adalava marked an inline comment as done. adalava added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:382 resetDataLayout("e-m:e-i64:64-n32:64"); - ABI = "elfv2"; } else { MaskRay wrote: > MaskRay wrote: > > Have you researched how G

[PATCH] D61950: [PowerPC64] recognize target triplet with ABI info (i.e. powerpc64-unknown-freebsd13-elfv2)

adalava created this revision. Herald added subscribers: llvm-commits, cfe-commits, jsji, dexonsmith, kbarton, hiraditya, nemanjai. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D61950 Files: clang/lib/Basic/Targets/PPC.h llvm/include/llv