[PATCH] D41308: [analyser] different.BitwiseOpBoolArg checker implementation

2017-12-15 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev created this revision. alexey.knyshev added reviewers: dcoughlin, dergachev.a, NoQ, zaks.anna, a.sidorin, kromanenkov. Herald added subscribers: cfe-commits, mgorny. Repository: rC Clang https://reviews.llvm.org/D41308 Files: include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

2017-12-11 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev added a comment. In https://reviews.llvm.org/D40715#951665, @dcoughlin wrote: > Thanks for looking into this! > > This checker is in the 'core' package, which means (when moved out of alpha) > it will be enabled by default. > > - Do you think that this checker should be enabled by

[PATCH] D41077: [analyser] different.CallArgsOrder checker implementation

2017-12-11 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev created this revision. alexey.knyshev added a project: clang. Herald added a subscriber: mgorny. CallArgsOrderChecker which looks for accidental swap or skip of arguments in function, methods, constructors and operators calls Repository: rC Clang https://reviews.llvm.org/D4107

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

2017-12-11 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:87 +BugReporter &BR) const { + auto LabelStmt = stmt(hasDescendant(switchStmt( + eachOf(has(compoundStmt(forEach(labelS

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

2017-12-10 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev added inline comments. Comment at: lib/StaticAnalyzer/Checkers/LabelInsideSwitchChecker.cpp:24 + + class WalkAST : public ConstStmtVisitor { +const CheckerBase *Checker; kromanenkov wrote: > Do you consider using ASTMatchers like in NumberObje

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

2017-12-10 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev updated this revision to Diff 126293. alexey.knyshev added a comment. 1. Now implemented via MatchFinder 2. Added missing License header 3. Pass all StringRefs by value 4. Method names now start from small letter 5. Using StringRef::edit_distance instead of custom "similarity" metri

[PATCH] D40715: [analyser] different.LabelInsideSwitch checker implementation

2017-12-01 Thread Alexey Knyshev via Phabricator via cfe-commits
alexey.knyshev created this revision. alexey.knyshev added a project: clang. Herald added subscribers: cfe-commits, mgorny. Implementation of checker "different.LabelInsideSwitch" from potential checkers list (https://clang-analyzer.llvm.org/potential_checkers.html#different) Repository: rC C