[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

https://github.com/gerekon updated https://github.com/llvm/llvm-project/pull/118008 >From 55b08ec540d18d50011ef9fb0e301e1f7650ca9e Mon Sep 17 00:00:00 2001 From: Andrei Safronov Date: Thu, 1 Jun 2023 00:42:37 +0300 Subject: [PATCH] [Clang][Xtensa] Add Xtensa target. --- clang/include/clang/Ba

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -0,0 +1,112 @@ +//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

https://github.com/gerekon updated https://github.com/llvm/llvm-project/pull/118008 >From bf0488585f41d3342c5c6d289d4621e3f50195cc Mon Sep 17 00:00:00 2001 From: Andrei Safronov Date: Thu, 1 Jun 2023 00:42:37 +0300 Subject: [PATCH 1/3] [Clang][Xtensa] Add Xtensa target. --- clang/include/clan

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -2742,3 +2742,275 @@ // RISCV64-LINUX: #define __unix__ 1 // RISCV64-LINUX: #define linux 1 // RISCV64-LINUX: #define unix 1 + +// RUN: %clang_cc1 -E -dM -ffreestanding -fgnuc-version=4.2.1 -triple=xtensa < /dev/null \ +// RUN: | FileCheck -match-full-lines -check-prefix

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -0,0 +1,141 @@ +//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const ASTContext *Context) { return Context->buildImplicitTypedef(VaListTagArrayType, "__builtin_va_list"); } +static TypedefDecl * +CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) { + /

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -0,0 +1,62 @@ +//===--- Xtensa.cpp - Implement Xtensa target feature support -===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const ASTContext *Context) { return Context->buildImplicitTypedef(VaListTagArrayType, "__builtin_va_list"); } +static TypedefDecl * +CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) { + /

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -358,7 +358,10 @@ class TargetInfo : public TransferrableTargetInfo, //void *__saved_reg_area_end_pointer; //void *__overflow_area_pointer; //} va_list; -HexagonBuiltinVaList +HexagonBuiltinVaList, + +// Tensilica Xtensa +XtensaABIBuiltinV

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const ASTContext *Context) { return Context->buildImplicitTypedef(VaListTagArrayType, "__builtin_va_list"); } +static TypedefDecl * +CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) { + /

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

https://github.com/gerekon updated https://github.com/llvm/llvm-project/pull/118008 >From bf0488585f41d3342c5c6d289d4621e3f50195cc Mon Sep 17 00:00:00 2001 From: Andrei Safronov Date: Thu, 1 Jun 2023 00:42:37 +0300 Subject: [PATCH 1/2] [Clang][Xtensa] Add Xtensa target. --- clang/include/clan

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -0,0 +1,62 @@ +//===--- Xtensa.cpp - Implement Xtensa target feature support -===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

https://github.com/gerekon edited https://github.com/llvm/llvm-project/pull/118008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -0,0 +1,62 @@ +//===--- Xtensa.cpp - Implement Xtensa target feature support -===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

@@ -0,0 +1,141 @@ +//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++ -*-===// +// +// The LLVM Compiler Infrastructure +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

gerekon wrote: Hi guys, Thanks for you comments. > I am a little concerned that progress on the upstreaming is moving > excessively slowly. what exactly has been happening? > That said, if there are signs that the target is only sporadically > maintained, reaffirming that's not the case woul

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

gerekon wrote: > I don't know what this target IS, did we have an RFC to approve this in Clang > as a target? Do we have sufficient interest in the project to maintain > it/keep it? This is a part of our work for upstreaming Xtensa target support. https://github.com/espressif/llvm-project/iss

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

gerekon wrote: ping https://github.com/llvm/llvm-project/pull/118008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Xtensa] Default to unsigned char (PR #115967)

gerekon wrote: > Looking at #118008 it sounds like we don't yet have complete codegen support > for XTensa in Clang, so it sounds like this is safe without a flag. Yes, it is not upstreamed yet. We are working on it. But after rebasing on the LLVM 20 we might get this fix in our repo, so that

[clang] [Xtensa] Default to unsigned char (PR #115967)

gerekon wrote: > Thanks, do you believe we need a backwards compatibility flag for the ABI to > be consistent with older clang or is this safe to land? I think as far as we can control behavior with `-fsigned-char` we do not need another option for this. @MabezDev WDYT? Will it be critical fo

[clang] [Xtensa] Default to unsigned char (PR #115967)

gerekon wrote: Hi @arichardson. Thanks for this change. Acc to the doc which I have `The char type is unsigned by default for Xtensa processors.` Our GCC Xtensa toolchain also interprets char type as unsigned by default. https://github.com/llvm/llvm-project/pull/115967 ___

[clang] [Xtensa] Default to unsigned char (PR #115967)

gerekon wrote: Looks like it is related to https://github.com/llvm/llvm-project/pull/118008 https://github.com/llvm/llvm-project/pull/115967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

gerekon wrote: @sstefan1 @andreisfr PTAL https://github.com/llvm/llvm-project/pull/118008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Xtensa] Add Xtensa target. (PR #118008)

https://github.com/gerekon created https://github.com/llvm/llvm-project/pull/118008 This PR implements support for generic Xtensa target in CLang. >From bf0488585f41d3342c5c6d289d4621e3f50195cc Mon Sep 17 00:00:00 2001 From: Andrei Safronov Date: Thu, 1 Jun 2023 00:42:37 +0300 Subject: [PATCH]