[clang] [Clang][SYCL] Add AOT compilation support for Intel GPUs in clang-sycl-linker (PR #133194)

2025-05-06 Thread Alexey Bader via cfe-commits
bader wrote: > I'm wondering though, is there a reason we can't just use the backend right > now? What do these tools do that running `llc` can't. These tools compile programs in SPIR-V to the format that can be consumed by Intel's OpenCL/Level Zero drivers. `llc` can't do that because there a

[clang] [Clang][SYCL] Add AOT compilation support for Intel GPUs in clang-sycl-linker (PR #133194)

2025-05-06 Thread Alexey Bader via cfe-commits
bader wrote: I suggest adjusting the PR title: "[Clang][SYCL] Add AOT compilation support for Intel GPUs in clang-sycl-linker" -> "[clang-sycl-linker] Add AOT compilation support for Intel GPUs" https://github.com/llvm/llvm-project/pull/133194 ___ cfe-

[clang] [NFC][clang-offload-bundler] Simplify main function (PR #138555)

2025-05-05 Thread Alexey Bader via cfe-commits
https://github.com/bader closed https://github.com/llvm/llvm-project/pull/138555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang-offload-bundler] Simplify main function (PR #138555)

2025-05-05 Thread Alexey Bader via cfe-commits
https://github.com/bader created https://github.com/llvm/llvm-project/pull/138555 Applied "no else after return" rule from the LLVM's Coding Standards https://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return Rate limit · GitHub body {

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-04-07 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,186 @@ +// RUN: %clang_cc1 -fsycl-is-host -emit-llvm -triple x86_64-unknown-linux-gnu %s -o - | FileCheck --check-prefixes=CHECK-HOST,CHECK-HOST-LINUX %s +// RUN: %clang_cc1 -fsycl-is-device -emit-llvm -aux-triple x86_64-unknown-linux-gnu -triple amdgcn-amd-amdhsa %s

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-03-26 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. https://github.com/llvm/llvm-project/pull/133030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Basic code generation for SYCL kernel caller offload entry point functions. (PR #133030)

2025-03-26 Thread Alexey Bader via cfe-commits
@@ -229,6 +229,12 @@ class CodeGenTypes { const CGFunctionInfo &arrangeBuiltinFunctionCall(QualType resultType, const CallArgList &args); + /// A SYCL device kernel function is a free standing function with + /// spir_kern

[clang] [Clang] Permit `-Xarch_` to be used with `--offload-arch` (PR #131884)

2025-03-18 Thread Alexey Bader via cfe-commits
bader wrote: > Like SPIRV is doing `nvidia_gpu_sm_89` instead of just `-Xarch_nvptx64 > --offload-arch=sm_89`. Like SYCL? https://github.com/llvm/llvm-project/pull/131884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [clang][SYCL] Disable float128 device mode diagnostic (PR #128513)

2025-03-13 Thread Alexey Bader via cfe-commits
@@ -4700,7 +4700,8 @@ void Sema::AddModeAttr(Decl *D, const AttributeCommonInfo &CI, if (NewElemTy.isNull()) { // Only emit diagnostic on host for 128-bit mode attribute -if (!(DestWidth == 128 && getLangOpts().CUDAIsDevice)) +if (!(DestWidth == 128 && +

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-22 Thread Alexey Bader via cfe-commits
https://github.com/bader edited https://github.com/llvm/llvm-project/pull/122379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-22 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. @tahonermann thanks a lot for the work. I really appreciate the detailed description and comments! @erichkeane did a great job with the code review, so I have nothing to add. I just have one small question that does not affect the merge. ht

[clang] [SYCL] AST support for SYCL kernel entry point functions. (PR #122379)

2025-01-22 Thread Alexey Bader via cfe-commits
@@ -362,3 +364,93 @@ void SemaSYCL::CheckSYCLEntryPointFunctionDecl(FunctionDecl *FD) { } } } + +namespace { + +// The body of a function declared with the [[sycl_kernel_entry_point]] +// attribute is cloned and transformed to substitute references to the original +// fu

[clang] [clang][Driver][SPIR-V] Make tool names consistent (PR #122343)

2025-01-10 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. https://github.com/llvm/llvm-project/pull/122343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Basic diagnostics for the sycl_kernel_entry_point attribute. (PR #120327)

2025-01-09 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/120327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][SPIR-V] Use consistent tools to convert between text and binary form (PR #120266)

2025-01-07 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. LGTM. @svenvh, do you have any objections? https://github.com/llvm/llvm-project/pull/120266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [SYCL] Change SYCL version according to standard (PR #114790)

2024-12-05 Thread Alexey Bader via cfe-commits
https://github.com/bader closed https://github.com/llvm/llvm-project/pull/114790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-12-04 Thread Alexey Bader via cfe-commits
@@ -178,6 +266,9 @@ void SPIRVPassConfig::addIRPasses() { addPass(createSPIRVStructurizerPass()); } + if (TM.getOptLevel() > CodeGenOptLevel::None) +addPass(createInferAddressSpacesPass(AddressSpace::Generic)); bader wrote: Out of curiosity, why do

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-12-04 Thread Alexey Bader via cfe-commits
@@ -92,6 +98,65 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T, const Triple &TT, setRequiresStructuredCFG(false); } +enum AddressSpace { + Function = storageClassToAddressSpace(SPIRV::StorageClass::Function), + CrossWorkgroup = + storageClassToAddressSpac

[clang] [SYCL] Change SYCL version according to standard (PR #114790)

2024-11-26 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. https://github.com/llvm/llvm-project/pull/114790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Change SYCL version according to standard (PR #114790)

2024-11-26 Thread Alexey Bader via cfe-commits
https://github.com/bader edited https://github.com/llvm/llvm-project/pull/114790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][SYCL] Fix use of uninitalized memory in temp files (PR #114488)

2024-10-31 Thread Alexey Bader via cfe-commits
bader wrote: PR title: "[Clang][SYCL] Fix use of uninitalized memory in temp files" tag: [Clang][SYCL] -> [clang-sycl-linker] typo: uninitalized -> uninitialized https://github.com/llvm/llvm-project/pull/114488 ___ cfe-commits mailing list cfe-commit

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-31 Thread Alexey Bader via cfe-commits
@@ -5116,11 +5123,34 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, if (const Arg *PF = Args.getLastArg(options::OPT_mprintf_kind_EQ)) PF->claim(); - if (Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false)) { -CmdArgs.push_back("-fsycl-

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-29 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,48 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -emit-llvm -c %s -o %t_1.bc +// RUN: %clangxx -emit-llvm -c %s -o %t_2.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t_1.bc %t_2.bc -o a.spv 2>&1 \ +/

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-29 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,13 @@ +// Tests the driver when linking LLVM IR bitcode files and targeting SPIR-V +// architecture. +// +// RUN: touch %t.bc +// RUN: %clangxx --target=spirv64 --sycl-link -### %t.bc 2>&1 \ +// RUN: | FileCheck %s -check-prefix=LINK +// LINK: "{{.*}}clang-sycl-linker

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-29 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. LGTM except a couple of minor nits. https://github.com/llvm/llvm-project/pull/112245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-29 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \ +// RUN: | FileCheck %s --check-prefix=SIMPLE +// SI

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-29 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,55 @@ +include "llvm/Option/OptParser.td" + +def WrapperOnlyOption : OptionFlag; + +def help : Flag<["-", "--"], "help">, + HelpText<"Display available options (--help-hidden for more)">; + +def help_hidden : Flag<["-", "--"], "help-hidden">, + HelpText<"Display all a

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,500 @@ +//= clang-sycl-linker/ClangSYCLLinker.cpp - SYCL Linker util ---=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,55 @@ +include "llvm/Option/OptParser.td" + +def WrapperOnlyOption : OptionFlag; + +def help : Flag<["-", "--"], "help">, + HelpText<"Display available options (--help-hidden for more)">; + +def help_hidden : Flag<["-", "--"], "help-hidden">, + HelpText<"Display all a

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \ +// RUN: | FileCheck %s --check-prefix=SIMPLE +// SI

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,500 @@ +//= clang-sycl-linker/ClangSYCLLinker.cpp - SYCL Linker util ---=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,13 @@ +// Tests the driver when linking LLVM IR bitcode files and targeting SPIR-V +// architecture. +// +// RUN: touch %t.bc +// RUN: %clangxx --target=spirv64 --sycl-link -### %t.bc 2>&1 \ +// RUN: | FileCheck %s -check-prefix=LINK +// LINK: "{{.*}}clang-sycl-linker

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \ +// RUN: | FileCheck %s --check-prefix=SIMPLE +// SI

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \ +// RUN: | FileCheck %s --check-prefix=SIMPLE +// SI

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,500 @@ +//= clang-sycl-linker/ClangSYCLLinker.cpp - SYCL Linker util ---=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc bader wrote: ```suggestion // RUN: %clangxx -emit-llvm -c %s -o %t.bc ``` `-fsycl` is useless here. We just nee

[clang] [Clang][SYCL] Introduce clang-sycl-linker to link SYCL offloading device code (Part 1 of many) (PR #112245)

2024-10-28 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,42 @@ +// Tests the clang-sycl-linker tool. +// +// Test a simple case without arguments. +// RUN: %clangxx -fsycl -emit-llvm -c %s -o %t.bc +// RUN: clang-sycl-linker --dry-run -triple spirv64 %t.bc -o a.spv 2>&1 \ +// RUN: | FileCheck %s --check-prefix=SIMPLE +// SI

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-25 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. Thanks. No other comments from my side. https://github.com/llvm/llvm-project/pull/107493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-25 Thread Alexey Bader via cfe-commits
@@ -767,6 +768,27 @@ Driver::OpenMPRuntimeKind Driver::getOpenMPRuntime(const ArgList &Args) const { return RT; } +static const char *getDefaultSYCLArch(Compilation &C) { + // If -fsycl is supplied we will assume SPIR-V + if (C.getDefaultToolChain().getTriple().getArch()

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-24 Thread Alexey Bader via cfe-commits
@@ -762,6 +762,10 @@ class ToolChain { virtual void AddHIPIncludeArgs(const llvm::opt::ArgList &DriverArgs, llvm::opt::ArgStringList &CC1Args) const; + /// Add arguments to use SYCL specific includes. bader wrote: ```sugge

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-24 Thread Alexey Bader via cfe-commits
https://github.com/bader edited https://github.com/llvm/llvm-project/pull/107493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-23 Thread Alexey Bader via cfe-commits
@@ -0,0 +1,188 @@ +//===--- SYCL.cpp - SYCL Tool and ToolChain Implementations -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-23 Thread Alexey Bader via cfe-commits
@@ -4867,12 +4946,13 @@ Action *Driver::ConstructPhaseAction( return C.MakeAction(Input, Output); } if (Args.hasArg(options::OPT_emit_llvm) || -(((Input->getOffloadingToolChain() && - Input->getOffloadingToolChain()->getTriple().isAMDGPU()) || -

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-23 Thread Alexey Bader via cfe-commits
@@ -217,10 +217,11 @@ static bool ActionFailed(const Action *A, if (FailingCommands.empty()) return false; - // CUDA/HIP can have the same input source code compiled multiple times so do - // not compiled again if there are already failures. It is OK to abort the - //

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-23 Thread Alexey Bader via cfe-commits
@@ -582,6 +582,10 @@ class Driver { /// @name Helper Methods /// @{ + /// MakeSYCLDeviceTriple - Returns the SYCL device triple for the + /// specified ArchType. + llvm::Triple MakeSYCLDeviceTriple(StringRef TargetArch = "spir64") const; bader wrote:

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-23 Thread Alexey Bader via cfe-commits
@@ -1073,6 +1074,8 @@ void Clang::AddPreprocessingOptions(Compilation &C, const JobAction &JA, getToolChain().AddCudaIncludeArgs(Args, CmdArgs); if (JA.isOffloading(Action::OFK_HIP)) getToolChain().AddHIPIncludeArgs(Args, CmdArgs); + if (JA.isOffloading(Action::OFK_

[clang] [llvm] [Driver][SYCL] Add initial SYCL offload compilation support (PR #107493)

2024-10-23 Thread Alexey Bader via cfe-commits
https://github.com/bader commented: @mdtoguchi, thank you for working on this! Overall, looks good to me, but I made a few suggestions in the comments. It would be great if @tahonermann and @AaronBallman can confirm that all their comments are addressed. https://github.com/llvm/llvm-project/pul

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-21 Thread Alexey Bader via cfe-commits
https://github.com/bader approved this pull request. LGTM, thanks! I second @keryell: thank you for the good documentation. https://github.com/llvm/llvm-project/pull/111389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-21 Thread Alexey Bader via cfe-commits
@@ -14296,6 +14296,30 @@ void ASTContext::getFunctionFeatureMap(llvm::StringMap &FeatureMap, } } +static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context, bader wrote: `Context` parameter is unused. I suppose it might trigger a compiler warning. Can

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-21 Thread Alexey Bader via cfe-commits
https://github.com/bader edited https://github.com/llvm/llvm-project/pull/111389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow all address spaces to be converted to the default (PR #112248)

2024-10-14 Thread Alexey Bader via cfe-commits
@@ -721,7 +721,9 @@ class Qualifiers { // to implicitly cast into the default address space. (A == LangAS::Default && (B == LangAS::cuda_constant || B == LangAS::cuda_device || - B == LangAS::cuda_shared)); + B == LangAS

[clang] [clang] Split up `SemaDeclAttr.cpp` (PR #93966)

2024-05-31 Thread Alexey Bader via cfe-commits
@@ -14,9 +14,11 @@ #define LLVM_CLANG_SEMA_SEMASYCL_H #include "clang/AST/Decl.h" +#include "clang/AST/DeclBase.h" bader wrote: I'm okay with that. It just looks strange to add forward declaration for `Decl` class when full declaration is included with `#inc

[clang] [clang] Split up `SemaDeclAttr.cpp` (PR #93966)

2024-05-31 Thread Alexey Bader via cfe-commits
@@ -14,9 +14,11 @@ #define LLVM_CLANG_SEMA_SEMASYCL_H #include "clang/AST/Decl.h" +#include "clang/AST/DeclBase.h" bader wrote: > This one should be fixed as well now. Can we drop `#include "clang/AST/Decl.h"` as well? https://github.com/llvm/llvm-project/p

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-05-30 Thread Alexey Bader via cfe-commits
https://github.com/bader commented: I'm okay with the patch in general, but I'd like either @michalpaszkowski or @VyacheslavLevytskyy to take a look. Just one question about doubling the test scope for LLVM tests with spir64 target triple. https://github.com/llvm/llvm-project/pull/89796 __

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-05-30 Thread Alexey Bader via cfe-commits
@@ -1,4 +1,5 @@ ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - | FileCheck %s +; RUN: llc -O0 -mtriple=spirv64-amd-amdhsa %s -o - | FileCheck %s bader wrote: I'm not sure if there is a value in testing `spirv64-amd-amdhsa` triple in addition to `spirv6

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-05-30 Thread Alexey Bader via cfe-commits
https://github.com/bader edited https://github.com/llvm/llvm-project/pull/89796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-05-13 Thread Alexey Bader via cfe-commits
bader wrote: @AlexVlx, do you think it's worth promoting [SPV_INTEL_inline_assembly](https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_inline_assembly.asciidoc) and [SPV_INTEL_function_pointers](https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-exte

[clang] [clang][CodeGen] Add AS for Globals to SPIR & SPIRV datalayouts (PR #88455)

2024-04-12 Thread Alexey Bader via cfe-commits
https://github.com/bader commented: > I'll emphasise that this is only a problem for things such as implicitly > generated globals (e.g. VTables or typeinfo for classes etc.) I suppose usage of VTables and typeinfo is kind of restricted in GPU programming models. Right? Anyway, I think it's a

[clang] [clang][CodeGen] Add AS for Globals to SPIR & SPIRV datalayouts (PR #88455)

2024-04-12 Thread Alexey Bader via cfe-commits
bader wrote: The change seems reasonable. > CodeGen/LLVM will default to AS0 in this case, which produces Globals that > end up in the private address space for e.g. OCL, HIPSPV or SYCL. Can we add a test checking LLVM address space for globals emitted from OCL/HIPSPV/SYCL, please? It's surpr

[clang] [llvm] [AMDGPU] Adding the amdgpu-num-work-groups function attribute (PR #75647)

2024-01-16 Thread Alexey Bader via cfe-commits
bader wrote: > How does this attribute relate to `reqd_work_group_size` and related existing > attributes? They seems to be different/"unrelated". Based on the description of the `amdgpu-num-work-groups` attribute it provides "number of work-groups", whereas `reqd_work_group_size` provides "n

[clang] a2e2f47 - [Clang][Docs] Fix typo in clang-offload-packager documentation

2023-09-11 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2023-09-11T16:24:37-07:00 New Revision: a2e2f471c51f0aea836a4929dfdf50523dcff1eb URL: https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb DIFF: https://github.com/llvm/llvm-project/commit/a2e2f471c51f0aea836a4929dfdf50523dcff1eb.diff

[clang] 66bd607 - [Attr][Doc] Fix pragma unroll documentation.

2022-10-19 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2022-10-19T03:50:47-07:00 New Revision: 66bd6074c133402e45075b591c062c22f308ef26 URL: https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26 DIFF: https://github.com/llvm/llvm-project/commit/66bd6074c133402e45075b591c062c22f308ef26.diff

[clang] 923b56e - [NFC] Add a TODO comment to apply nounwind attribute in all GPU modes.

2022-07-06 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2022-07-06T06:20:09-07:00 New Revision: 923b56e7ca96e03cedcb0e3a5df5c05e8e975a38 URL: https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38 DIFF: https://github.com/llvm/llvm-project/commit/923b56e7ca96e03cedcb0e3a5df5c05e8e975a38.diff

[clang] 87b28f5 - [clang][NFC] Extract the EmitAssemblyHelper::TargetTriple member

2022-04-04 Thread Alexey Bader via cfe-commits
Author: Pavel Samolysov Date: 2022-04-04T12:16:39+03:00 New Revision: 87b28f5092f2f92fc380f18e8578746bdd2a54b2 URL: https://github.com/llvm/llvm-project/commit/87b28f5092f2f92fc380f18e8578746bdd2a54b2 DIFF: https://github.com/llvm/llvm-project/commit/87b28f5092f2f92fc380f18e8578746bdd2a54b2.dif

[clang] 9ae5810 - [HIPSPV] Convert HIP kernels to SPIR-V kernels

2021-12-08 Thread Alexey Bader via cfe-commits
Author: Henry Linjamäki Date: 2021-12-08T12:18:15+03:00 New Revision: 9ae5810b53c2e096d7442ba8af3f00ebc3d301b0 URL: https://github.com/llvm/llvm-project/commit/9ae5810b53c2e096d7442ba8af3f00ebc3d301b0 DIFF: https://github.com/llvm/llvm-project/commit/9ae5810b53c2e096d7442ba8af3f00ebc3d301b0.dif

[clang] 49682f1 - [SPIR-V] Add translator tool

2021-11-17 Thread Alexey Bader via cfe-commits
Author: Henry Linjamäki Date: 2021-11-18T03:41:24+03:00 New Revision: 49682f14bf3fb8db5e2721d9896b27bb4c2bd635 URL: https://github.com/llvm/llvm-project/commit/49682f14bf3fb8db5e2721d9896b27bb4c2bd635 DIFF: https://github.com/llvm/llvm-project/commit/49682f14bf3fb8db5e2721d9896b27bb4c2bd635.dif

[clang] 15feaaa - Add myself as a code owner for SYCL support

2021-09-20 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-09-20T09:32:25+03:00 New Revision: 15feaaa359c7245bb59ff0a2aa3b806682f44286 URL: https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286 DIFF: https://github.com/llvm/llvm-project/commit/15feaaa359c7245bb59ff0a2aa3b806682f44286.diff

[clang] d754b97 - [NFC] Drop idle compiler option from the test.

2021-08-13 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-08-13T13:20:11+03:00 New Revision: d754b970eddb83b1c68346a36b067391d93166b0 URL: https://github.com/llvm/llvm-project/commit/d754b970eddb83b1c68346a36b067391d93166b0 DIFF: https://github.com/llvm/llvm-project/commit/d754b970eddb83b1c68346a36b067391d93166b0.diff

[clang] c064ba3 - [NFC] Add commas in code comments.

2021-08-13 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-08-13T08:59:47+03:00 New Revision: c064ba34c7d867c1180279fe3dca8817d835cb28 URL: https://github.com/llvm/llvm-project/commit/c064ba34c7d867c1180279fe3dca8817d835cb28 DIFF: https://github.com/llvm/llvm-project/commit/c064ba34c7d867c1180279fe3dca8817d835cb28.diff

[clang] 2ab513c - [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

2021-05-18 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-05-18T10:27:35+03:00 New Revision: 2ab513cd3e0648806db7ed1f8170ad4a3d4e7749 URL: https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749 DIFF: https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749.diff

[clang] 76f84e7 - [Doc] Fix sphinx warnings about wrong code-block format

2021-04-30 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-04-30T11:40:10+03:00 New Revision: 76f84e772978a3daef33df5bea7da676a0163f28 URL: https://github.com/llvm/llvm-project/commit/76f84e772978a3daef33df5bea7da676a0163f28 DIFF: https://github.com/llvm/llvm-project/commit/76f84e772978a3daef33df5bea7da676a0163f28.diff

[clang] b2bb13a - [Doc] Add SYCLSupport.rst to index toctree.

2021-04-26 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-04-26T16:16:10+03:00 New Revision: b2bb13a761644f675ec9f2d0b4371c51a05ab51c URL: https://github.com/llvm/llvm-project/commit/b2bb13a761644f675ec9f2d0b4371c51a05ab51c DIFF: https://github.com/llvm/llvm-project/commit/b2bb13a761644f675ec9f2d0b4371c51a05ab51c.diff

[clang] b52e69c - [SYCL][Doc] Add design document for SYCL mode

2021-04-26 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-04-26T15:39:43+03:00 New Revision: b52e69c4268181d8143fe49aee0ea85395c8737d URL: https://github.com/llvm/llvm-project/commit/b52e69c4268181d8143fe49aee0ea85395c8737d DIFF: https://github.com/llvm/llvm-project/commit/b52e69c4268181d8143fe49aee0ea85395c8737d.diff

[clang] 7818906 - [SYCL] Implement SYCL address space attributes handling

2021-04-26 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-04-26T13:44:10+03:00 New Revision: 7818906ca134775edffb77857f436359d3a50b90 URL: https://github.com/llvm/llvm-project/commit/7818906ca134775edffb77857f436359d3a50b90 DIFF: https://github.com/llvm/llvm-project/commit/7818906ca134775edffb77857f436359d3a50b90.diff

[clang] 95c614a - [NFC][SYCL] Drop idle triple component from regression tests.

2021-04-13 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2021-04-13T08:00:21+03:00 New Revision: 95c614afcd4de71d00a240d6a4a02c036c972ed0 URL: https://github.com/llvm/llvm-project/commit/95c614afcd4de71d00a240d6a4a02c036c972ed0 DIFF: https://github.com/llvm/llvm-project/commit/95c614afcd4de71d00a240d6a4a02c036c972ed0.diff

[clang] a500a43 - [CodeGen][AMDGPU] Fix ICE for static initializer IR generation

2020-12-12 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-12-12T23:26:54+03:00 New Revision: a500a4358789d1794bc672421c55900ea2bbc938 URL: https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938 DIFF: https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938.diff

[clang] 9263931 - [SYCL] Assume SYCL device functions are convergent

2020-09-29 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-09-29T15:23:50+03:00 New Revision: 9263931fcccdc99000c1de668bea330711333729 URL: https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729 DIFF: https://github.com/llvm/llvm-project/commit/9263931fcccdc99000c1de668bea330711333729.diff

[clang] 8d27be8 - [OpenCL] Add global_device and global_host address spaces

2020-07-29 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-07-29T17:24:53+03:00 New Revision: 8d27be8dbaffce0519ac41173d51923fc2524b1b URL: https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b DIFF: https://github.com/llvm/llvm-project/commit/8d27be8dbaffce0519ac41173d51923fc2524b1b.diff

[clang] 0bdcd95 - [SYCL][OpenMP] Implement thread-local storage restriction

2020-06-17 Thread Alexey Bader via cfe-commits
Author: Mariya Podchishchaeva Date: 2020-06-17T14:36:00+03:00 New Revision: 0bdcd95bf20f159a2512aff1ef032bec52039bf6 URL: https://github.com/llvm/llvm-project/commit/0bdcd95bf20f159a2512aff1ef032bec52039bf6 DIFF: https://github.com/llvm/llvm-project/commit/0bdcd95bf20f159a2512aff1ef032bec52039b

[clang] 93cd411 - [NFC] Run clang-format on clang/test/OpenMP/nvptx_target_codegen.cpp

2020-06-17 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-06-17T13:04:01+03:00 New Revision: 93cd4115799cefa698833ca7a2f1899243d94c77 URL: https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77 DIFF: https://github.com/llvm/llvm-project/commit/93cd4115799cefa698833ca7a2f1899243d94c77.diff

[clang] bd85b7d - [OpenMP][SYCL] Do not crash on attempt to diagnose unsupported type use

2020-05-30 Thread Alexey Bader via cfe-commits
Author: Mariya Podchishchaeva Date: 2020-05-30T12:27:58+03:00 New Revision: bd85b7d6688725e854a694f9f3e8baa6a3077a4a URL: https://github.com/llvm/llvm-project/commit/bd85b7d6688725e854a694f9f3e8baa6a3077a4a DIFF: https://github.com/llvm/llvm-project/commit/bd85b7d6688725e854a694f9f3e8baa6a3077a

[clang] cf6cc66 - [OpenMP][SYCL] Improve diagnosing of unsupported types usage

2020-05-29 Thread Alexey Bader via cfe-commits
Author: Mariya Podchishchaeva Date: 2020-05-29T18:00:48+03:00 New Revision: cf6cc6622b1416430f517850be9032788e39 URL: https://github.com/llvm/llvm-project/commit/cf6cc6622b1416430f517850be9032788e39 DIFF: https://github.com/llvm/llvm-project/commit/cf6cc6622b1416430f517850be9032788e

[clang] e95ee30 - [SYCL] Prohibit arithmetic operations for incompatible pointers

2020-05-22 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-05-22T13:43:24+03:00 New Revision: e95ee300c0530158d86430fd82ffabd36262e862 URL: https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862 DIFF: https://github.com/llvm/llvm-project/commit/e95ee300c0530158d86430fd82ffabd36262e862.diff

[clang] 118b057 - [SYCL] Driver option to select SYCL version

2020-03-07 Thread Alexey Bader via cfe-commits
Author: Ruyman Date: 2020-03-07T18:28:54+03:00 New Revision: 118b057f1268d1789e40ffceb214e73772df04f4 URL: https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4 DIFF: https://github.com/llvm/llvm-project/commit/118b057f1268d1789e40ffceb214e73772df04f4.diff LOG: [

[clang] 740ed61 - Revert "[SYCL] Driver option to select SYCL version"

2020-02-27 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-02-27T16:23:54+03:00 New Revision: 740ed617f7d4d16e7883636c5eff994f8be7eba4 URL: https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4 DIFF: https://github.com/llvm/llvm-project/commit/740ed617f7d4d16e7883636c5eff994f8be7eba4.diff

[clang] bd97704 - [SYCL] Driver option to select SYCL version

2020-02-27 Thread Alexey Bader via cfe-commits
Author: Ruyman Date: 2020-02-27T15:08:42+03:00 New Revision: bd97704eb5a95ecb048ce343c1a4be5d94e5 URL: https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 DIFF: https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5.diff LOG: [

[clang] 863d975 - [SYCL][Driver] Add clang driver option to enable SYCL compilation mode

2020-02-06 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-02-06T08:42:31+03:00 New Revision: 863d9752105f390b31b3d08d1980d2888c15b034 URL: https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034 DIFF: https://github.com/llvm/llvm-project/commit/863d9752105f390b31b3d08d1980d2888c15b034.diff

[clang] dd18729 - [Attr][Doc][NFC] Fix code snippet formatting for attribute documentation

2020-01-21 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-01-21T18:30:56+03:00 New Revision: dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97 URL: https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97 DIFF: https://github.com/llvm/llvm-project/commit/dd18729b2a7a23b76b8d74fbf4f4bb4efbe8aa97.diff

[clang] 128f39d - Fix crash in getFullyQualifiedName for inline namespace

2019-12-28 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2019-12-28T16:35:51+03:00 New Revision: 128f39da932be50cb49646084820119e6e0d1e22 URL: https://github.com/llvm/llvm-project/commit/128f39da932be50cb49646084820119e6e0d1e22 DIFF: https://github.com/llvm/llvm-project/commit/128f39da932be50cb49646084820119e6e0d1e22.diff

[clang] 2d6a5e4 - [OpenMP][Test] Add check for aux-triple predefined macros

2019-12-12 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2019-12-12T14:36:11+03:00 New Revision: 2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d URL: https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d DIFF: https://github.com/llvm/llvm-project/commit/2d6a5e4fe45d0a1f1c94df6b3422ffb0d676fb6d.diff

[clang] cb30ad7 - [SYCL] Add support for auxiliary triple specification to Frontend

2019-12-11 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2019-12-11T12:40:43+03:00 New Revision: cb30ad728f0b791c72a6a1399f36ebc60ad5 URL: https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5 DIFF: https://github.com/llvm/llvm-project/commit/cb30ad728f0b791c72a6a1399f36ebc60ad5.diff

[clang] 11a9bae - [AST] Enable expression of OpenCL language address spaces an attribute

2019-12-05 Thread Alexey Bader via cfe-commits
Author: Victor Lomuller Date: 2019-12-05T12:24:06+03:00 New Revision: 11a9bae8f66986751078501988b4414f24dbe37e URL: https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e DIFF: https://github.com/llvm/llvm-project/commit/11a9bae8f66986751078501988b4414f24dbe37e.dif

[clang] c094e7d - [SYCL] Add sycl_kernel attribute for accelerated code outlining

2019-12-03 Thread Alexey Bader via cfe-commits
Author: Mariya Podchishchaeva Date: 2019-12-03T16:13:22+03:00 New Revision: c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd URL: https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496abd DIFF: https://github.com/llvm/llvm-project/commit/c094e7dc4b3f9d1c1e590b008bb1cc46e3496a

r354773 - [SYCL] Add clang front-end option to enable SYCL device compilation flow.

2019-02-25 Thread Alexey Bader via cfe-commits
Author: bader Date: Mon Feb 25 03:48:48 2019 New Revision: 354773 URL: http://llvm.org/viewvc/llvm-project?rev=354773&view=rev Log: [SYCL] Add clang front-end option to enable SYCL device compilation flow. Patch by Mariya Podchishchaeva Added: cfe/trunk/test/Preprocessor/sycl-macro.cpp (w

r354337 - [OpenCL] Change type of block pointer for OpenCL

2019-02-19 Thread Alexey Bader via cfe-commits
Author: bader Date: Tue Feb 19 07:19:06 2019 New Revision: 354337 URL: http://llvm.org/viewvc/llvm-project?rev=354337&view=rev Log: [OpenCL] Change type of block pointer for OpenCL Summary: For some reason OpenCL blocks in LLVM IR are represented as function pointers. These pointers do not point

r335103 - [Sema] Allow creating types with multiple of the same addrspace.

2018-06-20 Thread Alexey Bader via cfe-commits
Author: bader Date: Wed Jun 20 01:31:24 2018 New Revision: 335103 URL: http://llvm.org/viewvc/llvm-project?rev=335103&view=rev Log: [Sema] Allow creating types with multiple of the same addrspace. Summary: The comment with the OpenCL clause about this clearly says: "No type shall be qualified by

r323522 - [OpenCL] Add "cles_khr_int64" extension.

2018-01-26 Thread Alexey Bader via cfe-commits
Author: bader Date: Fri Jan 26 03:48:46 2018 New Revision: 323522 URL: http://llvm.org/viewvc/llvm-project?rev=323522&view=rev Log: [OpenCL] Add "cles_khr_int64" extension. Summary: For OpenCL 1.1 embedded profile 64 bit integers i.e. long, ulong including the appropriate vector data types and op

r318290 - [OpenCL] Fix code generation of function-scope constant samplers.

2017-11-15 Thread Alexey Bader via cfe-commits
Author: bader Date: Wed Nov 15 03:38:17 2017 New Revision: 318290 URL: http://llvm.org/viewvc/llvm-project?rev=318290&view=rev Log: [OpenCL] Fix code generation of function-scope constant samplers. Summary: Constant samplers are handled as static variables and clang's code generation library, whi

r315453 - [OpenCL] Allow function declaration with empty argument list.

2017-10-11 Thread Alexey Bader via cfe-commits
Author: bader Date: Wed Oct 11 04:16:31 2017 New Revision: 315453 URL: http://llvm.org/viewvc/llvm-project?rev=315453&view=rev Log: [OpenCL] Allow function declaration with empty argument list. Treat 'f()' as 'f(void)' rather than a function w/o a prototype. Reviewers: Anastasia, yaxunl Reviewe

r306653 - [OpenCL] Allow function declaration with empty argument list.

2017-06-29 Thread Alexey Bader via cfe-commits
Author: bader Date: Thu Jun 29 01:44:10 2017 New Revision: 306653 URL: http://llvm.org/viewvc/llvm-project?rev=306653&view=rev Log: [OpenCL] Allow function declaration with empty argument list. Summary: does it make sense to enable K&R function declaration style for OpenCL? clang throws following

  1   2   3   >