[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

2019-06-14 Thread Alexandre Eichenberger via Phabricator via cfe-commits
AlexEichenberger added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:5122 +NewTask = CGF.EmitRuntimeCall( + createRuntimeFunction(OMPRTL__kmpc_omp_target_task_alloc), AllocArgs); + } else { gtbercea wrote: > ABataev wrote: > > gtbercea wr

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

2019-06-12 Thread Alexandre Eichenberger via Phabricator via cfe-commits
AlexEichenberger accepted this revision. AlexEichenberger added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63009/new/ https://reviews.llvm.org/D63009 __

[PATCH] D63010: [OpenMP] Add task alloc function

2019-06-11 Thread Alexandre Eichenberger via Phabricator via cfe-commits
AlexEichenberger accepted this revision. AlexEichenberger added a comment. This revision is now accepted and ready to land. LGTM Repository: rOMP OpenMP CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63010/new/ https://reviews.llvm.org/D63010 ___

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

2019-06-10 Thread Alexandre Eichenberger via Phabricator via cfe-commits
AlexEichenberger added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:610 + // size_t sizeof_shareds, kmp_routine_entry_t *task_entry, + // size_t device_id); + OMPRTL__kmpc_omp_target_task_alloc, device_id is int64_t Comment a

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

2019-04-16 Thread Alexandre Eichenberger via Phabricator via cfe-commits
AlexEichenberger accepted this revision. AlexEichenberger added a comment. This revision is now accepted and ready to land. fantastic Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 _

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

2019-04-12 Thread Alexandre Eichenberger via Phabricator via cfe-commits
AlexEichenberger requested changes to this revision. AlexEichenberger added a comment. This revision now requires changes to proceed. see note above; apologies if it is already done and hiding somewhere I did not see Comment at: lib/CodeGen/CGOpenMPRuntime.h:641 + /// directi