apivovarov wrote:
If there are no further questions, comments, or objections, I will merge this
PR in a few hours.
https://github.com/llvm/llvm-project/pull/99698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
apivovarov wrote:
@tschuett, Could you please help review this change?
https://github.com/llvm/llvm-project/pull/99698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/99698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/99698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/99698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/99698
>From 1bddc5cd8414453fd1e3b4f1ef297194f54eaa6c Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 19 Jul 2024 19:28:33 +
Subject: [PATCH] [APFloat] Add support for f8E3M4 IEEE 754 type
---
cla
https://github.com/apivovarov created
https://github.com/llvm/llvm-project/pull/99698
This PR adds `f8E4M3` type to APFloat.
`f8E3M4` type follows IEEE 754 convention
```c
f8E3M4 (IEEE 754)
- Exponent bias: 3
- Maximum stored exponent value: 6 (binary 110)
- Maximum unbiased exponent value: 6
https://github.com/apivovarov closed
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apivovarov wrote:
If there are no further questions, comments, or objections, I will merge this
PR in a few hours.
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
apivovarov wrote:
@ThomasRaoux Could you please help with reviewing this PR? It seems that this
PR was overlooked.
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
apivovarov wrote:
Hi @tschuett, @arsenm
I wanted to kindly request your review on this f8E4M3 PR when you have a moment.
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From 9b2e06f794ce810e9a7e68be64c46c2a31d695d9 Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH 1/2] [APFloat] Add support for f8E4M3 IEEE 754 type
---
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97179
>From 9b2e06f794ce810e9a7e68be64c46c2a31d695d9 Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH] [APFloat] Add support for f8E4M3 IEEE 754 type
---
cla
@@ -460,10 +460,10 @@ class alignas(void *) Stmt {
unsigned : NumExprBits;
static_assert(
-llvm::APFloat::S_MaxSemantics < 16,
-"Too many Semantics enum values to fit in bitfield of size 4");
+llvm::APFloat::S_MaxSemantics < 32,
+"Too ma
@@ -136,6 +136,7 @@ static constexpr fltSemantics semIEEEquad = {16383, -16382,
113, 128};
static constexpr fltSemantics semFloat8E5M2 = {15, -14, 3, 8};
static constexpr fltSemantics semFloat8E5M2FNUZ = {
15, -15, 3, 8, fltNonfiniteBehavior::NanOnly,
fltNanEncoding::Nega
apivovarov wrote:
Thorsten, Matt, looks like this PR was lost. Can you look at this PR one more
time? @tschuett @arsenm
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
apivovarov wrote:
> Hey @apivovarov I just wanted to say my bad for not getting to this yet - I'm
> buried at work but I haven't forgotten. If it's hipri I can find someone else
> to review. Otherwise ~couple of days I think and I'll be clear to review.
Hi Maksim, I think it has standard prior
apivovarov wrote:
> Hey @apivovarov I think this needs a rebase on top #97179?
Just rebased
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From 42cfec8242442119df7f64e3bcfbdc4de66cc13d Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH 1/2] [APFloat] Add support for f8E4M3 IEEE 754 type
---
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97179
>From 42cfec8242442119df7f64e3bcfbdc4de66cc13d Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH] [APFloat] Add support for f8E4M3 IEEE 754 type
---
cla
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -136,6 +136,7 @@ static constexpr fltSemantics semIEEEquad = {16383, -16382,
113, 128};
static constexpr fltSemantics semFloat8E5M2 = {15, -14, 3, 8};
static constexpr fltSemantics semFloat8E5M2FNUZ = {
15, -15, 3, 8, fltNonfiniteBehavior::NanOnly,
fltNanEncoding::Nega
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apivovarov wrote:
Changed commit message to "[APFloat] Add support for f8E4M3 IEEE 754 type" to
match PR title. And Rebased
https://github.com/llvm/llvm-project/pull/97179
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97179
>From 2c5a29ebe92a8352c31e34a36ff73959ce04a557 Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH] [APFloat] Add support for f8E4M3 IEEE 754 type
---
cla
apivovarov wrote:
Thorsten, Matt, What you think about adding the following tests?
```c
// E4M3 <-> E5M2
ConvertE4M3ToE5M2
ConvertE5M2ToE4M3
// E4M3 <-> E4M3FN
ConvertE4M3ToE4M3FN
ConvertE4M3FNToE4M3
```
@tschuett @arsenm
https://github.com/llvm/llvm-project/pull/97179
_
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97179
>From 639ca43f1c57657ecaeb43a097664bae008093fd Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH] Add f8E4M3 IEEE 754 type to llvm
---
clang/include/cla
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From 38a885014046f5e696a98361586919d14362dbed Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH 1/2] Add f8E4M3 IEEE 754 type to llvm
---
clang/include
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From 38a885014046f5e696a98361586919d14362dbed Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 21:09:33 +
Subject: [PATCH 1/2] Add f8E4M3 IEEE 754 type to llvm
---
clang/include
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apivovarov wrote:
> If this is a new float type, could you please split out the apfloat changes
> in separate PR.
Sure - [PR-97179](https://github.com/llvm/llvm-project/pull/97179) Add f8E4M3
IEEE 754 type to llvm
https://github.com/llvm/llvm-project/pull/97118
___
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov created
https://github.com/llvm/llvm-project/pull/97179
This PR adds `f8E4M3` type to llvm.
`f8E4M3` type follows IEEE 754 convention
```c
f8E4M3 (IEEE 754)
- Exponent: 4
- Mantissa: 3
- Exponent bias: 7
- Follows IEEE 754 conventions for representation of specia
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From e5fb4d85889472fd9880e5262d3a9cf00e1b1f89 Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 19:33:21 +
Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From 0b76af07d0dc567cbbcceeca2bc3858837875498 Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 19:33:21 +
Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa
https://github.com/apivovarov edited
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From 8b0671585864e13d26596b9e8ada39364c542517 Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 19:33:21 +
Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa
apivovarov wrote:
Reed, Benjamin, Can you look at this PR too? @reedwm @d0k
https://github.com/llvm/llvm-project/pull/97118
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From 8b0671585864e13d26596b9e8ada39364c542517 Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 19:33:21 +
Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa
https://github.com/apivovarov updated
https://github.com/llvm/llvm-project/pull/97118
>From f6d1c7120bbb382a5b38bd2172e743e7808e304c Mon Sep 17 00:00:00 2001
From: Alexander Pivovarov
Date: Fri, 28 Jun 2024 19:33:21 +
Subject: [PATCH 1/2] Rename f8E4M3 to f8E4M3FN in mlir.extras.types py pa
https://github.com/apivovarov created
https://github.com/llvm/llvm-project/pull/97118
This PR adds `f8E4M3` type which follows IEEE 754 convention
```c
f8E4M3 (IEEE 754)
- Exponent: 4
- Mantissa: 3
- Exponent bias: 7
- Follows IEEE 754 conventions for representation of special values
- Has Posi
Author: Alexander Pivovarov
Date: 2021-09-08T23:59:04-07:00
New Revision: 4bc8dbe0cae32f15008c1e98e7dd7d128e9dcbb6
URL:
https://github.com/llvm/llvm-project/commit/4bc8dbe0cae32f15008c1e98e7dd7d128e9dcbb6
DIFF:
https://github.com/llvm/llvm-project/commit/4bc8dbe0cae32f15008c1e98e7dd7d128e9dcbb6
Author: Alexander Pivovarov
Date: 2021-09-02T18:45:25-07:00
New Revision: 6cd4b508a8a51ecd16d2b0297dfeb445ab41b42e
URL:
https://github.com/llvm/llvm-project/commit/6cd4b508a8a51ecd16d2b0297dfeb445ab41b42e
DIFF:
https://github.com/llvm/llvm-project/commit/6cd4b508a8a51ecd16d2b0297dfeb445ab41b42e
50 matches
Mail list logo
