Re: [PATCH] D13048: Fix for merging decls in pragma weak

This revision was automatically updated to reflect the committed changes. Closed by commit rL254143: Fix for merging decls in pragma weak (authored by amusman). Changed prior to commit: http://reviews.llvm.org/D13048?vs=35348&id=41216#toc Repository: rL LLVM http://reviews.llvm.org/D13048

r254143 - Fix for merging decls in pragma weak

Author: amusman Date: Thu Nov 26 03:34:30 2015 New Revision: 254143 URL: http://llvm.org/viewvc/llvm-project?rev=254143&view=rev Log: Fix for merging decls in pragma weak Calling CheckFunctionDeclaration so that 2 decls for the 'weak' are merged. Differential Revision: http://reviews.llvm.org/D130

Re: [PATCH] D13048: Fix for merging decls in pragma weak

amusman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5201 @@ -5200,5 +5200,3 @@ if (FunctionDecl *FD = dyn_cast(ND)) { -FunctionDecl *NewFD; -// FIXME: Missing call to CheckFunctionDeclaration(). // FIXME: Mangling? // FIXME: Is the qualifier i

[PATCH] D13048: Fix for merging decls in pragma weak

amusman created this revision. amusman added reviewers: rsmith, aaron.ballman, ABataev. amusman added a subscriber: cfe-commits. In the following example, we have a declaration of weakfoo before #pragma weak. extern void weakfoo(); void localfoo() { }

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

amusman closed this revision. amusman added a comment. Thanks, I've commited the changes in revision 248158 (but forgot to add link in svn commit message). Alexander http://reviews.llvm.org/D12955 ___ cfe-commits mailing list cfe-commits@lists.llvm

r248158 - Fix assertion in inline assembler IR gen

Author: amusman Date: Mon Sep 21 09:41:00 2015 New Revision: 248158 URL: http://llvm.org/viewvc/llvm-project?rev=248158&view=rev Log: Fix assertion in inline assembler IR gen Several inputs may not refer to one output constraint in inline assembler insertions, clang was failing on assertion on suc

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

amusman updated this revision to Diff 35222. amusman added a comment. Added an assertion for TiedTo value. http://reviews.llvm.org/D12955 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaStmtAsm.cpp test/Sema/asm.c Index: lib/Sema/SemaStmtAsm.cpp ===

Re: [PATCH] D12955: Fix assertion in inline assembler IR gen

amusman added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:447 @@ +446,3 @@ +// Make sure no more than one input constraint matches each output. +if (InputMatchedToOutput[TiedTo] != ~0U) { + Diag(NS->getInputExpr(i)->getLocStart(), aaron.ball

[PATCH] D12955: Fix assertion in inline assembler IR gen

amusman created this revision. amusman added reviewers: rsmith, aaron.ballman, ABataev. amusman added a subscriber: cfe-commits. Several inputs may not refer to one output constraint in inline assembler insertions, clang fails on assertion on such test case here: llvm/lib/IR/InlineAsm.cpp:46: ll

Re: [PATCH] D12904: fix for assertion fail for pragma weak on typedef

This revision was automatically updated to reflect the committed changes. Closed by commit rL247975: Fix for assertion fail for pragma weak on typedef. (authored by amusman). Changed prior to commit: http://reviews.llvm.org/D12904?vs=34987&id=35066#toc Repository: rL LLVM http://reviews.llv

r247975 - Fix for assertion fail for pragma weak on typedef.

Author: amusman Date: Fri Sep 18 02:40:22 2015 New Revision: 247975 URL: http://llvm.org/viewvc/llvm-project?rev=247975&view=rev Log: Fix for assertion fail for pragma weak on typedef. Example: typedef int __td3; #pragma weak td3 = __td3 Differential Revision: http://reviews.llvm.org/D12904 Mod

Re: [PATCH] D12904: fix for assertion fail for pragma weak on typedef

amusman updated this revision to Diff 34987. amusman added a comment. Hi Aaron, Thank you for review. I've updated the warning for such cases. Regards, Alexander http://reviews.llvm.org/D12904 Files: lib/Sema/Sema.cpp lib/Sema/SemaDecl.cpp test/CodeGen/pragma-weak.c Index: lib/Sema/Sem

[PATCH] D12904: fix for assertion fail for pragma weak on typedef

amusman created this revision. amusman added reviewers: rsmith, ABataev. amusman added a subscriber: cfe-commits. Can you please review a fix for assertion fail on the following small test: typedef int __td3; #pragma weak td3 = __td3 Assertion failed: (isa(ND) || isa(ND)), function DeclClonePra