[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

alexolog added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") owenpan wrote: > alexolog wrote: > > alexolog wrote: > > > Here's my attempt at something flexible

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

alexolog added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") alexolog wrote: > Here's my attempt at something flexible: > Disclaimer: this is my first time loo

[PATCH] D142804: [clang-format] Support clang-format on/off line comments as prefixes

alexolog added inline comments. Comment at: clang/lib/Format/Format.cpp:3893 +bool isClangFormatOn(StringRef Comment) { + if (Comment == "/* clang-format on */") Here's my attempt at something flexible: Disclaimer: this is my first time looking at the LLVM cod

[PATCH] D118011: [RISCV] Adjust predicates and update intrinsic for clmul and clmulh in Zbkc extension

alextsao1999 added a comment. In D118011#3265374 , @Jimerlife wrote: > In D118011#3265071 , @craig.topper > wrote: > >> Will you also be updating clang's RISCVBuiltins.def? >> >> Can you add tests? > > I update B

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

alextsao1999 updated this revision to Diff 398354. alextsao1999 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116722/new/ https://reviews.llvm.org/D116722 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

alextsao1999 created this revision. alextsao1999 added a reviewer: compnerd. alextsao1999 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds to verify whether the ssp buffer size is a legal integer and a new diagnostic driver