alextsao1999 updated this revision to Diff 415737.
alextsao1999 added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D121779/new/
https://reviews.llvm.org/D121779
Files:
llvm/lib/Target/RISCV/RISCVInstrInfoC.td
llvm/test/MC/RIS
alextsao1999 created this revision.
alextsao1999 added a reviewer: s.
Herald added subscribers: VincentWu, luke957, vkmr, frasercrmck, jdoerfert,
evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,
jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,
alextsao1999 added inline comments.
Comment at: clang/lib/Tooling/Syntax/Pseudo/GLRParser.cpp:318
Bases.push_back(
-{Base, ParsingTable.getGoToState(Base->State, ReduceRule.Target)});
+{Base, ParsingTable.getGoToState(Base->State, ReduceSymbolID)}
alextsao1999 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96
+ uint8_t DotPos = 0;
+ uint8_t RuleLength = 0; // the length of rule body.
+};
sammccall wrote:
> alextsao1999 wrote:
> > hokein wrote:
> > > alextsao1999 wr
alextsao1999 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96
+ uint8_t DotPos = 0;
+ uint8_t RuleLength = 0; // the length of rule body.
+};
hokein wrote:
> alextsao1999 wrote:
> > Can we add LookaheadSymbol here to imp
alextsao1999 added inline comments.
Herald added a project: All.
Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96
+ uint8_t DotPos = 0;
+ uint8_t RuleLength = 0; // the length of rule body.
+};
Can we add LookaheadSymbol here to implement LR(1
alextsao1999 marked 2 inline comments as done.
alextsao1999 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3209
+} else
+ D.Diag(clang::diag::err_invalid_ssp_buffer_size);
}
compnerd wrote:
> Please consistently u