[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

This revision was automatically updated to reflect the committed changes. Closed by commit rG638dcea010cf: [clang] Implement P0692R1 from C++20 (access checking on specializations and… (authored by aorlov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 354193. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseTemplate.cpp cla

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Just a ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 346289. aorlov added a comment. Simplified the solution. Replaced RemoveDiagnosticsFromPool with SuppressAccessChecks. @krisb, please, look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://revi

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. @krisb Thanks for the review. Comment at: clang/lib/Parse/ParseDecl.cpp:3080 +// For instance this marked as unavailable: +//class __attribute((unavailable)) UnavailableClass;` +auto RemoveAccessCheckingDiagnostics = [&TemplateInfo, this]

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 340099. aorlov added a comment. Updated. @krisb, please, verify. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/include/clang/Parse/Parser.h clang/incl

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 340095. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DelayedDiagnostic.h clang/lib/Parse/ParseD

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added inline comments. Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {} +template void func11(A::C, A::D, int) {} +template void func12() {} krisb wrote: > aorlov wrote: > > krisb wrote: > > > Before this

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. @krisb In D92024#2677857 , @krisb wrote: > Do we still need the following tests: > > - clang/test/CXX/temp/temp.spec/temp.explicit/p11.cpp > - clang/test/CXX/temp/temp.spec/temp.explicit/p12.cpp > > ? We can remove **p11.cpp** and

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. @krisb Thank you for your comments. I will consider them. Comment at: clang/test/CXX/temp/temp.spec/func.spec.cpp:105 +template void func10(A::B, int x) {} +template void func11(A::C, A::D, int) {} +template void func12() {} krisb wro

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Ping! Please, review this patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Just one more ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Ping! Please, don't pass by this patch. I need your competent evaluation to load it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Hi, community. I kindly ask you to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-com

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. One more ping. Please, pay attention to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commi

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Please, look at my solution. Is it worth to be accepted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Just a ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added inline comments. Comment at: clang/test/CXX/class.access/class.friend/p1.cpp:290 A::I f2(A::I i = A::x) {} // expected-error 3 {{is a private member of}} - template A::I g2(A::I i) { // expected-error 2 {{is a private member of}} + template A::I g2(A::I i) { /

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 315840. aorlov added a comment. @Quuxplusone Thank you for your comments. I updated the patch according to your suggestions. Does anyone else from the review list want to waste some time to look at this patch? I would appreciate this. Repository: rG LLVM

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Please, somebody look at this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. One more ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. Hi, community. I kindly ask you to review this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 ___ cfe-commits mailing list cfe-com

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 311431. aorlov added reviewers: mibintc, hokein. aorlov added subscribers: mibintc, hokein. aorlov added a comment. Updated. Disabled function parameters access checking in function templates. Hi, @broadwaylamb, @rsmith, @saar.raz, @doug.gregor, @mibintc, @hoke

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 310416. aorlov added a comment. Simplify the patch. @Quuxplusone, Actually you've pushed me to some thinking of what more syntactic cases it could be. And I came to that we can get rid of this hack and simplify the patch pretty much. Hope, this fix will be mo

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added inline comments. Comment at: clang/lib/Parse/ParseTemplate.cpp:172 + + // TODO. This can produce wrong detection in case of a later class + // declaration. Example: Quuxplusone wrote: > I don't know the purpose of this code, but this //seems// like

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 309959. aorlov added a comment. Added test cases for explicit instantiations. > @Quuxplusone, > In particular, I'm very interested to know if P0692 is intended to have any > effect on the legality of https://godbolt.org/z/fqfo8q I've checked your particular

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov added a comment. In D92024#2431452 , @Quuxplusone wrote: > The subject line says "access checking on specializations and > instantiations," but I don't see any tests for explicit instantiations here — > just specializations. In particular, I'm ver

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 309252. aorlov added a comment. Fixed typos. Made minor changes in test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/include/clang/Parse/Parser.

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 308373. aorlov added a comment. Improved solution. Added more tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://reviews.llvm.org/D92024 Files: clang/include/clang/Parse/Parser.h clang/

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 307461. aorlov retitled this revision from "[clang] Partially implement P0692R1 from C++20 (access checking on specializations)" to "[clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)". aorlov edited the summary of thi

[PATCH] D92024: [clang] Partially implement P0692R1 from C++20 (access checking on specializations)

aorlov created this revision. aorlov added reviewers: broadwaylamb, rsmith, saar.raz, doug.gregor. aorlov added projects: LLVM, clang. Herald added a subscriber: cfe-commits. aorlov requested review of this revision. Disable usual access checking rules to template argument names in a declaration

[PATCH] D90054: Added remotely ran compiler-rt tests.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8aaafa06b2af: Added remotely ran compiler-rt tests. (authored by aorlov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D90054: Added remotely ran compiler-rt tests.

aorlov updated this revision to Diff 300708. aorlov added a comment. Disable compiler-rt crt tests for cross ARM builders since the tests are broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90054/new/ https://reviews.llvm.org/D90054 Files:

[PATCH] D90054: Added remotely ran compiler-rt tests.

aorlov created this revision. aorlov added reviewers: vvereschaka, broadwaylamb. aorlov added a project: LLVM. Herald added subscribers: cfe-commits, mgorny, dberris. Herald added a project: clang. aorlov requested review of this revision. Use LLVM/utils/remote-exec.py to run compiler-rt tests rem