[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-05 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes Message-ID: In-Reply-To: https://github.c

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-05 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes Message-ID: In-Reply-To:

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-05 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes Message-ID: In-Reply-To: asb wrote: I'm

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-04 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes Mess

[clang] Revert "[CLANG-CL] ignores wpadded" (PR #134239)

2025-04-04 Thread Alex Bradbury via cfe-commits
asb wrote: Pre-commit tests show this reverts cleanly. I'll commit directly in line with our patch reversion policy https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy https://github.com/llvm/llvm-project/pull/134239 ___ cfe-commits mai

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-04 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes Message-ID: In-Reply-To:

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-03 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes , =?utf-8?q?Th=C3=A9o?= De Magalhaes Mess

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-03 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes Message-ID: In-Reply-To:

[clang] [CLANG-CL] ignores wpadded (PR #130182)

2025-04-03 Thread Alex Bradbury via cfe-commits
=?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes , =?utf-8?q?Théo?= De Magalhaes Message-ID: In-Reply-To:

[clang] Revert "[CLANG-CL] ignores wpadded" (PR #134239)

2025-04-03 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/134239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[CLANG-CL] ignores wpadded" (PR #134239)

2025-04-03 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/134239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] SiFive CLIC Support (PR #132481)

2025-03-27 Thread Alex Bradbury via cfe-commits
@@ -486,6 +486,24 @@ def : SysReg<"mctrctl", 0x34e>; // Vendor CSRs //===--- +// XSfmclic +let FeaturesRequired = [{ {RISCV::FeatureVendorXSfmclic} }] in { +def : SysReg<"mtvt", 0x307>; +def : SysReg<"mnxti", 0x345>; +def : SysReg<"m

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-13 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/126352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-13 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/126352 >From 446b59bd47eb5356454665eeb82e75a77862350a Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Sat, 8 Feb 2025 06:27:26 + Subject: [PATCH 1/2] [doc] Add Discord invite link alongside channel links By far the

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-09 Thread Alex Bradbury via cfe-commits
@@ -12,7 +12,8 @@ The LLVM C Library LLVM-libc is not fully complete right now. Some programs may fail to build due to missing functions. If you would like to help us finish LLVM-libc, check out "`Contributing to the libc project `__" in the sidebar - or ask on `discord

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-07 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/126352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-07 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/126352 By far the most important part of this patch is updating GettingInvolved.rst to include the invite link, but I've grepped for any other discord.com links. I'm no Discord expert, but from my experience (confirmed via

[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)

2025-01-25 Thread Alex Bradbury via cfe-commits
asb wrote: > It could be due to builtins, I believe we always serialize them, and that > would be different between targets. Does RISC-V have a lot of them compared > to other targets? That's almost certainly it then, thanks! We have a _lot_ of vector builtins in particular. https://github.c

[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)

2025-01-23 Thread Alex Bradbury via cfe-commits
asb wrote: Thanks, I've gone ahead an merged. Any insight into why the module files may be larger on RISC-V vs other targets greatly appreciated - as I said in https://github.com/llvm/llvm-project/pull/111360 I'm not sure how to best inspect the module files. https://github.com/llvm/llvm-proj

[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)

2025-01-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/123959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Modules] Raise empty.modulemap expected size to <70KB to fix RISC-V failure (PR #123959)

2025-01-22 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/123959 I'm not sure why the test is larger for RISC-V than other targets, but we saw this before with #111360. The file is just over the current 60KB limit: ``` 62772 /home/asb/llvm-project/build/stage2/tools/clang/test/

[clang] [clang][ARM] disable frame pointers by default for bare metal ARM targets (PR #117140)

2024-12-08 Thread Alex Bradbury via cfe-commits
asb wrote: I think this change in behaviour deserves an entry in clang/docs/ReleaseNotes.rst https://github.com/llvm/llvm-project/pull/117140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang] [llvm] [RISC-V] Add support for MIPS P8700 CPU (PR #117865)

2024-11-28 Thread Alex Bradbury via cfe-commits
asb wrote: > RFC: > https://discourse.llvm.org/t/rfc-risc-v-add-support-for-mips-p8700-cpu/83365 Thank you Djordje - I've left some high level comments in response to your RFC post https://github.com/llvm/llvm-project/pull/117865 ___ cfe-commits ma

[clang] [llvm] [RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-11-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/113942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-11-09 Thread Alex Bradbury via cfe-commits
asb wrote: I've added the CHECK lines to riscv-profiles.c as spotted by @topperc, and based on the above discussion I think this is now ready to review. https://github.com/llvm/llvm-project/pull/113942 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [llvm] [RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-11-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/113942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RFC][RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-11-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/113942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RFC][RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-11-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/113942 >From 47418b35a6e3e02eb20ff7b81f45571bf1322f5b Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 28 Oct 2024 14:42:44 + Subject: [PATCH 1/3] [RISCV] Mark RVB23U64 and RVB23S64 as non-experimental The speci

[clang] [llvm] [RFC][RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-11-07 Thread Alex Bradbury via cfe-commits
asb wrote: > I think we shouldn't do this for RVA22, so as not to break existing users of > that profile, who may have a toolchain that doesn't support B. > > This change makes sense to me for the RV*23 profiles, especially since your > change to RVM23 has been accepted. For RVA22, I had a lo

[clang] [RISCV] Add sha and supm to checks in riscv-profiles.c (PR #114123)

2024-10-29 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. Thanks. https://github.com/llvm/llvm-project/pull/114123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Mark RVB23U64 and RVB23S64 as non-experimental (PR #113918)

2024-10-29 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/113918 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RFC][RISCV] Use the 'B' extension in RISC-V profile definitions (PR #113942)

2024-10-28 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113942 Stacks on top of #113918. RVA22 has retroactively been defined as including 'B' (as it's a shorthand for Zba+Zbb+Zbs, which were previously explicitly enumerated) and RV{A,B,M}23 are defined featuring B. We don't cur

[clang] [llvm] [RISCV] Mark RVB23U64 and RVB23S64 as non-experimental (PR #113918)

2024-10-28 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113918 The specification was recently ratified . >From 47418b35a6e3e02eb20ff7b81f45571bf1322f5b Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: M

[clang] [llvm] [RISCV] Add the Sha extension (PR #113820)

2024-10-28 Thread Alex Bradbury via cfe-commits
asb wrote: > > I haven't made it so if you enable all extensions that constitute Sha, Sha > > is implied. > > Great! I think it's most clear if we have "extensions only require things > they are made up of" (i.e. all the implications/requirements point to > earlier/lesser extensions) and "pro

[clang] [llvm] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental (PR #113826)

2024-10-28 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/113826 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental (PR #113826)

2024-10-28 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/113826 >From 9bba67ede7450699bfa095c69e24f052a8ef36c7 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Sun, 27 Oct 2024 17:54:47 + Subject: [PATCH] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental

[clang] [llvm] [RISCV] Use Sha extension in RVA23S64 profile (PR #113823)

2024-10-28 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/113823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add the Sha extension (PR #113820)

2024-10-28 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/113820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Use Sha extension in RVA23S64 profile (PR #113823)

2024-10-27 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113823 Stacks on top of #113820 In the ratified version of the RVA23S64 definition, the Sha extension is now used to group together the set of hypervisor related extensions.

[clang] [llvm] [RISCV] Mark the RVA23S64 and RVA23U64 profiles as non-experimental (PR #113826)

2024-10-27 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113826 All of the extensions used by these profile are themselves non-experimental, and RVA23 was just ratified .

[clang] [llvm] [RISCV] Add the Sha extension (PR #113820)

2024-10-27 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113820 This was introduced in the now-ratified RVA23 profile (and also added to the RVA22 text) as a simple way of referring to H plus the set of supervisor extensions required by RVA23. https://github.com/riscv/riscv-pro

[clang] [llvm] [RISCV] Mark pointer masking extensions as non-experimental (PR #113618)

2024-10-25 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/113618 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Mark pointer masking extensions as non-experimental (PR #113618)

2024-10-25 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/113618 >From 9e99d457321c1fdeed652518dbf37b9b2a1eab3f Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Thu, 24 Oct 2024 13:43:22 -0700 Subject: [PATCH] [RISCV] Mark pointer masking extensions as non-experimental These ex

[clang] [llvm] [RISCV] Add Supm extension to RVA23 profiles (PR #113619)

2024-10-25 Thread Alex Bradbury via cfe-commits
asb wrote: > LGTM. (And it's time to mark RV[A|B|M]23 as non-experimental now?) RVA23 and RVB23 yes. RVM23 isn't ratified yet. I've got a couple of other patches like this to lay the groundwork before flipping the switch. https://github.com/llvm/llvm-project/pull/113619 ___

[clang] [llvm] [RISCV] Add Supm extension to RVA23 profiles (PR #113619)

2024-10-24 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113619 This is mandatory for both RVA23U64 and RVA23S64 in the ratified version of the specification . >From 32239ed67654c71f04dd66ccd602e8d9641330a

[clang] [llvm] [RISCV] Mark pointer masking extensions as non-experimental (PR #113618)

2024-10-24 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/113618 >From 32239ed67654c71f04dd66ccd602e8d9641330ae Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Thu, 24 Oct 2024 13:43:22 -0700 Subject: [PATCH] [RISCV] Mark pointer masking extensions as non-experimental These ex

[clang] [llvm] [RISCV] Mark pointer masking extensions as non-experimental (PR #113618)

2024-10-24 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/113618 >From d76f4183a875b1ad0483ca2b97211c26065e9d34 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Thu, 24 Oct 2024 13:43:22 -0700 Subject: [PATCH 1/2] [RISCV] Mark pointer masking extensions as non-experimental The

[clang] [llvm] [RISCV] Mark pointer masking extensions as non-experimental (PR #113618)

2024-10-24 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/113618 These extensions were ratified very recently. I've ensured we have definitions for all extensions in the document

[clang] [clang][python] Don't add check-clang-python to check-all if cross-compiling (PR #111657)

2024-10-13 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/111657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][python] Don't add check-clang-python to check-all if cross-compiling (PR #111657)

2024-10-13 Thread Alex Bradbury via cfe-commits
@@ -47,6 +47,14 @@ if(${LLVM_NATIVE_ARCH} MATCHES "^(AArch64|Hexagon|Sparc|SystemZ)$") set(RUN_PYTHON_TESTS FALSE) endif() +# Tests will fail if cross-compiling for a different target, as tests will try +# to use the host Python3_EXECUTABLE and make FFI calls to functions i

[clang] [clang][python] Don't add check-clang-python to check-all if cross-compiling (PR #111657)

2024-10-13 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/111657 >From afd9488eb0b69c5375f7259a02581389c5003917 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Wed, 9 Oct 2024 11:09:44 +0100 Subject: [PATCH 1/4] [clang][python] Don't add check-clang-python to check-all if cros

[clang] [llvm] [RISCV] Add Smdbltrp and Ssdbltrp extension (PR #111837)

2024-10-10 Thread Alex Bradbury via cfe-commits
asb wrote: > > Personally I don't like to add a privileged extension if it doesn't > > introduce new CSRs/instructions. > > I'd actually put that on the > [agenda](https://docs.google.com/document/d/1G3ocHm2zE6AYTS2N3_3w2UxFnSEyKkcF57siLWe-NVs/edit?tab=t.0) > for today's sync-up call already.

[clang] [llvm] Add Smrnmi extension (PR #111668)

2024-10-09 Thread Alex Bradbury via cfe-commits
asb wrote: Welcome to the project @dong-miao! I'm not sure why the auto-labeler didn't kick in to attach the backend:RISC-V label (this is used to help ping the right people), but I've added that now. Just two quick comments as it's end of day here so I can't review properly right now: * We t

[clang] [clang][python] Don't add check-clang-python to check-all if cross-compiling (PR #111657)

2024-10-09 Thread Alex Bradbury via cfe-commits
@@ -47,6 +47,14 @@ if(${LLVM_NATIVE_ARCH} MATCHES "^(AArch64|Hexagon|Sparc|SystemZ)$") set(RUN_PYTHON_TESTS FALSE) endif() +# Tests will fail if cross-compiling for a different target, as tests will try +# to use the host Python3_EXECUTABLE and make FFI calls to functions i

[clang] [clang][python] Don't add check-clang-python to check-all if cross-compiling (PR #111657)

2024-10-09 Thread Alex Bradbury via cfe-commits
@@ -47,6 +47,14 @@ if(${LLVM_NATIVE_ARCH} MATCHES "^(AArch64|Hexagon|Sparc|SystemZ)$") set(RUN_PYTHON_TESTS FALSE) endif() +# Tests will fail if cross-compiling for a different target, as tests will try +# to use the host Python3_EXECUTABLE and make FFI calls to functions i

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/111367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/111367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/111367 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-09 Thread Alex Bradbury via cfe-commits
asb wrote: > > Though now I write this, I'm thinking it would make more sense to set > > RUN_PYTHON_TESTS to FALSE if CMAKE_CROSSCOMPILING is set. What do you think? > > Yes, I like this direction much more. Probably you should also print a > message during configuration saying that those test

[clang] [clang][python] Don't add check-clang-python to check-all if cross-compiling (PR #111657)

2024-10-09 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/111657 Consistent with other cases for these tests, we opt not to add the target to check-all if they're known to fail. The tests fail when cross compiling for a different architecture because the host Python3_EXECUTABLE i

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-09 Thread Alex Bradbury via cfe-commits
asb wrote: > Sorry, I'm asking for the use case for the particular CMake knob you're > adding. If there are more platforms that those tests are not working on, we > should simply expand the pre-existing list Ah sorry for misunderstanding you - good question. In my case it's a cross setup. The

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-08 Thread Alex Bradbury via cfe-commits
asb wrote: > > We already have hard-coded logic to disable adding these tests to the > > `check-all` target in various cases. > > Why do you have to do that? I've never worked with the clang python bindings before, but you can basically see the reasoning in https://github.com/llvm/llvm-proje

[clang] [modules][test] Bump maximum size for embed-files-compressed.cpp for the sake of RISC-V (PR #111360)

2024-10-07 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/111360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][python] Add CLANG_DISABLE_RUN_PYTHON_TESTS CMake option to disable clang python bindings tests (PR #111367)

2024-10-07 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/111367 We already have hard-coded logic to disable adding these tests to the `check-all` target in various cases. It's handy to have a CMake option to disable if in an environment where the tests don't work and you want `

[clang] [modules][test] Bump maximum size for embed-files-compressed.cpp for the sake of RISC-V (PR #111360)

2024-10-07 Thread Alex Bradbury via cfe-commits
asb wrote: In terms of why it's larger on RISC-V and has got bigger, I don't know enough about C++ modules to investigate much. `-module-file-info` wasn't very informative. The last commit that bumped up the maximum size was fa45f81ff7ea9fc2a2a40fea8dd7626ecc3a8dbb suggesting it may be increas

[clang] [modules][test] Bump maximum size for embed-files-compressed.cpp for the sake of RISC-V (PR #111360)

2024-10-07 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/111360 The size of a.pcm produced by an RV64 clang running natively is 67416 bytes, causing this test to fail. Bump up the maximum size. The test still retains its original intent as far as I can see, as it's really trying

[clang] [clang][OpenMP][test] Use x86_64-linux-gnu triple for test referencing avx512f feature (PR #111337)

2024-10-07 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/111337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP][test] Use x86_64-linux-gnu triple for test referencing avx512f feature (PR #111337)

2024-10-06 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/111337 This test passes as-is on non-X86 hosts only because almost no target implements `isValidFeatureName` (the default implementation unconditionally returns true). RISC-V does implement it, and like X86 checks that the

[clang] [llvm] [RISCV] Mark Zacas as non-experimental (PR #109651)

2024-09-24 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/109651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Mark Zacas as non-experimental (PR #109651)

2024-09-24 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/109651 >From 6e0e21779c13007ec8e102a6171636189550e770 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 23 Sep 2024 12:28:12 +0100 Subject: [PATCH 1/5] [RISCV] Mark Zacas as non-experimental The extension has been ra

[clang] [llvm] [RISCV] Mark Zacas as non-experimental (PR #109651)

2024-09-24 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/109651 >From 6e0e21779c13007ec8e102a6171636189550e770 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 23 Sep 2024 12:28:12 +0100 Subject: [PATCH 1/4] [RISCV] Mark Zacas as non-experimental The extension has been ra

[clang] [llvm] [RISCV] Mark Zacas as non-experimental (PR #109651)

2024-09-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/109651 >From 6e0e21779c13007ec8e102a6171636189550e770 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 23 Sep 2024 12:28:12 +0100 Subject: [PATCH 1/3] [RISCV] Mark Zacas as non-experimental The extension has been ra

[clang] [llvm] [RISCV] Mark Zacas as non-experimental (PR #109651)

2024-09-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/109651 >From 6e0e21779c13007ec8e102a6171636189550e770 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 23 Sep 2024 12:28:12 +0100 Subject: [PATCH 1/2] [RISCV] Mark Zacas as non-experimental The extension has been ra

[clang] [llvm] [RISCV] Mark Zacas as non-experimental (PR #109651)

2024-09-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/109651 >From 6e0e21779c13007ec8e102a6171636189550e770 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 23 Sep 2024 12:28:12 +0100 Subject: [PATCH 1/3] [RISCV] Mark Zacas as non-experimental The extension has been ra

[clang] [llvm] [RISCV] Mark Zacas as non-experimental (PR #109651)

2024-09-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/109651 The extension has been ratified for some time, but we kept it experimental (see #99898) due to . The ABI issue has been resolved by #101023 so I belie

[clang] [RISCV] Add testcase for -mcmodel= (PR #107816)

2024-09-10 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/107816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Allow -mcmodel= to accept large for RV64 (PR #107817)

2024-09-10 Thread Alex Bradbury via cfe-commits
asb wrote: I think we want to set a define for this as well, for consistency with medany and medlow (as tested in test/Preprocessor/riscv-cmodel.c). I submitted a trivial PR to riscv-c-api-doc to add this https://github.com/riscv-non-isa/riscv-c-api-doc/pull/86 which I'd hope lands quickly.

[clang] [llvm] [RISCV] Add Hazard3 CPU (PR #102452)

2024-08-15 Thread Alex Bradbury via cfe-commits
asb wrote: I think our conclusion from the sync-up call discussion matches what we'd roughly concluded in this thread, which is that with an instantiation of Hazard3 shipping in the RP2350 this isn't really a good test case for questions about when it's worth including a CPU definition for an

[clang] 3f0d3fd - [clang][test][RISCV] Add simple litmus test for --print-enabled-extensions

2024-08-14 Thread Alex Bradbury via cfe-commits
Author: Alex Bradbury Date: 2024-08-14T14:09:17+01:00 New Revision: 3f0d3fd3dea659330025712ea7fa914fd6af038b URL: https://github.com/llvm/llvm-project/commit/3f0d3fd3dea659330025712ea7fa914fd6af038b DIFF: https://github.com/llvm/llvm-project/commit/3f0d3fd3dea659330025712ea7fa914fd6af038b.diff

[clang] [llvm] [RISCV] Add Hazard3 CPU (PR #102452)

2024-08-08 Thread Alex Bradbury via cfe-commits
asb wrote: > I do have some worries about the definition as-is, as the core in the repo > has optional features (configurable at tape-out time). Reading the RP2350 > datasheet, not all of the optional features for Hazard3 are enabled (and I'm > of the opinion that the lack of arm-like `-mcpu=+

[clang] [RISCV] Allow YAML file to control multilib selection (PR #98856)

2024-08-01 Thread Alex Bradbury via cfe-commits
asb wrote: CC @MaskRay and @petrhosek - might you be able to help review this, or nominate someone else who can? Thanks! https://github.com/llvm/llvm-project/pull/98856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-23 Thread Alex Bradbury via cfe-commits
asb wrote: > It seems that this broke the CI: > https://lab.llvm.org/buildbot/#/builders/153/builds/3898 It did (apologies), but 2de1333af9a76fbdc46e117bebb3513e8991cd1f committed ~30 mins later should have fixed it. https://github.com/llvm/llvm-project/pull/99898

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/99898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-23 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/99898 >From 7862d7e5fc63749f68bfdc0f0d8c226d341c55e1 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 22 Jul 2024 17:58:05 +0100 Subject: [PATCH 1/3] [RISCV] Mark zacas as experimental again due to unresolved ABI is

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-22 Thread Alex Bradbury via cfe-commits
asb wrote: > Please update this line :) > > https://github.com/llvm/llvm-project/blob/90569e02e63ff5d0915446919f564e9b3638fe2a/llvm/lib/TargetParser/Host.cpp#L2070 I've tentatively removed the line, on the basis that even when requesting "native" detection, the user probably doesn't want exper

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-22 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/99898 >From 7862d7e5fc63749f68bfdc0f0d8c226d341c55e1 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 22 Jul 2024 17:58:05 +0100 Subject: [PATCH 1/2] [RISCV] Mark zacas as experimental again due to unresolved ABI is

[clang] [llvm] [RISCV] Mark zacas as experimental again due to unresolved ABI issue (PR #99898)

2024-07-22 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/99898 As discussed at the last sync-up call, mark Zacas as experimental until this ABI issue is resolved . >From 7862d7e5fc63749f68bfdc0f0d8c226d341c55e1 Mon

[clang] [llvm] [RISCV] Add riscv_atomic.h and Zawrs/Zalrsc builtins (PR #94578)

2024-06-20 Thread Alex Bradbury via cfe-commits
asb wrote: My understanding from the sync-up call just now is you're planning to drop lr/sc intrinsics due to the concerns listed in this thread (which I share), but will keep pushing the zawrs intrinsics. https://github.com/llvm/llvm-project/pull/94578

[clang] [llvm] [AArch64] Add support for Qualcomm Oryon processor (PR #91022)

2024-05-23 Thread Alex Bradbury via cfe-commits
@@ -0,0 +1,1664 @@ +//=- AArch64SchedOryon.td - Nuvia Inc Oryon CPU 001 ---*- tablegen -*-=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[clang] [llvm] [AArch64] Add support for Qualcomm Oryon processor (PR #91022)

2024-05-15 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/91022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add support for Qualcomm Oryon processor (PR #91022)

2024-05-15 Thread Alex Bradbury via cfe-commits
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/91022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Add support for Qualcomm Oryon processor (PR #91022)

2024-05-15 Thread Alex Bradbury via cfe-commits
@@ -0,0 +1,1664 @@ +//=- AArch64SchedOryon.td - Nuvia Inc Oryon CPU 001 ---*- tablegen -*-=// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[clang] [llvm] [RISCV] Gate unratified profiles behind -menable-experimental-extensions (PR #92167)

2024-05-15 Thread Alex Bradbury via cfe-commits
asb wrote: Thank you for the reviews - I've gone ahead and merged. One thing from the added tests that's worth highlighting perhaps is `RejectsProfilesWithAdditionalExtensionsGivenAlreadyInProfile` which documents that currently if you specify an extension that's already part of the profile t

[clang] [llvm] [RISCV] Gate unratified profiles behind -menable-experimental-extensions (PR #92167)

2024-05-15 Thread Alex Bradbury via cfe-commits
https://github.com/asb closed https://github.com/llvm/llvm-project/pull/92167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Gate unratified profiles behind -menable-experimental-extensions (PR #92167)

2024-05-15 Thread Alex Bradbury via cfe-commits
https://github.com/asb updated https://github.com/llvm/llvm-project/pull/92167 >From 5159fce9b2cca245335e124f7f0cd2149cdbcb2a Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Tue, 14 May 2024 20:45:41 +0100 Subject: [PATCH] [RISCV] Gate unratified profiles behind -menable-experimental-extensi

[clang] [llvm] [RISCV] Gate unratified profiles behind -menable-experimental-extensions (PR #92167)

2024-05-14 Thread Alex Bradbury via cfe-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/92167 As discussed in the last sync-up call, because these profiles are not yet finalised they shouldn't be exposed to users unless they opt-in to them (much like experimental extensions). We may later want to add a more s

[clang] [llvm] [RISCV] Add smstateen extension (PR #90818)

2024-05-02 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. Release note and RISCVUsage and it LGTM. https://github.com/llvm/llvm-project/pull/90818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] [RISCV] Refactor profile selection in RISCVISAInfo::parseArchString. (PR #90700)

2024-05-01 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/90700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][RISCV] Improve error message for invalid extension letters (PR #90468)

2024-04-29 Thread Alex Bradbury via cfe-commits
https://github.com/asb approved this pull request. LGTM, thanks. https://github.com/llvm/llvm-project/pull/90468 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add generic CPUs for profiles (PR #84877)

2024-04-25 Thread Alex Bradbury via cfe-commits
asb wrote: We discussed again in the sync-up call to try to move this forwards and per a discussion with @topperc and @preames were wondering if relying on -mattr and a corresponding feature for the profile might be the better approach after all. * There's not a lot of instances of this, but I

  1   2   3   >