noxwell wrote:
Closing this PR, because these changes are incompatible to DWARF standard, see
[83175#issuecomment-1969473992](https://github.com/llvm/llvm-project/pull/83175#issuecomment-1969473992)
https://github.com/llvm/llvm-project/pull/83175
___
https://github.com/noxwell closed
https://github.com/llvm/llvm-project/pull/83175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
noxwell wrote:
> Can you add a test for this?
I added a test for remapping of absolute path. It passes with this PR and fails
on trunk.
However, I found much bigger problem. This fix fails test
`debug-info-abspath.c`, more specifically the last case, which checks that CU
file has absolute pa
https://github.com/noxwell updated
https://github.com/llvm/llvm-project/pull/83175
>From 731463e1134b0821e518a3e8e521a2d44dd18a8e Mon Sep 17 00:00:00 2001
From: Aleksei Vetrov
Date: Tue, 27 Feb 2024 19:50:13 +
Subject: [PATCH] [Clang][DebugInfo] Use CGDebugInfo::createFile in
CGDebugInfo::
@@ -628,9 +628,8 @@ void CGDebugInfo::CreateCompileUnit() {
// file was specified with an absolute path.
if (CSKind)
CSInfo.emplace(*CSKind, Checksum);
- llvm::DIFile *CUFile = DBuilder.createFile(
- remapDIPath(MainFileName), remapDIPath(getCurrentDirname()), CSI
https://github.com/noxwell updated
https://github.com/llvm/llvm-project/pull/83175
>From 237264fded2b9806d273d7bc5d593a7dd0011850 Mon Sep 17 00:00:00 2001
From: Aleksei Vetrov
Date: Tue, 27 Feb 2024 19:50:13 +
Subject: [PATCH] [Clang][DebugInfo] Use CGDebugInfo::createFile in
CGDebugInfo::
https://github.com/noxwell created
https://github.com/llvm/llvm-project/pull/83175
Use `CGDebugInfo::createFile` wrapper that handles file remapping and corner
cases instead of directly using `DBuilder.createFile` in
`CGDebugInfo::CreateCompileUnit`.
Fixes #83174
>From 704f9042bb357cb600894c
