[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

2019-03-13 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov added a comment. Thank you! I've added a slightly reworked test too. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58544/new/ https://reviews.llvm.org/D58544 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

2019-03-13 Thread Aleksandr Urakov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL356047: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder` (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Ch

[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

2019-03-12 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov added a comment. Ping! Can you take a look, please? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58544/new/ https://reviews.llvm.org/D58544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D58544: [AST] Improve support of external layouts in `MicrosoftRecordLayoutBuilder`

2019-02-22 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: rnk, zturner, rsmith. aleksandr.urakov added a project: clang. Herald added subscribers: cfe-commits, jdoerfert. This patch fixes several small problems with external layouts support in `MicrosoftRecordLayoutBuilder`: - al

[PATCH] D53497: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when an external layout is used

2018-10-23 Thread Aleksandr Urakov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC345012: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when (authored by aleksandr.urakov, committed by ). Repository: rC Clang https://reviews.llvm.org/D53497 Files: lib/AST/Re

[PATCH] D53497: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when an external layout is used

2018-10-23 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov added a comment. Thank you! Repository: rC Clang https://reviews.llvm.org/D53497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53497: [AST] Do not align virtual bases in `MicrosoftRecordLayoutBuilder` when an external layout is used

2018-10-22 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: rnk, rsmith, zturner, mstorsjo, majnemer. aleksandr.urakov added a project: clang. Herald added a subscriber: cfe-commits. The patch removes alignment of virtual bases when an external layout is used. We have two cases: -

[PATCH] D49871: Improve support of PDB as an external layout source

2018-07-31 Thread Aleksandr Urakov via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL338353: Improve support of PDB as an external layout source (authored by aleksandr.urakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D498

[PATCH] D49871: Improve support of PDB as an external layout source

2018-07-26 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov added a comment. Thank you! Can you, please, commit this for me? I have no commit access. Repository: rC Clang https://reviews.llvm.org/D49871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D49871: Improve support of PDB as an external layout source

2018-07-26 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: rsmith, zturner, rnk, mstorsjo, majnemer. aleksandr.urakov added a project: clang. This patch improves support of PDB as an external layout source in the next cases: - Multiple non-virtual inheritance from packed base clas

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-13 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov added a comment. Thank you! Repository: rL LLVM https://reviews.llvm.org/D49227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-12 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov updated this revision to Diff 155324. aleksandr.urakov added a comment. Thank you! Yes, I have added a test case for that. If it's OK, can you commit this for me, please? I have no commit access. https://reviews.llvm.org/D49227 Files: lib/AST/RecordLayoutBuilder.cpp test/

[PATCH] D49227: Override a bit fields layout from an external source

2018-07-12 Thread Aleksandr Urakov via Phabricator via cfe-commits
aleksandr.urakov created this revision. aleksandr.urakov added reviewers: rsmith, mstorsjo, arphaman, whunt, majnemer. aleksandr.urakov added a project: clang. This patch adds a possibility to use an external layout for bit fields. The problem occurred while debugging a Windows application with P