[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair added a comment. In D135273#3942011 , @theraven wrote: > In D135273#3936297 , @al45tair > wrote: > >> @theraven Any chance you could glance over this and reassure us that it >> isn't going to break the

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair added a comment. @theraven Any chance you could glance over this and reassure us that it isn't going to break the GNU runtime if we do this? (We're adding an extra attribute in the property attribute string so that we can detect `@optional` properties in ObjC protocols at runtime.) R

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair marked an inline comment as done. al45tair added inline comments. Comment at: clang/test/CodeGenObjC/objc-asm-attribute-test.m:20 +@class Message; + ahatanak wrote: > Do you need this change? No, I think this is left-over from an earlier revision. I'll

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair updated this revision to Diff 476387. al45tair marked 2 inline comments as done. al45tair added a comment. Updated following comments from @ahatanak. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135273/new/ https://reviews.llvm.org/D13527

[PATCH] D135273: [Clang][ObjC] Add optionality to property attribute strings.

al45tair created this revision. al45tair added reviewers: ahatanak, rjmccall, theraven. Herald added a project: All. al45tair requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new attribute, "?", to the property attribute string for pro