K-ballo added a subscriber: K-ballo.
K-ballo added a comment.
LGTM
http://reviews.llvm.org/D21260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
K-ballo updated this revision to Diff 42892.
K-ballo marked 15 inline comments as done.
K-ballo added a comment.
Addressed review comments. Use `UNSUPPORTED` in `pairs.by.type.pass`.
http://reviews.llvm.org/D14839
Files:
include/__tuple
include/array
include/tuple
include/utility
test
K-ballo updated this revision to Diff 42432.
K-ballo added a comment.
Addressed review comments
http://reviews.llvm.org/D14839
Files:
include/__tuple
include/array
include/tuple
include/utility
test/std/containers/sequences/array/array.tuple/get_const_rv.pass.cpp
test/std/utilities/
K-ballo marked 2 inline comments as done.
K-ballo added a comment.
In http://reviews.llvm.org/D14839#306306, @EricWF wrote:
> int x = 42;
> int const y = 43;
> std::pair const p(x, y);
> static_assert(std::is_same decltype(std::get<0>(std::move(p)))>::value, "");
> static_assert(std::is
K-ballo added a comment.
> After that these changes LGTM. @K-ballo I'm happy to make the changes as I
> commit this if your OK with that?
@EricWF Go ahead, thank you!
http://reviews.llvm.org/D14814
___
cfe-commits mailing list
cfe-commits@lists.l
K-ballo created this revision.
K-ballo added reviewers: mclow.lists, EricWF.
K-ballo added a subscriber: cfe-commits.
Implement LWG2485, `get()` should be overloaded for `const tuple&&`.
http://reviews.llvm.org/D14839
Files:
include/__tuple
include/array
include/tuple
include/utility
t
K-ballo created this revision.
K-ballo added reviewers: mclow.lists, EricWF, majnemer, rsmith.
K-ballo added a subscriber: cfe-commits.
Use the `__make_integer_seq` builtin, introduced by r252036, when available.
This allows for an incredibly fast `std::make_integer_sequence` implementation.
htt
K-ballo added a comment.
In http://reviews.llvm.org/D6964#241105, @EricWF wrote:
> @K-ballo May I commit this with a couple of small changes? I want to fully
> qualify all of the calls to "declval(...)".
Please do. I have submitted bug reports in the past for pesky unqualified calls
to `declv
