K-ballo added inline comments.
Comment at: include/ostream:225
+basic_ostream& operator<<(nullptr_t)
+{ return *this << (const void*)0; }
+
Quuxplusone wrote:
> mclow.lists wrote:
> > lichray wrote:
> > > Oh, common, I persuaded the committee to allow you
K-ballo added a comment.
Thanks @lichray
Repository:
rL LLVM
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
K-ballo updated this revision to Diff 126545.
K-ballo added a comment.
Fixed incorrect test case.
https://reviews.llvm.org/D38831
Files:
include/type_traits
include/variant
test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
test/std/utilities/function.objects/unord.hash/non
K-ballo added a comment.
In https://reviews.llvm.org/D38831#952228, @lichray wrote:
> [...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9:
> error: static_assert failed due to requirement
> '!std::is_nothrow_invocable_r_v' ""
> static_assert(!std::is_nothrow_in
K-ballo updated this revision to Diff 124201.
K-ballo edited the summary of this revision.
K-ballo added a comment.
Turn fail test into SFINAE based pass test, mark XFAIL for clang.
https://reviews.llvm.org/D40259
Files:
include/__functional_base
include/functional
test/std/utilities/fun
K-ballo updated this revision to Diff 124005.
K-ballo added a comment.
Back to `decltype`-based SFINAE.
https://reviews.llvm.org/D40259
Files:
include/__functional_base
include/functional
test/std/utilities/function.objects/refwrap/refwrap.assign/copy_assign.pass.cpp
test/std/utilitie
K-ballo updated this revision to Diff 123813.
K-ballo added a comment.
Full context diff.
https://reviews.llvm.org/D40259
Files:
include/__functional_base
include/functional
test/std/utilities/function.objects/refwrap/refwrap.assign/copy_assign.pass.cpp
test/std/utilities/function.obj
K-ballo updated this revision to Diff 123679.
K-ballo added a comment.
Addressed review comments. Added tests for SFINAE, noexcept, deduction guide.
https://reviews.llvm.org/D40259
Files:
include/__functional_base
include/functional
test/std/utilities/function.objects/refwrap/refwrap.ass
K-ballo created this revision.
Implement LWG2993, `reference_wrapper` conversion from `T&&`.
The conversion fail test currently fails to fail (passes), due to
https://bugs.llvm.org/show_bug.cgi?id=35332. Flagging it `XFAIL` does not seem
to have any effect.
https://reviews.llvm.org/D40259
Fi
K-ballo added a comment.
In https://reviews.llvm.org/D38831#917439, @EricWF wrote:
> @K-ballo I always forget. Do you have commit access?
I do not. It's all yours.
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llv
K-ballo updated this revision to Diff 119764.
K-ballo added a comment.
Fix synopsis
https://reviews.llvm.org/D38831
Files:
include/type_traits
include/variant
test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
test/std/utilities/function.objects/unord.hash/non_enum.pass.cpp
K-ballo created this revision.
Introduce a new form of `result_of` without function type encoding.
Rename and split `is_callable/is_nothrow_callable` into
`is_invocable/is_nothrow_invocable/is_invocable_r/is_nothrow_invocable_r` (and
associated types accordingly)
Change function type encoding
K-ballo created this revision.
With effects equivalent to `os << (const void*)nullptr`.
https://reviews.llvm.org/D33776
Files:
include/ostream
test/std/input.output/iostream.format/output.streams/ostream.formatted/ostream.inserters.arithmetic/nullptr_t.pass.cpp
www/cxx1z_status.html
Ind
K-ballo accepted this revision.
K-ballo added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D27565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
K-ballo added a comment.
I don't see any potential layout change, other than the case in which both `T1`
and `T2` are empty (which I understand doesn't happen within libc++). As far as
I know, the rest of the cases should result in the same layout regardless of
whether EBO actually applies or n
15 matches
Mail list logo
