[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069935 , @enh wrote: > In D137268#4069856 , @zatrazz wrote: > >> I think I have caught this because your standard conformance tests checks >> for __gnuc_va_list >> on wchar.h

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz added a comment. In D137268#4069779 , @enh wrote: > is there a corresponding glibc change so that `va_list` is exported for > `_POSIX_SOURCE` cases? see > https://android-review.git.corp.google.com/c/platform/bionic/+/2397313 where > i'm having

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e956995db1f: [clang][Headers] Do not define varargs macros for __need___va_list (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz updated this revision to Diff 474028. zatrazz marked 2 inline comments as done. zatrazz added a comment. Update review based on reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137268/new/ https://reviews.llvm.org/D137268

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz marked 2 inline comments as done. zatrazz added inline comments. Comment at: clang/lib/Headers/stdarg.h:17 +#ifndef __GNUC_VA_LIST +#define __GNUC_VA_LIST 1 +typedef __builtin_va_list __gnuc_va_list; MaskRay wrote: > To match gcc stdarg.h, `#define __GNUC

[PATCH] D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e172309cf6: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later (authored by zatrazz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137267/new/

[PATCH] D137268: [clang][Headers] Do not define varargs macros for __need___va_list

zatrazz created this revision. zatrazz added reviewers: jfb, eli.friedman, MaskRay. Herald added subscribers: Enna1, StephenFan. Herald added a project: All. zatrazz requested review of this revision. Herald added projects: clang, Sanitizers. Herald added a subscriber: Sanitizers. The glibc uses t

[PATCH] D137267: [clang][Headers] Only define FLT_EVAL_METHOD for C99 and later

zatrazz created this revision. zatrazz added reviewers: jfb, eli.friedman, MaskRay. Herald added a subscriber: StephenFan. Herald added a project: All. zatrazz requested review of this revision. Herald added a project: clang. It was reported by glibc conform test [1]. [1] https://sourceware.org/

[PATCH] D131528: [Clang] Restrict non fixed enum to a value outside the range of the enumeration values warning to context requiring a constant expression

zatrazz added a comment. It does help on test-suite, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131528/new/ https://reviews.llvm.org/D131528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

zatrazz added a comment. This commit seems to have broken test-suite on aarch64 [1]. The warning shows: FAILED: MultiSource/Benchmarks/PAQ8p/CMakeFiles/paq8p.dir/paq8p.cpp.o /home/adhemerval.zanella/projects/llvm/test-suite-build/tools/timeit --summary MultiSource/Benchmarks/PAQ8p/CMakeFiles

[PATCH] D96803: EntryExitInstrumenter: Enable at all optimization levels (PR49143)

zatrazz updated this revision to Diff 325004. zatrazz retitled this revision from "EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)" to "EntryExitInstrumenter: Enable at all optimization levels (PR49143)". zatrazz edited the summary of this revision. za

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz added a comment. In D96803#2569436 , @aeubanks wrote: > In D96803#2568179 , @zatrazz wrote: > >> In D96803#2566322 , @aeubanks wrote: >> >>> why is this now a module

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz added a comment. In D96803#2566322 , @aeubanks wrote: > why is this now a module pass? Mainly to avoid the default rule from new pass manager to *not* apply any FunctionPass for optnone (which is the main issue for PR49143). Is there a better wa

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

zatrazz created this revision. zatrazz added reviewers: lenary, ostannard, aeubanks. Herald added a subscriber: hiraditya. zatrazz requested review of this revision. Herald added projects: clang, LLVM. The function passes are disabled by default for optnone with the new pass manager. The pass is

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz added a comment. In D72449#1812818 , @arichardson wrote: > I'm fine with this workaround although I'm very surprised that the test is > not working. Especially since `deterministic-archive.test` and > `replace-update.test` also set TZ to get repr

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz added a comment. In D72449#1812130 , @arichardson wrote: > I was careful in the test to use `TZ=UTC` for all commands printing dates and > it works fine for me in UTC+1 and in the UK which is currently UTC. Does the > bot in question ignore the T

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz updated this revision to Diff 237134. zatrazz added a comment. Updated patch based on previous comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72449/new/ https://reviews.llvm.org/D72449 Files: llvm/test/tools/llvm-ranlib/D-flag.test Index: llvm/test/tools/llvm-ranli

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz marked 2 inline comments as done. zatrazz added inline comments. Comment at: llvm/test/tools/llvm-ranlib/D-flag.test:13 # RUN: cp %t-no-index.a %t.a && llvm-ranlib -D %t.a -# RUN: env TZ=UTC llvm-ar tv %t.a | FileCheck %s --check-prefix=DETERMINISTIC-VALUES +# RUN: (env

[PATCH] D72449: [PATCH] [llvm-ranlib] Take in consideration UTC offset for D-flag.test

zatrazz created this revision. zatrazz added reviewers: arichardson, emaste, rupprecht. Herald added a subscriber: kristof.beyls. Herald added a project: LLVM. The llvm-ar uses localtime to print the object timestamp and it is subject to UTC offset (daylight for instance). The patch changes the t

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

zatrazz added a comment. Hi, I am investigating a recurring regression on aarch64-linux bots and bisecting the commits on the build [1] that introduced the regression it points to this one. I don't understand exactly what is triggering the issue, but it only happen on the stage2 build with sta

[PATCH] D62019: [clang] Handle lrint/llrint builtins

zatrazz updated this revision to Diff 200291. zatrazz added a comment. Updated patch based on D62026 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62019/new/ https://reviews.llvm.org/D62019 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[PATCH] D62019: [clang] Handle lrint/llrint builtins

zatrazz created this revision. zatrazz added reviewers: efriedma, rengolin, javed.absar, huntergr, SjoerdMeijer, t.p.northover, echristo, evandro. zatrazz added a project: clang. Herald added subscribers: kristina, kristof.beyls. As for other floating-point rounding builtins that can be optimized

[PATCH] D61392: [clang] Handle lround/llround builtins

zatrazz created this revision. zatrazz added reviewers: efriedma, rengolin, javed.absar, huntergr, SjoerdMeijer, t.p.northover, echristo, evandro. zatrazz added a project: clang. Herald added subscribers: kristina, kristof.beyls. As for other floating-point rounding builtins that can be optimized