adamf added a comment.
@thakis Yes please, I cannot commit this patch by myself, because I don't have
commit access.
Surely, next time I will add more context in diff.
Thanks a lot for the effort.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68099/new/
https://
adamf created this revision.
adamf added reviewers: rnk, thakis.
adamf added a project: clang.
Herald added a subscriber: cfe-commits.
MS name mangling supports cache for first 10 distinct function arguments.
The error was when non cached template type occurred twice (e.g. 11th and 12th).
For such
adamf updated this revision to Diff 96454.
adamf added a comment.
Thanks for your comments!
Updated test case according to @vsk comment about test case reduction.
@rnk, your compilation command probably exposes another issue (with your
compilation command the test still failure). I don't have t
adamf created this revision.
In function CodeGenPGO::skipRegionMappingForDecl there is possible NULL pointer
dereference on line:
auto Loc = D->getBody()->getLocStart();
Value returned by getBody may be NULL.
In corresponding test it happens during processing the virtual destructor ~A.
(minor)
adamf added a comment.
!MD->getParent()->getDescribedClassTemplate() looks like redundant now. This
check is already done in isDependentContext.
https://reviews.llvm.org/D32144
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
