[clang] Add back include for AutoConvert.h as it's needed for z/OS (PR #135430)

2025-04-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/135430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Mark text files as text in ClangScanDeps (PR #127514)

2025-02-18 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/127514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Mark text files as text in ClangScanDeps (PR #127514)

2025-02-17 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/127514 >From a015e8389fa263cbbb28e56e93fae733f5e94dde Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 17 Feb 2025 10:56:10 -0500 Subject: [PATCH 1/2] mark text files as text in ClangScanDeps ---

[clang] [SystemZ][z/OS] Mark text files as text in ClangScanDeps (PR #127514)

2025-02-17 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/127514 This patch continues the work that was started here https://reviews.llvm.org/D99426 to correctly open text files in text mode. >From a015e8389fa263cbbb28e56e93fae733f5e94dde Mon Sep 17 00:00:00 2001 From: A

[clang-tools-extra] [SystemZ][z/OS] Open text files in text mode (PR #125570)

2025-02-04 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/125570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [SystemZ][z/OS] Open text files in text mode (PR #125570)

2025-02-03 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/125570 This patch continues the work that was started here https://reviews.llvm.org/D99426 to correctly open text files in text mode. >From 7ac3589c34f4cb48bbf9b0fea74adfc9fccaecdf Mon Sep 17 00:00:00 2001 From: A

[clang] [z/OS] Add option to target older versions of LE on z/OS (PR #123399)

2025-01-23 Thread Abhina Sree via cfe-commits
@@ -277,6 +277,11 @@ def err_cpu_unsupported_isa def err_arch_unsupported_isa : Error<"architecture '%0' does not support '%1' execution mode">; +def err_zos_target_release_discontinued + : Error<"z/OS target level \"%0\" is discontinued. Unexpected behavior might occur i

[clang] [z/OS] Add option to target older versions of LE on z/OS (PR #123399)

2025-01-23 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [z/OS][SystemZ] Clang dependency files are text files (PR #121849)

2025-01-07 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/121849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX] fix unsupported diff flag on AIX (-strip-trailing-cr) (PR #120276)

2024-12-17 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/120276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/98652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/3] update autoconversion functionality to fix erro

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-09 Thread Abhina Sree via cfe-commits
@@ -70,6 +70,13 @@ class FileEntryRef { const FileEntry &getFileEntry() const { return *getBaseMapEntry().second->V.get(); } + + // This is a non const version of getFileEntry() which is used if the buffer + // size needs to be increased due to potential z/OS EBCDIC -

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/4] update autoconversion functionality to fix erro

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/3] update autoconversion functionality to fix erro

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-09 Thread Abhina Sree via cfe-commits
@@ -70,6 +70,13 @@ class FileEntryRef { const FileEntry &getFileEntry() const { return *getBaseMapEntry().second->V.get(); } + + // This is a non const version of getFileEntry() which is used if the buffer + // size needs to be increased due to potential z/OS EBCDIC -

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/2] update autoconversion functionality to fix erro

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/2] update autoconversion functionality to fix erro

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/2] update autoconversion functionality to fix erro

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/98652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
@@ -617,6 +625,23 @@ FileID SourceManager::createFileIDImpl(ContentCache &File, StringRef Filename, return FileID::get(LoadedID); } unsigned FileSize = File.getSize(); +#ifdef __MVS__ abhina-sree wrote: Thanks, I made a small helper function to move o

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
@@ -617,6 +625,23 @@ FileID SourceManager::createFileIDImpl(ContentCache &File, StringRef Filename, return FileID::get(LoadedID); } unsigned FileSize = File.getSize(); +#ifdef __MVS__ + llvm::ErrorOr NeedConversion = + llvm::needzOSConversion(Filename.str().c_str

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/98652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
@@ -166,8 +167,15 @@ ContentCache::getBufferOrNone(DiagnosticsEngine &Diag, FileManager &FM, // Unless this is a named pipe (in which case we can handle a mismatch), // check that the file's size is the same as in the file entry (which may // have come from a stat cache)

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-06 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From 4583cacec6daa1e980d5149be063120b34731f4c Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/2] update autoconversion functionality to fix erro

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-04 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/98652 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-12-04 Thread Abhina Sree via cfe-commits
@@ -70,6 +70,11 @@ class FileEntryRef { const FileEntry &getFileEntry() const { return *getBaseMapEntry().second->V.get(); } +#ifdef __MVS__ abhina-sree wrote: There are a lot of uses of the const function so we would hit a lot of errors if we got rid

[clang] [z/OS] Make sure __alignas_is_defined and __alignof_is_defined are defined on z/OS. (PR #115368)

2024-11-07 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/115368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstrPGO] Support cold function coverage instrumentation (PR #109837)

2024-10-30 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > > Hi, this PR is causing a regression on the AIX bot here > > https://lab.llvm.org/buildbot/#/builders/64/builds/1321/steps/6/logs/FAIL__Clang__pgo-cold-function-coverage_c. > > Would you be able to take a look? I think it can be resolved by using > > clang_cc1 in the test

[clang] [llvm] [InstrPGO] Support cold function coverage instrumentation (PR #109837)

2024-10-29 Thread Abhina Sree via cfe-commits
abhina-sree wrote: Hi, this PR is causing a regression on the AIX bot here https://lab.llvm.org/buildbot/#/builders/64/builds/1321/steps/6/logs/FAIL__Clang__pgo-cold-function-coverage_c. Would you be able to take a look? I think it can be resolved by using clang_cc1 in the testcase of marking

[clang] [NFC] Move RegisterBuiltinMacro function into the Preprocessor class (PR #100142)

2024-10-25 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/100142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM, just needs to include the suggested formatting fix https://github.com/llvm/llvm-project/pull/11 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-21 Thread Abhina Sree via cfe-commits
abhina-sree wrote: Closing this because an alternative solution was implemented here https://github.com/llvm/llvm-project/pull/111723 https://github.com/llvm/llvm-project/pull/110661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-21 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/110661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-21 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/111723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/112814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" abhina-sree wrote: Yes, I think that would be a better solution, I will try to get to that when I have time,

[clang] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" abhina-sree wrote: Inside that header we guard the C++ code inside an `#ifdef __cplusplus` so it should work

[clang] [NFC] Fix c++ style comment in c file (PR #112814)

2024-10-18 Thread Abhina Sree via cfe-commits
@@ -8,7 +8,6 @@ #include "clang-c/Documentation.h" #include "clang-c/Index.h" #include "clang/Config/config.h" -#include "llvm/Support/AutoConvert.h" abhina-sree wrote: We need this header because we are using the function enablezOSAutoConversion below in thi

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
abhina-sree wrote: @cor3ntin, I've added support for #embed handling now, I've added a z/OS only testcase clang/test/Preprocessor/embed_zos.c which is a copy of clang/test/Preprocessor/embed_art.c except it changes the file tag to be non-ascii which is now working with the latest commit. http

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/3] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > @abhina-sree do you plan to modify embed in this PR? Actually Sean has pointed out that if we pass in non-ascii inputs, the tests do in fact fail. So I will look into passing the IsText parameter in the necessary functions. Thanks for pointing this out! https://github.com

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-10 Thread Abhina Sree via cfe-commits
@@ -54,7 +54,9 @@ std::unique_ptr HeaderMap::Create(FileEntryRef FE, FileManager &FM) { unsigned FileSize = FE.getSize(); if (FileSize <= sizeof(HMapHeader)) return nullptr; - auto FileBuffer = FM.getBufferForFile(FE); + auto FileBuffer = + FM.getBufferForFile(FE,

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-09 Thread Abhina Sree via cfe-commits
@@ -302,6 +305,17 @@ class RealFileSystem : public FileSystem { return Storage; } + ErrorOr> openFileForRead(const Twine &Name, abhina-sree wrote: I don't think I'm able to mark it static because it calls adjustPath which is non-static https://github

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-09 Thread Abhina Sree via cfe-commits
@@ -324,6 +330,17 @@ ErrorOr RealFileSystem::status(const Twine &Path) { ErrorOr> RealFileSystem::openFileForRead(const Twine &Name) { + SmallString<256> RealName, Storage; abhina-sree wrote: I've created a private function for both functions to call, thanks

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-09 Thread Abhina Sree via cfe-commits
@@ -117,8 +117,12 @@ FileSystem::~FileSystem() = default; ErrorOr> FileSystem::getBufferForFile(const llvm::Twine &Name, int64_t FileSize, - bool RequiresNullTerminator, bool IsVolatile) { - auto F = openFileForRead(Name); +

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From c1676e48a587e10ba54c28e99192fd5e6a36f72e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH] [SystemZ][z/OS] Add new openFileForReadBinary funct

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/111723 >From 8443744a40bd1397155ea9d91fbe720a8826139d Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 9 Oct 2024 13:23:41 -0400 Subject: [PATCH 1/2] [SystemZ][z/OS] Add new openFileForReadBinary f

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-09 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > The default is set to OF_Text instead of OF_None, this change in value does > not affect any other platforms other than z/OS. Setting this parameter > correctly is required to open files on z/OS in the correct encoding. The > IsText parameter is based on the context of whe

[clang] [llvm] [SystemZ][z/OS] Add new openFileForReadBinary function, and pass IsText parameter to getBufferForFile (PR #111723)

2024-10-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/111723 This patch adds an IsText parameter to the following getBufferForFile, getBufferForFileImpl. We introduce a new virtual function openFileForReadBinary which defaults to openFileForRead except in RealFileSys

[clang] [SystemZ][z/OS] Add z/OS customization file (PR #111182)

2024-10-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/82 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-07 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > https://github.com/llvm/llvm-project/blob/main/clang/lib/Lex/PPDirectives.cpp#L3964-L3990 Yes I think we still require specifying the Text/Binary parameter based on the context of where it is called. I will look into adding the new virtual functions as an alternative solu

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2024-10-07 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/111035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the XL pragma pack semantics on z/OS (PR #111053)

2024-10-04 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM, can we add [SystemZ][z/OS] in the title to make it consistent with other PRs https://github.com/llvm/llvm-project/pull/111053 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-02 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > > sorry this is same as #107906 (with a bigger impact radius, as you're also > > changing getBufferForFile) and doesn't address any of the issues mention > > about explaining the semantics of `IsText` or justification for changing > > the core VFS interfaces, for an operat

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-01 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/110661 >From b4bf7c601d2b790ea5e65f68cb1fa9375457b558 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH] Propagate IsText parameter to openFileForRead funct

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-01 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/110661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-01 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > > @perry-ca raised some concerns in #109664 about this functionality > > requiring some context awareness, I don't think any of those is addressed > > by this patch either. Pretty much all of the callers apart from ASTReader > > is just using `IsText = true`. > > It just

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-01 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/110661 >From 1a5096483d5d6d84087e913b20f6f260452988b3 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH] Propagate IsText parameter to openFileForRead funct

[clang] [llvm] [SystemZ][z/OS] Open text files in text mode (PR #109972)

2024-09-25 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/109972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Open text files in text mode (PR #109972)

2024-09-25 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/109972 >From 0dd3d22bfa419a70fe91c6b1b0c277d7cb21a51e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Wed, 25 Sep 2024 08:42:10 -0400 Subject: [PATCH] [SystemZ][z/OS] Open text files in text mode ---

[clang] Mark tests as unsupported when targeting z/OS (PR #107916)

2024-09-24 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Mark tests as unsupported when targeting z/OS (PR #107916)

2024-09-23 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/107916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Mark tests as unsupported when targeting z/OS (PR #107916)

2024-09-23 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/107916 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Mark tests as unsupported when targeting z/OS (PR #107916)

2024-09-23 Thread Abhina Sree via cfe-commits
@@ -24,6 +24,7 @@ // // FIXME: Path handling should work on all platforms. // REQUIRES: system-linux +// UNSUPPORTED: target={{.*}}-zos{{.*}} abhina-sree wrote: Would this work instead? I think this testcase won't work for all non-linux targets // REQUIRES:

[clang] [SystemZ][z/OS] fix ppc-xmmintrin.c on z/OS (PR #109676)

2024-09-23 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-23 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > OpenFlags |= sys::fs::OF_Text; Thanks, I've made your suggested change and I opened a new PR here https://github.com/llvm/llvm-project/pull/109664. A short explanation for why distinguishing text and binary files on z/OS is important is because the native encoding is not

[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > thanks a lot for the swift response! > > I can see how none of these implementations are not using those flags > _today_, but we're changing the observable behavior for them as well, and if > some of those implementations decides to give meaning to these flags, it > might

[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread Abhina Sree via cfe-commits
@@ -323,10 +325,11 @@ ErrorOr RealFileSystem::status(const Twine &Path) { } ErrorOr> -RealFileSystem::openFileForRead(const Twine &Name) { +RealFileSystem::openFileForRead(const Twine &Name, bool IsText) { SmallString<256> RealName, Storage; Expected FDOrErr = sys::fs::

[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-20 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > 3b3accb Hi, sure I will revert the two changes so we can discuss further. The OF_Text flag only affects the z/OS platform behaviour, the OF_TextWithCRLF will affect z/OS and Windows. On other platforms, the flag doesn't show any difference in behaviour that I'm aware of

[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-19 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/107906 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-09-19 Thread Abhina Sree via cfe-commits
@@ -532,9 +532,371 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation +//===

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-09-19 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree deleted https://github.com/llvm/llvm-project/pull/101024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-09-19 Thread Abhina Sree via cfe-commits
@@ -532,9 +532,371 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation +//===

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-09-11 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From e7be53314994b9a051ba2ff99dfd029937ebcc07 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/3] update autoconversion functionality to fix erro

[clang] [clang-tools-extra] [lldb] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-10 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/107906 >From 758745c955471b0ad65cd3a33381f753e2b63797 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH 1/2] Propagate IsText parameter to openFileForRead f

[clang] [clang-tools-extra] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/107906 >From 758745c955471b0ad65cd3a33381f753e2b63797 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 9 Sep 2024 15:32:09 -0400 Subject: [PATCH] Propagate IsText parameter to openFileForRead funct

[clang] The real option name and not the alias used is displayed in msgs when using a config file (PR #107613)

2024-09-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107613 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-09-09 Thread Abhina Sree via cfe-commits
@@ -326,7 +326,7 @@ ErrorOr> RealFileSystem::openFileForRead(const Twine &Name) { SmallString<256> RealName, Storage; Expected FDOrErr = sys::fs::openNativeFileForRead( - adjustPath(Name, Storage), sys::fs::OF_None, &RealName); + adjustPath(Name, Storage), sys::fs

[clang] [clang-tools-extra] [llvm] [SystemZ][z/OS] Propagate IsText parameter to open text files as text (PR #107906)

2024-09-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/107906 This patch adds an IsText parameter to the following functions openFileForRead, getBufferForFile, getBufferForFileImpl and determines whether a file is text by querying the file tag on z/OS. The default is

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-09-09 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/98652 >From e7be53314994b9a051ba2ff99dfd029937ebcc07 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Fri, 12 Jul 2024 11:17:24 -0400 Subject: [PATCH 1/3] update autoconversion functionality to fix erro

[clang] [llvm] [NFC][SystemZ][z/OS] Rename autoconversion-related functions to be less generic (PR #107399)

2024-09-05 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/107399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] Update autoconversion functions to improve support for UTF-8 (PR #98652)

2024-09-05 Thread Abhina Sree via cfe-commits
@@ -52,6 +53,12 @@ std::error_code restoreStdHandleAutoConversion(int FD); /// \brief Set the tag information for a file descriptor. std::error_code setFileTag(int FD, int CCSID, bool Text); +// Get the the tag ccsid for a file name or a file descriptor. +ErrorOr<__ccsid_t> ge

[clang] [llvm] [NFC][SystemZ][z/OS] Rename autoconversion-related functions to be less generic (PR #107399)

2024-09-05 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/107399 This patch renames the functions in AutoConvert.h/cpp to have a less generic name because they are z/OS specific. >From 34e044dc5677b345570a202dd0542440a7eee8d9 Mon Sep 17 00:00:00 2001 From: Abhina Sreeska

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-08-20 Thread Abhina Sree via cfe-commits
@@ -532,9 +532,371 @@ bool SystemZTargetCodeGenInfo::isVectorTypeBased(const Type *Ty, return false; } +//===--===// +// z/OS XPLINK ABI Implementation +//===

[clang] [NFC] Remove unnecessary copy of Triples (PR #102469)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/102469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove unnecessary copy of Triples (PR #102469)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/102469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove unnecessary copy of Triples (PR #102469)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/102469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove unnecessary copy of Triple in ItaniumMangle.cpp (PR #102469)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/102469 >From e5139d8079471ac6e6f0d76f36ed7ef593fff1b7 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Thu, 8 Aug 2024 09:57:03 -0400 Subject: [PATCH 1/2] [NFC] Remove unnecessary copy of Triple in Ita

[clang] [llvm] [SystemZ][z/OS] __ptr32 support for z/OS (PR #101696)

2024-08-08 Thread Abhina Sree via cfe-commits
@@ -2727,6 +2727,8 @@ void CXXNameMangler::mangleQualifiers(Qualifiers Quals, const DependentAddressSp //::= U //::= U +llvm::Triple Triple = getASTContext().getTargetInfo().getTriple(); abhina-sree wrote: Thanks for catching, I fixed t

[clang] [NFC] Remove unnecessary copy of Triple in ItaniumMangle.cpp (PR #102469)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree edited https://github.com/llvm/llvm-project/pull/102469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Remove unnecessary copy of Triple in ItaniumMangle.cpp (PR #102469)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/102469 Remove unnecessary copy of Triple in ItaniumMangle.cpp >From e5139d8079471ac6e6f0d76f36ed7ef593fff1b7 Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Thu, 8 Aug 2024 09:57:03 -0400 Subject: [PA

[clang] [llvm] [SystemZ][z/OS] __ptr32 support for z/OS (PR #101696)

2024-08-08 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree closed https://github.com/llvm/llvm-project/pull/101696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >