[clang] Split -Wcast-function-type into a separate group (PR #86131)

Abhinkop wrote: > Hi @Abhinkop! I was wondering if there was any progress regarding the patch > to resolve the stage 2 failure, as our bot is still red > (https://lab.llvm.org/buildbot/#/builders/36/builds/43929/steps/12/logs/stdio). > Please let me know if you would also like me to test any p

[clang] Split -Wcast-function-type into a separate group (PR #86131)

Abhinkop wrote: @amy-kwan I'm looking at it now. I will most probably raise a review some time later in the evening or tomorrow if I am not able to complete it today. https://github.com/llvm/llvm-project/pull/86131 ___ cfe-commits mailing list cfe-co

[clang] Split -Wcast-function-type into a separate group (PR #86131)

Abhinkop wrote: @AaronBallman @amy-kwan Here is the pull request for compiler-rt patch https://github.com/llvm/llvm-project/pull/86290. I am not able to add reviewers to that pull request. https://github.com/llvm/llvm-project/pull/86131 ___ cfe-commi

[clang] Split -Wcast-function-type into a separate group (PR #86131)

Abhinkop wrote: Yes, I will create a separate patch. I'm not sure it would be able to do it in this patch. I am halfway through verifying the fix in this patch. https://github.com/llvm/llvm-project/pull/86131 ___ cfe-commits mailing list cfe-commits@l

[clang] Split -Wcast-function-type into a separate group (PR #86131)

Abhinkop wrote: Yes. I have done that. The tests failed because zlib was not enabled. Running them with a rebuild after force-enabling zlib now. Will keep you updated on the results. https://github.com/llvm/llvm-project/pull/86131 ___ cfe-commits mai

[clang] Split -Wcast-function-type into a separate group (PR #86131)

Abhinkop wrote: @AaronBallman @amy-kwan I am working on a patch for this build breaking in https://lab.llvm.org/buildbot/#/builders/57/builds/33656. Is there anything else I should also be considering? https://github.com/llvm/llvm-project/pull/86131

[clang] Split -Wcast-function-type into a separate group (PR #86131)

Abhinkop wrote: I think that this would occur primarily in the whole code base. Because a compilation that has added -Wextra diagnostic group would provide new warnings and coupling, this with -Werror would break the build. I think we have to take a look at these builds and investigate why it

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

Abhinkop wrote: > > > I'm confused as to how this code ever compiled in the first place... In > > > each case, this is C++ code that's failing: > > > ``` > > > /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/sanitizer_common

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

Abhinkop wrote: > I'm confused as to how this code ever compiled in the first place... In each > case, this is C++ code that's failing: > > ``` > /home/buildbots/llvm-external-buildbots/workers/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-project/compiler-rt/lib/sanitizer_common/sanitizer_po

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

Abhinkop wrote: > I believe this patch is causing some issues on two PPC bots. Would you be > able to help take a look? > https://lab.llvm.org/buildbot/#/builders/57/builds/33601/steps/5/logs/stdio > https://lab.llvm.org/buildbot/#/builders/36/builds/43759/steps/12/logs/stdio I guess adding t

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

Abhinkop wrote: @nickdesaulniers @AaronBallman Can you'll take a look at this pull request? https://github.com/llvm/llvm-project/pull/77178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/8] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/4] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/3] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Abhinkop wrote: Done. File removed, and a FIXME comment added for the existing test. https://github.com/llvm/llvm-project/pull/77178 ___ cfe-commit

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int (f2)(voi

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ Abhinkop wrote: Didn't have to do it as the

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/3] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH 1/2] [clang] move -Wcast-function-type under -Wextra ---

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int (f2)(voi

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int (f2)(voi

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Abhinkop wrote: Ok. sounds good I will do that. https://github.com/llvm/llvm-project/pull/77178 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop edited https://github.com/llvm/llvm-project/pull/77178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Abhinkop wrote: No I was thinking of adding extra runs for both -Wcast-function-type and -Wextra or should the one for -Wcast-function-type be done in a different issue? https://github.com/ll

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify + + +int t(int array[static 12]); +int u(int i); +const int v(int i); /* expected-warning {{'const' type qualifier on return type has no effec}} */ +int x(long); + +typedef int (f1)(long); +typedef int (f2)(voi

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 %s -fsyntax-only -Wextra -verify Abhinkop wrote: add runs for -std=cNN for all remaining 5 of them? and also add extra test cases where conflicts arise? https://github.com/llvm/llvm-project/pull/77178 ___

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop updated https://github.com/llvm/llvm-project/pull/77178 >From d147292312ea05eb6b4a28940faffe54093c900e Mon Sep 17 00:00:00 2001 From: Abhin Parekadan Jose Date: Sat, 6 Jan 2024 05:09:36 +0100 Subject: [PATCH] [clang] move -Wcast-function-type under -Wextra --- clan

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

Abhinkop wrote: @nickdesaulniers https://github.com/llvm/llvm-project/pull/77178 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] move -Wcast-function-type under -Wextra (PR #77178)

https://github.com/Abhinkop created https://github.com/llvm/llvm-project/pull/77178 This patch is for github issue https://github.com/llvm/llvm-project/issues/76872. The -Wcast-fuction-type-strict has been moved under dignstic group -Wextra. Edited the test cases for -Wcast-fuction-type-stric