sabel83 added inline comments.
Comment at: clang/lib/Frontend/FrontendActions.cpp:554
+
+llvm_unreachable("Failed to retrieve a name for this entry!");
+ }
Have you considered generating some default text here?
In case a new, uncovered case does not get cov
sabel83 updated this revision to Diff 133614.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/clang/Sema/Sema.h
include/clang/Sema/Temp
sabel83 updated this revision to Diff 133400.
sabel83 marked an inline comment as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
sabel83 marked an inline comment as done.
sabel83 added inline comments.
Comment at: include/clang/Driver/CC1Options.td:537
+def templight_dump : Flag<["-"], "templight-dump">,
+ HelpText<"Dump templight information to stdout">;
def ast_dump_lookups : Flag<["-"], "ast-dump-look
sabel83 added a comment.
This pull requests consists of two parts:
a) a hook, which is called during template instantiation events
b) a callback, which dumps the details of the events out to standard output
Tools like Templight (https://github.com/mikael-s-persson/templight) rely on
the hook.
sabel83 updated this revision to Diff 132778.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/clang/Sema/Sema.h
include/clang/Sema/Temp
sabel83 added a comment.
I have no commit access, please commit the patch for me.
https://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sabel83 marked 2 inline comments as done.
sabel83 added a comment.
I have extended the context as suggested.
https://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
sabel83 updated this revision to Diff 125272.
sabel83 marked an inline comment as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
sabel83 updated this revision to Diff 123465.
Herald added a subscriber: rnkovacs.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/clang/
sabel83 added a comment.
In https://reviews.llvm.org/D5767#920085, @rsmith wrote:
> I'm not entirely sure what's happening with this and
> https://reviews.llvm.org/D38818, but the direction looks good to me, and I
> left a couple of comments on the other review thread.
This was the original p
sabel83 updated this revision to Diff 122325.
sabel83 marked an inline comment as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
sabel83 marked an inline comment as done.
sabel83 added a comment.
The last update of the patch also contains the changes to this pull request
based on comments from https://reviews.llvm.org/D5767.
https://reviews.llvm.org/D38818
___
cfe-commits ma
sabel83 marked an inline comment as done.
sabel83 added a comment.
I have moved the tests into their own directory in the last update.
Comment at: tools/CMakeLists.txt:37
add_clang_subdirectory(libclang)
+add_subdirectory(templight)
rsmith wrote:
> Did you mea
sabel83 updated this revision to Diff 122324.
https://reviews.llvm.org/D38818
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/clang/Sema/Sema.h
include/clang/Sema/Tem
sabel83 updated this revision to Diff 120358.
sabel83 marked 2 inline comments as done.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/c
sabel83 added a comment.
I've updated the patch based on your comments.
https://reviews.llvm.org/D5767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sabel83 updated this revision to Diff 119774.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/clang/FrontendTool/Utils.h
include/clang/Sema/Sema.h
include/clang/Sema/Temp
sabel83 updated this revision to Diff 119377.
sabel83 added reviewers: cfe-commits, klimek, mclow.lists, martong, xazax.hun.
https://reviews.llvm.org/D5767
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendActions.h
include/clang/Frontend/FrontendOptions.h
include/c
19 matches
Mail list logo
