[clang] [CIR] Add 'get element' for array index ops (PR #172897)

2025-12-18 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/172897 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add 'get element' for array index ops (PR #172897)

2025-12-18 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm % description fix https://github.com/llvm/llvm-project/pull/172897 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 04638a7 - [NFC] [C++20] [Modules] Adding test for typeinfo

2025-12-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2025-12-19T15:52:27+08:00 New Revision: 04638a76c1d8d572e56f3c8103bc642c4355fa7f URL: https://github.com/llvm/llvm-project/commit/04638a76c1d8d572e56f3c8103bc642c4355fa7f DIFF: https://github.com/llvm/llvm-project/commit/04638a76c1d8d572e56f3c8103bc642c4355fa7f.diff LO

[clang] [LifetimeSafety] Add bailout for large CFGs (PR #170444)

2025-12-18 Thread via cfe-commits
https://github.com/DEBADRIBASAK edited https://github.com/llvm/llvm-project/pull/170444 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add FixItHint for designated init order (PR #172959)

2025-12-18 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/172959 >From bcdb0fd408b055baaf1a1dc3cde1d87daf5cde44 Mon Sep 17 00:00:00 2001 From: Mythreya Date: Thu, 18 Dec 2025 23:21:50 -0800 Subject: [PATCH 1/2] [clang] Add FixItHint for designated init order --- clang/lib

[clang] [clang] Add FixItHint for designated init order (PR #172959)

2025-12-18 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK edited https://github.com/llvm/llvm-project/pull/172959 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Implement conditional Zca implies C extension rule (PR #172860)

2025-12-18 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/172860 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5937d7f - [C++20] [Modules] Correct the behavior for adding mangling for lambda in modules

2025-12-18 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2025-12-19T15:44:34+08:00 New Revision: 5937d7f907ef656abb16622c8b4e72fe906e9328 URL: https://github.com/llvm/llvm-project/commit/5937d7f907ef656abb16622c8b4e72fe906e9328 DIFF: https://github.com/llvm/llvm-project/commit/5937d7f907ef656abb16622c8b4e72fe906e9328.diff LO

[libcxx] [libcxxabi] [libunwind] [runtimes] Rename the %{flags} Lit substitution to %{common_flags} (PR #172931)

2025-12-18 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 approved this pull request. https://github.com/llvm/llvm-project/pull/172931 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Implement conditional Zca implies C extension rule (PR #172860)

2025-12-18 Thread Jim Lin via cfe-commits
https://github.com/tclin914 approved this pull request. LGTM. But please wait other reviews's comment. https://github.com/llvm/llvm-project/pull/172860 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang] Add FixItHint for designated init order (PR #172959)

2025-12-18 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK updated https://github.com/llvm/llvm-project/pull/172959 >From bcdb0fd408b055baaf1a1dc3cde1d87daf5cde44 Mon Sep 17 00:00:00 2001 From: Mythreya Date: Thu, 18 Dec 2025 23:21:50 -0800 Subject: [PATCH] [clang] Add FixItHint for designated init order --- clang/lib/Sem

[clang] [CIR][X86] Add support for shuff32x4/shufi32x4 builtins (PR #172960)

2025-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Julian Pokrovsky (raventid) Changes This implementation is adapted from the existing code for `X86::BI__builtin_ia32_shuf_i*` and `X86::BI__builtin_ia32_shuf_f*` from `/llvm-project/clang/lib/CodeGen/TargetBuiltins/X86.cpp`. It adds supp

[clang] [CIR][X86] Add support for shuff32x4/shufi32x4 builtins (PR #172960)

2025-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Julian Pokrovsky (raventid) Changes This implementation is adapted from the existing code for `X86::BI__builtin_ia32_shuf_i*` and `X86::BI__builtin_ia32_shuf_f*` from `/llvm-project/clang/lib/CodeGen/TargetBuiltins/X86.cpp`. It adds su

[clang] [CIR][X86] Add support for shuff32x4/shufi32x4 builtins (PR #172960)

2025-12-18 Thread Julian Pokrovsky via cfe-commits
https://github.com/raventid created https://github.com/llvm/llvm-project/pull/172960 This implementation is adapted from the existing code for `X86::BI__builtin_ia32_shuf_i*` and `X86::BI__builtin_ia32_shuf_f*` from `/llvm-project/clang/lib/CodeGen/TargetBuiltins/X86.cpp`. It adds support for

[clang] [clang] Add FixItHint for designated init order (PR #172959)

2025-12-18 Thread Mythreya Kuricheti via cfe-commits
https://github.com/MythreyaK created https://github.com/llvm/llvm-project/pull/172959 None >From e74519649a148d01b04f0934638df4dec8372423 Mon Sep 17 00:00:00 2001 From: Mythreya Date: Tue, 16 Dec 2025 02:44:10 -0800 Subject: [PATCH] [clang] Add FixItHint for designated init order --- clang/l

[libclc] [libclc] Improve __clc_min/max/clamp implementation (PR #172599)

2025-12-18 Thread Wenju He via cfe-commits
https://github.com/wenju-he closed https://github.com/llvm/llvm-project/pull/172599 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] d532641 - [libclc] Improve __clc_min/max/clamp implementation (#172599)

2025-12-18 Thread via cfe-commits
Author: Wenju He Date: 2025-12-19T14:36:03+08:00 New Revision: d5326411fe866e010aadd3af3155b656a5aeaae3 URL: https://github.com/llvm/llvm-project/commit/d5326411fe866e010aadd3af3155b656a5aeaae3 DIFF: https://github.com/llvm/llvm-project/commit/d5326411fe866e010aadd3af3155b656a5aeaae3.diff LOG:

[clang-tools-extra] [clang-tidy][NFC] Give structs, classes, and enums internal linkage where applicable (PR #172947)

2025-12-18 Thread via cfe-commits
https://github.com/zeyi2 approved this pull request. https://github.com/llvm/llvm-project/pull/172947 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add keydecls to modules instead of just expanding them. (PR #172898)

2025-12-18 Thread Michael Park via cfe-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/172898 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LifetimeSafety] Add missing origins stats for lifetime analysis (PR #166568)

2025-12-18 Thread via cfe-commits
https://github.com/DEBADRIBASAK updated https://github.com/llvm/llvm-project/pull/166568 >From fd8693c51af7d9f91be0926f4150e77c39e2dba4 Mon Sep 17 00:00:00 2001 From: Debadri Basak Date: Wed, 5 Nov 2025 14:07:42 + Subject: [PATCH 01/15] Adding the lifetime stats collection logic to Analysi

[clang] [LifetimeSafety] Add missing origins stats for lifetime analysis (PR #166568)

2025-12-18 Thread via cfe-commits
https://github.com/DEBADRIBASAK updated https://github.com/llvm/llvm-project/pull/166568 >From fd8693c51af7d9f91be0926f4150e77c39e2dba4 Mon Sep 17 00:00:00 2001 From: Debadri Basak Date: Wed, 5 Nov 2025 14:07:42 + Subject: [PATCH 01/15] Adding the lifetime stats collection logic to Analysi

[clang] [llvm] [mlir] [AMDGPU] add clamp immediate operand to WMMA iu8 intrinsic (PR #171069)

2025-12-18 Thread Shilei Tian via cfe-commits
@@ -1665,6 +1665,13 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, if (AppendFalseForOpselArg) Args.push_back(Builder.getFalse()); +if (BuiltinID == AMDGPU::BI__builtin_amdgcn_wmma_i32_16x16x64_iu8) { + if (Args.size() == 7) --

[clang] [llvm] [mlir] [AMDGPU] add clamp immediate operand to WMMA iu8 intrinsic (PR #171069)

2025-12-18 Thread Shilei Tian via cfe-commits
@@ -856,7 +856,7 @@ TARGET_BUILTIN(__builtin_amdgcn_wmma_f16_16x16x64_fp8_fp8, "V8hV8iV8iIsV8hIbIb", TARGET_BUILTIN(__builtin_amdgcn_wmma_f16_16x16x64_fp8_bf8, "V8hV8iV8iIsV8hIbIb", "nc", "gfx1250-insts,wavefrontsize32") TARGET_BUILTIN(__builtin_amdgcn_wmma_f16_16x16x64_bf8_fp

[clang] Add keydecls to modules instead of just expanding them. (PR #172898)

2025-12-18 Thread Michael Park via cfe-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/172898 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add keydecls to modules instead of just expanding them. (PR #172898)

2025-12-18 Thread Michael Park via cfe-commits
@@ -,6 +,7 @@ class ASTDeclContextNameLookupTrait }; ASTReader *Chain = Writer.getChain(); for (NamedDecl *D : Decls) { + AddDecl(D); mpark wrote: @Sterling-Augustine I understand you cannot share the repro you have, would you be able

[clang] [WinEH] Fix crash, object unwinding in the except block (PR #172287)

2025-12-18 Thread via cfe-commits
https://github.com/GkvJwa updated https://github.com/llvm/llvm-project/pull/172287 >From 2e34318cd3fbffedbd231239d9f99a0907442970 Mon Sep 17 00:00:00 2001 From: GkvJwa Date: Thu, 18 Dec 2025 00:30:02 +0800 Subject: [PATCH 1/5] Add test and skip Borland --- clang/lib/Sema/SemaStmt.cpp

[clang] [WinEH] Fix crash, object unwinding in the except block (PR #172287)

2025-12-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Sema/SemaStmt.cpp clang/test/SemaCXX/e

[clang] [WinEH] Fix crash, object unwinding in the except block (PR #172287)

2025-12-18 Thread via cfe-commits
https://github.com/GkvJwa updated https://github.com/llvm/llvm-project/pull/172287 >From 2e34318cd3fbffedbd231239d9f99a0907442970 Mon Sep 17 00:00:00 2001 From: GkvJwa Date: Thu, 18 Dec 2025 00:30:02 +0800 Subject: [PATCH 1/4] Add test and skip Borland --- clang/lib/Sema/SemaStmt.cpp

[clang-tools-extra] [clang-tidy][NFC] Give structs, classes, and enums internal linkage where applicable (PR #172947)

2025-12-18 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/172947 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Handle optional alignment in alloca lowering (PR #172663)

2025-12-18 Thread Akimasa Watanuki via cfe-commits
https://github.com/Men-cotton updated https://github.com/llvm/llvm-project/pull/172663 >From 326addd57e92ad32094d4c81b412e279ee2ad130 Mon Sep 17 00:00:00 2001 From: mencotton Date: Wed, 17 Dec 2025 21:28:59 +0900 Subject: [PATCH 1/3] [CIR] Handle optional alignment in alloca lowering --- clan

[clang] [clang][cmake] Add option to control scan-build-py installation (PR #172727)

2025-12-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `reverse-iteration` running on `hexagon-build-03` while building `clang` at step 6 "check_all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/110/builds/6880 Here is the relevant piece of the build l

[clang] [clang] Define __PTRAUTH_INTRINSICS__ for arm64e-apple-* targets (PR #172944)

2025-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Mike Hommey (glandium) Changes The macro is set by Xcode clang for the arm64e-apple-* targets, and ifdefed in the macOS and iPhoneOS SDKs. --- Full diff: https://github.com/llvm/llvm-project/pull/172944.diff 2 Files Affected:

[clang] [clang] Define __PTRAUTH_INTRINSICS__ for arm64e-apple-* targets (PR #172944)

2025-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mike Hommey (glandium) Changes The macro is set by Xcode clang for the arm64e-apple-* targets, and ifdefed in the macOS and iPhoneOS SDKs. --- Full diff: https://github.com/llvm/llvm-project/pull/172944.diff 2 Files Affected: - (modifi

[clang] [clang] Define __PTRAUTH_INTRINSICS__ for arm64e-apple-* targets (PR #172944)

2025-12-18 Thread Mike Hommey via cfe-commits
https://github.com/glandium created https://github.com/llvm/llvm-project/pull/172944 The macro is set by Xcode clang for the arm64e-apple-* targets, and ifdefed in the macOS and iPhoneOS SDKs. >From f8af753c0503f3648d772dc14e3e9ddd34747094 Mon Sep 17 00:00:00 2001 From: Mike Hommey Date: Fri,

[clang] [llvm] [mlir] [Clang]Check for a valid Index in array before getting it (PR #172399)

2025-12-18 Thread Balaji V. Iyer. via cfe-commits
https://github.com/bviyer edited https://github.com/llvm/llvm-project/pull/172399 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [Clang]Check for a valid Index in array before getting it (PR #172399)

2025-12-18 Thread Balaji V. Iyer. via cfe-commits
https://github.com/bviyer updated https://github.com/llvm/llvm-project/pull/172399 >From 18a648b9b1a5afb20ac964f581f80281377360e1 Mon Sep 17 00:00:00 2001 From: "Balaji V. Iyer" Date: Mon, 15 Dec 2025 20:36:00 -0600 Subject: [PATCH 1/6] Check for a valid Index in array before getting it Fixes

[clang] Add keydecls to modules instead of just expanding them. (PR #172898)

2025-12-18 Thread Michael Park via cfe-commits
mpark wrote: > > Hi @Sterling-Augustine, thanks for this! Curious, are you able to share the > > several hundred line repro you do have? Maybe with some obfuscating? > > > > Alas, it is hundreds of files still, not hundreds of lines. And many are > confidential. Ohh I see. I misread that.

[clang] [Clang]Check for a valid Index in array before getting it (PR #172399)

2025-12-18 Thread Balaji V. Iyer. via cfe-commits
bviyer wrote: > This change needs a release note. Please add an entry to > `clang/docs/ReleaseNotes.rst` in the section the most adapted to the change, > and referencing any Github issue this change fixes. Thanks! Added. https://github.com/llvm/llvm-project/pull/172399 ___

[clang] [Clang]Check for a valid Index in array before getting it (PR #172399)

2025-12-18 Thread Balaji V. Iyer. via cfe-commits
bviyer wrote: > -fexperimental-new-constant-interpreter When I have this enabled in the test case, it will evaluate it and find out that the array index is greater than array size and thus cannot be represented. So I added a test where it catches these errors. https://github.com/llvm/llvm-pro

[clang] [Clang]Check for a valid Index in array before getting it (PR #172399)

2025-12-18 Thread Balaji V. Iyer. via cfe-commits
@@ -9749,6 +9749,11 @@ bool LValueExprEvaluator::VisitArraySubscriptExpr(const ArraySubscriptExpr *E) { if (Success) { Result.setFrom(Info.Ctx, Val); + // If Index cannot be represented as a 64 bit integer, return + // unsuccessful. + if (!Index.tryEx

[clang] Reapply "[HLSL] Rewrite semantics parsing" (#157718) (PR #158044)

2025-12-18 Thread Shafik Yaghmour via cfe-commits
@@ -1616,29 +1622,70 @@ bool SemaHLSL::diagnosePositionType(QualType T, const ParsedAttr &AL) { return true; } -void SemaHLSL::handleSV_PositionAttr(Decl *D, const ParsedAttr &AL) { - auto *VD = cast(D); - if (!diagnosePositionType(VD->getType(), AL)) -return; - - D-

[clang] Reapply "[HLSL] Rewrite semantics parsing" (#157718) (PR #158044)

2025-12-18 Thread Shafik Yaghmour via cfe-commits
@@ -1616,29 +1622,70 @@ bool SemaHLSL::diagnosePositionType(QualType T, const ParsedAttr &AL) { return true; } -void SemaHLSL::handleSV_PositionAttr(Decl *D, const ParsedAttr &AL) { - auto *VD = cast(D); - if (!diagnosePositionType(VD->getType(), AL)) -return; - - D-

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread via cfe-commits
github-actions[bot] wrote: @MarwanTarik Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/171694 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7ee923d - [CIR] Upstream convert to mask builtins in CIR codegen (#171694)

2025-12-18 Thread via cfe-commits
Author: Starlight Date: 2025-12-19T01:54:31Z New Revision: 7ee923d0ecc6bd46bf1b7d90a40c36114a20d66b URL: https://github.com/llvm/llvm-project/commit/7ee923d0ecc6bd46bf1b7d90a40c36114a20d66b DIFF: https://github.com/llvm/llvm-project/commit/7ee923d0ecc6bd46bf1b7d90a40c36114a20d66b.diff LOG: [CI

[clang] [C++20][Modules] Implement P1857R3 Modules Dependency Discovery (PR #107168)

2025-12-18 Thread via cfe-commits
@@ -20450,7 +20450,7 @@ C++ defect report implementation status [https://wg21.link/cpp.module";>cpp.module] open Limiting macro expansion in pp-module -Not resolved +Clang 22 h-vetinari wrote: ```suggestion Clang 22 ``` https://github

[clang] [CIR] Handle optional alignment in alloca lowering (PR #172663)

2025-12-18 Thread Akimasa Watanuki via cfe-commits
Men-cotton wrote: > @Men-cotton How did you encounter the crash you are fixing here? Fuzz testing? I found this crash via `./build/bin/cir-opt --cir-to-llvm clang/test/CIR/IR/types.cir`. https://github.com/llvm/clangir/blob/main/clang/test/CIR/IR/types.cir https://github.com/llvm/llvm-project/

[clang] [CIR] Make x86 i1 mask vectors signed (PR #172912)

2025-12-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/14831 Here is the relev

[clang] [X86][bytecode] Allow SSE/AVX PBLENDVB intrinsics to be used in constexpr (PR #157100)

2025-12-18 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/157100 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86][bytecode] Allow SSE/AVX PBLENDVB intrinsics to be used in constexpr (PR #157100)

2025-12-18 Thread Shafik Yaghmour via cfe-commits
@@ -3412,6 +3412,13 @@ bool InterpretBuiltin(InterpState &S, CodePtr OpPC, const CallExpr *Call, case Builtin::BI__builtin_elementwise_fma: return interp__builtin_elementwise_fma(S, OpPC, Call); + case clang::X86::BI__builtin_ia32_pblendvb128: + case clang::X86::BI__b

[clang] [CIR] Upstream support for data member comparison (PR #171897)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/171897 >From a858a130a933db2753b7f678c5d0893e8d09efed Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 9 Dec 2025 14:45:09 -0800 Subject: [PATCH 1/2] [CIR] Add support for data member comparison This adds supp

[clang] [clang][cmake] Add option to control scan-build-py installation (PR #172727)

2025-12-18 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/23895 Here is the relevant piece of the

[clang] c2f33b5 - [CIR] Implement AggExprEmitter::VisitVAArgExpr (#172551)

2025-12-18 Thread via cfe-commits
Author: adams381 Date: 2025-12-18T15:53:04-08:00 New Revision: c2f33b5a28f82b723db51469aa4681cefea23c09 URL: https://github.com/llvm/llvm-project/commit/c2f33b5a28f82b723db51469aa4681cefea23c09 DIFF: https://github.com/llvm/llvm-project/commit/c2f33b5a28f82b723db51469aa4681cefea23c09.diff LOG:

[clang] [CIR] Implement AggExprEmitter::VisitVAArgExpr (PR #172551)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/172551 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][driver][darwin] Base the system prefix on the SDK, not the target (PR #171970)

2025-12-18 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > Any chance we can run the LLDB test-suite on macOS against this change? Happy > to help if you haven't got that set up Is there a way to do that in CI? I don't have any lldb stuff set up locally, would you or another lldb engineer mind running that if there's no CI w

[clang-tools-extra] [clang-tidy] Teach `misc-use-internal-linkage` to suggest giving classes internal linkage (PR #172797)

2025-12-18 Thread Baranov Victor via cfe-commits
vbvictor wrote: > allow users to pick-and-choose whether they want functions, variables, or > classes to be diagnosed? This configuration will be very much needed indeed. https://github.com/llvm/llvm-project/pull/172797 ___ cfe-commits mailing list

[clang] Implement select/selectsh builtins in CIR (PR #172299)

2025-12-18 Thread Andy Kaylor via cfe-commits
@@ -1334,10 +1353,14 @@ CIRGenFunction::emitX86BuiltinExpr(unsigned builtinID, const CallExpr *expr) { case X86::BI__builtin_ia32_selectpd_128: case X86::BI__builtin_ia32_selectpd_256: case X86::BI__builtin_ia32_selectpd_512: +return emitX86VectorSelect(builder, getL

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread via cfe-commits
@@ -768,3 +756,51 @@ unsigned char test_ktestz_mask64_u8(__mmask64 A, __mmask64 B) { return _ktestz_mask64_u8(A, B); } + + +__m512i test_mm512_movm_epi16(__mmask32 __A) { + // CIR-LABEL: _mm512_movm_epi16 + // CIR: %{{.*}} = cir.cast bitcast %{{.*}} : !u32i -> !cir.vector

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread Andy Kaylor via cfe-commits
@@ -768,3 +756,51 @@ unsigned char test_ktestz_mask64_u8(__mmask64 A, __mmask64 B) { return _ktestz_mask64_u8(A, B); } + + +__m512i test_mm512_movm_epi16(__mmask32 __A) { + // CIR-LABEL: _mm512_movm_epi16 + // CIR: %{{.*}} = cir.cast bitcast %{{.*}} : !u32i -> !cir.vector

[clang] [CIR][X86] Implement lowering for `_AddressOfReturnAddress` builtin (PR #171974)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/171974 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6d6c0cc - [CIR][X86] Implement lowering for `_AddressOfReturnAddress` builtin (#171974)

2025-12-18 Thread via cfe-commits
Author: Haocong Lu Date: 2025-12-18T14:48:19-08:00 New Revision: 6d6c0cc3bb9123f0b915c0593ec3105a538e0d51 URL: https://github.com/llvm/llvm-project/commit/6d6c0cc3bb9123f0b915c0593ec3105a538e0d51 DIFF: https://github.com/llvm/llvm-project/commit/6d6c0cc3bb9123f0b915c0593ec3105a538e0d51.diff LO

[clang] [CIR][X86] Implement lowering for `_AddressOfReturnAddress` builtin (PR #171974)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/171974 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][cmake] Add option to control scan-build-py installation (PR #172727)

2025-12-18 Thread via cfe-commits
https://github.com/serge-sans-paille approved this pull request. This does not change the default behavior, and matches what's already done for scan-build (through `CLANG_INSTALL_SCANBUILD`), lgtm https://github.com/llvm/llvm-project/pull/172727 ___ c

[clang] [llvm] AMDGPU: Add builtin/intrinsic global_(load|store)_b128 (PR #172090)

2025-12-18 Thread Matt Arsenault via cfe-commits
arsenm wrote: > Then at least we need to check the string in the front end. I thought those were validated for the existing atomics? https://github.com/llvm/llvm-project/pull/172090 ___ cfe-commits mailing list [email protected] https://lists

[clang] [CIR] Add emitDeclInvariant for global with constant storage (PR #171915)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/171915 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d524ecb - [CIR] Add emitDeclInvariant for global with constant storage (#171915)

2025-12-18 Thread via cfe-commits
Author: adams381 Date: 2025-12-18T14:40:41-08:00 New Revision: d524ecbf0f735fa2b5ea73ea70da8c68985afe33 URL: https://github.com/llvm/llvm-project/commit/d524ecbf0f735fa2b5ea73ea70da8c68985afe33 DIFF: https://github.com/llvm/llvm-project/commit/d524ecbf0f735fa2b5ea73ea70da8c68985afe33.diff LOG:

[clang] [CIR] Add emitDeclInvariant for global with constant storage (PR #171915)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/171915 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Move CIR CXXABI lowering to a standlone pass (PR #172133)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/172133 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 58cf128 - [CIR] Move CIR CXXABI lowering to a standlone pass (#172133)

2025-12-18 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-12-18T22:36:17Z New Revision: 58cf128e50fe759373798c4512830c177ed9ecdb URL: https://github.com/llvm/llvm-project/commit/58cf128e50fe759373798c4512830c177ed9ecdb DIFF: https://github.com/llvm/llvm-project/commit/58cf128e50fe759373798c4512830c177ed9ecdb.diff LOG: [

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread Andy Kaylor via cfe-commits
@@ -768,3 +756,51 @@ unsigned char test_ktestz_mask64_u8(__mmask64 A, __mmask64 B) { return _ktestz_mask64_u8(A, B); } + + +__m512i test_mm512_movm_epi16(__mmask32 __A) { + // CIR-LABEL: _mm512_movm_epi16 + // CIR: %{{.*}} = cir.cast bitcast %{{.*}} : !u32i -> !cir.vector

[clang] [CIR] Make x86 i1 mask vectors signed (PR #172912)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/172912 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 73938a5 - [CIR] Make x86 i1 mask vectors signed (#172912)

2025-12-18 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-12-18T14:33:48-08:00 New Revision: 73938a576812dc78005a3f2379d85fa4af059309 URL: https://github.com/llvm/llvm-project/commit/73938a576812dc78005a3f2379d85fa4af059309 DIFF: https://github.com/llvm/llvm-project/commit/73938a576812dc78005a3f2379d85fa4af059309.diff L

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread Andy Kaylor via cfe-commits
@@ -768,3 +756,51 @@ unsigned char test_ktestz_mask64_u8(__mmask64 A, __mmask64 B) { return _ktestz_mask64_u8(A, B); } + + +__m512i test_mm512_movm_epi16(__mmask32 __A) { + // CIR-LABEL: _mm512_movm_epi16 + // CIR: %{{.*}} = cir.cast bitcast %{{.*}} : !u32i -> !cir.vector

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread via cfe-commits
@@ -1,32 +1,21 @@ // RUN: %clang_cc1 -x c -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-linux -target-feature +avx512bw -fclangir -emit-cir -o %t.cir -Wall -Werror -Wsign-conversion // RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s -// RUN: %

[clang] [CIR] Add X86 prefetch builtins (PR #168051)

2025-12-18 Thread Andy Kaylor via cfe-commits
andykaylor wrote: @HendrikHuebner Now that we've introduced `std::optional` returns as you had proposed here, can you rebase this PR to use that mechanism? https://github.com/llvm/llvm-project/pull/168051 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang] Make error for [[clang::coro_wrapper]] be downgradable to a warning (PR #172910)

2025-12-18 Thread via cfe-commits
github-actions[bot] wrote: # :window: Windows x64 Test Results The build failed before running any tests. Click on a failure below to see the details. [code=1] tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaDecl.cpp.obj ``` FAILED: [code=1] tools/clang/lib/Sema/CMakeFiles/obj.clang

[clang] [clang] Make error for [[clang::coro_wrapper]] be downgradable to a warning (PR #172910)

2025-12-18 Thread via cfe-commits
github-actions[bot] wrote: # :penguin: Linux x64 Test Results The build failed before running any tests. Click on a failure below to see the details. tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaDecl.cpp.o ``` FAILED: tools/clang/lib/Sema/CMakeFiles/obj.clangSema.dir/SemaDecl.cpp.o

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread Andy Kaylor via cfe-commits
@@ -1,32 +1,21 @@ // RUN: %clang_cc1 -x c -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-linux -target-feature +avx512bw -fclangir -emit-cir -o %t.cir -Wall -Werror -Wsign-conversion // RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s -// RUN: %

[clang] [CIR] Move CIR CXXABI lowering to a standlone pass (PR #172133)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor auto_merge_enabled https://github.com/llvm/llvm-project/pull/172133 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Move CIR CXXABI lowering to a standlone pass (PR #172133)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/172133 >From e3c6b5d8fe0c00f44718f8218c7925ffe50b1f22 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Fri, 12 Dec 2025 22:13:11 -0800 Subject: [PATCH 1/4] [CIR] Move CIR CXXABI lowering to a standlone pass This mo

[clang-tools-extra] [clang-tidy][NFC] Fix `bugprone-unchecked-optional-access` warnings in codebase (PR #170004)

2025-12-18 Thread Baranov Victor via cfe-commits
vbvictor wrote: > > I will double-check later. > > Thanks! I checked, and the results are: ```bash time python3 clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -clang-tidy-binary=./build/bin/clang-tidy -checks='-*,bugprone-unchecked-optional-access' -p=./build -enable-check-profi

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread via cfe-commits
@@ -1,32 +1,21 @@ // RUN: %clang_cc1 -x c -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-linux -target-feature +avx512bw -fclangir -emit-cir -o %t.cir -Wall -Werror -Wsign-conversion // RUN: FileCheck --check-prefix=CIR --input-file=%t.cir %s -// RUN: %

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread via cfe-commits
https://github.com/MarwanTarik updated https://github.com/llvm/llvm-project/pull/171694 >From 82529b8bfd35c9e8059b49e2f17b3c837232cf09 Mon Sep 17 00:00:00 2001 From: MarwanTarik Date: Wed, 10 Dec 2025 22:21:55 +0200 Subject: [PATCH 01/17] Upstream CIR Codgen for convert to mask X86 builtins --

[clang] [llvm] [AMDGPU] Add `nocreateundeforpoison` annotations (PR #166450)

2025-12-18 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/166450 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Apply Rule of Three to BuildLockset (PR #172908)

2025-12-18 Thread via cfe-commits
github-actions[bot] wrote: # :window: Windows x64 Test Results * 53101 tests passed * 2087 tests skipped * 1 test failed ## Failed Tests (click on a test name to see its output) ### SanitizerCommon-Unit SanitizerCommon-Unit._/Sanitizer-x86_64-Test_exe/StopTheWorld/SuspendThreadsAdvanced ```

[clang] [llvm] [AMDGPU] Add `nocreateundeforpoison` annotations (PR #166450)

2025-12-18 Thread Matt Arsenault via cfe-commits
@@ -754,6 +754,19 @@ class MSBuiltin { string MSBuiltinName = name; } +/// Utility class for intrinsics that +/// 1. Don't touch memory or any hidden state +/// 2. Can be freely speculated, and +/// 3. Will not create undef or poison on defined inputs. +class PureTotalIntrin

[clang] [CIR] Make x86 i1 mask vectors signed (PR #172912)

2025-12-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes A number of x86 builtins need to cast a mask value to a vector of i1 values. Strictly speaking, these i1 values should be signless. However, we don't have signless types in CIR, so we have to choose whet

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread Andy Kaylor via cfe-commits
@@ -279,6 +285,102 @@ static mlir::Value emitX86MaskTest(CIRGenBuilderTy &builder, mlir::Location loc, mlir::ValueRange{lhsVec, rhsVec}); } +// TODO: The cgf parameter should be removed when all the NYI cases are implemented. +static std::optiona

[clang] [CIR] Make x86 i1 mask vectors signed (PR #172912)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/172912 A number of x86 builtins need to cast a mask value to a vector of i1 values. Strictly speaking, these i1 values should be signless. However, we don't have signless types in CIR, so we have to choose whether

[clang] [clang] Make error for [[clang::coro_wrapper]] be downgradable to a warning (PR #172910)

2025-12-18 Thread via cfe-commits
https://github.com/higher-performance created https://github.com/llvm/llvm-project/pull/172910 Given that both `-Wreturn-type` and `-Wdangling` are already warnings and not hard errors, it makes sense for this diagnostic to behave similarly. This allows suppressing benign occurrences of the er

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread via cfe-commits
@@ -279,6 +285,102 @@ static mlir::Value emitX86MaskTest(CIRGenBuilderTy &builder, mlir::Location loc, mlir::ValueRange{lhsVec, rhsVec}); } +// TODO: The cgf parameter should be removed when all the NYI cases are implemented. +static std::optiona

[clang] [CIR] Add 'get element' for array index ops (PR #172897)

2025-12-18 Thread Henrich Lauko via cfe-commits
@@ -2694,6 +2694,69 @@ def CIR_GetMemberOp : CIR_Op<"get_member"> { let hasVerifier = 1; } +//===--===// + + +// GetElementOp + + +//===--=

[clang] [CIR] Combine effectively duplicate getMaskVecValue functions (PR #172896)

2025-12-18 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/172896 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fcadb2b - [CIR] Combine effectively duplicate getMaskVecValue functions (#172896)

2025-12-18 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-12-18T13:36:58-08:00 New Revision: fcadb2b3da69bade9c4e091f126826dcc43a040d URL: https://github.com/llvm/llvm-project/commit/fcadb2b3da69bade9c4e091f126826dcc43a040d DIFF: https://github.com/llvm/llvm-project/commit/fcadb2b3da69bade9c4e091f126826dcc43a040d.diff L

[clang] [CIR] Upstream convert to mask builtins in CIR codegen (PR #171694)

2025-12-18 Thread Andy Kaylor via cfe-commits
@@ -279,6 +285,102 @@ static mlir::Value emitX86MaskTest(CIRGenBuilderTy &builder, mlir::Location loc, mlir::ValueRange{lhsVec, rhsVec}); } +// TODO: The cgf parameter should be removed when all the NYI cases are implemented. +static std::optiona

[clang] [CIR] Handle optional alignment in alloca lowering (PR #172663)

2025-12-18 Thread Bruno Cardoso Lopes via cfe-commits
bcardosolopes wrote: > We should probably just make it a required attribute in CIR +1, we could probably have a default value to keep it terse https://github.com/llvm/llvm-project/pull/172663 ___ cfe-commits mailing list [email protected] htt

[clang] [CIR] Upstream Exceptions EHTypeIdOp (PR #172558)

2025-12-18 Thread Bruno Cardoso Lopes via cfe-commits
https://github.com/bcardosolopes approved this pull request. https://github.com/llvm/llvm-project/pull/172558 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][X86] Add support for `intersect` builtins (PR #172554)

2025-12-18 Thread Bruno Cardoso Lopes via cfe-commits
@@ -2694,6 +2694,58 @@ def CIR_GetMemberOp : CIR_Op<"get_member"> { let hasVerifier = 1; } +//===--===// +// GetMemberValueOp +//===--===//

[clang-tools-extra] 6a470bf - [clang-tidy][NFC] Remove redundant braces with clang-format 'RemoveBracesLLVM' (N/N) (#172754)

2025-12-18 Thread via cfe-commits
Author: Baranov Victor Date: 2025-12-19T00:32:02+03:00 New Revision: 6a470bfd7cd038dd70fd47f1d388595e0d2f3b2f URL: https://github.com/llvm/llvm-project/commit/6a470bfd7cd038dd70fd47f1d388595e0d2f3b2f DIFF: https://github.com/llvm/llvm-project/commit/6a470bfd7cd038dd70fd47f1d388595e0d2f3b2f.diff

[clang-tools-extra] [clang-tidy][NFC] Remove redundant braces with clang-format 'RemoveBracesLLVM' (N/N) (PR #172754)

2025-12-18 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/172754 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >