[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
https://github.com/Bhuvan1527 updated https://github.com/llvm/llvm-project/pull/171565 >From 629487c66072b6dd7c173b32a8abef5d7562ea4f Mon Sep 17 00:00:00 2001 From: bhuvan1527 Date: Wed, 10 Dec 2025 11:28:32 +0530 Subject: [PATCH] [clang-tidy] Moved Multiple Inheritence check from fuchsia to m

[clang-tools-extra] [clang-tidy] Enable C99 in `implicit-bool-conversion` and avoid FP with `bool` operands in C23 (PR #171070)

2025-12-09 Thread via cfe-commits
Chase-san wrote: I do have a few concerns. If this particular warning is reported when we have a `bool || int` or similar situation the general consensus will be to simply disable the warning because that is an extremely common pattern. Allowances for such things are generally made because the

[clang] [Clang] Make __builtin_assume_dereferenceable constexpr (PR #169869)

2025-12-09 Thread NagaChaitanya Vellanki via cfe-commits
@@ -0,0 +1,50 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -std=c++14 -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -std=c++14 -emit-llvm -o - %s -fexperimental-new-constant-interpreter | FileCheck %s + +int b = 10; +const int f =

[clang] 43f0b69 - [AMDGPU] Removal of language sensitive option for _Float16 and half('e') handling (#170443)

2025-12-09 Thread via cfe-commits
Author: Rana Pratap Reddy Date: 2025-12-10T13:12:12+05:30 New Revision: 43f0b6960e1816d1c1c5ec04ee2bc8c5638fb4e0 URL: https://github.com/llvm/llvm-project/commit/43f0b6960e1816d1c1c5ec04ee2bc8c5638fb4e0 DIFF: https://github.com/llvm/llvm-project/commit/43f0b6960e1816d1c1c5ec04ee2bc8c5638fb4e0.d

[clang] [AMDGPU] Removal of language sensitive option for _Float16 and half('e') handling (PR #170443)

2025-12-09 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 closed https://github.com/llvm/llvm-project/pull/170443 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Aditi Medhane via cfe-commits
@@ -36,5 +36,106 @@ entry: ret <16 x i8> %0 } +define dso_local <16 x i8> @test_bcdshift_imm0(<16 x i8> noundef %a, i32 %b) { AditiRM wrote: done https://github.com/llvm/llvm-project/pull/154715 ___ cfe-commits m

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Aditi Medhane via cfe-commits
@@ -104,14 +104,81 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI, return Diag(TheCall->getBeginLoc(), diag::err_64_bit_builtin_32_bit_tgt) << TheCall->getSourceRange(); + // Common BCD type-validation helpers + // Emit diagnostics and retu

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Aditi Medhane via cfe-commits
@@ -104,14 +104,81 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI, return Diag(TheCall->getBeginLoc(), diag::err_64_bit_builtin_32_bit_tgt) << TheCall->getSourceRange(); + // Common BCD type-validation helpers + // Emit diagnostics and retu

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Aditi Medhane via cfe-commits
https://github.com/AditiRM updated https://github.com/llvm/llvm-project/pull/154715 >From 20acfd4109a453060f3678e536234de94012f19c Mon Sep 17 00:00:00 2001 From: AditiRM Date: Thu, 21 Aug 2025 09:40:59 + Subject: [PATCH 01/24] Implement frontend for bcd builtins --- clang/include/clang/Ba

[clang] [llvm] [X86] EmitX86BuiltinExpr - attempt to convert SSE41/AVX1 roundps/d/ss/sd builtins to regular rounding modes (PR #171227)

2025-12-09 Thread Phoebe Wang via cfe-commits
phoebewang wrote: Commit message should be updated. https://github.com/llvm/llvm-project/pull/171227 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] EmitX86BuiltinExpr - attempt to convert SSE41/AVX1 roundps/d/ss/sd builtins to regular rounding modes (PR #171227)

2025-12-09 Thread Phoebe Wang via cfe-commits
@@ -75,25 +75,29 @@ TEST_CONSTEXPR(match_m128(_mm_blendv_ps((__m128)(__v4sf){0.0f, 1.0f, 2.0f, 3.0f} __m128d test_mm_ceil_pd(__m128d x) { // CHECK-LABEL: test_mm_ceil_pd - // CHECK: call {{.*}}<2 x double> @llvm.x86.sse41.round.pd(<2 x double> %{{.*}}, i32 2) + // CHECK

[clang] [clang] Implement __builtin_stdc_rotate_left, __builtin_stdc_rotate_right (PR #160259)

2025-12-09 Thread NagaChaitanya Vellanki via cfe-commits
https://github.com/chaitanyav updated https://github.com/llvm/llvm-project/pull/160259 >From cfbcaa736d2d273d5db22001868c830292ff3987 Mon Sep 17 00:00:00 2001 From: NagaChaitanya Vellanki Date: Tue, 23 Sep 2025 02:17:49 -0700 Subject: [PATCH 1/9] [clang] Implement __builtin_stdc_rotate_left and

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Tony Varghese via cfe-commits
https://github.com/tonykuttai edited https://github.com/llvm/llvm-project/pull/154715 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Tony Varghese via cfe-commits
@@ -36,5 +36,106 @@ entry: ret <16 x i8> %0 } +define dso_local <16 x i8> @test_bcdshift_imm0(<16 x i8> noundef %a, i32 %b) { tonykuttai wrote: I think this test file have lot of these. https://github.com/llvm/llvm-project/pull/154715 _

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Tony Varghese via cfe-commits
@@ -104,14 +104,81 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI, return Diag(TheCall->getBeginLoc(), diag::err_64_bit_builtin_32_bit_tgt) << TheCall->getSourceRange(); + // Common BCD type-validation helpers + // Emit diagnostics and retu

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Tony Varghese via cfe-commits
@@ -36,5 +36,106 @@ entry: ret <16 x i8> %0 } +define dso_local <16 x i8> @test_bcdshift_imm0(<16 x i8> noundef %a, i32 %b) { tonykuttai wrote: nit: clean up `dso_local` and `noundef`, Its not required. https://github.com/llvm/llvm-project/pull/154715

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Tony Varghese via cfe-commits
@@ -104,14 +104,81 @@ bool SemaPPC::CheckPPCBuiltinFunctionCall(const TargetInfo &TI, return Diag(TheCall->getBeginLoc(), diag::err_64_bit_builtin_32_bit_tgt) << TheCall->getSourceRange(); + // Common BCD type-validation helpers + // Emit diagnostics and retu

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Tony Varghese via cfe-commits
https://github.com/tonykuttai requested changes to this pull request. LGTM with nots. https://github.com/llvm/llvm-project/pull/154715 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Tony Varghese via cfe-commits
https://github.com/tonykuttai edited https://github.com/llvm/llvm-project/pull/154715 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Add Support for BCDSHIFT, BCDSHIFTR, BCDTRUNC, BCDUTRUNC, and BCDUSHIFT instruction support (PR #154715)

2025-12-09 Thread Aditi Medhane via cfe-commits
https://github.com/AditiRM edited https://github.com/llvm/llvm-project/pull/154715 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [LFI] Introduce AArch64 LFI Target (PR #167061)

2025-12-09 Thread Dmitry Vyukov via cfe-commits
https://github.com/dvyukov approved this pull request. https://github.com/llvm/llvm-project/pull/167061 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [UBSAN] add null and alignment checks for aggregates (PR #164548)

2025-12-09 Thread VASU SHARMA via cfe-commits
@@ -0,0 +1,134 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=alignment,null \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-UBSAN +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s -o - \ +// RUN: | FileCheck %s --check-prefix=CHECK-NO-UB

[clang] [compiler-rt] [UBSAN] add null and alignment checks for aggregates (PR #164548)

2025-12-09 Thread VASU SHARMA via cfe-commits
@@ -0,0 +1,134 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=alignment,null \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-UBSAN +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s -o - \ +// RUN: | FileCheck %s --check-prefix=CHECK-NO-UB

[clang] [compiler-rt] [UBSAN] add null and alignment checks for aggregates (PR #164548)

2025-12-09 Thread VASU SHARMA via cfe-commits
@@ -0,0 +1,134 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=alignment,null \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-UBSAN +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s -o - \ +// RUN: | FileCheck %s --check-prefix=CHECK-NO-UB

[clang] [compiler-rt] [UBSAN] add null and alignment checks for aggregates (PR #164548)

2025-12-09 Thread VASU SHARMA via cfe-commits
@@ -0,0 +1,134 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=alignment,null \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-UBSAN +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s -o - \ +// RUN: | FileCheck %s --check-prefix=CHECK-NO-UB

[clang] [compiler-rt] [UBSAN] add null and alignment checks for aggregates (PR #164548)

2025-12-09 Thread VASU SHARMA via cfe-commits
@@ -0,0 +1,134 @@ +// RUN: %clang_cc1 -triple x86_64-linux-gnu -fsanitize=alignment,null \ +// RUN: -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK-UBSAN +// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm %s -o - \ +// RUN: | FileCheck %s --check-prefix=CHECK-NO-UB

[clang] [clang] Implement gcc_struct attribute on Itanium targets (PR #71148)

2025-12-09 Thread Fangrui Song via cfe-commits
Martin =?utf-8?q?Storsj=C3=B6?= Message-ID: In-Reply-To: https://github.com/MaskRay commented: Remove my "Request changes". https://github.com/llvm/llvm-project/pull/71148 ___ cfe-commits mailing list [email protected] https://lists.llvm.or

[clang] [clang][ExprConstant] Reject integral casts of addr-label-diffs... (PR #171437)

2025-12-09 Thread Timm Baeder via cfe-commits
tbaederr wrote: > What's the benefit of hardcoding "32" here? Does it help simplify the > interpreter implementation somehow? I hardcoded 32 because you said "I don't think there's any reason anyone would want to go narrower than 32 bits," in https://github.com/llvm/llvm-project/issues/136135

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
zeyi2 wrote: I think instead of adding a new test file, we can just move the original test here. You can see this [PR](https://github.com/llvm/llvm-project/pull/171058) as a reference. https://github.com/llvm/llvm-project/pull/171565

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
https://github.com/zeyi2 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/171565 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
@@ -6,12 +6,12 @@ // //===--===// -#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_FUCHSIA_MULTIPLEINHERITANCECHECK_H -#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_FUCHSIA_MULTIPLEINHERITANCECHECK_H +#ifndef LLVM_CLAN

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
@@ -86,6 +87,8 @@ class MiscModule : public ClangTidyModule { "misc-use-anonymous-namespace"); CheckFactories.registerCheck( "misc-use-internal-linkage"); +CheckFactories.registerCheck( EugeneZelenko wrote: Please keep alphabetical orde

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
@@ -27,6 +27,7 @@ add_clang_library(clangTidyMiscModule STATIC MiscTidyModule.cpp MisleadingBidirectionalCheck.cpp MisleadingIdentifierCheck.cpp + MultipleInheritanceCheck.cpp MisplacedConstCheck.cpp EugeneZelenko wrote: ```suggestion MisplacedCons

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
@@ -17,6 +17,7 @@ #include "IncludeCleanerCheck.h" #include "MisleadingBidirectionalCheck.h" #include "MisleadingIdentifierCheck.h" +#include "MultipleInheritanceCheck.h" #include "MisplacedConstCheck.h" EugeneZelenko wrote: ```suggestion #include "MisplacedC

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
https://github.com/EugeneZelenko commented: Documentation was not moved and Release Notes entry is missing. https://github.com/llvm/llvm-project/pull/171565 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
https://github.com/EugeneZelenko edited https://github.com/llvm/llvm-project/pull/171565 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [llvm] [Support][JSON] Use `std::map` for object storage (PR #171230)

2025-12-09 Thread Zixu Wang via cfe-commits
@@ -94,9 +94,9 @@ class Value; template Value toJSON(const std::optional &Opt); /// An Object is a JSON object, which maps strings to heterogenous JSON values. -/// It simulates DenseMap. ObjectKey is a maybe-owned string. +/// ObjectKey is a maybe-owned string. class Object

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code linter, clang-tidy found issues in your code. :warning: You can test this locally with the following command: ```bash git diff -U0 origin/main...HEAD -- clang-tools-extra/clang-tidy/fuchsia/FuchsiaTidyModule.cpp clang-tools-extra/clang-ti

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang-tools-extra/test/clang-tidy/checkers/mis

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Bala_Bhuvan_Varma (Bhuvan1527) Changes Resolves: [#171136](https://github.com/llvm/llvm-project/issues/171136) Referred the issue tagged in the issue mentioned. --- Full diff: https://github.com/llvm/llvm-project/pull/171565.

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Bala_Bhuvan_Varma (Bhuvan1527) Changes Resolves: [#171136](https://github.com/llvm/llvm-project/issues/171136) Referred the issue tagged in the issue mentioned. --- Full diff: https://github.com/llvm/llvm-project/pull/171565.diff

[clang-tools-extra] [clang-tidy] Moved Multiple Inheritence check from fuchsia to misc module (PR #171565)

2025-12-09 Thread via cfe-commits
https://github.com/Bhuvan1527 created https://github.com/llvm/llvm-project/pull/171565 Resolves: [#171136](https://github.com/llvm/llvm-project/issues/171136) Referred the issue tagged in the issue mentioned. >From dddbc6294fa772d0f90d29a73933b1ec5d5654fb Mon Sep 17 00:00:00 2001 From: bhuvan

[clang] [llvm] [HLSL][Matrix] Support row and column indexing modes for MatrixSubscriptExpr (PR #171564)

2025-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Farzon Lotfi (farzonl) Changes fixes #167617 In DXC HLSL supports different indexing modes via codegen for its equivalent of the MatrixSubscriptExpr when the /Zpr and /Zpc flags are used see: https://godbolt.org/z/bz5Y5WG36. This change

[clang] [llvm] [HLSL][Matrix] Support row and column indexing modes for MatrixSubscriptExpr (PR #171564)

2025-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Farzon Lotfi (farzonl) Changes fixes #167617 In DXC HLSL supports different indexing modes via codegen for its equivalent of the MatrixSubscriptExpr when the /Zpr and /Zpc flags are used see: https://godbolt.org/z/bz5Y5WG36. Thi

[clang] [llvm] [HLSL][Matrix] Support row and column indexing modes for MatrixSubscriptExpr (PR #171564)

2025-12-09 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/171564 fixes #167617 In DXC HLSL supports different indexing modes via codegen for its equivalent of the MatrixSubscriptExpr when the /Zpr and /Zpc flags are used see: https://godbolt.org/z/bz5Y5WG36. This change mo

[clang] [AMDGPU] Removal of language sensitive option for _Float16 and half('e') handling (PR #170443)

2025-12-09 Thread Rana Pratap Reddy via cfe-commits
https://github.com/ranapratap55 updated https://github.com/llvm/llvm-project/pull/170443 >From 84e4a4c5b2fa1bbfed9484bdf6e6043f5d0c9a93 Mon Sep 17 00:00:00 2001 From: ranapratap55 Date: Wed, 3 Dec 2025 14:48:30 +0530 Subject: [PATCH] [AMDGPU] Removal of language sensitive option for _Float16 a

[clang] [clang][bytecode] Check types when loading values (PR #165385)

2025-12-09 Thread Timm Baeder via cfe-commits
@@ -101,6 +101,7 @@ inline constexpr bool isSignedType(PrimType T) { enum class CastKind : uint8_t { Reinterpret, + ReinterpretLike, tbaederr wrote: It means "cast that performs the conversions of a reinterpret_cast" but isn't one explicitly. https://git

[clang] [NFC][HIP] Disable device-side kernel launches for HIP (PR #171043)

2025-12-09 Thread via cfe-commits
darkbuck wrote: > > > > We added sema check @ > > > > https://github.com/llvm/llvm-project/blob/8378a6fa4f5c83298fb0b5e240bb7f254f7b1137/clang/lib/Sema/SemaCUDA.cpp#L83 > > > > > > > > to generate error message on HIP based on Sam's request as HIP > > > > currently doesnt' support device-side

[clang] [clang-tools-extra] [llvm] [Support][JSON] Use `std::map` for object storage (PR #171230)

2025-12-09 Thread Volodymyr Sapsai via cfe-commits
@@ -94,9 +94,9 @@ class Value; template Value toJSON(const std::optional &Opt); /// An Object is a JSON object, which maps strings to heterogenous JSON values. -/// It simulates DenseMap. ObjectKey is a maybe-owned string. +/// ObjectKey is a maybe-owned string. class Object

[clang-tools-extra] [clang-tidy] Make `readability-redundant-control-flow` not suggest deleting unrelated lines (PR #171287)

2025-12-09 Thread via cfe-commits
https://github.com/zeyi2 approved this pull request. https://github.com/llvm/llvm-project/pull/171287 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Make ignored files unformatted instead of empty. (PR #170416)

2025-12-09 Thread via cfe-commits
https://github.com/owenca requested changes to this pull request. cc @mydeveloperday https://github.com/llvm/llvm-project/pull/170416 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Make ignored files unformatted instead of empty. (PR #170416)

2025-12-09 Thread via cfe-commits
@@ -701,9 +711,8 @@ int main(int argc, const char **argv) { } if (FileNames.empty()) { -if (isIgnored(AssumeFileName)) - return 0; -return clang::format::format("-", FailOnIncompleteFormat); +return clang::format::format("-", FailOnIncompleteFormat, +

[clang] [clang-format] Handle templates in qualified typenames (PR #143194)

2025-12-09 Thread via cfe-commits
github-actions[bot] wrote: @bdunkin Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [clang-format] Handle templates in qualified typenames (PR #143194)

2025-12-09 Thread via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/143194 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0bac8f1 - [clang-format] Handle templates in qualified typenames (#143194)

2025-12-09 Thread via cfe-commits
Author: Ben Dunkin Date: 2025-12-09T20:47:38-08:00 New Revision: 0bac8f1729512a0b392908d6a57a00b0387a855f URL: https://github.com/llvm/llvm-project/commit/0bac8f1729512a0b392908d6a57a00b0387a855f DIFF: https://github.com/llvm/llvm-project/commit/0bac8f1729512a0b392908d6a57a00b0387a855f.diff LO

[clang] [clang] Implement __builtin_stdc_rotate_left, __builtin_stdc_rotate_right (PR #160259)

2025-12-09 Thread NagaChaitanya Vellanki via cfe-commits
chaitanyav wrote: am still simplifying the code. https://github.com/llvm/llvm-project/pull/160259 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tooling] Fix misleading progress report when files have multiple compile commands (PR #169640)

2025-12-09 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/169640 >From 0bcc0a061e4c03f85a2f7481591e97779785f731 Mon Sep 17 00:00:00 2001 From: mtx Date: Mon, 24 Nov 2025 10:14:58 +0800 Subject: [PATCH 1/7] [Tooling] Fix misleading progress report when files have multiple compi

[clang] [llvm] [clang][NVPTX] Add support for mixed-precision FP arithmetic (PR #168359)

2025-12-09 Thread Alex MacLean via cfe-commits
https://github.com/AlexMaclean approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/168359 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add --project-root to clangd (PR #155905)

2025-12-09 Thread Aiden Grossman via cfe-commits
boomanaiden154 wrote: Seeing the same thing with ASan at -O1: ``` <<< initialize: {} <-- initialize(0) third_party/llvm/llvm-project/clang-tools-extra/clangd/ClangdLSPServer.cpp:557:14: runtime error: load of value 112, which is not a valid value for type 'bool' ``` Only `--gtest_filter="LSPTes

[clang-tools-extra] 01c4eb5 - Revert "[clangd] Add a (currently hidden) --strong-workspace-mode flag (#155905)"

2025-12-09 Thread Aiden Grossman via cfe-commits
Author: Aiden Grossman Date: 2025-12-10T03:08:52Z New Revision: 01c4eb5b9b0690692638e8be353e1c6cf2da5d9a URL: https://github.com/llvm/llvm-project/commit/01c4eb5b9b0690692638e8be353e1c6cf2da5d9a DIFF: https://github.com/llvm/llvm-project/commit/01c4eb5b9b0690692638e8be353e1c6cf2da5d9a.diff LOG

[clang-tools-extra] [clang-tidy] Make `readability-redundant-control-flow` not suggest deleting unrelated lines (PR #171287)

2025-12-09 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/171287 >From ef8d31e5b88f03c2703a00f8801e525b6c30e825 Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Tue, 9 Dec 2025 00:21:21 -0800 Subject: [PATCH 1/2] [clang-tidy] Make `readability-redundant-control-flow`

[clang] [clang][tooling] Fix `getFileRange` false negative (PR #171555)

2025-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Eric Li (tJener) Changes When an expression is in a single macro argument but also contains a macro, `getFileRange` would incorrectly reject that expression, concluding that it came from two different macro arguments because they came fro

[clang] [clang][tooling] Fix `getFileRange` false negative (PR #171555)

2025-12-09 Thread Eric Li via cfe-commits
https://github.com/tJener created https://github.com/llvm/llvm-project/pull/171555 When an expression is in a single macro argument but also contains a macro, `getFileRange` would incorrectly reject that expression, concluding that it came from two different macro arguments because they came f

[clang] [clang][ExprConstant] Reject integral casts of addr-label-diffs... (PR #171437)

2025-12-09 Thread Richard Smith via cfe-commits
@@ -18606,12 +18606,15 @@ bool IntExprEvaluator::VisitCastExpr(const CastExpr *E) { if (!Result.isInt()) { // Allow casts of address-of-label differences if they are no-ops - // or narrowing. (The narrowing case isn't actually guaranteed to + // or narrow

[clang] [llvm] [WinEH] Fix try scopes leaking to caller on inline (PR #167176)

2025-12-09 Thread Eli Friedman via cfe-commits
@@ -635,14 +635,30 @@ void CodeGenFunction::EmitCXXTryStmt(const CXXTryStmt &S) { ExitCXXTryStmt(S); } +struct TerminateTryScope final : EHScopeStack::Cleanup { + llvm::BasicBlock *InvokeDest; + + TerminateTryScope(llvm::BasicBlock *BB) : InvokeDest(BB) {} + + void Emi

[clang] [llvm] [WinEH] Fix try scopes leaking to caller on inline (PR #167176)

2025-12-09 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,62 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 6 +// RUN: %clang_cc1 -O3 -triple x86_64-windows -fasync-exceptions -fcxx-exceptions -fexceptions -fms-extensions -x c++ -Wno-implicit-function-declaration -emit-

[clang] [llvm] [WinEH] Fix try scopes leaking to caller on inline (PR #167176)

2025-12-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: Does this fix #62723? https://github.com/llvm/llvm-project/pull/167176 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WinEH] Fix try scopes leaking to caller on inline (PR #167176)

2025-12-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/167176 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen][ObjC] Initial WebAssembly Support for GNUstep (PR #169043)

2025-12-09 Thread Derek Schuff via cfe-commits
dschuff wrote: @sbc100 I also re-read First Issue in OP, and it looks like (mangling aside) the underlying problem is that symbols are being exported that weren't intended to be in the first place. It looks like maybe OP is running into the issue of Emscripten's hack of EMSCRIPTEN_KEEPALIVE ->

[clang] [clang][ExprConstant] Reject integral casts of addr-label-diffs... (PR #171437)

2025-12-09 Thread Eli Friedman via cfe-commits
@@ -18606,12 +18606,15 @@ bool IntExprEvaluator::VisitCastExpr(const CastExpr *E) { if (!Result.isInt()) { // Allow casts of address-of-label differences if they are no-ops - // or narrowing. (The narrowing case isn't actually guaranteed to + // or narrow

[clang] [clang] Limit lifetimes of temporaries to the full expression (PR #170517)

2025-12-09 Thread Nathan Chancellor via cfe-commits
nathanchance wrote: I saw an assertion failure when building `fs/bcachefs` in the Linux kernel's 6.12 and 6.17 branches (may be the same root cause but it looks different so just mentioning it anyways). ``` clang: /mnt/nvme/tmp/cvise.ssStCqfBAx/src/clang/lib/CodeGen/CGCleanup.cpp:708: void cl

[clang] [clang][DependencyScanning] Fix spellling mistake for DiagnosticsEngineWithDiagOpts (PR #171535)

2025-12-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions h,cpp -- clang/include/clang/DependencyScanning/Depende

[clang] [clang][DependencyScanning] Fix spellling mistake for DiagnosticsEngineWithDiagOpts (PR #171535)

2025-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Naveen Seth Hanig (naveen-seth) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/171535.diff 3 Files Affected: - (modified) clang/include/clang/DependencyScanning/DependencyScannerImpl.h (+3-3) - (modified) clang/lib/

[clang] [clang][DependencyScanning] Fix spellling mistake for DiagnosticsEngineWithDiagOpts (PR #171535)

2025-12-09 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth created https://github.com/llvm/llvm-project/pull/171535 None >From 1e86d044f390cadeae2bbbc717ce7e7b2f9d4bd8 Mon Sep 17 00:00:00 2001 From: Naveen Seth Hanig Date: Wed, 10 Dec 2025 00:37:40 +0100 Subject: [PATCH] [clang][DependencyScanning] Fix spellling mistake

[clang] [clang] Implement -fstrict-bool (PR #160790)

2025-12-09 Thread Eli Friedman via cfe-commits
=?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier , =?utf-8?q?Félix?= Cloutier Message-ID: In-Reply-To: efriedma-quic wrote: None of this is relevant to packed bool vectors, yes. But HLSL has unpacked bool vectors. https://github.com/llvm/llvm-project/pull

[clang] [llvm] RFC: Implementing new mechanism for hard register operands to inline asm as a constraint. (PR #85846)

2025-12-09 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: An example that might be helpful (using x86 asm): ``` int shift(int x, char amt) { asm("shll %0, %1" : "+r"(x) : "{cl}i"(amt)); return x; } int a(int x) { return shift(x, 1); } ``` Here, you want one of two choices: either an immediate, or the register "cl". I

[clang] [ExtractAPI] Format typedef params correctly (PR #171516)

2025-12-09 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#171522 https://github.com/llvm/llvm-project/pull/171516 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add the support for recognizing WTF::move like std::move (PR #170820)

2025-12-09 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/170820 >From 289c8175465f20bdd7d701432f923d624259b505 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Fri, 5 Dec 2025 01:03:17 -0800 Subject: [PATCH 1/3] Add the support for recognizing WTF::move like std::move This P

[clang] [flang] [llvm] [openmp] [Flang] Move builtin .mod generation into runtimes (Reapply #137828) (PR #169638)

2025-12-09 Thread Michael Kruse via cfe-commits
Meinersbur wrote: This indicates that `LLVM_TARGET_TRIPLE` is not defined, which seems quite unusual. How does the runtime no know what target it is building for? You were included as reviewer in the original PR #137828 without participarting in it. LLVM's workflow explicitly mentions [post-co

[clang] Add the support for recognizing WTF::move like std::move (PR #170820)

2025-12-09 Thread Ryosuke Niwa via cfe-commits
@@ -185,6 +185,15 @@ bool isCtorOfSafePtr(const clang::FunctionDecl *F) { isCtorOfRetainPtrOrOSPtr(F); } +bool isStdOrWTFMove(const clang::FunctionDecl *F) { + auto FnName = safeGetName(F); + auto *Namespace = F->getParent(); + if (!Namespace) +return false; +

[clang] Add the support for recognizing WTF::move like std::move (PR #170820)

2025-12-09 Thread Balázs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/170820 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add the support for recognizing WTF::move like std::move (PR #170820)

2025-12-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions h,cpp -- clang/lib/StaticAnalyzer/Checkers/WebKit/ASTUt

[clang-tools-extra] [clang-tidy] Add AnalyzeParameters option to misc-const-correctness (PR #171215)

2025-12-09 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/171215 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Make sure libunwind test dependencies are installed before running tests (PR #171474)

2025-12-09 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/171474 >From be09c5985dfff239132e08951c34c048987617c2 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 9 Dec 2025 11:04:36 -0500 Subject: [PATCH 1/6] [libunwind] Make sure libunwind test dependencies are install

[clang] Add the support for recognizing WTF::move like std::move (PR #170820)

2025-12-09 Thread Balázs Benics via cfe-commits
@@ -185,6 +185,15 @@ bool isCtorOfSafePtr(const clang::FunctionDecl *F) { isCtorOfRetainPtrOrOSPtr(F); } +bool isStdOrWTFMove(const clang::FunctionDecl *F) { + auto FnName = safeGetName(F); + auto *Namespace = F->getParent(); + if (!Namespace) +return false; +

[clang-tools-extra] [clang-tidy] Add AnalyzeParameters option to misc-const-correctness (PR #171215)

2025-12-09 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/171215 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add AnalyzeParameters option to misc-const-correctness (PR #171215)

2025-12-09 Thread Baranov Victor via cfe-commits
@@ -135,20 +147,83 @@ void ConstCorrectnessCheck::registerMatchers(MatchFinder *Finder) { .bind("function-decl"); Finder->addMatcher(FunctionScope, this); + + if (AnalyzeParameters) { +const auto ParamMatcher = +parmVarDecl(unless(CommonExcludeTypes),

[clang] [CIR] Add support for thread-local storage (TLS) (PR #168662)

2025-12-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. This looks good, but it needs to be rebased. https://github.com/llvm/llvm-project/pull/168662 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [llvm] Added partial support for compiling C++20 modules and header-units without scanning. (PR #147682)

2025-12-09 Thread Chris B via cfe-commits
@@ -0,0 +1,182 @@ + llvm-beanz wrote: Code contributed to LLVM should be made available under the LLVM license whenever possible (see the [developer policy](https://llvm.org/docs/DeveloperPolicy.html#copyright-license-and-patents). If you're unwilling to contr

[clang-tools-extra] [clang-tidy] Rename 'google-build-namespaces' check to 'misc-anonymous-namespace-in-header' and keep initial as alias. (PR #170986)

2025-12-09 Thread Baranov Victor via cfe-commits
=?utf-8?q?Ond=C5=99ej_=C5=A0torc?= ,Ondrej Storc ,Ondrej Storc ,Ondrej Storc ,Ondrej Storc Message-ID: In-Reply-To: Cj09PT09PT09PT09PT09PT0KQEAgLTEsMTMgKzEsMTQgQEAKIC4uIHRpdGxlOjogY2xhbmctdGlk eSAtIGdvb2dsZS1idWlsZC1uYW1lc3BhY2VzCisuLiBtZXRhOjoKKyAgIDpodHRwLWVxdWl2PXJl ZnJlc2g6IDU7VVJMPS4uL21p

[clang-tools-extra] [clang-tidy] Rename 'google-build-namespaces' check to 'misc-anonymous-namespace-in-header' and keep initial as alias. (PR #170986)

2025-12-09 Thread Baranov Victor via cfe-commits
___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Tooling] Fix misleading progress report when files have multiple compile commands (PR #169640)

2025-12-09 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/169640 >From 0bcc0a061e4c03f85a2f7481591e97779785f731 Mon Sep 17 00:00:00 2001 From: mtx Date: Mon, 24 Nov 2025 10:14:58 +0800 Subject: [PATCH 1/7] [Tooling] Fix misleading progress report when files have multiple compi

[clang] [-Wunsafe-buffer-usage] Ignore consteval functions (PR #171503)

2025-12-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis @llvm/pr-subscribers-clang Author: Max (mxms0) Changes We dont need to visit or warn on consteval functions as they can't have UB. --- Full diff: https://github.com/llvm/llvm-project/pull/171503.diff 2 Files Affected: - (modified) clan

[clang] [-Wunsafe-buffer-usage] Ignore consteval functions (PR #171503)

2025-12-09 Thread via cfe-commits
mxms0 wrote: cc @jkorous-apple https://github.com/llvm/llvm-project/pull/171503 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [-Wunsafe-buffer-usage] Ignore consteval functions (PR #171503)

2025-12-09 Thread via cfe-commits
https://github.com/mxms0 created https://github.com/llvm/llvm-project/pull/171503 We dont need to visit or warn on consteval functions as they can't have UB. >From 6ca667130537476bd4268e15b0f899446f30b6e8 Mon Sep 17 00:00:00 2001 From: mxms Date: Tue, 9 Dec 2025 20:54:14 + Subject: [PATCH]

[clang] 87bf5ee - [CIR] Add basic support for data member pointers (#170939)

2025-12-09 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-12-09T12:55:47-08:00 New Revision: 87bf5ee23863bc0b467ee44b2184b2c134a98464 URL: https://github.com/llvm/llvm-project/commit/87bf5ee23863bc0b467ee44b2184b2c134a98464 DIFF: https://github.com/llvm/llvm-project/commit/87bf5ee23863bc0b467ee44b2184b2c134a98464.diff L

[clang] [CIR] Add basic support for data member pointers (PR #170939)

2025-12-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/170939 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver][SPIR-V] Allow linking IR using llvm-link (PR #169572)

2025-12-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex updated https://github.com/llvm/llvm-project/pull/169572 >From 89b0fe0a8cc57d27c69d18927c1ae10833d82a29 Mon Sep 17 00:00:00 2001 From: Nick Sarnie Date: Tue, 25 Nov 2025 13:23:36 -0800 Subject: [PATCH 1/4] [clang][Driver][SPIR-V] Allow linking IR using llvm-link Signe

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore a lambda which gets called immediately (PR #162977)

2025-12-09 Thread Balázs Benics via cfe-commits
steakhal wrote: My bad for the sloppy reviews. Ill admit, I wanted to just get through them. https://github.com/llvm/llvm-project/pull/162977 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [flang] [llvm] [openmp] [Flang] Move builtin .mod generation into runtimes (Reapply #137828) (PR #169638)

2025-12-09 Thread Petr Hosek via cfe-commits
petrhosek wrote: This broke the runtimes build on Windows when targeting a non-Windows target with the following error: ``` CMake Error at C:/b/s/w/ir/x/w/llvm-llvm-project/cmake/Modules/GetToolchainDirs.cmake:76 (string): string sub-command REPLACE requires at least four arguments. Call Sta

  1   2   3   4   5   6   >