@@ -1822,6 +1821,37 @@ TEST(DesignatorHints, NoCrash) {
ExpectedHint{".b=", "b"});
}
+TEST(DesignatorHints, BasicParenInit) {
+ assertDesignatorHints(R"cpp(
+struct S {
+ int x;
+ int y;
+ int z;
+};
+S s ($x[[1]], $y[[2+2]
@@ -699,6 +699,26 @@ class InlayHintVisitor : public
RecursiveASTVisitor {
return InstantiatedFunction->getParamDecl(ParamIdx);
}
+ bool VisitCXXParenListInitExpr(CXXParenListInitExpr *E) {
+// TODO: Lang check needed?
+if (!Cfg.InlayHints.Designators &&
+
@@ -699,6 +699,26 @@ class InlayHintVisitor : public
RecursiveASTVisitor {
return InstantiatedFunction->getParamDecl(ParamIdx);
}
+ bool VisitCXXParenListInitExpr(CXXParenListInitExpr *E) {
+// TODO: Lang check needed?
+if (!Cfg.InlayHints.Designators &&
+
https://github.com/MythreyaK edited
https://github.com/llvm/llvm-project/pull/170642
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1822,6 +1821,37 @@ TEST(DesignatorHints, NoCrash) {
ExpectedHint{".b=", "b"});
}
+TEST(DesignatorHints, BasicParenInit) {
+ assertDesignatorHints(R"cpp(
+struct S {
+ int x;
+ int y;
+ int z;
+};
+S s ($x[[1]], $y[[2+2]
https://github.com/MythreyaK updated
https://github.com/llvm/llvm-project/pull/170642
>From 64e2e838413b55262ab5cb925b80c69968b3c844 Mon Sep 17 00:00:00 2001
From: Mythreya
Date: Wed, 3 Dec 2025 21:41:40 -0800
Subject: [PATCH 1/3] Enable designator hints test
---
.../clangd/unittests/InlayHin
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: owenca (owenca)
Changes
Fixes #170573
---
Full diff: https://github.com/llvm/llvm-project/pull/170969.diff
2 Files Affected:
- (modified) clang/lib/Format/UnwrappedLineParser.cpp (+4-4)
- (modified) clang/unittests/Format/TokenA
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/170969
Fixes #170573
>From d0e38b2c3201dab9c66c8df2527d5872347a9ed7 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 5 Dec 2025 22:46:50 -0800
Subject: [PATCH] [clang-format] Fix a regression in annotating star befor
https://github.com/Camsyn closed
https://github.com/llvm/llvm-project/pull/165700
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kunqiu Chen
Date: 2025-12-06T14:44:58+08:00
New Revision: fa2eabd7706d2f47064c980b456d3a255e9ea3f3
URL:
https://github.com/llvm/llvm-project/commit/fa2eabd7706d2f47064c980b456d3a255e9ea3f3
DIFF:
https://github.com/llvm/llvm-project/commit/fa2eabd7706d2f47064c980b456d3a255e9ea3f3.diff
L
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/28] Add CIR sqrt builtin suppor
github-actions[bot] wrote:
# :penguin: Linux x64 Test Results
* 84967 tests passed
* 1147 tests skipped
* 3 tests failed
## Failed Tests
(click on a test name to see its output)
### Clang
Clang.CodeGen/ARM/build-attributes.c
```
Exit Code: 2
Command Output (stdout):
--
# RUN: at line 1
/ho
@@ -19156,6 +19168,42 @@ void HandleComplexComplexDiv(APFloat A, APFloat B,
APFloat C, APFloat D,
}
}
+APSInt NormalizeRotateAmount(const APSInt &Value, const APSInt &Amount) {
+ // Normalize shift amount to [0, BitWidth) range to match runtime behavior
+ APSInt NormAmt =
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/170272
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2025-12-06T06:37:45+01:00
New Revision: 8fe38c4c9c71c7a86ecdba476ee5bae4c02c0dfe
URL:
https://github.com/llvm/llvm-project/commit/8fe38c4c9c71c7a86ecdba476ee5bae4c02c0dfe
DIFF:
https://github.com/llvm/llvm-project/commit/8fe38c4c9c71c7a86ecdba476ee5bae4c02c0dfe.diff
L
https://github.com/paperchalice updated
https://github.com/llvm/llvm-project/pull/161106
>From d6ff975f03defe14c38b1df8e3c860481945bae5 Mon Sep 17 00:00:00 2001
From: PaperChalice
Date: Sat, 27 Sep 2025 17:30:14 +0800
Subject: [PATCH 1/2] [ARM][clang] Add some build attributes support
---
cla
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building
`clang` at step 6 "test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/174/builds/28510
Her
https://github.com/chandraghale closed
https://github.com/llvm/llvm-project/pull/169622
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Sairudra More
Date: 2025-12-06T10:30:19+05:30
New Revision: 9e9e64af48bce45c8f569e02d568ec58a855aadb
URL:
https://github.com/llvm/llvm-project/commit/9e9e64af48bce45c8f569e02d568ec58a855aadb
DIFF:
https://github.com/llvm/llvm-project/commit/9e9e64af48bce45c8f569e02d568ec58a855aadb.diff
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/170217
>From 59b01f66e63062919dfde3e318dbeb8d11e8ef7d Mon Sep 17 00:00:00 2001
From: Adam
Date: Mon, 1 Dec 2025 17:14:00 -0500
Subject: [PATCH 1/4] Replace interp__builtin_blend with
interp__builtin_ia32_shuffle_gene
https://github.com/DeinAlptraum approved this pull request.
LGTM!
@Endilll if you have no further comments, I would merge this
https://github.com/llvm/llvm-project/pull/170201
___
cfe-commits mailing list
[email protected]
https://lists.llvm.
https://github.com/wizardengineer updated
https://github.com/llvm/llvm-project/pull/169081
>From d015af2cb7ca61a0445a78781b31178e3f6fa9f2 Mon Sep 17 00:00:00 2001
From: Jasmine Tang
Date: Thu, 20 Nov 2025 05:23:58 -0800
Subject: [PATCH 1/7] Skeleton
---
.../include/clang/CIR/Sema/CIRAnalysisK
@@ -315,43 +315,53 @@ void
SemaSYCL::CheckSYCLEntryPointFunctionDecl(FunctionDecl *FD) {
}
}
+ if (isa(FD)) {
erichkeane wrote:
What is happening in this file change? What relationship does this have to the
kernel-launch support?
https://github.c
@@ -17,6 +17,10 @@ module M2 { header "m2.h" }
#--- common.h
template struct KN;
+// A generic kernel launch function.
+template
+void sycl_kernel_launch(const char *, Ts...) {}
erichkeane wrote:
It would have been lovely for the purposes of actually reviewin
@@ -315,43 +315,53 @@ void
SemaSYCL::CheckSYCLEntryPointFunctionDecl(FunctionDecl *FD) {
}
}
+ if (isa(FD)) {
+Diag(SKEPAttr->getLocation(), diag::err_sycl_entry_point_invalid)
+<< SKEPAttr << /*constructor*/ 3;
+SKEPAttr->setInvalidAttr();
+ }
+ if (
@@ -28,6 +28,9 @@
// A unique kernel name type is required for each declared kernel entry point.
template struct KN;
+template
+void sycl_kernel_launch(const char *, Ts... Args) {}
+
erichkeane wrote:
What is this change doing here?
https://github.com/llvm/
@@ -0,0 +1,541 @@
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -std=c++17 -fsyntax-only
-fsycl-is-host -fcxx-exceptions -verify %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -std=c++17 -fsyntax-only
-fsycl-is-device -verify %s
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -std=
@@ -17,6 +17,21 @@
using namespace clang;
using namespace CodeGen;
+void CodeGenFunction::EmitSYCLKernelCallStmt(const SYCLKernelCallStmt &S) {
+ if (getLangOpts().SYCLIsDevice) {
+// A sycl_kernel_entry_point attributed function is unlikely to be emitted
+// during d
@@ -15,6 +15,10 @@
#--- pch.h
template struct KN;
+// A generic kernel launch function.
+template
+void sycl_kernel_launch(const char *, Ts...) {}
erichkeane wrote:
Or at least... do we intend the library to support these? Maybe we should have
an Inputs hea
@@ -898,6 +899,25 @@ static std::string convertCallArgsToString(Sema &S,
return Result;
}
+static std::string
+printCallArgsValueCategoryAndType(Sema &S, llvm::ArrayRef Args) {
+ std::string Result;
+ llvm::raw_string_ostream OS(Result);
+ llvm::ListSeparator Comma;
+ OS
https://github.com/wizardengineer updated
https://github.com/llvm/llvm-project/pull/169081
>From d015af2cb7ca61a0445a78781b31178e3f6fa9f2 Mon Sep 17 00:00:00 2001
From: Jasmine Tang
Date: Thu, 20 Nov 2025 05:23:58 -0800
Subject: [PATCH 1/7] Skeleton
---
.../include/clang/CIR/Sema/CIRAnalysisK
https://github.com/chaitanyav updated
https://github.com/llvm/llvm-project/pull/160259
>From 7cc0c703ca545443679d7902f7f661d5e6e365d4 Mon Sep 17 00:00:00 2001
From: NagaChaitanya Vellanki
Date: Tue, 23 Sep 2025 02:17:49 -0700
Subject: [PATCH 1/6] [clang] Implement __builtin_stdc_rotate_left and
https://github.com/cs25resch11005-bhuvan updated
https://github.com/llvm/llvm-project/pull/169582
>From 961bd15f0f06624450d755ff53cefcb47ae9432d Mon Sep 17 00:00:00 2001
From: bhuvan1527
Date: Wed, 26 Nov 2025 05:11:22 +0530
Subject: [PATCH 1/3] [CIR][CIRGen][Builtin][X86] Masked compress Intri
@@ -199,3 +199,36 @@ __m256i test_mm256_mask_i32gather_epi32(__m256i __v1_old,
__mmask8 __mask, __m25
// OGCG: @llvm.x86.avx512.mask.gather3siv8.si
return _mm256_mmask_i32gather_epi32(__v1_old, __mask, __index, __addr, 2);
}
+
+__m128d test_mm_mask_expand_pd(__m128d __W,
@@ -151,6 +151,17 @@ computeFullLaneShuffleMask(CIRGenFunction &cgf, const
mlir::Value vec,
outIndices.resize(numElts);
}
+static mlir::Value emitX86CompressExpand(CIRGenBuilderTy &builder,
+ mlir::Location loc, mlir::Value
source,
+
@@ -151,6 +151,17 @@ computeFullLaneShuffleMask(CIRGenFunction &cgf, const
mlir::Value vec,
outIndices.resize(numElts);
}
+static mlir::Value emitX86CompressExpand(CIRGenBuilderTy &builder,
+ mlir::Location loc, mlir::Value
source,
+
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/27] Add CIR sqrt builtin suppor
Priyanshu3820 wrote:
> This looks good except for the BOM issue.
removed now
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cs25resch11005-bhuvan updated
https://github.com/llvm/llvm-project/pull/169582
>From 961bd15f0f06624450d755ff53cefcb47ae9432d Mon Sep 17 00:00:00 2001
From: bhuvan1527
Date: Wed, 26 Nov 2025 05:11:22 +0530
Subject: [PATCH 1/3] [CIR][CIRGen][Builtin][X86] Masked compress Intri
https://github.com/Priyanshu3820 updated
https://github.com/llvm/llvm-project/pull/169310
>From 627bcb3bde64a780ed2b99267d97c9679f9c Mon Sep 17 00:00:00 2001
From: Priyanshu3820 <[email protected]>
Date: Wed, 26 Nov 2025 17:45:00 +0530
Subject: [PATCH 01/27] Add CIR sqrt builtin suppor
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/143194
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Katya Romanova
Date: 2025-12-05T18:56:48-08:00
New Revision: 72d5fe5ec4d400b1e9444d78f2022f486aa19af1
URL:
https://github.com/llvm/llvm-project/commit/72d5fe5ec4d400b1e9444d78f2022f486aa19af1
DIFF:
https://github.com/llvm/llvm-project/commit/72d5fe5ec4d400b1e9444d78f2022f486aa19af1.diff
https://github.com/romanova-ekaterina closed
https://github.com/llvm/llvm-project/pull/170507
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
romanova-ekaterina wrote:
Thank you so much for the review. I assume that I can commit now, since I
received LGTM before the minor corrections.
https://github.com/llvm/llvm-project/pull/170507
___
cfe-commits mailing list
[email protected]
ht
@@ -345,6 +418,27 @@ static __inline int __get_cpuid_count (unsigned int __leaf,
// builtin. Given __has_builtin does not detect builtins on aux triples, we
need
// to explicitly check for some offloading cases.
#if !defined(__NVPTX__) && !defined(__AMDGPU__) && !defined(__SPI
@@ -278,6 +278,23 @@
: "0"(__leaf), "2"(__count))
#endif
+/// Queries the processor to determine the highest supported \c CPUID leaf.
+///
+/// \headerfile
+///
+/// This intrinsic corresponds to the CPUID instruction.
+///
+/// \param __leaf
+///\a __leaf can b
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/170885
>From e4dd6308c4141fe86f0b8f9b2f4a39108c51c34c Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Fri, 5 Dec 2025 11:56:00 -0500
Subject: [PATCH 1/2] [HLSL][Matrix] Add support for ICK_HLSL_Matrix_Splat to
add s
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/153049
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/w2yehia edited
https://github.com/llvm/llvm-project/pull/153049
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeyi2 closed https://github.com/llvm/llvm-project/pull/168827
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -291,12 +291,47 @@ TEST(DynTypedMatcherTest,
ConstructWithTraversalKindSetsTK) {
}
TEST(DynTypedMatcherTest, ConstructWithTraversalKindOverridesNestedTK) {
zwuis wrote:
Two `withTraversalKind` seemed intended.
https://github.com/llvm/llvm-project/pull/17
adbox53 wrote:
Is there any further action needed from my side?
https://github.com/llvm/llvm-project/pull/170217
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/170953
>From e63525d4f71ba361031f501ec84b3bacafb29889 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 5 Dec 2025 13:56:44 -0800
Subject: [PATCH 1/4] [clang] Add missing support for traversal kind in
addMatcher ov
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/165078
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/166457
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Andy Kaylor
Date: 2025-12-05T17:27:47-08:00
New Revision: 6d8714b52375b3b7a7f269cd1ec4cc73baece38b
URL:
https://github.com/llvm/llvm-project/commit/6d8714b52375b3b7a7f269cd1ec4cc73baece38b
DIFF:
https://github.com/llvm/llvm-project/commit/6d8714b52375b3b7a7f269cd1ec4cc73baece38b.diff
L
@@ -161,28 +183,36 @@ class OffloadFile : public OwningBinary {
using TargetID = std::pair;
OffloadFile(std::unique_ptr Binary,
- std::unique_ptr Buffer)
- : OwningBinary(std::move(Binary), std::move(Buffer)) {}
+ std::shared_ptr SharedBuffer
@@ -204,59 +232,108 @@ OffloadBinary::create(MemoryBufferRef Buf) {
new OffloadBinary(Buf, TheHeader, TheEntry));
}
-SmallString<0> OffloadBinary::write(const OffloadingImage &OffloadingData) {
+Expected>
+OffloadBinary::createV2(MemoryBufferRef Buf) {
+ auto HeaderOrEr
jkorous-apple wrote:
Thank you all for great feedback!
I have unfortunately been distracted with other tasks this week but I am
working my way though all the comments.
https://github.com/llvm/llvm-project/pull/169131
___
cfe-commits mailing list
cfe-c
https://github.com/jkorous-apple edited
https://github.com/llvm/llvm-project/pull/169131
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Michael137 wrote:
> * This could probably get rid of the additional bool flags, and rely on
> PrintingPolicy entirely.
> * Instead of the `printAnonymousTagDecl` helper, we could probably implement
> a `print` method for TagDecls, which takes care of the named case, and for
> the unnamed case,
@@ -0,0 +1,47 @@
+//===- EntityName.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -121,6 +123,7 @@ struct PrintingPolicy {
/// \endcode
LLVM_PREFERRED_TYPE(bool)
unsigned SuppressTagKeyword : 1;
+ unsigned SuppressTagKeywordInAnonymousTagNames : 1;
Michael137 wrote:
Made it an enum in one of the latest commits. Bit awkward with th
@@ -4954,19 +4959,76 @@ void TagDecl::setQualifierInfo(NestedNameSpecifierLoc
QualifierLoc) {
}
}
+void TagDecl::printAnonymousTagDecl(llvm::raw_ostream &OS,
+const PrintingPolicy &Policy) const {
Michael137 wrote:
I'd p
Alexander-Johnston wrote:
> Looking at your similar PR (#168874), do you also need to add SPIRV::OpDPdy
> and SPIRV::OpDPdx to
> https://github.com/llvm/llvm-project/pull/168874/files#diff-ba9921ea1bab49f211b472854e8609ffc38debd428641ebd1b68512314ab9b6dR2155
A good catch! I had to check, but l
https://github.com/jkorous-apple updated
https://github.com/llvm/llvm-project/pull/169131
>From 61f84a4c4dfa70a4c4367c07075ac9a392cf70b4 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Fri, 21 Nov 2025 15:53:11 -0800
Subject: [PATCH 01/19] [clang][ssaf] Introduce entity abstraction for SSAF
Ad
https://github.com/bob80905 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/168887
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/YuriPlyakhin edited
https://github.com/llvm/llvm-project/pull/169425
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilovepi updated
https://github.com/llvm/llvm-project/pull/170953
>From e63525d4f71ba361031f501ec84b3bacafb29889 Mon Sep 17 00:00:00 2001
From: Paul Kirth
Date: Fri, 5 Dec 2025 13:56:44 -0800
Subject: [PATCH 1/2] [clang] Add missing support for traversal kind in
addMatcher ov
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-4` while building `clang` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/32291
Here is th
https://github.com/andykaylor updated
https://github.com/llvm/llvm-project/pull/166457
>From 98101759475ef24a7e4f3ee24726d0fc221ccdf4 Mon Sep 17 00:00:00 2001
From: Andy Kaylor
Date: Tue, 4 Nov 2025 14:24:43 -0800
Subject: [PATCH 1/5] [Clang][CIR][Doc] Document CIR code duplication plans
This
https://github.com/spall approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/168874
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zwuis wrote:
Please add a release note entry. Otherwise LGTM.
https://github.com/llvm/llvm-project/pull/170953
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/andykaylor approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/170916
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18,9 +18,13 @@ using namespace clang::ast_matchers;
namespace clang::tidy::readability {
void RedundantTypenameCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(typeLoc(unless(hasAncestor(decl(isInstantiated()
- .bind("nonDepe
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/169967
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Andres-Salamanca
Date: 2025-12-05T16:12:37-08:00
New Revision: 762a171b3d6f6eb64dc5a844fcb25caa4ece7d00
URL:
https://github.com/llvm/llvm-project/commit/762a171b3d6f6eb64dc5a844fcb25caa4ece7d00
DIFF:
https://github.com/llvm/llvm-project/commit/762a171b3d6f6eb64dc5a844fcb25caa4ece7d00.di
https://github.com/spall commented:
Looking at your similar PR (https://github.com/llvm/llvm-project/pull/168874),
do you also need to add SPIRV::OpDPdy and SPIRV::OpDPdx to
https://github.com/llvm/llvm-project/pull/168874/files#diff-ba9921ea1bab49f211b472854e8609ffc38debd428641ebd1b68512314ab9
@@ -1,4 +1,4 @@
-//- LowerToLLVM.cpp - Lowering from CIR to LLVMIR
-===//
+//- LowerToLLVM.cpp - Lowering from CIR to LLVMIR
-===//
andykaylor wrote:
You still need to remove whatever BOM character is on this lin
https://github.com/andykaylor commented:
This looks good except for the BOM issue.
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/andykaylor edited
https://github.com/llvm/llvm-project/pull/169310
___
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,119 +1,542 @@
-=
-SYCL Compiler and Runtime architecture design
-=
+
+SYCL Support
+
.. contents::
:local:
Introduction
+The `SYCL 2020 spe
@@ -887,7 +921,30 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_extractf64x2_256_mask:
case X86::BI__builtin_ia32_extracti64x2_256_mask:
case X86::BI__builtin_ia32_extractf64x2_512_mask:
- case X86::BI__builtin_ia32_ext
@@ -152,6 +152,40 @@ computeFullLaneShuffleMask(CIRGenFunction &cgf, const
mlir::Value vec,
outIndices.resize(numElts);
}
+static mlir::Value getBoolMaskVecValue(CIRGenBuilderTy &builder,
+ mlir::Location loc, mlir::Value mask,
+
@@ -887,7 +921,30 @@ mlir::Value CIRGenFunction::emitX86BuiltinExpr(unsigned
builtinID,
case X86::BI__builtin_ia32_extractf64x2_256_mask:
case X86::BI__builtin_ia32_extracti64x2_256_mask:
case X86::BI__builtin_ia32_extractf64x2_512_mask:
- case X86::BI__builtin_ia32_ext
@@ -250,8 +250,8 @@ def CIR_PtrToArray : CIR_PtrToType;
def CIR_AnyVectorType : CIR_TypeBase<"::cir::VectorType", "vector type">;
-def CIR_VectorElementType : AnyTypeOf<[CIR_AnyIntOrFloatType, CIR_AnyPtrType],
-"any cir integer, floating point or pointer type"
+def CIR_Ve
@@ -1870,8 +1896,8 @@ def CIR_SelectOp : CIR_Op<"select", [
let summary = "Yield one of two values based on a boolean value";
let description = [{
The `cir.select` operation takes three operands. The first operand
-`condition` is a boolean value of type `!cir.bool`.
@@ -1885,8 +1911,12 @@ def CIR_SelectOp : CIR_Op<"select", [
```
}];
- let arguments = (ins CIR_BoolType:$condition, CIR_AnyType:$true_value,
- CIR_AnyType:$false_value);
+ let arguments = (ins
+CIR_ScalarOrVectorOf:$condition,
+CIR_AnyTy
@@ -425,6 +425,32 @@ def CIR_ConstantOp : CIR_Op<"const", [
return boolAttr.getValue();
llvm_unreachable("Expected a BoolAttr in ConstantOp");
}
+static bool isAllOnesValue(mlir::Value value) {
+ auto constOp =
mlir::dyn_cast_or_null(value.getDefinin
@@ -425,6 +425,32 @@ def CIR_ConstantOp : CIR_Op<"const", [
return boolAttr.getValue();
llvm_unreachable("Expected a BoolAttr in ConstantOp");
}
+static bool isAllOnesValue(mlir::Value value) {
andykaylor wrote:
This feels weird as a stat
@@ -1870,8 +1896,8 @@ def CIR_SelectOp : CIR_Op<"select", [
let summary = "Yield one of two values based on a boolean value";
let description = [{
The `cir.select` operation takes three operands. The first operand
-`condition` is a boolean value of type `!cir.bool`.
bdunkin wrote:
My apologies for disappearing for a while on this change. I had to change focus
at work for a while, but I am now able to pick this back up.
I have updated the code to include all the suggested changes.
https://github.com/llvm/llvm-project/pull/143194
___
@@ -18,9 +18,13 @@ using namespace clang::ast_matchers;
namespace clang::tidy::readability {
void RedundantTypenameCheck::registerMatchers(MatchFinder *Finder) {
- Finder->addMatcher(typeLoc(unless(hasAncestor(decl(isInstantiated()
- .bind("nonDepe
@@ -3669,12 +3718,11 @@ static FormatToken *getFunctionName(const AnnotatedLine
&Line,
}
// Skip to the unqualified part of the name.
-while (Tok->startsSequence(tok::identifier, tok::coloncolon)) {
- assert(Tok->Next);
- Tok = Tok->Next->Next;
- if
@@ -3632,6 +3632,36 @@ static unsigned maxNestingDepth(const AnnotatedLine
&Line) {
return Result;
}
+// Returns the token after the first qualifier of the name, or nullptr if there
+// is no qualifier.
+static FormatToken *skipNameQualifier(const FormatToken *Tok) {
+ //
@@ -3632,6 +3632,36 @@ static unsigned maxNestingDepth(const AnnotatedLine
&Line) {
return Result;
}
+// Returns the token after the first qualifier of the name, or nullptr if there
+// is no qualifier.
+static FormatToken *skipNameQualifier(const FormatToken *Tok) {
+ //
@@ -3669,12 +3718,11 @@ static FormatToken *getFunctionName(const AnnotatedLine
&Line,
}
// Skip to the unqualified part of the name.
-while (Tok->startsSequence(tok::identifier, tok::coloncolon)) {
- assert(Tok->Next);
- Tok = Tok->Next->Next;
- if
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Paul Kirth (ilovepi)
Changes
This was noted in #170540, and seems to simply be an oversight. This
patch just add the same logic already used in other addMatcher()
implementations that honor the traversal kind.
---
Full diff: https://gith
https://github.com/ilovepi created
https://github.com/llvm/llvm-project/pull/170953
This was noted in #170540, and seems to simply be an oversight. This patch just
add the same logic already used in other addMatcher() implementations that
honor the traversal kind.
>From e63525d4f71ba361031f50
@@ -3632,6 +3632,36 @@ static unsigned maxNestingDepth(const AnnotatedLine
&Line) {
return Result;
}
+// Returns the token after the first qualifier of the name, or nullptr if there
+// is no qualifier.
+static FormatToken *skipNameQualifier(const FormatToken *Tok) {
+ //
1 - 100 of 483 matches
Mail list logo
