[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
https://github.com/capitan-davide updated https://github.com/llvm/llvm-project/pull/162361 >From 5f61932af5a90b52b5939406a929734dd6353316 Mon Sep 17 00:00:00 2001 From: Davide Cunial Date: Fri, 24 Oct 2025 08:18:09 +0200 Subject: [PATCH 1/7] [clang-tidy] Add new check 'bugprone-inconsistent-if

[clang-tools-extra] [clang-tidy] Fix `bugprone-exception-escape` not diagnosing throws in argument lists (PR #165955)

2025-11-07 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook edited https://github.com/llvm/llvm-project/pull/165955 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix `bugprone-exception-escape` not diagnosing throws in argument lists (PR #165955)

2025-11-07 Thread Victor Chernyakin via cfe-commits
@@ -601,10 +591,25 @@ ExceptionAnalyzer::throwsException(const Stmt *St, Results.merge(Excs); } } else { +// Check whether any of this node's subexpressions throws. for (const Stmt *Child : St->children()) { ExceptionInfo Excs = throwsException(Child

[clang-tools-extra] [clang-doc] Remove an unused local variable (NFC) (PR #167104)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes Identified with bugprone-unused-local-non-trivial-variable. --- Full diff: https://github.com/llvm/llvm-project/pull/167104.diff 1 Files Affected: - (modified) clang-tools-extra/clang-do

[clang-tools-extra] [clang-doc] Remove an unused local variable (NFC) (PR #167104)

2025-11-07 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/167104 Identified with bugprone-unused-local-non-trivial-variable. >From 89ea120cb7d8587ba4569f83eecba8d23074243c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Fri, 7 Nov 2025 09:48:39 -0800 Subject: [PATCH

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
https://github.com/capitan-davide deleted https://github.com/llvm/llvm-project/pull/162361 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
@@ -0,0 +1,89 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [clang][Sema] Fix Issue: #166957 - type inconsistency for constrained auto variables(Fixes #166957) (PR #167100)

2025-11-07 Thread via cfe-commits
KaushalMorankar wrote: The bug was in the internal type consistency between getTypeSourceInfo()->getType() and getType(). I added compilation tests that serve as regression tests to ensure these patterns continue to compile correctly. While these tests don't directly verify the AST consistency

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
capitan-davide wrote: > To me, this is purely readability check > `readability-inconsistent-ifelse-braces`. I would leave `bugprone` category > for checks that catch pattern which almost certainly have a bug (or very easy > to have a bug). With such inconsistent braces, I don't think it's _ver

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
https://github.com/capitan-davide updated https://github.com/llvm/llvm-project/pull/162361 >From 5f61932af5a90b52b5939406a929734dd6353316 Mon Sep 17 00:00:00 2001 From: Davide Cunial Date: Fri, 24 Oct 2025 08:18:09 +0200 Subject: [PATCH 1/7] [clang-tidy] Add new check 'bugprone-inconsistent-if

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
https://github.com/capitan-davide updated https://github.com/llvm/llvm-project/pull/162361 >From 5f61932af5a90b52b5939406a929734dd6353316 Mon Sep 17 00:00:00 2001 From: Davide Cunial Date: Fri, 24 Oct 2025 08:18:09 +0200 Subject: [PATCH 1/7] [clang-tidy] Add new check 'bugprone-inconsistent-if

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
https://github.com/capitan-davide updated https://github.com/llvm/llvm-project/pull/162361 >From 5f61932af5a90b52b5939406a929734dd6353316 Mon Sep 17 00:00:00 2001 From: Davide Cunial Date: Fri, 24 Oct 2025 08:18:09 +0200 Subject: [PATCH 1/7] [clang-tidy] Add new check 'bugprone-inconsistent-if

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-07 Thread Davide Cunial via cfe-commits
@@ -0,0 +1,89 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [clang][bytecode] Fix a std::optional mishap (PR #167091)

2025-11-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux` running on `systemz-1` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/42/builds/6888 Here is the relevant piece of the build log f

[clang-tools-extra] [clang-tidy][NFC] Remove trailing whitespaces in documentation (PR #167103)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: mitchell (zeyi2) Changes This is part of the codebase cleanup described in [#167098](https://github.com/llvm/llvm-project/issues/167098) --- Patch is 35.03 KiB, truncated to 20.00 KiB below, ful

[clang-tools-extra] [clang-tidy][NFC] Remove trailing whitespaces in documentation (PR #167103)

2025-11-07 Thread via cfe-commits
https://github.com/zeyi2 created https://github.com/llvm/llvm-project/pull/167103 This is part of the codebase cleanup described in [#167098](https://github.com/llvm/llvm-project/issues/167098) >From 56c42fac652aca23da40c009e0b8b3ee0ec8e08b Mon Sep 17 00:00:00 2001 From: mtx Date: Sat, 8 Nov

[clang-tools-extra] [clang-tidy] Fix `bugprone-exception-escape` not diagnosing throws in argument lists (PR #165955)

2025-11-07 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook updated https://github.com/llvm/llvm-project/pull/165955 >From 47c2c2ef1a65ffc55ef8a8a926fab39cc56a1429 Mon Sep 17 00:00:00 2001 From: Victor Chernyakin Date: Fri, 31 Oct 2025 19:15:34 -0700 Subject: [PATCH 1/2] [clang-tidy] Fix `bugprone-exception-escape` not dia

[clang] [AMDGPU][clang] Fix clang driver check for multiple sanitizer arguments (PR #166851)

2025-11-07 Thread Amit Kumar Pandey via cfe-commits
@@ -1074,27 +1074,32 @@ ROCMToolChain::getCommonDeviceLibNames( getSanitizerArgs(DriverArgs).needsAsanRt()); } -bool AMDGPUToolChain::shouldSkipSanitizeOption( +std::optional AMDGPUToolChain::filterSanitizeOption( const ToolChain &TC, const llvm::opt::ArgList &Drive

[clang] [RISCV] Set __GCC_CONSTRUCTIVE_SIZE/__GCC_DESTRUCTIVE_SIZE to 64 (PR #162986)

2025-11-07 Thread Pengcheng Wang via cfe-commits
https://github.com/wangpc-pp updated https://github.com/llvm/llvm-project/pull/162986 >From 2dc5e8e616c061be15006d075d8115c14185834e Mon Sep 17 00:00:00 2001 From: Pengcheng Wang Date: Sat, 11 Oct 2025 17:32:34 +0800 Subject: [PATCH 1/5] [RISCV] Set __GCC_CONSTRUCTIVE_SIZE/__GCC_DESTRUCTIVE_SI

[clang] [AMDGPU][clang] Fix clang driver check for multiple sanitizer arguments (PR #166851)

2025-11-07 Thread Amit Kumar Pandey via cfe-commits
ampandey-1995 wrote: Can this functionality be included in this function [diagnoseUnsupportedSanitizers](https://github.com/llvm/llvm-project/blob/0875755f5275dc7a84b1aeb526b7822b47a733c9/clang/lib/Driver/ToolChains/AMDGPU.h#L158) as we try to warn and skip processing of the unsupported sanitiz

[clang] [clang][Sema] Fix Issue: #166957 - type inconsistency for constrained auto variables(Fixes #166957) (PR #167100)

2025-11-07 Thread Yanzuo Liu via cfe-commits
zwuis wrote: Can you explain how the added test verifies that the issue is fixed? https://github.com/llvm/llvm-project/pull/167100 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix Issue: #166957 - type inconsistency for constrained auto variables(Fixes #166957) (PR #167100)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kaushal1042 (KaushalMorankar) Changes ```markdown Fixes #166957 This PR fixes an inconsistency where `getTypeSourceInfo()->getType()` and `getType()` return different `AutoType` instances with different `isDependentType()` values for con

[clang] [clang][Sema] Fix Issue: #166957 - type inconsistency for constrained auto variables(Fixes #166957) (PR #167100)

2025-11-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][Sema] Fix Issue: #166957 - type inconsistency for constrained auto variables(Fixes #166957) (PR #167100)

2025-11-07 Thread via cfe-commits
https://github.com/KaushalMorankar updated https://github.com/llvm/llvm-project/pull/167100 >From e413e6242644ce89aad131fed5ca2e120b35e86d Mon Sep 17 00:00:00 2001 From: KaushalMorankar Date: Sat, 8 Nov 2025 11:44:08 +0530 Subject: [PATCH] [clang][Sema] Fix Issue: #166957 - type inconsistency f

[clang] [clang][Sema] Fix Issue: #166957 - type inconsistency for constrained auto variables(Fixes #166957) (PR #167100)

2025-11-07 Thread via cfe-commits
https://github.com/KaushalMorankar created https://github.com/llvm/llvm-project/pull/167100 ```markdown Fixes #166957 This PR fixes an inconsistency where `getTypeSourceInfo()->getType()` and `getType()` return different `AutoType` instances with different `isDependentType()` values for const

[clang] [Headers][X86] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - allow PALIGNR byte shift intrinsics to be used in constexpr (PR #162005)

2025-11-07 Thread Ye Tian via cfe-commits
https://github.com/TianYe717 updated https://github.com/llvm/llvm-project/pull/162005 >From 28819c6782e4d6b351b617460b79e4436cc2644a Mon Sep 17 00:00:00 2001 From: Ye Tian <[email protected]> Date: Sun, 2 Nov 2025 21:45:55 +0800 Subject: [PATCH 1/5] [Headers][X86] Improve PALIGNR helper: unify a

[clang] [clang-format] Fix a crash in AlignArrayOfStructures (PR #167099)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: owenca (owenca) Changes Fixes #157405 --- Full diff: https://github.com/llvm/llvm-project/pull/167099.diff 2 Files Affected: - (modified) clang/lib/Format/WhitespaceManager.cpp (+4-1) - (modified) clang/unittests/Format/FormatTe

[clang] [clang-format] Fix a crash in AlignArrayOfStructures (PR #167099)

2025-11-07 Thread via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/167099 Fixes #157405 >From 981d3ac3bf6d8bdd212b5a93944e185c468e0956 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 8 Sep 2025 21:27:07 -0700 Subject: [PATCH] [clang-format] Fix a crash in AlignArrayOfStructures Fi

[clang] [clang][bytecode] Check source pointer for bitcast validity (PR #166907)

2025-11-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/166907 >From c4613ae0fbe5d35ac0205b93c53265fc5f95b57f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 7 Nov 2025 09:32:52 +0100 Subject: [PATCH] [clang][bytecode] Check source pointer for bitca

[clang] [clang][bytecode] Fix a std::optional mishap (PR #167091)

2025-11-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr auto_merge_enabled https://github.com/llvm/llvm-project/pull/167091 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix a std::optional mishap (PR #167091)

2025-11-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/167091 >From aae3c5d1a01f51798e18d447506152d1d94cfbfd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sat, 8 Nov 2025 05:20:29 +0100 Subject: [PATCH] [clang][bytecode] Fix a std::optional mishap Th

[clang] [clang-format] Add xxxMaxDigitsNoSeparator (PR #164286)

2025-11-07 Thread via cfe-commits
=?utf-8?q?Björn_Schäpers?= , =?utf-8?q?Björn_Schäpers?= Message-ID: In-Reply-To: owenca wrote: Instead of adding `MaxDigitsNoSeparator` suboptions, how about extending `Decimal`, etc.? For example, `Decimal: -4` would set an upper bound of 4 digits for removing the separators whereas `Decima

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-11-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-win-x-armv7l` running on `as-builder-1` while building `clang-tools-extra` at step 9 "test-check-llvm". Full details are available at: https://lab.llvm.org/buildbot/#/builders/38/builds/6235 Here is the relevant

[clang] [clang][bytecode] Avoid copies with elidable CXXConstructExprs (PR #166931)

2025-11-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/166931 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6fac21e - [clang][bytecode] Avoid copies with elidable CXXConstructExprs (#166931)

2025-11-07 Thread via cfe-commits
Author: Timm Baeder Date: 2025-11-08T05:30:01+01:00 New Revision: 6fac21e4049cfa375dd2f2a5e449358e257377a0 URL: https://github.com/llvm/llvm-project/commit/6fac21e4049cfa375dd2f2a5e449358e257377a0 DIFF: https://github.com/llvm/llvm-project/commit/6fac21e4049cfa375dd2f2a5e449358e257377a0.diff L

[clang] [clang][bytecode] Fix a std::optional mishap (PR #167091)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes This is about the value saved in the std::optional, not about whether the optional has a value at all. --- Full diff: https://github.com/llvm/llvm-project/pull/167091.diff 1 Files Affected: - (modified) c

[clang] [clang][bytecode] Fix a std::optional mishap (PR #167091)

2025-11-07 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/167091 This is about the value saved in the std::optional, not about whether the optional has a value at all. >From 1ebcbfc920b44d61d60763a6afadd0dcd32e03e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?

[clang] [C2y] Allow static local variables in inline functions with external … (PR #167086)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pranjal Prajapati (Pranjal095) Changes …linkage (N3622) This allows static local variables to be declared in inline functions with external linkage, a constraint that was removed in WG14 N3622. Such declarations are now allowed in C2y mo

[clang] [C2y] Allow static local variables in inline functions with external … (PR #167086)

2025-11-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [C2y] Allow static local variables in inline functions with external … (PR #167086)

2025-11-07 Thread Pranjal Prajapati via cfe-commits
https://github.com/Pranjal095 created https://github.com/llvm/llvm-project/pull/167086 …linkage (N3622) This allows static local variables to be declared in inline functions with external linkage, a constraint that was removed in WG14 N3622. Such declarations are now allowed in C2y mode, and

[clang] [X86][clang-cl] Add CL option /vlen (PR #166375)

2025-11-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/18645 Here is the relevant piece

[clang] [clang][DependencyScanning] Implementation of `CompilerInstanceWithContext` to Improve By-Name Queries (PR #164345)

2025-11-07 Thread Qiongsi Wu via cfe-commits
qiongsiwu wrote: Pushed 82b921628b97f1ca45b524439aea86018712b85f to fix the UB. https://github.com/llvm/llvm-project/pull/164345 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 82b9216 - Fix UB introduced by be0aa7b6c72bdb162f1f3fe251e469927118963e.

2025-11-07 Thread Qiongsi Wu via cfe-commits
Author: Qiongsi Wu Date: 2025-11-07T19:45:08-08:00 New Revision: 82b921628b97f1ca45b524439aea86018712b85f URL: https://github.com/llvm/llvm-project/commit/82b921628b97f1ca45b524439aea86018712b85f DIFF: https://github.com/llvm/llvm-project/commit/82b921628b97f1ca45b524439aea86018712b85f.diff LO

[clang-tools-extra] [clang-tidy][NFC] Add missing "Check" suffix to filenames in clang-tidy checks (PR #166889)

2025-11-07 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/166889 >From 3a8721888fa09815f68f18f7fbe39f5fa68f3758 Mon Sep 17 00:00:00 2001 From: mtx Date: Fri, 7 Nov 2025 12:27:39 +0800 Subject: [PATCH 1/4] [clang-tidy] Add missing "Check" suffix to checks --- .../clang-tidy/ce

[clang] [X86][clang-cl] Add CL option /vlen (PR #166375)

2025-11-07 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/166375 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ad7488a - [X86][clang-cl] Add CL option /vlen (#166375)

2025-11-07 Thread via cfe-commits
Author: Phoebe Wang Date: 2025-11-08T11:28:18+08:00 New Revision: ad7488a941555a689c94db5d51d4eeb849e41f43 URL: https://github.com/llvm/llvm-project/commit/ad7488a941555a689c94db5d51d4eeb849e41f43 DIFF: https://github.com/llvm/llvm-project/commit/ad7488a941555a689c94db5d51d4eeb849e41f43.diff L

[clang-tools-extra] [clang-tidy][NFC] Add missing "Check" suffix to filenames in clang-tidy checks (PR #166889)

2025-11-07 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/166889 >From 3a8721888fa09815f68f18f7fbe39f5fa68f3758 Mon Sep 17 00:00:00 2001 From: mtx Date: Fri, 7 Nov 2025 12:27:39 +0800 Subject: [PATCH 1/3] [clang-tidy] Add missing "Check" suffix to checks --- .../clang-tidy/ce

[clang] [llvm] [llvm][clang] Sandbox filesystem reads (PR #165350)

2025-11-07 Thread Jan Svoboda via cfe-commits
@@ -1447,6 +1448,8 @@ class directory_iterator { explicit directory_iterator(const Twine &path, std::error_code &ec, bool follow_symlinks = true) : FollowSymlinks(follow_symlinks) { +sandbox::violationIfEnabled(); jansv

[clang] [llvm] [llvm][clang] Sandbox filesystem reads (PR #165350)

2025-11-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/165350 >From db5971beb9a4108b300e4dd666d3b6760d4c4890 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 27 Oct 2025 16:00:53 -0700 Subject: [PATCH 01/21] [Support] Introduce IO sandboxing --- llvm/CMakeLists

[clang] [Clang] Consider reachability for file-scope warnings on initializers (PR #163885)

2025-11-07 Thread Justin Stitt via cfe-commits
JustinStitt wrote: Thanks for the approvals @zwuis and @kees. Planning to click the big green button next week. @cor3ntin Did I properly address your concerns from a few weeks ago? I never heard back. Thanks :) https://github.com/llvm/llvm-project/pull/163885 __

[clang] [lld] [llvm] [LLVM][WebAssembly] Implement branch hinting proposal (PR #146230)

2025-11-07 Thread Derek Schuff via cfe-commits
Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?utf-8?q?Döllerer?= , Lukas =?u

[clang] [clang][DependencyScanning] Implementation of `CompilerInstanceWithContext` to Improve By-Name Queries (PR #164345)

2025-11-07 Thread Qiongsi Wu via cfe-commits
qiongsiwu wrote: Found a fix. Will push momentarily. https://github.com/llvm/llvm-project/pull/164345 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][clang] Sandbox filesystem reads (PR #165350)

2025-11-07 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/165350 >From db5971beb9a4108b300e4dd666d3b6760d4c4890 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 27 Oct 2025 16:00:53 -0700 Subject: [PATCH 01/20] [Support] Introduce IO sandboxing --- llvm/CMakeLists

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-11-07 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-win-x-aarch64` running on `as-builder-2` while building `clang-tools-extra` at step 10 "test-check-clang". Full details are available at: https://lab.llvm.org/buildbot/#/builders/193/builds/11960 Here is the rele

[clang] [CIR] Emit promise declaration in coroutine (PR #166683)

2025-11-07 Thread Andy Kaylor via cfe-commits
@@ -33,6 +34,65 @@ struct clang::CIRGen::CGCoroData { CIRGenFunction::CGCoroInfo::CGCoroInfo() {} CIRGenFunction::CGCoroInfo::~CGCoroInfo() {} +namespace { +// FIXME: both GetParamRef and ParamReferenceReplacerRAII are good template +// candidates to be shared among LLVM / CIR

[clang] [CIR] Emit promise declaration in coroutine (PR #166683)

2025-11-07 Thread Andy Kaylor via cfe-commits
@@ -33,6 +34,65 @@ struct clang::CIRGen::CGCoroData { CIRGenFunction::CGCoroInfo::CGCoroInfo() {} CIRGenFunction::CGCoroInfo::~CGCoroInfo() {} +namespace { +// FIXME: both GetParamRef and ParamReferenceReplacerRAII are good template +// candidates to be shared among LLVM / CIR

[clang] [CIR] Emit promise declaration in coroutine (PR #166683)

2025-11-07 Thread Andy Kaylor via cfe-commits
@@ -149,7 +209,46 @@ CIRGenFunction::emitCoroutineBody(const CoroutineBodyStmt &s) { if (s.getReturnStmtOnAllocFailure()) cgm.errorNYI("handle coroutine return alloc failure"); - assert(!cir::MissingFeatures::generateDebugInfo()); - assert(!cir::MissingFeatures::emitB

[clang] [CIR] Emit promise declaration in coroutine (PR #166683)

2025-11-07 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. This looks good. I just have some nits about style and possibly some unmarked missing code. https://github.com/llvm/llvm-project/pull/166683 ___ cfe-commits mailing list [email protected].

[clang] [CIR] Emit promise declaration in coroutine (PR #166683)

2025-11-07 Thread Andy Kaylor via cfe-commits
@@ -152,6 +152,9 @@ class CIRGenFunction : public CIRGenTypeCache { /// global initializers. mlir::Operation *curFn = nullptr; + /// Save Parameter Decl for coroutine. + llvm::SmallVector fnArgs; andykaylor wrote: Do we have a good reason for the 4 here

[clang] [CIR] Emit promise declaration in coroutine (PR #166683)

2025-11-07 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/166683 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [LFI] Introduce AArch64 LFI Target (PR #167061)

2025-11-07 Thread Zachary Yedidia via cfe-commits
https://github.com/zyedidia edited https://github.com/llvm/llvm-project/pull/167061 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (6/N) (PR #167056)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) Changes --- Patch is 33.79 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/167056.diff 21 Files Affected: - (modified) c

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (6/N) (PR #167056)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/167056 None >From be10091201b42698ed5e84c0c9aa5ecfa0248e25 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 8 Nov 2025 03:00:28 +0300 Subject: [PATCH] [clang-tidy][NFC] Fix misc-const-correctness warnings (6/

[clang-tools-extra] [clang-tidy][NFC] Use llvm::DenseMap (PR #167050)

2025-11-07 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/167050 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "Reland [clang][modules-driver] Add scanner to detect C++20 module presence (#153497)" (PR #163371)

2025-11-07 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth updated https://github.com/llvm/llvm-project/pull/163371 >From ce400dc5410d84f43c68d2c0b6eb4798505bfe53 Mon Sep 17 00:00:00 2001 From: Naveen Seth Hanig Date: Tue, 14 Oct 2025 14:17:29 +0200 Subject: [PATCH] Revert "Reland [clang][modules-driver] Add scanner to de

[clang-tools-extra] [clang-tidy][NFC] Use llvm::DenseMap (PR #167050)

2025-11-07 Thread Baranov Victor via cfe-commits
@@ -7,53 +7,48 @@ //===--===// #include "AssertEquals.h" +#include "llvm/ADT/StringMap.h" -#include #include using namespace clang::ast_matchers; namespace clang::tidy::objc { // Mapping from `X

[clang-tools-extra] [clang-tidy][NFC] Use llvm::DenseMap (PR #167050)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/167050 >From 6858da23fc9b5f83a3c74b5ea0cdcd2cefdc3792 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 8 Nov 2025 02:49:51 +0300 Subject: [PATCH] [clang-tidy][NFC] Use llvm::DenseMap --- .../clang-tidy/objc/

[clang] [llvm] [llvm][clang] Sandbox filesystem reads (PR #165350)

2025-11-07 Thread Ben Langmuir via cfe-commits
@@ -1132,6 +1147,8 @@ bool is_other(const basic_file_status &status) { } std::error_code is_other(const Twine &Path, bool &Result) { + sandbox::violationIfEnabled(); benlangmuir wrote: That's my weak preference, but I won't block the PR over this if anyone

[clang] [llvm] [llvm][clang] Sandbox filesystem reads (PR #165350)

2025-11-07 Thread Jan Svoboda via cfe-commits
@@ -110,9 +105,6 @@ class LLVM_ABI AsmPrinter : public MachineFunctionPass { /// generating (such as the current section etc). std::unique_ptr OutStreamer; - /// The VFS to resolve asm include directives. - IntrusiveRefCntPtr VFS; jansvoboda11 wrote: No

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (3/N) (PR #167040)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) Changes --- Patch is 38.63 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/167040.diff 31 Files Affected: - (modified) clang-tools-extra/clang-tidy/abse

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (2/N) (PR #167035)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/167035 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 913849e - [clang-tidy][NFC] Fix misc-const-correctness warnings (2/N) (#167035)

2025-11-07 Thread via cfe-commits
Author: Baranov Victor Date: 2025-11-08T01:59:20+03:00 New Revision: 913849ecc0361e463e893f5fbc8fdf4902b39bca URL: https://github.com/llvm/llvm-project/commit/913849ecc0361e463e893f5fbc8fdf4902b39bca DIFF: https://github.com/llvm/llvm-project/commit/913849ecc0361e463e893f5fbc8fdf4902b39bca.diff

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (3/N) (PR #167040)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/167040 None >From 14c7714eb44149063fdcbe488438346633446a14 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 8 Nov 2025 01:53:30 +0300 Subject: [PATCH] [clang-tidy][NFC] Fix misc-const-correctness warnings (3/

[clang] [llvm] [llvm][clang] Sandbox filesystem reads (PR #165350)

2025-11-07 Thread Jan Svoboda via cfe-commits
@@ -111,10 +118,16 @@ class CrossProcessModuleCache : public ModuleCache { std::unique_ptr getLock(StringRef ModuleFilename) override { +// This is a compiler-internal input/output, let's bypass the sandbox. +auto BypassSandbox = llvm::sys::sandbox::scopedDisable()

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/167030 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 11efce4 - [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (#167030)

2025-11-07 Thread via cfe-commits
Author: Baranov Victor Date: 2025-11-08T01:53:56+03:00 New Revision: 11efce4605e6ad168a665e6cab7b84e592c5064f URL: https://github.com/llvm/llvm-project/commit/11efce4605e6ad168a665e6cab7b84e592c5064f DIFF: https://github.com/llvm/llvm-project/commit/11efce4605e6ad168a665e6cab7b84e592c5064f.diff

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (2/N) (PR #167035)

2025-11-07 Thread Baranov Victor via cfe-commits
@@ -119,11 +119,11 @@ static EditGenerator rewrite(RangeSelector Call, RangeSelector Builder) { } static RewriteRuleWith useNewMlirOpBuilderCheckRule() { - Stencil Message = cat("use 'OpType::create(builder, ...)' instead of " -"'builder.create(...)'"

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (2/N) (PR #167035)

2025-11-07 Thread Baranov Victor via cfe-commits
@@ -119,11 +119,11 @@ static EditGenerator rewrite(RangeSelector Call, RangeSelector Builder) { } static RewriteRuleWith useNewMlirOpBuilderCheckRule() { - Stencil Message = cat("use 'OpType::create(builder, ...)' instead of " -"'builder.create(...)'"

[clang] [llvm] [llvm][clang] Sandbox filesystem reads (PR #165350)

2025-11-07 Thread Jan Svoboda via cfe-commits
@@ -347,12 +348,15 @@ llvm::Expected FileManager::getSTDIN() { if (STDIN) return *STDIN; - std::unique_ptr Content; - if (auto ContentOrError = llvm::MemoryBuffer::getSTDIN()) -Content = std::move(*ContentOrError); - else + auto ContentOrError = [] { +auto By

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (2/N) (PR #167035)

2025-11-07 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/167035 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (2/N) (PR #167035)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) Changes --- Patch is 23.97 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/167035.diff 12 Files Affected: - (modified) clang-tools-extra/clang-tidy/hicpp/Multi

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (2/N) (PR #167035)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/167035 None >From f1cbc889ab354fe02e6ff844ef2138592a6a1b7e Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 8 Nov 2025 01:46:58 +0300 Subject: [PATCH] [clang-tidy][NFC] Fix misc-const-correctness warnings (2/

[clang] [CIR] Re-land: Recognize constant aggregate initialization of auto vars (PR #167033)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes This adds code that was previously missing from emitAutoVarAlloca to identify when an aggregate auto var is being emitted with a constant initializer, and the associated code that is called from emitAuto

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/167030 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/167030 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread Baranov Victor via cfe-commits
@@ -803,7 +805,7 @@ void ClangTidyDiagnosticConsumer::removeDuplicatedDiagnosticsOfAliasCheckers() { auto IT = Errors.begin(); while (IT != Errors.end()) { ClangTidyError &Error = *IT; -std::pair Inserted = +const std::pair Inserted = vbvictor

[clang] [HLSL] Add internal linkage attribute to resources (PR #166844)

2025-11-07 Thread Deric C. via cfe-commits
https://github.com/Icohedron approved this pull request. https://github.com/llvm/llvm-project/pull/166844 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/167030 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread via cfe-commits
@@ -803,7 +805,7 @@ void ClangTidyDiagnosticConsumer::removeDuplicatedDiagnosticsOfAliasCheckers() { auto IT = Errors.begin(); while (IT != Errors.end()) { ClangTidyError &Error = *IT; -std::pair Inserted = +const std::pair Inserted = EugeneZel

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) Changes Start fixing `misc-const-correctness` warning to enable the check in config --- Patch is 25.07 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/16703

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) Changes Start fixing `misc-const-correctness` warning to enable the check in config --- Patch is 25.07 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/167030.diff

[clang-tools-extra] [clang-tidy][NFC] Fix misc-const-correctness warnings (1/N) (PR #167030)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/167030 Start fixing `misc-const-correctness` warning to enable the check in config >From bbf776436d3073c07ebd120537b06853e27ba24b Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sat, 8 Nov 2025 01:33:03 +0300 Sub

[clang-tools-extra] [clang-doc] revert to a nested directory structure (PR #166978)

2025-11-07 Thread Erick Velez via cfe-commits
https://github.com/evelez7 closed https://github.com/llvm/llvm-project/pull/166978 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] afb84ca - [clang-doc] revert to a nested directory structure (#166978)

2025-11-07 Thread via cfe-commits
Author: Erick Velez Date: 2025-11-07T14:29:22-08:00 New Revision: afb84ca157e1b756012003657ce6840c8db24c62 URL: https://github.com/llvm/llvm-project/commit/afb84ca157e1b756012003657ce6840c8db24c62 DIFF: https://github.com/llvm/llvm-project/commit/afb84ca157e1b756012003657ce6840c8db24c62.diff L

[clang-tools-extra] [clang-doc] revert to a nested directory structure (PR #166978)

2025-11-07 Thread Erick Velez via cfe-commits
evelez7 wrote: CI keeps failing, see c0e4bce. https://github.com/llvm/llvm-project/pull/166978 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Recognize constant aggregate initialization of auto vars (PR #166850)

2025-11-07 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > I've reverted this in > [ec21e58](https://github.com/llvm/llvm-project/commit/ec21e58a30b2855e1e0140d417031281f2675a54) > given it doesn't seem like a forward fix is eminent. Yeah, my apologies to everyone. I didn't realize my change was causing the failure since it didn't

[clang-tools-extra] [clang-tidy][NFC] Enable "HeaderFilterRegex" in clang-tidy codebase (PR #167020)

2025-11-07 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/167020 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Enable "HeaderFilterRegex" in clang-tidy codebase (PR #167020)

2025-11-07 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. Looks OK for me, but please wait for other reviewers. https://github.com/llvm/llvm-project/pull/167020 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/m

[clang-tools-extra] [clang-tidy][NFC] Temporary disable `llvm-header-filter` check (PR #167021)

2025-11-07 Thread via cfe-commits
https://github.com/EugeneZelenko approved this pull request. https://github.com/llvm/llvm-project/pull/167021 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] revert to a nested directory structure (PR #166978)

2025-11-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. https://github.com/llvm/llvm-project/pull/166978 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >