[clang] [clang-format] Handle static_assert more accurately (PR #166042)

2025-11-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-msan` running on `sanitizer-buildbot10` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/12328 Here is the rele

[clang] [clang-format] Align trailing comments for function parameters (PR #164458)

2025-11-02 Thread via cfe-commits
@@ -507,7 +507,7 @@ static unsigned AlignTokens(const FormatStyle &Style, F &&Matches, }; unsigned I = StartAt; - unsigned E = Changes.size(); + auto E = Changes.size(); owenca wrote: `const auto` as suggested? https://github.com/llvm/llvm-project/pul

[clang] [clang-format] Add option to separate comment alignment between ... (PR #165033)

2025-11-02 Thread via cfe-commits
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?= Message-ID: In-Reply-To: owenca wrote: Looks like this can be moved into the `AlignTrailingComments` option. https://github.com/llvm/llvm-project/pull/165033 ___ cfe-commits mailing list [email protected]

[clang] [llvm] [ORC][LLJIT] Cleanup platform state after failed materialization (PR #166071)

2025-11-02 Thread via cfe-commits
devajithvs wrote: CC: @lhames, @vgvassilev This will fix the clang-repl (and cling) error mentioned in the PR description. https://github.com/llvm/llvm-project/pull/166071 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/

[clang] [llvm] [ORC][LLJIT] Cleanup platform state after failed materialization (PR #166071)

2025-11-02 Thread via cfe-commits
https://github.com/devajithvs edited https://github.com/llvm/llvm-project/pull/166071 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ORC][LLJIT] Cleanup platform state after failed materialization (PR #166071)

2025-11-02 Thread via cfe-commits
https://github.com/devajithvs edited https://github.com/llvm/llvm-project/pull/166071 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Migrate away from a soft-deprecated constructor of APInt (NFC) (PR #166127)

2025-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Kazu Hirata (kazutakahirata) Changes We have: /// Once all uses of this constructor are migrated to other constructors, /// consider marking this overload ""= delete" to prevent calls from being /// incor

[clang] [clang] Migrate away from a soft-deprecated constructor of APInt (NFC) (PR #166127)

2025-11-02 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/166127 We have: /// Once all uses of this constructor are migrated to other constructors, /// consider marking this overload ""= delete" to prevent calls from being /// incorrectly bound to the APInt(unsigned, u

[clang] [clang-format] Fix ColumnLimit violation while aligning (PR #165627)

2025-11-02 Thread via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/165627 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support header shadowing diagnostics in Clang header search (PR #162491)

2025-11-02 Thread Qiu Chaofan via cfe-commits
@@ -0,0 +1,14 @@ +// RUN: rm -rf %t +// RUN: split-file %s %t + +// RUN: %clang_cc1 -Wheader-shadowing -Eonly %t/main.c -I %t/include 2>&1 | FileCheck %s --check-prefix=SHADOWING +// SHADOWING: {{.*}} warning: multiple candidates for header 'header.h' found; + +//--- main.c +#in

[clang] [lldb] [Clang][LLDB] Refactor trap reason demangling out of LLDB and into Clang (PR #165996)

2025-11-02 Thread Dan Liew via cfe-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/165996 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [Clang][LLDB] Refactor trap reason demangling out of LLDB and into Clang (PR #165996)

2025-11-02 Thread Dan Liew via cfe-commits
@@ -97,6 +97,9 @@ add_lldb_library(lldbTarget lldbUtility lldbValueObject lldbPluginProcessUtility + + CLANG_LIBS +clangCodeGen delcypher wrote: > AFAIU the core of LLDB is supposed to be as generic as possible. Plugins are > supposed to prov

[clang] [lldb] [Clang][LLDB] Refactor trap reason demangling out of LLDB and into Clang (PR #165996)

2025-11-02 Thread Dan Liew via cfe-commits
@@ -97,6 +97,9 @@ add_lldb_library(lldbTarget lldbUtility lldbValueObject lldbPluginProcessUtility + + CLANG_LIBS +clangCodeGen delcypher wrote: > Yea we can definitely do it incrementally. Will try to put something up for > review tomorrow

[clang] [clang-format] Handle static_assert more accurately (PR #166042)

2025-11-02 Thread via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/166042 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3c0d4aa - [clang-format] Handle static_assert more accurately (#166042)

2025-11-02 Thread via cfe-commits
Author: owenca Date: 2025-11-02T22:35:50-08:00 New Revision: 3c0d4aa60156b05c5ca71a78b5f384820814f604 URL: https://github.com/llvm/llvm-project/commit/3c0d4aa60156b05c5ca71a78b5f384820814f604 DIFF: https://github.com/llvm/llvm-project/commit/3c0d4aa60156b05c5ca71a78b5f384820814f604.diff LOG: [

[clang] [clang] Adjust TextDiagnostic style ranges for interesting source region (PR #164941)

2025-11-02 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/164941 >From a1bcecb7a604ce7c9cee9b4443e67a173328bed1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= D

[clang-tools-extra] [clang-tidy] Implement alphabetical order test (PR #166072)

2025-11-02 Thread via cfe-commits
zeyi2 wrote: With the latest bugfix, the CI is expected to fail in `list.rst`, see this PR: https://github.com/llvm/llvm-project/pull/166123 https://github.com/llvm/llvm-project/pull/166072 ___ cfe-commits mailing list [email protected] https

[clang-tools-extra] [clang-tidy] Implement alphabetical order test (PR #166072)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/166072 >From 7b4e4172fc3cea8e8194aa3544f2c2ec30e3616a Mon Sep 17 00:00:00 2001 From: mtx Date: Sun, 2 Nov 2025 22:56:53 +0800 Subject: [PATCH 1/6] [clang-tidy][docs] Implement alphabetical order check --- .../clang-tid

[clang-tools-extra] [clang-tidy][NFC] Fix alphabetical order in `list.rst` (PR #166123)

2025-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: mitchell (zeyi2) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/166123.diff 1 Files Affected: - (modified) clang-tools-extra/docs/clang-tidy/checks/list.rst (+1-1) ``diff diff --git a/clang-tools-extra

[clang-tools-extra] [clang-tidy][NFC] Fix alphabetical order in `list.rst` (PR #166123)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 created https://github.com/llvm/llvm-project/pull/166123 None >From 5971b0e6cf60ff7d042b02e0546fbc9828c522ed Mon Sep 17 00:00:00 2001 From: mtx Date: Mon, 3 Nov 2025 14:12:30 +0800 Subject: [PATCH] [clang-tidy][NFC] Fix alphabetical order in `list.rst` --- clang-tool

[clang] [clang] Adjust TextDiagnostic style ranges for interesting source region (PR #164941)

2025-11-02 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1391,6 +1421,12 @@ void TextDiagnostic::emitSnippetAndCaret( OS.indent(MaxLineNoDisplayWidth + 2) << "| "; }; + Columns MessageLength = DiagOpts.MessageLength; + + // If we don't have eno

[clang] [clang-format] Handle static_assert more accurately (PR #166042)

2025-11-02 Thread via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/166042 >From 23ec6307c6a27dfe9818a35bc4837b4485875abe Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 2 Nov 2025 00:12:10 -0700 Subject: [PATCH 1/2] [clang-format] Handle static_assert more accurately --- clang/lib

[clang] [clang-format] Handle static_assert more accurately (PR #166042)

2025-11-02 Thread via cfe-commits
@@ -358,8 +358,8 @@ class AnnotatingParser { Contexts.back().IsExpression = false; } else if (OpeningParen.Previous && (OpeningParen.Previous->isOneOf( -tok::kw_static_assert, tok::kw_noexcept, tok::kw_explicit, -

[clang] [clang-format][NFC] Clean up FormatTestComments.cpp (PR #166029)

2025-11-02 Thread via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/166029 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a9f0594 - [clang-format][NFC] Clean up FormatTestComments.cpp (#166029)

2025-11-02 Thread via cfe-commits
Author: owenca Date: 2025-11-02T22:01:25-08:00 New Revision: a9f059483126428a445a67c3c00ed36a3ed14361 URL: https://github.com/llvm/llvm-project/commit/a9f059483126428a445a67c3c00ed36a3ed14361 DIFF: https://github.com/llvm/llvm-project/commit/a9f059483126428a445a67c3c00ed36a3ed14361.diff LOG: [

[clang] [clang-format][NFC] Clean up FormatTestComments.cpp (PR #166029)

2025-11-02 Thread via cfe-commits
owenca wrote: > Just out of curiosity, with which tool did you check for the duplicated > strings? I wrote a quick and dirty Python script (when I started cleaning up `FormatTest.cpp` and other unittest files a few years ago). It basically uses regex. https://github.com/llvm/llvm-project/pul

[clang] [llvm] [InstrProf] Fix frontend generated function hash (PR #165358)

2025-11-02 Thread Stephen Senran Zhang via cfe-commits
zsrkmyn wrote: A soft ping. https://github.com/llvm/llvm-project/pull/165358 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][RISCV] Add C intrinsics for XSfvfexp* and XSfvfexpa* (PR #165792)

2025-11-02 Thread Jim Lin via cfe-commits
https://github.com/tclin914 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/165792 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][RISCV] Add C intrinsics for XSfvfexp* and XSfvfexpa* (PR #165792)

2025-11-02 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat approved this pull request. LGTM~ https://github.com/llvm/llvm-project/pull/165792 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Fix assignment ignore in ScalarExprEmitter (PR #166118)

2025-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Morris Hafner (mmha) Changes We are missing a couple of cases were we are not supposed to ignore assignment results but did so, which results in compiler crashes. Fix that. --- Full diff: https://github.com/llvm/llvm-project/pull/166118

[clang] [CIR] Fix assignment ignore in ScalarExprEmitter (PR #166118)

2025-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Morris Hafner (mmha) Changes We are missing a couple of cases were we are not supposed to ignore assignment results but did so, which results in compiler crashes. Fix that. --- Full diff: https://github.com/llvm/llvm-project/pull/166118.d

[clang] [CIR] Fix assignment ignore in ScalarExprEmitter (PR #166118)

2025-11-02 Thread Morris Hafner via cfe-commits
https://github.com/mmha created https://github.com/llvm/llvm-project/pull/166118 We are missing a couple of cases were we are not supposed to ignore assignment results but did so, which results in compiler crashes. Fix that. >From 16947a920e19a854e79ae1670d1d997ce253fa61 Mon Sep 17 00:00:00 200

[clang-tools-extra] [clang-tidy] Implement alphabetical order test (PR #166072)

2025-11-02 Thread via cfe-commits
zeyi2 wrote: Sorry for the inconvenience I brought, I've updated the python script and it would be easier to review now. Thank you for your patience. https://github.com/llvm/llvm-project/pull/166072 ___ cfe-commits mailing list [email protected].

[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

2025-11-02 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos converted_to_draft https://github.com/llvm/llvm-project/pull/166110 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

2025-11-02 Thread Doug Wyatt via cfe-commits
dougsonos wrote: TODO: Consider `auto x = []() { /* lambda body */ };` which becomes `VarDecl` holding `ExprWithCleanups` holding `CXXBindTemporaryExpr`. We currently look for a destructor on a VarDecl but I suspect that becomes a redundant check with this change. Need to verify. https://gith

[clang] [clang-format] Align trailing comments for function parameters (PR #164458)

2025-11-02 Thread via cfe-commits
https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/164458 >From 1db4303b26210bfb7c8b3f60740a1036ede70425 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Tue, 21 Oct 2025 16:35:27 + Subject: [PATCH 1/5] [clang-format] Align trailing comments for function parameters bef

[clang] 43177bf - [clang-format] Recognize Verilog followed-by operators (#165594)

2025-11-02 Thread via cfe-commits
Author: sstwcw Date: 2025-11-03T03:55:53Z New Revision: 43177bf777f6a44c058277e9b504687bdc0370cc URL: https://github.com/llvm/llvm-project/commit/43177bf777f6a44c058277e9b504687bdc0370cc DIFF: https://github.com/llvm/llvm-project/commit/43177bf777f6a44c058277e9b504687bdc0370cc.diff LOG: [clang

[clang] [clang-format] Recognize Verilog followed-by operators (PR #165594)

2025-11-02 Thread via cfe-commits
https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/165594 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Implement alphabetical order test (PR #166072)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/166072 >From 7b4e4172fc3cea8e8194aa3544f2c2ec30e3616a Mon Sep 17 00:00:00 2001 From: mtx Date: Sun, 2 Nov 2025 22:56:53 +0800 Subject: [PATCH 1/5] [clang-tidy][docs] Implement alphabetical order check --- .../clang-tid

[clang] [clang-format] Allow line breaking with PointerAlignment configured (PR #164686)

2025-11-02 Thread via cfe-commits
sstwcw wrote: I did not understand what the behavior should be at the start. Now it looks like none of the changed lines will remain. Maybe I will try to fix the bug in the future. But not right now. So it is fine if someone else wants to work on it. https://github.com/llvm/llvm-project/pu

[clang] [clang-format] Allow line breaking with PointerAlignment configured (PR #164686)

2025-11-02 Thread via cfe-commits
https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/164686 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Implement alphabetical order test (PR #166072)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/166072 >From 7b4e4172fc3cea8e8194aa3544f2c2ec30e3616a Mon Sep 17 00:00:00 2001 From: mtx Date: Sun, 2 Nov 2025 22:56:53 +0800 Subject: [PATCH 1/4] [clang-tidy][docs] Implement alphabetical order check --- .../clang-tid

[clang] [clang-format] Recognize Verilog DPI export and import (PR #165595)

2025-11-02 Thread via cfe-commits
https://github.com/sstwcw edited https://github.com/llvm/llvm-project/pull/165595 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Recognize Verilog export and import (PR #165595)

2025-11-02 Thread via cfe-commits
https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/165595 >From 455a5ab590e058e50dc8b1c3eff126e34706a44c Mon Sep 17 00:00:00 2001 From: sstwcw Date: Wed, 29 Oct 2025 16:44:15 + Subject: [PATCH 1/2] [clang-format] Recognize Verilog export and import The directives s

[clang] [clang-format] Recognize Verilog export and import (PR #165595)

2025-11-02 Thread via cfe-commits
@@ -4555,6 +4559,26 @@ void UnwrappedLineParser::parseVerilogCaseLabel() { Line->Level = OrigLevel; } +bool UnwrappedLineParser::tryToParseVerilogExtern() { + assert( + FormatTok->isOneOf(tok::kw_extern, tok::kw_export, Keywords.kw_import)); + nextToken(); + // "DPI-

[clang-tools-extra] [clang-tidy] Rename `cert-dcl58-cpp` to `bugprone-std-namespace-modification` (PR #165659)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/165659 >From 0f42a4416fbc86556d45df83fbbe269253b6eb8b Mon Sep 17 00:00:00 2001 From: mtx Date: Thu, 30 Oct 2025 13:12:26 +0800 Subject: [PATCH 1/4] [clang-tidy] Rename `cert-dcl58-cpp` to `bugprone-dont-modify-std-names

[clang] [Clang][Sema] Check null after ExtractTypeForDeductionGuide (PR #165776)

2025-11-02 Thread Qiu Chaofan via cfe-commits
ecnelises wrote: @Fznamznon could you have a quick look at the release note? thanks! https://github.com/llvm/llvm-project/pull/165776 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Check null after ExtractTypeForDeductionGuide (PR #165776)

2025-11-02 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/165776 >From a74b48f5641bec3f64b99434a00c9131f08d4e60 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Mon, 3 Nov 2025 10:19:59 +0800 Subject: [PATCH] [Clang][Sema] Check null after ExtractTypeForDeductionGuide ---

[clang] [Clang][Sema] Check null after ExtractTypeForDeductionGuide (PR #165776)

2025-11-02 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/165776 >From 60c6b136f55a866f92edfdb7c207ac37fe139510 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Thu, 30 Oct 2025 13:12:25 -0700 Subject: [PATCH] [Clang][Sema] Check null after ExtractTypeForDeductionGuide ---

[clang] [Clang][Sema] Check null after ExtractTypeForDeductionGuide (PR #165776)

2025-11-02 Thread Qiu Chaofan via cfe-commits
https://github.com/ecnelises updated https://github.com/llvm/llvm-project/pull/165776 >From c3aeacf5781ade7b465f5440f6e1bff9f3b81097 Mon Sep 17 00:00:00 2001 From: Qiu Chaofan Date: Thu, 30 Oct 2025 13:12:25 -0700 Subject: [PATCH] [Clang][Sema] Check null after ExtractTypeForDeductionGuide ---

[clang-tools-extra] [clang-tidy] Rename `cert-dcl58-cpp` to `bugprone-std-namespace-modification` (PR #165659)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/165659 >From 0f42a4416fbc86556d45df83fbbe269253b6eb8b Mon Sep 17 00:00:00 2001 From: mtx Date: Thu, 30 Oct 2025 13:12:26 +0800 Subject: [PATCH 1/4] [clang-tidy] Rename `cert-dcl58-cpp` to `bugprone-dont-modify-std-names

[clang-tools-extra] [clang-tidy] Rename `cert-mem57-cpp` to `bugprone-default-operator-new-on-overaligned-type` (PR #165542)

2025-11-02 Thread via cfe-commits
zeyi2 wrote: silent ping, I've resolved conflicts with base branch :) https://github.com/llvm/llvm-project/pull/165542 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Rename `cert-mem57-cpp` to `bugprone-default-operator-new-on-overaligned-type` (PR #165542)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 updated https://github.com/llvm/llvm-project/pull/165542 >From 106c7ed6dff8976a8dfc4b85aeed96a478cfab34 Mon Sep 17 00:00:00 2001 From: mtx Date: Wed, 29 Oct 2025 16:25:37 +0800 Subject: [PATCH 1/6] Rename `cert-mem57-cpp` to `bugprone-default-operator-new-alignment` -

[clang] [Headers][X86] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - allow PALIGNR byte shift intrinsics to be used in constexpr (PR #162005)

2025-11-02 Thread Ye Tian via cfe-commits
https://github.com/TianYe717 updated https://github.com/llvm/llvm-project/pull/162005 >From 28819c6782e4d6b351b617460b79e4436cc2644a Mon Sep 17 00:00:00 2001 From: Ye Tian <[email protected]> Date: Sun, 2 Nov 2025 21:45:55 +0800 Subject: [PATCH 1/2] [Headers][X86] Improve PALIGNR helper: unify a

[clang-tools-extra] [clang-tidy] Rename `cert-dcl58-cpp` to `bugprone-std-namespace-modification` (PR #165659)

2025-11-02 Thread via cfe-commits
https://github.com/zeyi2 edited https://github.com/llvm/llvm-project/pull/165659 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [ExprMutation] fix false postives on pointer-to-member operator (PR #166069)

2025-11-02 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/166069 >From 90ecfe136730918c6d80148ad8e2a870ac86fda5 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sun, 2 Nov 2025 21:00:31 +0800 Subject: [PATCH] [ExprMutation] fix false postives on pointer-to-member operat

[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

2025-11-02 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos updated https://github.com/llvm/llvm-project/pull/166110 >From 0ab16b664773bd7b3859ec9e6fc84217dbac1de9 Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Sun, 2 Nov 2025 15:55:48 -0800 Subject: [PATCH 1/2] [Clang] FunctionEffect analysis was missing a CXXBindTemporar

[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

2025-11-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp -- clang/lib/Sema/SemaFunctionEffects.cpp clang/te

[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

2025-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Doug Wyatt (dougsonos) Changes This example is reduced from a discovery: resetting a shared pointer from a nonblocking function is not diagnosed. ``` void nb23() { struct X { int *ptr = nullptr; X()

[clang] [Clang] FunctionEffect analysis was missing a CXXBindTemporaryExpr's implicit call to a destructor. (PR #166110)

2025-11-02 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos created https://github.com/llvm/llvm-project/pull/166110 This example is reduced from a discovery: resetting a shared pointer from a nonblocking function is not diagnosed. ``` void nb23() { struct X { int *ptr = nullptr; X()

[clang] [llvm] [InstCombine] Fold select(X >s 0, 0, -X) | smax(X, 0) to abs(X) (PR #165200)

2025-11-02 Thread Wenju He via cfe-commits
https://github.com/wenju-he closed https://github.com/llvm/llvm-project/pull/165200 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 79bf8c0 - [InstCombine] Fold select(X >s 0, 0, -X) | smax(X, 0) to abs(X) (#165200)

2025-11-02 Thread via cfe-commits
Author: Wenju He Date: 2025-11-03T07:38:21+08:00 New Revision: 79bf8c0331bc7e3655e208da7ad8aa780105ac82 URL: https://github.com/llvm/llvm-project/commit/79bf8c0331bc7e3655e208da7ad8aa780105ac82 DIFF: https://github.com/llvm/llvm-project/commit/79bf8c0331bc7e3655e208da7ad8aa780105ac82.diff LOG:

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/162361 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor commented: To me, this is purely readability check `readability-inconsistent-ifelse-braces`. I would leave `bugprone` category for checks that catch pattern which almost certainly have a bug (or very easy to have a bug). With such braces, I don't think it's _very_

[clang] [lldb] [Clang][LLDB] Refactor trap reason demangling out of LLDB and into Clang (PR #165996)

2025-11-02 Thread Michael Buch via cfe-commits
@@ -97,6 +97,9 @@ add_lldb_library(lldbTarget lldbUtility lldbValueObject lldbPluginProcessUtility + + CLANG_LIBS +clangCodeGen Michael137 wrote: > Can you elaborate on this restriction? Given that LLDB already links against > Clang it's not

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-11-02 Thread Dasha Buka via cfe-commits
https://github.com/dvbuka updated https://github.com/llvm/llvm-project/pull/164566 >From 4640cf73b874a90acd4799b6a710d6139fcd08cb Mon Sep 17 00:00:00 2001 From: Dasha Buka <[email protected]> Date: Wed, 22 Oct 2025 00:17:46 -0700 Subject: [PATCH 01/10] Move check cert-oop

[clang] [lldb] [Clang][LLDB] Refactor trap reason demangling out of LLDB and into Clang (PR #165996)

2025-11-02 Thread Michael Buch via cfe-commits
@@ -97,6 +97,9 @@ add_lldb_library(lldbTarget lldbUtility lldbValueObject lldbPluginProcessUtility + + CLANG_LIBS +clangCodeGen Michael137 wrote: > Rather than move all the frame recognizers at once maybe we could just move > the VerboseTrapF

[clang] Issue #162051: [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - add AVX512 KTEST/KORTEST intrinsics to be used in constexpr (PR #166103)

2025-11-02 Thread Roberto Turrado Camblor via cfe-commits
rturrado wrote: I have left a couple of TODOs on purpose. They are more a question to reviewers. I didn't know: 1) If I had to check for a carry/zero flag as a result of a kortestc/kortestz operation, respectively. 2) And if so, how to do it. https://github.com/llvm/llvm-project/pull/166103 __

[clang-tools-extra] [clang-tidy][NFC] Enable 'readability-simplify-boolean-expr' check (PR #158706)

2025-11-02 Thread Baranov Victor via cfe-commits
vbvictor wrote: Looking at it again, I think we can't enable this check for now in the codebase because of patterns described in https://github.com/llvm/llvm-project/issues/164896. In our concrete example, we have: ```cpp if (isCommonPrefixWithoutSomeCharacters( Threshold, StringRe

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-11-02 Thread Baranov Victor via cfe-commits
@@ -199,6 +200,8 @@ class BugproneModule : public ClangTidyModule { "bugprone-multiple-new-in-one-expression"); CheckFactories.registerCheck( "bugprone-multiple-statement-macro"); +CheckFactories.registerCheck( +"bugprone-copy-constructor-mutates

[clang-tools-extra] [clang-tidy] Add a fully custom message to `bugprone-unsafe-functions` (PR #162443)

2025-11-02 Thread Baranov Victor via cfe-commits
@@ -97,33 +97,61 @@ The functions are matched using POSIX extended regular expressions. The `reason` is optional and is used to provide additional information about the reasoning behind the replacement. The default reason is `is marked as unsafe`. -If `replacement` is empty,

[clang-tools-extra] [clang-tidy] Add a fully custom message to `bugprone-unsafe-functions` (PR #162443)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM with nit https://github.com/llvm/llvm-project/pull/162443 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add a fully custom message to `bugprone-unsafe-functions` (PR #162443)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/162443 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-11-02 Thread Dasha Buka via cfe-commits
https://github.com/dvbuka updated https://github.com/llvm/llvm-project/pull/164566 >From 4640cf73b874a90acd4799b6a710d6139fcd08cb Mon Sep 17 00:00:00 2001 From: Dasha Buka <[email protected]> Date: Wed, 22 Oct 2025 00:17:46 -0700 Subject: [PATCH 1/9] Move check cert-oop58

[clang-tools-extra] [clang-tidy] Teach `modernize-deprecated-headers` about more no-op headers (PR #165674)

2025-11-02 Thread Baranov Victor via cfe-commits
@@ -3,12 +3,55 @@ modernize-deprecated-headers -Some headers from C library were deprecated in C++ and are no longer welcome in -C++ codebases. Some have no effect in C++. For more details refer to the C++14 -Standard [depr.c.headers] section. - -T

[clang-tools-extra] [clang-tidy] Teach `modernize-deprecated-headers` about more no-op headers (PR #165674)

2025-11-02 Thread Baranov Victor via cfe-commits
@@ -21,46 +64,9 @@ removes redundant ones. #include // No 'stdbool.h' here. -Important note: the Standard doesn't guarantee that the C++ headers declare all -the same functions in the global namespace. The check in its current form can -break the code that uses library sy

[clang-tools-extra] [clang-tidy] Teach `modernize-deprecated-headers` about more no-op headers (PR #165674)

2025-11-02 Thread Baranov Victor via cfe-commits
@@ -3,12 +3,55 @@ modernize-deprecated-headers -Some headers from C library were deprecated in C++ and are no longer welcome in -C++ codebases. Some have no effect in C++. For more details refer to the C++14 -Standard [depr.c.headers] section.

[clang] Issue #162051: [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - add AVX512 KTEST/KORTEST intrinsics to be used in constexpr (PR #166103)

2025-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Roberto Turrado Camblor (rturrado) Changes Add AVX512 KTEST/KORTEST intrinsics to be used in constexpr. --- Patch is 29.86 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/166103.diff 8 F

[clang] Issue #162051: [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - add AVX512 KTEST/KORTEST intrinsics to be used in constexpr (PR #166103)

2025-11-02 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Issue #162051: [X86][Clang] VectorExprEvaluator::VisitCallExpr / InterpretBuiltin - add AVX512 KTEST/KORTEST intrinsics to be used in constexpr (PR #166103)

2025-11-02 Thread Roberto Turrado Camblor via cfe-commits
https://github.com/rturrado created https://github.com/llvm/llvm-project/pull/166103 Add AVX512 KTEST/KORTEST intrinsics to be used in constexpr. >From 084f456a91a2bcb921f84a19c367ccd9d5e05700 Mon Sep 17 00:00:00 2001 From: rturrado Date: Sat, 1 Nov 2025 19:53:19 +0100 Subject: [PATCH 1/5] Mar

[clang-tools-extra] Improve attribute range handling for attributed function types in sel… (PR #163926)

2025-11-02 Thread via cfe-commits
=?utf-8?b?5YWo5Y2T?= , =?utf-8?b?5YWo5Y2T?= Message-ID: In-Reply-To: github-actions[bot] wrote: @quanzhuo Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bo

[clang-tools-extra] Improve attribute range handling for attributed function types in sel… (PR #163926)

2025-11-02 Thread Nathan Ridge via cfe-commits
=?utf-8?b?5YWo5Y2T?= , =?utf-8?b?5YWo5Y2T?= Message-ID: In-Reply-To: https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/163926 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] c1d1a40 - [clangd] Handle AttributedTypeLoc in SelectionTree (#163926)

2025-11-02 Thread via cfe-commits
Author: Quan Zhuo Date: 2025-11-02T17:21:03-05:00 New Revision: c1d1a40796426af668dac2cac1e6e89cc1082113 URL: https://github.com/llvm/llvm-project/commit/c1d1a40796426af668dac2cac1e6e89cc1082113 DIFF: https://github.com/llvm/llvm-project/commit/c1d1a40796426af668dac2cac1e6e89cc1082113.diff LOG

[clang-tools-extra] Improve attribute range handling for attributed function types in sel… (PR #163926)

2025-11-02 Thread Nathan Ridge via cfe-commits
=?utf-8?b?5YWo5Y2T?= , =?utf-8?b?5YWo5Y2T?= Message-ID: In-Reply-To: https://github.com/HighCommander4 approved this pull request. Thanks, LGTM! https://github.com/llvm/llvm-project/pull/163926 ___ cfe-commits mailing list [email protected]

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM if conflicts are resolved https://github.com/llvm/llvm-project/pull/164566 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop57-cpp' to 'bugprone-raw-memory-call-on-non-trivial-type' (PR #162039)

2025-11-02 Thread via cfe-commits
github-actions[bot] wrote: @dvbuka Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop57-cpp' to 'bugprone-raw-memory-call-on-non-trivial-type' (PR #162039)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/162039 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 6b147b4 - [clang-tidy] Rename and move 'cert-oop57-cpp' to 'bugprone-raw-memory-call-on-non-trivial-type' (#162039)

2025-11-02 Thread via cfe-commits
Author: Dasha Buka Date: 2025-11-03T01:08:50+03:00 New Revision: 6b147b46fefc27812f179fb9cef5c6f0bb894878 URL: https://github.com/llvm/llvm-project/commit/6b147b46fefc27812f179fb9cef5c6f0bb894878 DIFF: https://github.com/llvm/llvm-project/commit/6b147b46fefc27812f179fb9cef5c6f0bb894878.diff LO

[clang] [clang] Reject 'auto' storage class with type specifier in C++ (PR #166004)

2025-11-02 Thread Osama Abdelkader via cfe-commits
https://github.com/osamakader updated https://github.com/llvm/llvm-project/pull/166004 >From 849e398468c3ed3075dff01d8c9433fd5fcc5672 Mon Sep 17 00:00:00 2001 From: Osama Abdelkader Date: Sun, 2 Nov 2025 17:03:02 +0200 Subject: [PATCH] [clang] Reject 'auto' storage class with type specifier in

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop57-cpp' to 'bugprone-raw-memory-call-on-non-trivial-type' (PR #162039)

2025-11-02 Thread Dasha Buka via cfe-commits
dvbuka wrote: Done https://github.com/llvm/llvm-project/pull/162039 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CGObjC] Allow clang.arc.attachedcall on -O0 (PR #164875)

2025-11-02 Thread via cfe-commits
https://github.com/AZero13 updated https://github.com/llvm/llvm-project/pull/164875 >From 70475594df6bb94f6093e15dbd731692db4a23e5 Mon Sep 17 00:00:00 2001 From: AZero13 Date: Thu, 23 Oct 2025 14:39:18 -0400 Subject: [PATCH] [CGObjC] Allow clang.arc.attachedcall on -O0 on AArch64 It is support

[clang] [llvm] [CGObjC] Allow clang.arc.attachedcall on -O0 (PR #164875)

2025-11-02 Thread via cfe-commits
https://github.com/AZero13 updated https://github.com/llvm/llvm-project/pull/164875 >From 8f091f5588bf04e9bf38a28fcf480128519bae93 Mon Sep 17 00:00:00 2001 From: AZero13 Date: Thu, 23 Oct 2025 14:39:18 -0400 Subject: [PATCH] [CGObjC] Allow clang.arc.attachedcall on -O0 on AArch64 It is support

[clang-tools-extra] [clang-tidy] add option to `readability-use-concise-preprocessor-directives` to take consistency into account (PR #156220)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/156220 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add option to `readability-use-concise-preprocessor-directives` to take consistency into account (PR #156220)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor commented: Leaving note that I've checked this PR and nothing looks odd to the eye, but I could fully understand how it works, so I can't make "lgtm" for now :( Maybe anyone else is interested to take a look at this closely? https://github.com/llvm/llvm-project/pull

[clang-tools-extra] [clang-tidy][NFC] Enable `performance-unnecessary-value-param` in the codebase (PR #163686)

2025-11-02 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor approved this pull request. LGTM once https://github.com/llvm/llvm-project/pull/163686/files#r2451415731 is resolved https://github.com/llvm/llvm-project/pull/163686 ___ cfe-commits mailing list [email protected] h

[clang] [Clang] FunctionEffects: properly extract the type of a bound member member function from a CallExpr. (PR #166101)

2025-11-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Doug Wyatt (dougsonos) Changes There's a bug illustrated by this example: ``` template struct Holder { T value; T& operator*() { return value; } }; struct X { using Dispatch = float (X::*)() [

[clang] [Clang] FunctionEffects: properly extract the type of a bound member member function from a CallExpr. (PR #166101)

2025-11-02 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos created https://github.com/llvm/llvm-project/pull/166101 There's a bug illustrated by this example: ``` template struct Holder { T value; T& operator*() { return value; } }; struct X { using Dispatch = float (X::*)() [[clang::nonbl

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-11-02 Thread Dasha Buka via cfe-commits
https://github.com/dvbuka updated https://github.com/llvm/llvm-project/pull/164566 >From 4640cf73b874a90acd4799b6a710d6139fcd08cb Mon Sep 17 00:00:00 2001 From: Dasha Buka <[email protected]> Date: Wed, 22 Oct 2025 00:17:46 -0700 Subject: [PATCH 1/9] Move check cert-oop58

[clang] [clang] Reject 'auto' storage class with type specifier in C++ (PR #166004)

2025-11-02 Thread Osama Abdelkader via cfe-commits
https://github.com/osamakader updated https://github.com/llvm/llvm-project/pull/166004 >From 711223c52ffed99c83fee8209b0ddc3a220b3ee2 Mon Sep 17 00:00:00 2001 From: Osama Abdelkader Date: Sun, 2 Nov 2025 17:03:02 +0200 Subject: [PATCH] [clang] Reject 'auto' storage class with type specifier in

[clang] [clang] Reject 'auto' storage class with type specifier in C++ (PR #166004)

2025-11-02 Thread Osama Abdelkader via cfe-commits
@@ -4095,11 +4095,22 @@ void Parser::ParseDeclarationSpecifiers( case tok::kw_auto: if (getLangOpts().CPlusPlus11 || getLangOpts().C23) { if (isKnownToBeTypeSpecifier(GetLookAheadToken(1))) { - isInvalid = DS.SetStorageClassSpec(Actions, DeclSpec::SCS

  1   2   3   >