[clang] [Clang] Fix an iterator invalidation bug in concept normalization cache (PR #165352)

2025-10-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/165352 >From 855c54c8639e9bd790bc4966eb633b3a2e046f4d Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 28 Oct 2025 12:57:58 +0800 Subject: [PATCH] [Clang] Fix an iterator invalidation bug in concept normalizatio

[clang] [clang-format] Align trailing comments for function parameters (PR #164458)

2025-10-27 Thread via cfe-commits
@@ -650,8 +650,16 @@ static unsigned AlignTokens(const FormatStyle &Style, F &&Matches, MatchedIndices.push_back(I); } + // Pass to the function entire lines, so it can update the state of all tokens + // that move. EndOfSequence = I; + while (EndOfSequence < Cha

[clang] [clang-format] Fix a bug in annotating operator functions (PR #165351)

2025-10-27 Thread via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/165351 >From 85036b258697d6c279d9b8150530ef8d2f6e29b6 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 27 Oct 2025 21:42:03 -0700 Subject: [PATCH 1/2] [clang-format] Fix a bug in annotating operator functions Fixes #

[clang] [clang-format] Fix a bug in annotating operator function declarations (PR #165351)

2025-10-27 Thread via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/165351 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix an iterator invalidation bug in concept normalization cache (PR #165352)

2025-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes The NormalizationCache may be inserted recursively when normalizing template arguments with non-dependent default arguments. Since the ADT doesn't preserve iterator validity, this caused undefined behavior.

[clang] [Clang] Fix an iterator invalidation bug in concept normalization cache (PR #165352)

2025-10-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 converted_to_draft https://github.com/llvm/llvm-project/pull/165352 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix an iterator invalidation bug in concept normalization cache (PR #165352)

2025-10-27 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/165352 The NormalizationCache may be inserted recursively when normalizing template arguments with non-dependent default arguments. Since the ADT doesn't preserve iterator validity, this caused undefined behavior. We

[clang] [clang-format] Fix a bug in annotating operator functions (PR #165351)

2025-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: owenca (owenca) Changes Fixes #164866 --- Full diff: https://github.com/llvm/llvm-project/pull/165351.diff 2 Files Affected: - (modified) clang/lib/Format/TokenAnnotator.cpp (+7-4) - (modified) clang/unittests/Format/TokenAnnota

[clang] [flang] [llvm] [OpenMP] Add parser/semantic support for dyn_groupprivate clause (PR #152651)

2025-10-27 Thread Kevin Sala Penades via cfe-commits
https://github.com/kevinsala edited https://github.com/llvm/llvm-project/pull/152651 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang-format] Annotate ::operator and Foo::operator correctly" (PR #164670)

2025-10-27 Thread via cfe-commits
owenca wrote: > As far as I can tell, what happened is @owenca committed a patch on Oct 17, > which broke a workflow for @PiJoules, which was reported on Oct 21.  He asked > for a immediate fix/revert, which did not happen, then he reverted on Oct 22.  > After that point, this turned into a re

[clang] [clang-format] Fix a bug in annotating operator functions (PR #165351)

2025-10-27 Thread via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/165351 Fixes #164866 >From 85036b258697d6c279d9b8150530ef8d2f6e29b6 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 27 Oct 2025 21:42:03 -0700 Subject: [PATCH] [clang-format] Fix a bug in annotating operator functio

[clang] [llvm] Rename wasm32-wasi to wasm32-wasip1. (PR #165345)

2025-10-27 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode updated https://github.com/llvm/llvm-project/pull/165345 >From 4809631f529f6f83105d97a4ecbe7c8312f2c5fd Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Mon, 27 Oct 2025 19:13:17 -0700 Subject: [PATCH 1/3] Rename wasm32-wasi to wasm32-wasip1. This adds code to rec

[clang] [llvm] Sandboxing v2 (PR #165350)

2025-10-27 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/165350 None >From ce13278e1df2649e7c0c889da4b9eafa258dde06 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Mon, 27 Oct 2025 16:00:53 -0700 Subject: [PATCH 01/17] [llvm] Introduce IO sandboxing --- llvm/CMakeLi

[clang] [llvm] [InstCombine] Fold select(X >s 0, 0, -X) | smax(X, 0) to abs(X) (PR #165200)

2025-10-27 Thread Wenju He via cfe-commits
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/165200 >From 4629547485d5b0c4f0a0e3e2e026222bbb654c7a Mon Sep 17 00:00:00 2001 From: Wenju He Date: Mon, 27 Oct 2025 05:41:34 +0100 Subject: [PATCH 1/9] [InstCombine] Fold select(X >s 0, 0, -X) | smax(X, 0) to abs(X)

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Oliver Hunt via cfe-commits
ojhunt wrote: Ok, I've added multiple and virtual inheritance tests, and included tests that force static and dynamic this adjustments. We currently do not appear to devirtualise dynamic this adjustments, which means the tests currently use the vtable to perform dynamic this adjustments, and

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/165341 >From f2b5020e406c521dd185659c04817be0e5c97e3e Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Mon, 27 Oct 2025 15:12:17 -0700 Subject: [PATCH 1/4] [clang] Allow devirtualisation of indirect calls to final virt

[clang] [Clang] Freeze padded vectors before storing. (PR #164821)

2025-10-27 Thread Florian Hahn via cfe-commits
@@ -0,0 +1,42 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 6 +// RUN: %clang_cc1 -fenable-matrix -triple arm64-apple-macosx %s -emit-llvm -disable-llvm-passes -o - | FileCheck %s + +typedef float float3 __attribute__((ext_

[clang] [Clang] Freeze padded vectors before storing. (PR #164821)

2025-10-27 Thread Florian Hahn via cfe-commits
@@ -0,0 +1,42 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 6 +// RUN: %clang_cc1 -fenable-matrix -triple arm64-apple-macosx %s -emit-llvm -disable-llvm-passes -o - | FileCheck %s + +typedef float float3 __attribute__((ext_

[clang] [clang] Proofread UsersManual.rst (PR #164928)

2025-10-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `ppc64le-flang-rhel-clang` running on `ppc64le-flang-rhel-test` while building `clang` at step 3 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/41872 Here is the relevan

[clang] [Clang] Freeze padded vectors before storing. (PR #164821)

2025-10-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/164821 >From 982b2154bdfbd56f74f38822c67aa6a8ee9ad741 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Thu, 23 Oct 2025 14:01:19 +0100 Subject: [PATCH 1/4] [Clang] Add test --- .../CodeGen/AArch64/ext-vector-coercion.

[clang] [clang-format] Option to insert spaces before the closing `*/` (PR #162105)

2025-10-27 Thread via cfe-commits
https://github.com/Men-cotton updated https://github.com/llvm/llvm-project/pull/162105 >From 1cf571b409ec379dc9c52b51f58a63db318df691 Mon Sep 17 00:00:00 2001 From: mencotton Date: Tue, 7 Oct 2025 23:14:20 +0900 Subject: [PATCH] [clang-format] Add SpaceInComments controls for block comment del

[clang] [clang][lex] Use `FileManager` to make prebuilt module paths absolute (PR #165347)

2025-10-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jan Svoboda (jansvoboda11) Changes This PR switches from using `llvm::sys::fs::make_absolute()` to `FileManager::makeAbsolutePath()` so that `FileSystemOptions` (i.e. the `-working-directory` option) and the `VFS`'s CWD have a say in how

[clang] [clang][lex] Use `FileManager` to make prebuilt module paths absolute (PR #165347)

2025-10-27 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/165347 This PR switches from using `llvm::sys::fs::make_absolute()` to `FileManager::makeAbsolutePath()` so that `FileSystemOptions` (i.e. the `-working-directory` option) and the `VFS`'s CWD have a say in how th

[clang-tools-extra] [clang-tidy][readability-redundant-parentheses] add option to prevent widely used work around (PR #164827)

2025-10-27 Thread via cfe-commits
@@ -27,3 +27,17 @@ affect the semantics. .. code-block:: c++ int a = (1 * 2) + 3; // no warning + +Options +--- + +.. option:: AllowedDecls + + Semicolon-separated list of regular expressions matching names of declarations + to ignore when the parentheses are around.

[clang-tools-extra] 7de1a17 - [clang-tidy] Fix `modernize-use-scoped-lock` crash on malformed code (#165127)

2025-10-27 Thread via cfe-commits
Author: Victor Chernyakin Date: 2025-10-27T20:04:00-07:00 New Revision: 7de1a17cc64bfcd1f0de055682d562dfb6476fb2 URL: https://github.com/llvm/llvm-project/commit/7de1a17cc64bfcd1f0de055682d562dfb6476fb2 DIFF: https://github.com/llvm/llvm-project/commit/7de1a17cc64bfcd1f0de055682d562dfb6476fb2.d

[clang-tools-extra] [clang-tidy] Fix `modernize-use-scoped-lock` crash on malformed code (PR #165127)

2025-10-27 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook closed https://github.com/llvm/llvm-project/pull/165127 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][readability-redundant-parentheses] add option to prevent widely used work around (PR #164827)

2025-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/164827 >From 525b01535ccde73b341231fccf4d493fc1433914 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 23 Oct 2025 22:36:40 +0800 Subject: [PATCH 1/4] [clang-tidy][readability-redundant-parentheses] add opti

[clang-tools-extra] [clang-tidy] Add more constexpr options to `readability-identifier-naming` (PR #162160)

2025-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/162160 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] d63983b - [clang-tidy] Add more constexpr options to `readability-identifier-naming` (#162160)

2025-10-27 Thread via cfe-commits
Author: Alex White Date: 2025-10-28T10:54:34+08:00 New Revision: d63983b2c47befd34121de19320a778b97e5c520 URL: https://github.com/llvm/llvm-project/commit/d63983b2c47befd34121de19320a778b97e5c520 DIFF: https://github.com/llvm/llvm-project/commit/d63983b2c47befd34121de19320a778b97e5c520.diff LO

[clang-tools-extra] [clang-tidy] Fix `modernize-use-scoped-lock` crash on malformed code (PR #165127)

2025-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/165127 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > BTW, have you tested it with bootstrapped build? > > no, but honestly my success rate at simply getting a trivial bootstrap build > to work has not been great :-/ I can try to make it. https://github.com/llvm/llvm-project/pull/165341 _

[clang] [clang-tools-extra] [llvm] [clang]: reflection operator parsing for global namespace and primitive types (PR #164692)

2025-10-27 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/164692 error: too big or took too long to generate ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [llvm] Rename wasm32-wasi to wasm32-wasip1. (PR #165345)

2025-10-27 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode updated https://github.com/llvm/llvm-project/pull/165345 >From 4809631f529f6f83105d97a4ecbe7c8312f2c5fd Mon Sep 17 00:00:00 2001 From: Dan Gohman Date: Mon, 27 Oct 2025 19:13:17 -0700 Subject: [PATCH 1/2] Rename wasm32-wasi to wasm32-wasip1. This adds code to rec

[clang] [llvm] Rename wasm32-wasi to wasm32-wasip1. (PR #165345)

2025-10-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff origin/main HEAD --extensions cpp,h -- clang/lib/Basic/Targets.cpp clang/lib/Basic/Ta

[clang] [llvm] Rename wasm32-wasi to wasm32-wasip1. (PR #165345)

2025-10-27 Thread Dan Gohman via cfe-commits
https://github.com/sunfishcode created https://github.com/llvm/llvm-project/pull/165345 This adds code to recognize "wasm32-wasip1", "wasm32-wasip2", and "wasm32-wasip3" as explicit targets, and adds a deprecation warning when the "wasm32-wasi" target is used, pointing users to the "wasm32-was

[clang-tools-extra] [clang-tidy] Rename 'cert-err60-cpp' to 'bugprone-exception-type-not-nothrow-copy-constructible' (PR #164061)

2025-10-27 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/164061 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Rename 'cert-err60-cpp' to 'bugprone-exception-type-not-nothrow-copy-constructible' (PR #164061)

2025-10-27 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: What do you think about `nothrow-copy-constructible-exception-object`? I ask AI to generate 10 names and select the best from them. 😆 https://github.com/llvm/llvm-project/pull/164061 ___ cfe-commits mailing list [email protected]

[clang] [Clang][Driver] Enable offloadlib option for clang-cl (PR #162980)

2025-10-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/23253 Here is the relevant piece o

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Oliver Hunt via cfe-commits
ojhunt wrote: > BTW, have you tested it with bootstrapped build? no, but honestly my success rate at simply getting a trivial bootstrap build to work has not been great :-/ https://github.com/llvm/llvm-project/pull/165341 ___ cfe-commits mailing list

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/165341 >From f2b5020e406c521dd185659c04817be0e5c97e3e Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Mon, 27 Oct 2025 15:12:17 -0700 Subject: [PATCH 1/2] [clang] Allow devirtualisation of indirect calls to final virt

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Oliver Hunt via cfe-commits
@@ -1316,7 +1316,17 @@ void CodeGenFunction::StartFunction(GlobalDecl GD, QualType RetTy, // fast register allocator would be happier... CXXThisValue = CXXABIThisValue; } - +if (CGM.getCodeGenOpts().StrictVTablePointers) { + const CXXRecordDecl *ThisRe

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: BTW, have you tested it with bootstrapped build? https://github.com/llvm/llvm-project/pull/165341 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [tysan] Type Sanitizer support for SystemZ (PR #162396)

2025-10-27 Thread via cfe-commits
https://github.com/anoopkg6 edited https://github.com/llvm/llvm-project/pull/162396 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Chuanqi Xu via cfe-commits
@@ -0,0 +1,95 @@ +// RUN: %clang_cc1 -std=c++26 %s -emit-llvm -O3 -o - | FileCheck %s +// RUN: %clang_cc1 -std=c++26 %s -emit-llvm -O3 -fstrict-vtable-pointers -o - | FileCheck %s --check-prefix=STRICT ChuanqiXu9 wrote: Maybe we don't n

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Chuanqi Xu via cfe-commits
@@ -1316,7 +1316,17 @@ void CodeGenFunction::StartFunction(GlobalDecl GD, QualType RetTy, // fast register allocator would be happier... CXXThisValue = CXXABIThisValue; } - +if (CGM.getCodeGenOpts().StrictVTablePointers) { + const CXXRecordDecl *ThisRe

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/165341 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 commented: LGTM generally, thanks. https://github.com/llvm/llvm-project/pull/165341 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Fix include guard typo in hlsl_compat_overloads.h (PR #164540)

2025-10-27 Thread Krisitan Erik Olsen via cfe-commits
https://github.com/Kristianerik updated https://github.com/llvm/llvm-project/pull/164540 >From ea81ce0fb2440d0b12497fca7adfd08f3043f31e Mon Sep 17 00:00:00 2001 From: Kristianerik <[email protected]> Date: Tue, 21 Oct 2025 19:01:36 -0700 Subject: [PATCH] Fix include

[clang] [llvm] [CGObjC] Allow clang.arc.attachedcall on -O0 (PR #164875)

2025-10-27 Thread via cfe-commits
AZero13 wrote: > Okay, what you're saying is that this is now supported in GlobalISel, so we > can use it in -O0 on the same architectures that use it for -O? If so, great, > let's remove the -O0 condition. Already did! https://github.com/llvm/llvm-project/pull/164875

[clang] [llvm] [CGObjC] Allow clang.arc.attachedcall on -O0 (PR #164875)

2025-10-27 Thread via cfe-commits
AZero13 wrote: Yes I did do that. @rjmcall https://github.com/llvm/llvm-project/pull/164875 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [clang] Move options from clangDriver into new clangOptions library (NFC) (PR #163659)

2025-10-27 Thread Naveen Seth Hanig via cfe-commits
naveen-seth wrote: Note: Linux AArch64 CI is currently having trouble (failing everywhere), which is why this isn't passing all checks. https://github.com/llvm/llvm-project/pull/163659 ___ cfe-commits mailing list [email protected] https://li

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [clang] Remove clangDriver dependency from clangFrontend (NFC) (PR #165277)

2025-10-27 Thread Naveen Seth Hanig via cfe-commits
naveen-seth wrote: Note: Linux AArch64 CI is currently having trouble (failing everywhere), which is why this isn't passing all checks. https://github.com/llvm/llvm-project/pull/165277 ___ cfe-commits mailing list [email protected] https://li

[clang] [Clang][Driver] Enable offloadlib option for clang-cl (PR #162980)

2025-10-27 Thread via cfe-commits
https://github.com/jinge90 closed https://github.com/llvm/llvm-project/pull/162980 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0ece134 - [Clang][Driver] Enable offloadlib option for clang-cl (#162980)

2025-10-27 Thread via cfe-commits
Author: jinge90 Date: 2025-10-28T09:10:28+08:00 New Revision: 0ece134031c5e442103db25985c4a36b338127bb URL: https://github.com/llvm/llvm-project/commit/0ece134031c5e442103db25985c4a36b338127bb DIFF: https://github.com/llvm/llvm-project/commit/0ece134031c5e442103db25985c4a36b338127bb.diff LOG:

[clang] [clang][docs] assert.h is not a good candidate for a textual header (PR #165057)

2025-10-27 Thread Richard Smith via cfe-commits
zygoloid wrote: > We've (Apple) found `textual header`s to be very limited in practice. > Basically they can't cause a declaration to exist in multiple modules. Swift > will see those declarations as distinct because the module name is part of > the type/function name, and as distinct things t

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/165341 When -fstrict-vtable-pointers is set we can devirtualise calls to virtual functions when called indirectly through a separate function that does not locally know the exact type it is operating on. This only permi

[clang] [clang] Allow devirtualisation of indirect calls to final virtual methods (PR #165341)

2025-10-27 Thread Oliver Hunt via cfe-commits
ojhunt wrote: @ChuanqiXu9 I'm sure this will change codegen for existing tests so am running all of them atm, but I thought you should have a look at this. https://github.com/llvm/llvm-project/pull/165341 ___ cfe-commits mailing list cfe-commits@lists

[clang] [clang-tools-extra] [llvm] [clang]: reflection operator parsing for global namespace and primitive types (PR #164692)

2025-10-27 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/164692 error: too big or took too long to generate ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang-tools-extra] [llvm] [clang]: reflection operator parsing for global namespace and primitive types (PR #164692)

2025-10-27 Thread Nhat Nguyen via cfe-commits
https://github.com/changkhothuychung updated https://github.com/llvm/llvm-project/pull/164692 error: too big or took too long to generate ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[libunwind] [libunwind] Fix execution flow imbalance when using C++ Exceptions (PR #165066)

2025-10-27 Thread Oliver Hunt via cfe-commits
@@ -20,6 +20,7 @@ #include <__libunwind_config.h> +// clang-format off ojhunt wrote: ditto https://github.com/llvm/llvm-project/pull/165066 ___ cfe-commits mailing list [email protected] https://lists.llv

[libunwind] [libunwind] Fix execution flow imbalance when using C++ Exceptions (PR #165066)

2025-10-27 Thread Oliver Hunt via cfe-commits
@@ -28,6 +29,9 @@ #define _LIBUNWIND_SUPPORT_COMPACT_UNWIND 1 #define _LIBUNWIND_SUPPORT_DWARF_UNWIND 1 #endif + #if (defined(__aarch64__) || defined(__arm64__) || defined(__arm64e__)) ojhunt wrote: ditto on the ()s - I feel there should be a single

[libunwind] [libunwind] Fix execution flow imbalance when using C++ Exceptions (PR #165066)

2025-10-27 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt commented: mostly just nits https://github.com/llvm/llvm-project/pull/165066 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix execution flow imbalance when using C++ Exceptions (PR #165066)

2025-10-27 Thread Oliver Hunt via cfe-commits
@@ -132,6 +133,10 @@ #if defined(__APPLE__) +#if (defined(__aarch64__) || defined(__arm64__) || defined(__arm64e__)) ojhunt wrote: nit: don't need the outer ()s https://github.com/llvm/llvm-project/pull/165066 ___

[libunwind] [libunwind] Fix execution flow imbalance when using C++ Exceptions (PR #165066)

2025-10-27 Thread Oliver Hunt via cfe-commits
@@ -15,6 +15,7 @@ #ifndef UNWIND_ASSEMBLY_H #define UNWIND_ASSEMBLY_H +// clang-format off ojhunt wrote: I recognize clang format struggles with these files, but I think this change shouldn't be part of this PR https://github.com/llvm/llvm-project/pull/1650

[libunwind] [libunwind] Fix execution flow imbalance when using C++ Exceptions (PR #165066)

2025-10-27 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt edited https://github.com/llvm/llvm-project/pull/165066 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Support Zvfofp4min assembler version 0.1 (PR #164820)

2025-10-27 Thread Craig Topper via cfe-commits
https://github.com/topperc requested changes to this pull request. Missing update of RISCVUsage.rst https://github.com/llvm/llvm-project/pull/164820 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] workflows/release-binaries: Disable flang on Darwin (PR #164667)

2025-10-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64le-linux-multistage` running on `ppc64le-clang-multistage-test` while building `.github,clang` at step 10 "build stage 2". Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/13305 H

[clang] [clang][docs] assert.h is not a good candidate for a textual header (PR #165057)

2025-10-27 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > The problem is that there's a lot of code that uses `` in a modular > way, only defining `NDEBUG` on the command line, but there's also a lot of > code that does `#define NDEBUG`. Only one of these ways can practicably work > in a module. > > Maybe it would be best

[clang] [llvm] [CGObjC] Allow clang.arc.attachedcall on -O0 (PR #164875)

2025-10-27 Thread John McCall via cfe-commits
rjmccall wrote: Okay, what you're saying is that this is now supported in GlobalISel, so we can use it in -O0 on the same architectures that use it for -O? If so, great, let's remove the -O0 condition. https://github.com/llvm/llvm-project/pull/164875 ___

[clang-tools-extra] [clang-tidy] Fix param-pack fix-its for 'performance-unnecessary-value-param' check (PR #164130)

2025-10-27 Thread Victor Chernyakin via cfe-commits
https://github.com/localspook approved this pull request. https://github.com/llvm/llvm-project/pull/164130 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] assert.h is not a good candidate for a textual header (PR #165057)

2025-10-27 Thread Michael Spencer via cfe-commits
Bigcheese wrote: The problem is that there's a lot of code that uses `` in a modular way, only defining `NDEBUG` on the command line, but there's also a lot of code that does `#define NDEBUG`. Only one of these ways can practicably work in a module. Maybe it would be best if we had a way to k

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-10-27 Thread Dasha Buka via cfe-commits
https://github.com/dvbuka updated https://github.com/llvm/llvm-project/pull/164566 >From 4640cf73b874a90acd4799b6a710d6139fcd08cb Mon Sep 17 00:00:00 2001 From: Dasha Buka <[email protected]> Date: Wed, 22 Oct 2025 00:17:46 -0700 Subject: [PATCH 1/8] Move check cert-oop58

[clang-tools-extra] [Docs][clang-tools-extra] Convert maintainers list to .rst format (PR #165171)

2025-10-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/165171 >From c356294a81d884e0fbfc7fe6260c39ec82c2729b Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sun, 26 Oct 2025 23:19:21 +0300 Subject: [PATCH 1/3] [clang-tools-extra] Convert maintainers list to .rst form

[clang-tools-extra] [clang-tidy][NFC] Fix various clang-tidy warning on headers 1/N (PR #165175)

2025-10-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang-tools-extra` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/24598 Here is the

[clang] [clang][docs] assert.h is not a good candidate for a textual header (PR #165057)

2025-10-27 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > > Sure, but if you can't include `` from a modular header, then > > that basically means `` can't itself be a modular header. > > What do you mean by "modular header" here? The terminology I'm familiar with > considers textual headers and modular headers to be mutual

[clang-tools-extra] [clang-tidy] Rename 'cert-err60-cpp' to 'bugprone-exception-type-not-nothrow-copy-constructible' (PR #164061)

2025-10-27 Thread Baranov Victor via cfe-commits
vbvictor wrote: @HerrCai0907, @carlosgalvezp I'm not 100% happy with the name, but It's the best I could think of. Could you verify check name or maybe have some ideas about it? https://github.com/llvm/llvm-project/pull/164061 ___ cfe-commits mailing

[clang-tools-extra] [Docs][clang-tools-extra] Convert maintainers list to .rst format (PR #165171)

2025-10-27 Thread via cfe-commits
@@ -2,9 +2,13 @@ Clang Tools Extra Maintainers = -This file is a list of the maintainers -(https://llvm.org/docs/DeveloperPolicy.html#maintainers) for clang-tools-extra. +This file is a list of the +`maintainers

[clang-tools-extra] [clang-tidy] Add fine-graded configuration for 'bugprone-exception-escape' (PR #164081)

2025-10-27 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping, should be easy NFC-ish patch https://github.com/llvm/llvm-project/pull/164081 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][Driver] Enable -pie and -no-pie in flang's driver (PR #164890)

2025-10-27 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > The test passed on Both AIX and LoP. Thanks. Thanks for checking Daniel. And apologies for not responding to your first question about the patch not applying. I got tangled up with other things. https://github.com/llvm/llvm-project/pull/164890 _

[clang-tools-extra] [clang-tidy] Fix param-pack fix-its for 'performance-unnecessary-value-param' check (PR #164130)

2025-10-27 Thread Baranov Victor via cfe-commits
vbvictor wrote: Ping, should be easy patch https://github.com/llvm/llvm-project/pull/164130 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][clang-tools-extra] Convert maintainers list to .rst format (PR #165171)

2025-10-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/165171 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][clang-tools-extra] Convert maintainers list to .rst format (PR #165171)

2025-10-27 Thread Baranov Victor via cfe-commits
@@ -2,9 +2,13 @@ Clang Tools Extra Maintainers = -This file is a list of the maintainers -(https://llvm.org/docs/DeveloperPolicy.html#maintainers) for clang-tools-extra. +This file is a list of the +`maintainers

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop58-cpp' to 'bugprone-copy-constructor-mutates-argument' (PR #164566)

2025-10-27 Thread Dasha Buka via cfe-commits
https://github.com/dvbuka updated https://github.com/llvm/llvm-project/pull/164566 >From 4640cf73b874a90acd4799b6a710d6139fcd08cb Mon Sep 17 00:00:00 2001 From: Dasha Buka <[email protected]> Date: Wed, 22 Oct 2025 00:17:46 -0700 Subject: [PATCH 1/7] Move check cert-oop58

[clang-tools-extra] [clang-tidy] Emit warnings from user headers by default (PR #164165)

2025-10-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/164165 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Emit warnings from user headers by default (PR #164165)

2025-10-27 Thread Baranov Victor via cfe-commits
@@ -133,13 +133,15 @@ file, if any. static cl::opt HeaderFilter("header-filter", desc(R"( Regular expression matching the names of the headers to output diagnostics from. Diagnostics -from the main file of each translation unit are -always displayed. +from the main file and all

[clang-tools-extra] [Docs][clang-tools-extra] Convert maintainers list to .rst format (PR #165171)

2025-10-27 Thread via cfe-commits
@@ -2,9 +2,13 @@ Clang Tools Extra Maintainers = -This file is a list of the maintainers -(https://llvm.org/docs/DeveloperPolicy.html#maintainers) for clang-tools-extra. +This file is a list of the +`maintainers

[clang-tools-extra] [Docs][clang-tools-extra] Convert maintainers list to .rst format (PR #165171)

2025-10-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/165171 >From c356294a81d884e0fbfc7fe6260c39ec82c2729b Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Sun, 26 Oct 2025 23:19:21 +0300 Subject: [PATCH 1/2] [clang-tools-extra] Convert maintainers list to .rst form

[clang-tools-extra] [Docs][clang-tools-extra] Convert maintainers list to .rst format (PR #165171)

2025-10-27 Thread Baranov Victor via cfe-commits
@@ -2,9 +2,13 @@ Clang Tools Extra Maintainers = -This file is a list of the maintainers -(https://llvm.org/docs/DeveloperPolicy.html#maintainers) for clang-tools-extra. +This file is a list of the +`maintainers

[clang-tools-extra] 676d3b8 - [clang-tidy][NFC] Fix various clang-tidy warning on headers 1/N (#165175)

2025-10-27 Thread via cfe-commits
Author: Baranov Victor Date: 2025-10-28T01:32:58+03:00 New Revision: 676d3b881b0b5b39ce74f83e9a924ab05384035c URL: https://github.com/llvm/llvm-project/commit/676d3b881b0b5b39ce74f83e9a924ab05384035c DIFF: https://github.com/llvm/llvm-project/commit/676d3b881b0b5b39ce74f83e9a924ab05384035c.diff

[clang-tools-extra] [clang-tidy][NFC] Fix various clang-tidy warning on headers 1/N (PR #165175)

2025-10-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor closed https://github.com/llvm/llvm-project/pull/165175 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-10-27 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,41 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][CodeGen][CIR][NFC] Refactor CGCXXABI classes for code sharing (PR #165078)

2025-10-27 Thread Oliver Hunt via cfe-commits
@@ -0,0 +1,99 @@ +//===- CXXABIShared.h - Shared C++ ABI Base Class ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang] Support header shadowing diagnostics in Clang header search (PR #162491)

2025-10-27 Thread Tom Honermann via cfe-commits
tahonermann wrote: I haven't taken the time to fully comprehend the source code changes and I'm not fully clear on the intent for this diagnostic. Additional test cases might help to make it clear. For example, is the intent that a diagnostic would be issued for a case like this? ``` $ cat t.c

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop57-cpp' to 'bugprone-raw-memory-call-on-non-trivial-type' (PR #162039)

2025-10-27 Thread Dasha Buka via cfe-commits
https://github.com/dvbuka reopened https://github.com/llvm/llvm-project/pull/162039 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Rename and move 'cert-oop57-cpp' to 'bugprone-raw-memory-call-on-non-trivial-type' (PR #162039)

2025-10-27 Thread Dasha Buka via cfe-commits
https://github.com/dvbuka updated https://github.com/llvm/llvm-project/pull/162039 >From 6f679f0f80efafba84a8cf73a651b603b1559707 Mon Sep 17 00:00:00 2001 From: Dasha Buka <[email protected]> Date: Mon, 27 Oct 2025 15:23:52 -0700 Subject: [PATCH] Update cert-oop57-cpp to

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-10-27 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,38 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-10-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/162361 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-10-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/162361 ___ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add new check 'bugprone-inconsistent-ifelse-braces' (PR #162361)

2025-10-27 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,38 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang][CodeGen][CIR][NFC] Refactor CGCXXABI classes for code sharing (PR #165078)

2025-10-27 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,99 @@ +//===- CXXABIShared.h - Shared C++ ABI Base Class ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

  1   2   3   4   5   >