[clang] [clang-format] Add IgnoreExtension to SortIncludes (PR #137840)

2025-07-16 Thread Daan De Meyer via cfe-commits
DaanDeMeyer wrote: @owenca @mydeveloperday @HazardyKnusperkeks Can any of you merge this? I don't have commit rights https://github.com/llvm/llvm-project/pull/137840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [compiler-rt] [llvm-cov] Add gap region between binary operator '&& and ||' and RHS (PR #149085)

2025-07-16 Thread via cfe-commits
https://github.com/int-zjt updated https://github.com/llvm/llvm-project/pull/149085 >From 763293b20bb79bb28c0187edc4b282a1536993dc Mon Sep 17 00:00:00 2001 From: int-zjt Date: Wed, 16 Jul 2025 19:03:11 +0800 Subject: [PATCH 1/3] [llvm-cov] Add gap region after binary operator && and || --- cl

[clang-tools-extra] [clang-tidy][NFC] Enable 'performance-move-const-arg' in '.clang-tidy' config (PR #148549)

2025-07-16 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: Are they really need to "std::move" in the patch? I think `MixData` is meaningless since it is still need to copy all field. https://github.com/llvm/llvm-project/pull/148549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang][Driver] Prefer non-Linux emulations for baremetal Arm/AArch64… (PR #149235)

2025-07-16 Thread Jonathon Penix via cfe-commits
https://github.com/jonathonpenix updated https://github.com/llvm/llvm-project/pull/149235 >From eb234c6c2d132d47034195a361f9f5c7b3a70d38 Mon Sep 17 00:00:00 2001 From: Jonathon Penix Date: Tue, 15 Jul 2025 11:50:52 -0700 Subject: [PATCH] [clang][Driver] Prefer non-Linux emulations for baremetal

[clang-tools-extra] [clang-tidy] Improve `bugprone-infinite-loop` check by adding handing for structured bindings (PR #144213)

2025-07-16 Thread Congcong Cai via cfe-commits
@@ -83,6 +83,23 @@ static bool isVarThatIsPossiblyChanged(const Decl *Func, const Stmt *LoopStmt, isChanged(LoopStmt, Var, Context); // FIXME: Track references. } + +if (const auto *BD = dyn_cast(DRE->getDecl())) { + if (const auto *DD = +

[clang-tools-extra] [clang-tidy] Improve `bugprone-infinite-loop` check by adding handing for structured bindings (PR #144213)

2025-07-16 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM except nit https://github.com/llvm/llvm-project/pull/144213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve `bugprone-infinite-loop` check by adding handing for structured bindings (PR #144213)

2025-07-16 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/144213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm-cov] Add gap region between binary operator '&& and ||' and RHS (PR #149085)

2025-07-16 Thread Mingjie Xu via cfe-commits
Enna1 wrote: Clang :: CoverageMapping/logical.cpp test failed https://github.com/llvm/llvm-project/pull/149085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Do not treat Foo -> const Foo conversion sequences as perfect (PR #148613)

2025-07-16 Thread Corentin Jabot via cfe-commits
cor3ntin wrote: Thanks for the heads up! I'm looking into it. Reduced to ```cpp struct TmsException { int _what; const char* what() const; template int& what() & { return _what; } }; int main() { TmsException E; E.what() = 42; }``` https://github.com/llvm/llvm-project/pull/148613

[clang] [Sema] Remove unnecessary casts (NFC) (PR #149253)

2025-07-16 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/149253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Remove unnecessary casts (NFC) (PR #149253)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes getParam already returns NamedDecl *. --- Full diff: https://github.com/llvm/llvm-project/pull/149253.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaTemplateDeduction.cpp (+3-5) `

[clang] [Sema] Remove unnecessary casts (NFC) (PR #149253)

2025-07-16 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/149253 getParam already returns NamedDecl *. >From 2f93bbada1bdc3980948fc6e147542af5e937400 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 15 Jul 2025 09:12:18 -0700 Subject: [PATCH] [Sema] Remove unnec

[clang] [Clang][OpenMP] Fixing Clang error for metadirective with multiple when clauses and no otherwise (PR #148583)

2025-07-16 Thread via cfe-commits
Ritanya-B-Bharadwaj wrote: > You need to add a LIT test. Done! https://github.com/llvm/llvm-project/pull/148583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Fixing Clang error for metadirective with multiple when clauses and no otherwise (PR #148583)

2025-07-16 Thread via cfe-commits
https://github.com/Ritanya-B-Bharadwaj updated https://github.com/llvm/llvm-project/pull/148583 >From cc247bc1eb330dd2d3ccebabc7c1d3b524073627 Mon Sep 17 00:00:00 2001 From: Ritanya B Bharadwaj Date: Mon, 14 Jul 2025 03:18:25 -0500 Subject: [PATCH 1/2] [Clang][OpenMP] Fixing error - 147336 ---

[libclc] [NFC][libclc] Delete clc/include/clc/relational/floatn.inc (PR #149252)

2025-07-16 Thread Wenju He via cfe-commits
https://github.com/wenju-he created https://github.com/llvm/llvm-project/pull/149252 llvm-diff shows no change to amdgcn--amdhsa.bc. >From 91827fa45fbf45936e57241b0bb0c1a215112834 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Thu, 17 Jul 2025 07:27:50 +0200 Subject: [PATCH] [NFC][libclc] Delet

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-07-16 Thread via cfe-commits
pirama-arumuga-nainar wrote: > We would be happy to consult and review Android related changes (e.g. > sanitizers) if needed. Correct, we are not actively investigating memprof on Android but would be happy to see/support any work in this area. https://github.com/llvm/llvm-project/pull/14288

[libclc] [libclc] Add generic implementation of bitfield_insert/extract,bit_reverse (PR #149070)

2025-07-16 Thread Wenju He via cfe-commits
https://github.com/wenju-he updated https://github.com/llvm/llvm-project/pull/149070 >From 9f8b12e6cf600cd05bab586e3d521e5354789e12 Mon Sep 17 00:00:00 2001 From: Wenju He Date: Wed, 16 Jul 2025 12:44:48 +0200 Subject: [PATCH 1/3] [libclc] Add generic implementation of bitfield_insert/extract,

[clang] [clang-format] Handle templates in qualified typenames (PR #143194)

2025-07-16 Thread Owen Pan via cfe-commits
@@ -3630,6 +3630,36 @@ static unsigned maxNestingDepth(const AnnotatedLine &Line) { return Result; } +// Returns the token after the first qualifier of the name, or nullptr if there +// is no qualifier. +static FormatToken* skipNameQualifier(const FormatToken *Tok) { --

[clang] [clang-format] Handle templates in qualified typenames (PR #143194)

2025-07-16 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/143194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle templates in qualified typenames (PR #143194)

2025-07-16 Thread Owen Pan via cfe-commits
https://github.com/owenca requested changes to this pull request. Please run `ninja clang-format-check-format` before `git push`. Also, run `ninja polly-check-format`, which gives the assertion failure below: ``` Assertion failed: (Tok->is(TT_TemplateOpener)), function getFunctionName, file Tok

[clang] [clang][docs] Fix example in SanitizerSpecialCaseList.rst (PR #149244)

2025-07-16 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/149244 As-ie example suppresses buffer overflow in malloc, and leave memory leak in place. It can be confusing. Fixes #62421. >From f885749699d886d77d8290ca250276704e677dd7 Mon Sep 17 00:00:00 2001 From: Vitaly Bu

[clang] [Sanitize] fix crash in -fsanitize-annotate-debug-info (PR #149237)

2025-07-16 Thread Thurston Dang via cfe-commits
@@ -6480,20 +6480,23 @@ SanitizerOrdinalToCheckLabel(SanitizerKind::SanitizerOrdinal Ordinal) { llvm::DILocation *CodeGenFunction::SanitizerAnnotateDebugInfo( ArrayRef Ordinals, SanitizerHandler Handler) { + llvm::DILocation *CheckDI = Builder.getCurrentDebugLocation(

[clang] [Sanitize] fix crash in -fsanitize-annotate-debug-info (PR #149237)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Florian Mayer (fmayer) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/149237.diff 2 Files Affected: - (modified) clang/lib/CodeGen/CGDebugInfo.cpp (+6-3) - (added) clang/test/CodeGen/null-sanitizer-debug-info

[clang] [Sanitize] fix crash in -fsanitize-annotate-debug-info (PR #149237)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Florian Mayer (fmayer) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/149237.diff 2 Files Affected: - (modified) clang/lib/CodeGen/CGDebugInfo.cpp (+6-3) - (added) clang/test/CodeGen/null-sanitizer-debug-info-regress

[clang] [Sanitize] fix crash in -fsanitize-annotate-debug-info (PR #149237)

2025-07-16 Thread Florian Mayer via cfe-commits
https://github.com/fmayer ready_for_review https://github.com/llvm/llvm-project/pull/149237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sanitize] fix crash in -fsanitize-annotate-debug-info (PR #149237)

2025-07-16 Thread Florian Mayer via cfe-commits
https://github.com/fmayer created https://github.com/llvm/llvm-project/pull/149237 None >From 6324602575fc5310b5ff49bfcb985d531035811b Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Wed, 16 Jul 2025 20:00:45 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=

[clang] [compiler-rt] [llvm-cov] Add gap region between binary operator '&& and ||' and RHS (PR #149085)

2025-07-16 Thread via cfe-commits
https://github.com/int-zjt updated https://github.com/llvm/llvm-project/pull/149085 >From 763293b20bb79bb28c0187edc4b282a1536993dc Mon Sep 17 00:00:00 2001 From: int-zjt Date: Wed, 16 Jul 2025 19:03:11 +0800 Subject: [PATCH 1/2] [llvm-cov] Add gap region after binary operator && and || --- cl

[clang] [clang-format] Fix a regression of annotating PointerOrReference (PR #149039)

2025-07-16 Thread Owen Pan via cfe-commits
@@ -3122,6 +3122,9 @@ class AnnotatingParser { } } +if (PrevToken->isTypeName(LangOpts)) owenca wrote: It works if `TypeNames: [MyType]` is added to the config, but I've added a heuristic so that it won't be necessary. https://github.com/llvm/

[clang] [clang-format] Fix a regression of annotating PointerOrReference (PR #149039)

2025-07-16 Thread Owen Pan via cfe-commits
https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/149039 >From 2418846a33683555f2e14de91aa42c1ec38b3fdb Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Wed, 16 Jul 2025 01:59:40 -0700 Subject: [PATCH 1/2] [clang-format] Fix a regression of annotating PointerOrReference

[clang] Check if clang::FieldDecl has constant-integer bit width before getting the width (PR #148692)

2025-07-16 Thread Shafik Yaghmour via cfe-commits
@@ -709,7 +709,8 @@ AST_MATCHER(FieldDecl, isBitField) { /// fieldDecl(hasBitWidth(2)) /// matches 'int a;' and 'int c;' but not 'int b;'. AST_MATCHER_P(FieldDecl, hasBitWidth, unsigned, Width) { - return Node.isBitField() && Node.getBitWidthValue() == Width; + return Node.

[clang] [Clang] Fix FE crash during CGCoroutine GRO Alloca Emission (PR #148962)

2025-07-16 Thread via cfe-commits
llvmbot wrote: Failed to cherry-pick: c36156d` https://github.com/llvm/llvm-project/actions/runs/16333601152 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare) https://github.com/

[clang] [SPIR] Set MaxAtomicInlineWidth minimum size to 32 for spir32 and 64 for spir64 (PR #148997)

2025-07-16 Thread Wenju He via cfe-commits
https://github.com/wenju-he closed https://github.com/llvm/llvm-project/pull/148997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR] Set MaxAtomicInlineWidth minimum size to 32 for spir32 and 64 for spir64 (PR #148997)

2025-07-16 Thread Wenju He via cfe-commits
https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/148997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b413982 - [SPIR] Set MaxAtomicInlineWidth minimum size to 32 for spir32 and 64 for spir64 (#148997)

2025-07-16 Thread via cfe-commits
Author: Wenju He Date: 2025-07-17T09:02:10+08:00 New Revision: b41398294c85eacdb37b9637eed6f0e91edf35cf URL: https://github.com/llvm/llvm-project/commit/b41398294c85eacdb37b9637eed6f0e91edf35cf DIFF: https://github.com/llvm/llvm-project/commit/b41398294c85eacdb37b9637eed6f0e91edf35cf.diff LOG:

[clang] [SPIR] Set MaxAtomicInlineWidth minimum size to 32 for spir32 and 64 for spir64 (PR #148997)

2025-07-16 Thread Wenju He via cfe-commits
https://github.com/wenju-he edited https://github.com/llvm/llvm-project/pull/148997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-07-16 Thread Ryotaro Kasuga via cfe-commits
kasuga-fj wrote: Thanks for the reviews! https://github.com/llvm/llvm-project/pull/135163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (PR #135163)

2025-07-16 Thread Ryotaro Kasuga via cfe-commits
https://github.com/kasuga-fj closed https://github.com/llvm/llvm-project/pull/135163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0692572 - [clang][CodeGen] Fix metadata when vectorization is disabled by pragma (#135163)

2025-07-16 Thread via cfe-commits
Author: Ryotaro Kasuga Date: 2025-07-17T10:01:10+09:00 New Revision: 0692572e040979b2de0dceb8f0537aa16caf351f URL: https://github.com/llvm/llvm-project/commit/0692572e040979b2de0dceb8f0537aa16caf351f DIFF: https://github.com/llvm/llvm-project/commit/0692572e040979b2de0dceb8f0537aa16caf351f.diff

[clang] Ensure proper NULL macro definition for system include files. (PR #149176)

2025-07-16 Thread Hubert Tong via cfe-commits
@@ -39,6 +39,25 @@ set(core_files varargs.h ) +set(aix_wrapper_files + dbm.h + stdio.h + stdlib.h + string.h + time.h + unistd.h + wchar.h + ) hubert-reinterpretcast wrote: At least `locale.h` was also affected. https://github.com/llvm/llvm-proje

[clang] [Clang] Fix FE crash during CGCoroutine GRO Alloca Emission (PR #148962)

2025-07-16 Thread Adrian Vogelsgesang via cfe-commits
vogelsgesang wrote: > Would like to. Please advise next steps. efriedma already took care of creating the PR for the backport via the `/cherry-pick c36156d` command. It's now up to the original approver (@bcardosolopes) to also approve that backport PR. The goal of that second review is prima

[clang] [Clang][AMDGPU] Add builtins for some buffer resource atomics (PR #149216)

2025-07-16 Thread Shilei Tian via cfe-commits
@@ -252,6 +252,15 @@ TARGET_BUILTIN(__builtin_amdgcn_flat_atomic_fmax_f64, "dd*0d", "t", "gfx90a-inst TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_f64, "dd*3d", "t", "gfx90a-insts") TARGET_BUILTIN(__builtin_amdgcn_ds_atomic_fadd_f32, "ff*3f", "t", "gfx8-insts") +TARGET_BUI

[clang] [llvm] [AMDGPU] Add support for `v_exp_bf16` on gfx1250 (PR #149229)

2025-07-16 Thread Shilei Tian via cfe-commits
@@ -25,4 +25,27 @@ define amdgpu_ps void @llvm_log2_bf16_s(ptr addrspace(1) %out, bfloat inreg %src ret void } +define amdgpu_ps void @llvm_exp2_bf16_v(ptr addrspace(1) %out, bfloat %src) { +; GCN-LABEL: llvm_exp2_bf16_v: +; GCN: ; %bb.0: +; GCN-NEXT:v_exp_bf16_e3

[clang] [Clang][AMDGPU] Add builtins for some buffer resource atomics (PR #149216)

2025-07-16 Thread Anshil Gandhi via cfe-commits
https://github.com/gandhi56 approved this pull request. LGTM, assuming `gfx90a-insts` is the suitable attribute and there is another approval. https://github.com/llvm/llvm-project/pull/149216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [llvm] [AMDGPU] Add support for `v_exp_bf16` on gfx1250 (PR #149229)

2025-07-16 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,240 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5 arsenm wrote: Can you give this a bf16 suffix instead of bfloat, and add the other targets where it's not legal https://github.com/llvm/llvm

[clang] [lld] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-16 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/144745 >From e7ccf87561e090a224021e2223e36599396f6335 Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Fri, 13 Jun 2025 12:45:34 -0700 Subject: [PATCH] Fix IP2State tables style: revert one change Adjust tests ad

[clang] [Clang] Rework creating offloading toolchains (PR #125556)

2025-07-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/125556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Introduce '--offload-targets=' to generically target toolchains (PR #125556)

2025-07-16 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/125556 >From 543c6f63e087b8595fc5c6abfcb74cc982df476e Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 3 Feb 2025 12:46:27 -0600 Subject: [PATCH] [Clang] Introduce '--offload-targets=' to genericall target toolc

[clang] [Clang] Do not treat Foo -> const Foo conversion sequences as perfect (PR #148613)

2025-07-16 Thread Matthias Braun via cfe-commits
MatzeB wrote: FYI: This change breaks common thrift-generated code. Reduced example here shows the problem and produces "expression is not assignable" (but is accepted by all released gcc and clang versions as far as I can tell). No idea if the code is valid/invalid: ``` #include struct TmsEx

[clang] [CIR] Upstream Unary Inc/Dec for ComplexType (PR #149162)

2025-07-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. This looks good, but I'm asking for changes to make the tests more readable. https://github.com/llvm/llvm-project/pull/149162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [CIR] Upstream Unary Inc/Dec for ComplexType (PR #149162)

2025-07-16 Thread Andy Kaylor via cfe-commits
@@ -83,8 +83,204 @@ void foo2() { // OGCG: %[[A_REAL:.*]] = load float, ptr %[[A_REAL_PTR]], align 4 // OGCG: %[[A_IMAG_PTR:.*]] = getelementptr inbounds nuw { float, float }, ptr %[[COMPLEX]], i32 0, i32 1 // OGCG: %[[A_IMAG:.*]] = load float, ptr %[[A_IMAG_PTR]], align 4 -//

[clang] [CIR] Upstream Unary Inc/Dec for ComplexType (PR #149162)

2025-07-16 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor edited https://github.com/llvm/llvm-project/pull/149162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add support for `v_rsq_bf16` on gfx1250 (PR #149194)

2025-07-16 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec approved this pull request. https://github.com/llvm/llvm-project/pull/149194 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Add support for `v_rsq_bf16` on gfx1250 (PR #149194)

2025-07-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: undef deprecator found issues in your code. :warning: You can test this locally with the following command: ``bash git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD llvm/test/CodeGen/AMDGPU/l

[clang] [llvm] [AMDGPU] Add support for `v_rsq_bf16` on gfx1250 (PR #149194)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Shilei Tian (shiltian) Changes Co-authored-by: Mekhanoshin, Stanislav --- Patch is 69.61 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/149194.diff 23

[clang] [llvm] [AMDGPU] Add support for `v_rsq_bf16` on gfx1250 (PR #149194)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Author: Shilei Tian (shiltian) Changes Co-authored-by: Mekhanoshin, Stanislav --- Patch is 69.61 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/149194.diff 23 Files Affec

[clang] [llvm] [AMDGPU] Add support for `v_rsq_bf16` on gfx1250 (PR #149194)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shilei Tian (shiltian) Changes Co-authored-by: Mekhanoshin, Stanislav --- Patch is 69.61 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/149194.diff 23 Files Af

[clang] [llvm] [AMDGPU] Add support for `v_rsq_bf16` on gfx1250 (PR #149194)

2025-07-16 Thread Shilei Tian via cfe-commits
shiltian wrote: * **#149194** https://app.graphite.dev/github/pr/llvm/llvm-project/149194?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/149

[clang] [llvm] [AMDGPU] Add support for `v_rsq_bf16` on gfx1250 (PR #149194)

2025-07-16 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/149194 Co-authored-by: Mekhanoshin, Stanislav >From 296077854b4bcad36f9b924da1dbfe4376d8b4d5 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 16 Jul 2025 17:31:42 -0400 Subject: [PATCH] [AMDGPU] Add support for

[clang] [clang][deps] Properly capture the global module and '\n' for all module directives (PR #148685)

2025-07-16 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. Looks good to me, but I'd also like @akyrtzi to take a look if they have time. https://github.com/llvm/llvm-project/pull/148685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-16 Thread Jacques Pienaar via cfe-commits
jpienaar wrote: Good question. I think there are a few style things we could flag, but nothing planned. And this current one I'd assume lives for like 6-9 months and then we remove it. Having this flagged on commits to both MLIR & Flang to reduce migration need later. Well I know a couple of d

[clang] [LifetimeSafety] Revamp test suite using unittests (PR #149158)

2025-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/149158 >From 0311169154e4db2bb049168a1e73e3ae67d96848 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 16 Jul 2025 18:22:39 + Subject: [PATCH] [LifetimeSafety] Revamp test suite using unittests --- .../clan

[clang] [LifetimeSafety] Revamp test suite using unittests (PR #149158)

2025-07-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/unittests/Analysis/LifetimeSafetyTest.cpp cl

[clang] [LifetimeSafety] Revamp test suite using unittests (PR #149158)

2025-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/149158 >From 299ff3039df54ee9acc2a81a3204b43cad40f84e Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 16 Jul 2025 18:22:39 + Subject: [PATCH] [LifetimeSafety] Revamp test suite using unittests --- .../clan

[clang] [clang][deps] Properly capture the global module and '\n' for all module directives (PR #148685)

2025-07-16 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth edited https://github.com/llvm/llvm-project/pull/148685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Test SPE incompatibility with VSX (PR #147184)

2025-07-16 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/147184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-16 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: I agree that a new module seems unnecessary, do we know that it will contain more checks in the future? If not moving to llvm or plugins would perhaps be more suitable. https://github.com/llvm/llvm-project/pull/149148 ___ cfe-com

[clang] Ensure proper NULL macro definition for system include files. (PR #149176)

2025-07-16 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Developer Policy](https://llvm.org/docs/DeveloperPol

[clang] [clang][deps] Recognize 'module;' in dependency directive scanner (PR #148685)

2025-07-16 Thread Naveen Seth Hanig via cfe-commits
https://github.com/naveen-seth updated https://github.com/llvm/llvm-project/pull/148685 >From 7a759271c54b78eb940bf12274bcc535a3df22e3 Mon Sep 17 00:00:00 2001 From: Naveen Seth Hanig Date: Mon, 14 Jul 2025 19:17:10 +0200 Subject: [PATCH 1/3] [clang][deps] Recognize 'module;' in dependency dire

[clang] Ensure proper NULL macro definition for system include files. (PR #149176)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Jamie Schmeiser (jamieschmeiser) Changes The C standard allows for at least 2 valid definitions of a null pointer constant and mandates that several standard headers files define the macro NULL to be a null pointer constant. Ensure

[clang] Ensure proper NULL macro definition for system include files. (PR #149176)

2025-07-16 Thread Jamie Schmeiser via cfe-commits
https://github.com/jamieschmeiser created https://github.com/llvm/llvm-project/pull/149176 The C standard allows for at least 2 valid definitions of a null pointer constant and mandates that several standard headers files define the macro NULL to be a null pointer constant. Ensure that defini

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-16 Thread Jacques Pienaar via cfe-commits
jpienaar wrote: I considered placing it in LLVM module instead given part of LLVM project. https://github.com/llvm/llvm-project/pull/149148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [C++20][Modules] Implement P1857R3 Modules Dependency Discovery (PR #107168)

2025-07-16 Thread Michael Spencer via cfe-commits
Bigcheese wrote: > I have a question, when the input does not meet the restrictions of P1857R3, > do we need to fallback to the old parsing method to perform error recovery? Hmm, that would probably be the most useful. There's not any ambiguity about what the user meant by: ``` import a; ```

[clang] Allow packing fields into tail padding of record fields (PR #122197)

2025-07-16 Thread Reid Kleckner via cfe-commits
@@ -803,10 +804,16 @@ bool ConstStructBuilder::Build(const InitListExpr *ILE, bool AllowOverwrite) { if (!AppendField(Field, Layout.getFieldOffset(FieldNo), EltInit, AllowOverwrite)) return false; - // After emitting a non-empty field

[clang] Allow packing fields into tail padding of record fields (PR #122197)

2025-07-16 Thread Reid Kleckner via cfe-commits
@@ -803,10 +804,16 @@ bool ConstStructBuilder::Build(const InitListExpr *ILE, bool AllowOverwrite) { if (!AppendField(Field, Layout.getFieldOffset(FieldNo), EltInit, AllowOverwrite)) return false; - // After emitting a non-empty field

[clang] Allow packing fields into tail padding of record fields (PR #122197)

2025-07-16 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/122197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Allow packing fields into tail padding of record fields (PR #122197)

2025-07-16 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: I had some pending draft comments from back when this was active. My recollection is that this is actually quite difficult and I am not likely to have time in the near future to work on it. https://github.com/llvm/llvm-project/pull/122197

[clang] Allow packing fields into tail padding of record fields (PR #122197)

2025-07-16 Thread Reid Kleckner via cfe-commits
@@ -389,14 +389,28 @@ void CGRecordLowering::accumulateFields(bool isNonVirtualBaseType) { // Empty fields have no storage. ++Field; } else { - // Use base subobject layout for the potentially-overlapping field, - // as it is done in RecordLayoutBuild

[clang] [clang-tools-extra] [clang-tidy] bugprone-infinite-loop: Add support for tuple structured bindings (PR #147410)

2025-07-16 Thread Baranov Victor via cfe-commits
vbvictor wrote: Thank you for the PR! Did you try to address this issue https://github.com/llvm/llvm-project/issues/138842? There is an ongoing PR https://github.com/llvm/llvm-project/pull/144213 that essentially tries to handle the same case with structured bindings. To be fair with everyone,

[clang] [llvm] [PowerPC] Test SPE incompatibility with VSX (PR #147184)

2025-07-16 Thread Guy David via cfe-commits
https://github.com/guy-david edited https://github.com/llvm/llvm-project/pull/147184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Remove SPE from triple in VSX test (PR #147184)

2025-07-16 Thread Guy David via cfe-commits
https://github.com/guy-david edited https://github.com/llvm/llvm-project/pull/147184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PowerPC] Remove SPE from triple in VSX test (PR #147184)

2025-07-16 Thread Guy David via cfe-commits
https://github.com/guy-david updated https://github.com/llvm/llvm-project/pull/147184 >From 3336929fcd243162d2063998a2624017e4e89143 Mon Sep 17 00:00:00 2001 From: Guy David Date: Sun, 6 Jul 2025 15:22:38 +0300 Subject: [PATCH] [PowerPC] Test SPE incompatibility with VSX PPCSubtarget is not al

[clang] [LifetimeSafety] Revamp test suite using unittests (PR #149158)

2025-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/149158 >From e5fefc05dcef6fd80fb459cca0d68a4d14c66564 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 16 Jul 2025 18:22:39 + Subject: [PATCH] [LifetimeSafety] Revamp test suite using unittests --- .../clan

[clang] [clang-repl] Lay the basic infrastructure for pretty printing of types (PR #148701)

2025-07-16 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/148701 >From 114e4ec4194afa865bd22f6d76b29200d231bef9 Mon Sep 17 00:00:00 2001 From: Vassil Vassilev Date: Sun, 16 Jul 2023 21:18:26 + Subject: [PATCH 1/7] [clang-repl] Lay the basic infrastructure for pretty p

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-16 Thread Baranov Victor via cfe-commits
vbvictor wrote: I think we should go through an RFC before creating a new module. TBH, I don't think we need a new module for MLIR in upstream since it is not a widely known thing in C++ community. Would it be viable for MLIR folks to use [plugins](https://clang.llvm.org/extra/clang-tidy/Contr

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-07-16 Thread Snehasish Kumar via cfe-commits
snehasish wrote: > I can reach out to the Android toolchain team to gauge interest. I chatted with @pirama-arumuga-nainar about this. My takeaway is that the team is more focused on broader platform optimizations right now and this may not be a high priority due to it's application specific re

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-16 Thread Eli Friedman via cfe-commits
@@ -37,9 +37,11 @@ cond.end: ; preds = %entry, %cond.true ; CHECK: testq ; CHECK: je ; CHECK: callq alloc +; CHECK-NEXT: nop efriedma-quic wrote: > No IP2State table mean no need to insert NOPs at all, even for SEH, rig

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Jacques Pienaar (jpienaar) Changes Moving towards new create method invocation, add check to flag old usage. --- Full diff: https://github.com/llvm/llvm-project/pull/149148.diff 10 Files Affected: - (modified) clang-tools-ex

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-16 Thread Jacques Pienaar via cfe-commits
https://github.com/jpienaar ready_for_review https://github.com/llvm/llvm-project/pull/149148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream builtin_conj for ComplexType (PR #149170)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for builtin_conj for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/149170.diff 4 Files Affected: - (mo

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-16 Thread via cfe-commits
@@ -37,9 +37,11 @@ cond.end: ; preds = %entry, %cond.true ; CHECK: testq ; CHECK: je ; CHECK: callq alloc +; CHECK-NEXT: nop sivadeilra wrote: I implemented the more-accurate optimizations for NOP padding (only insertin

[clang] [CIR] Upstream builtin_conj for ComplexType (PR #149170)

2025-07-16 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/149170 This change adds support for builtin_conj for ComplexType https://github.com/llvm/llvm-project/issues/141365 >From 2965c5b9f3684b321aa654105e2854d1711f8274 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date

[clang] [llvm] Fix Windows EH IP2State tables (remove +1 bias) (PR #144745)

2025-07-16 Thread via cfe-commits
https://github.com/sivadeilra updated https://github.com/llvm/llvm-project/pull/144745 >From 9e5cca779abaf4b282d2f17d326d98cb07e8a14c Mon Sep 17 00:00:00 2001 From: Arlie Davis Date: Fri, 13 Jun 2025 12:45:34 -0700 Subject: [PATCH 1/2] Fix IP2State tables style: revert one change Adjust tests

[clang] [clang-tools-extra] [clang-tidy] bugprone-infinite-loop: Add support for tuple structured bindings (PR #147410)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Aviral Goel (aviralg) Changes Tuple structured bindings can introduce new variable declarations under `BindingDecl` nodes which are currently ignored by the infinite loop checker. This PR implements support for extracting vari

[clang] [clang-tools-extra] [clang-tidy] bugprone-infinite-loop: Add support for tuple structured bindings (PR #147410)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aviral Goel (aviralg) Changes Tuple structured bindings can introduce new variable declarations under `BindingDecl` nodes which are currently ignored by the infinite loop checker. This PR implements support for extracting variables from t

[clang] [clang-tools-extra] [clang-tidy] bugprone-infinite-loop: Add support for tuple structured bindings (PR #147410)

2025-07-16 Thread Aviral Goel via cfe-commits
https://github.com/aviralg ready_for_review https://github.com/llvm/llvm-project/pull/147410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang-tidy] bugprone-infinite-loop: Add support for tuple structured bindings (PR #147410)

2025-07-16 Thread Aviral Goel via cfe-commits
https://github.com/aviralg updated https://github.com/llvm/llvm-project/pull/147410 >From be9fc41e5b1b52cf3f0bfb6acc4debae5561575a Mon Sep 17 00:00:00 2001 From: Aviral Goel Date: Mon, 7 Jul 2025 14:38:00 -0700 Subject: [PATCH] [clang-tidy] bugprone-infinite-loop: Add support for tuple structu

[clang] [llvm] [HLSL][DXIL] Implement `refract` intrinsic (PR #147342)

2025-07-16 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `arc-builder` running on `arc-worker` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/3/builds/19138 Here is the relevant pie

[clang-tools-extra] [clang-tidy] Add MLIR check for old op builder usage. (PR #149148)

2025-07-16 Thread Jacques Pienaar via cfe-commits
https://github.com/jpienaar updated https://github.com/llvm/llvm-project/pull/149148 >From f5d80596c0dc56086b585e9d59afa7472ff16321 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Wed, 16 Jul 2025 17:37:53 + Subject: [PATCH] [clang-tidy] Add MLIR check for old op builder usage. Moving

[clang] [llvm] [Clang] Reintroduce obsolete libclang symbols to avoid an ABI break (PR #149079)

2025-07-16 Thread via cfe-commits
Sirraide wrote: > Don't you have to undo the changes to clang/tools/libclang/libclang.map too? > Else these might not be marked as exported on all platforms. (This: > https://github.com/llvm/llvm-project/pull/119269/files#diff-2aa9e5e6908b0366b33796fa1f944b25d5b77abdf8eaceac7de55ccadaa7f04f) C

[clang] [CIR] Upstream Unary Inc/Dec for ComplexType (PR #149162)

2025-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for unary inc/dec operators for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Patch is 20.30 KiB, truncated to 20.00 KiB below, full version: https://github

  1   2   3   4   5   >