[clang] [Clang][Driver][SamplePGO] Enable -fsample-profile-use-profi for SamplePGO (PR #145957)

2025-06-27 Thread Nilanjana Basu via cfe-commits
nilanjana87 wrote: > We evaluated profi internally (at Google) last year. Our configuration uses > AutoFDO with [flow-sensitive discriminators > ](https://lists.llvm.org/pipermail/llvm-dev/2020-November/146694.html) > (FS-AFDO). We found slight regressions with this configuration and didn't >

[clang] [Clang][ByteCode][NFC] Avoid copies by using move in Disasm.cpp (PR #146127)

2025-06-27 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/146127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8bc61cb - [Clang][ByteCode][NFC] Avoid copies by using move in Disasm.cpp (#146127)

2025-06-27 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2025-06-27T14:53:20-07:00 New Revision: 8bc61cbfde28c014b8d18ae8066f1371808d2aa7 URL: https://github.com/llvm/llvm-project/commit/8bc61cbfde28c014b8d18ae8066f1371808d2aa7 DIFF: https://github.com/llvm/llvm-project/commit/8bc61cbfde28c014b8d18ae8066f1371808d2aa7.dif

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-27 Thread Oliver Hunt via cfe-commits
ojhunt wrote: Re: the oracle concerns - there are some protections we have, but in general I think the current pointer auth semantics/diagnostics make it too easy to silently introduce oracles. Additionally a lot of the current unwind pointerauth work is focused on protecting the ABI boundarie

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -2258,6 +2258,27 @@ class alignas(TypeAlignment) Type : public ExtQualsTypeCommonBase { unsigned NumExpansions; }; + enum class PredefinedSugarKind { +/// The "size_t" type. +SizeT, + +/// The "signed size_t" type. mizvekov wrote: ```su

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -2767,6 +2767,10 @@ class DependentBitIntTypeLoc final : public InheritingConcreteTypeLoc {}; +class PredefinedSugarTypeLoc final +: public InheritingConcreteTypeLoc {}; mizvekov wrote: These should ideally never be used in practice, as a Predefined

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -5216,6 +5237,25 @@ QualType ASTContext::getDependentBitIntType(bool IsUnsigned, return QualType(New, 0); } +QualType ASTContext::getPredefinedSugarType(uint32_t KD) const { + using Kind = PredefinedSugarType::Kind; + auto getUnderlyingType = [](const ASTContext &Ctx,

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -1480,6 +1480,16 @@ static bool IsStructurallyEquivalent(StructuralEquivalenceContext &Context, return false; break; } + case Type::PredefinedSugar: { +const auto *TP1 = cast(T1); +const auto *TP2 = cast(T2); +if (TP1->getKind() != TP2->getKind()) +

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -6796,14 +6836,25 @@ QualType ASTContext::getTagDeclType(const TagDecl *Decl) const { /// getSizeType - Return the unique type for "size_t" (C99 7.17), the result /// of the sizeof operator (C99 6.5.3.4p4). The value is target dependent and /// needs to agree with the defin

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -5622,3 +5622,15 @@ HLSLAttributedResourceType::findHandleTypeOnResource(const Type *RT) { } return nullptr; } + +StringRef PredefinedSugarType::getName() const { + switch (getKind()) { + case Kind::SizeT: +return "__size_t"; + case Kind::SignedSizeT: +return

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -8038,6 +8060,32 @@ class DependentBitIntType final : public Type, public llvm::FoldingSetNode { } }; +class PredefinedSugarType final : public Type { +public: + friend class ASTContext; + using Kind = PredefinedSugarKind; + +private: + PredefinedSugarType(Kind KD, Qu

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -1567,6 +1567,8 @@ class ASTContext : public RefCountedBase { /// and bit count. QualType getDependentBitIntType(bool Unsigned, Expr *BitsExpr) const; + QualType getPredefinedSugarType(uint32_t KD) const; mizvekov wrote: It would be more helpful and l

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -1516,6 +1516,23 @@ void ASTContext::InitBuiltinTypes(const TargetInfo &Target, MSGuidTagDecl = buildImplicitRecord("_GUID"); getTranslationUnitDecl()->addDecl(MSGuidTagDecl); } + + // size_t (C99TC3 6.5.3.4), signed size_t (C++23 5.13.2) and + // ptrdiff_t (C99

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -5216,6 +5237,25 @@ QualType ASTContext::getDependentBitIntType(bool IsUnsigned, return QualType(New, 0); } +QualType ASTContext::getPredefinedSugarType(uint32_t KD) const { + using Kind = PredefinedSugarType::Kind; + auto getUnderlyingType = [](const ASTContext &Ctx,

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -8038,6 +8060,32 @@ class DependentBitIntType final : public Type, public llvm::FoldingSetNode { } }; +class PredefinedSugarType final : public Type { +public: + friend class ASTContext; + using Kind = PredefinedSugarKind; + +private: + PredefinedSugarType(Kind KD, Qu

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov commented: Thanks, this looks good! It would be awesome to use these in existing cases which we handle with a builtin typedef, as this would be helpful to validate the design, but this is not required and doesn't need to be part of this PR. https://github.com/llvm/

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -7248,6 +7250,22 @@ QualType TreeTransform::TransformDependentBitIntType( return Result; } +template +QualType TreeTransform::TransformPredefinedSugarType( +TypeLocBuilder &TLB, PredefinedSugarTypeLoc TL) { + const PredefinedSugarType *EIT = TL.getTypePtr(); + Qua

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
@@ -14526,6 +14564,9 @@ static QualType getCommonSugarTypeNode(ASTContext &Ctx, const Type *X, DX->isCountInBytes(), DX->isOrNull(), CDX); } + case Type::PredefinedSugar: +// FIXME: Should this

[clang] [clang-tools-extra] [Clang] Make the SizeType, SignedSizeType and PtrdiffType be named sugar types instead of built-in types (PR #143653)

2025-06-27 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/143653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang] Enable strict mode for `getTrailingObjects` (PR #144930)

2025-06-27 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/144930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang] Enable strict mode for `getTrailingObjects` (PR #144930)

2025-06-27 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/144930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream get_bitfield operation to load bit-field members from structs (PR #145971)

2025-06-27 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/145971 >From d2e19a9ce2270ae9d764f1e2ba3978aaab2c1e2a Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 26 Jun 2025 15:51:02 -0500 Subject: [PATCH 1/4] Get Lvalue for bit-field --- clang/include/cla

[clang] [llvm] [LLVM][Clang] Add and enable strict mode for `getTrailingObjects` (PR #144930)

2025-06-27 Thread Rahul Joshi via cfe-commits
jurahul wrote: That was fast! Thanks https://github.com/llvm/llvm-project/pull/144930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream get_bitfield operation to load bit-field members from structs (PR #145971)

2025-06-27 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/145971 >From d2e19a9ce2270ae9d764f1e2ba3978aaab2c1e2a Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 26 Jun 2025 15:51:02 -0500 Subject: [PATCH 1/3] Get Lvalue for bit-field --- clang/include/cla

[clang] [llvm] [LLVM][Clang] Add and enable strict mode for `getTrailingObjects` (PR #144930)

2025-06-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/144930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang] Add and enable strict mode for `getTrailingObjects` (PR #144930)

2025-06-27 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/144930 >From ee982b8b2d14b1199f051db53aea4f26899d4d77 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Thu, 19 Jun 2025 10:25:12 -0700 Subject: [PATCH] [LLVM][Clang] Add and enable strict mode for `getTrailingObjects`

[clang] [llvm] [NFC][HLSL][DirectX] Let `HLSLRootSignature` reuse the `dxbc` defined enums (PR #145986)

2025-06-27 Thread Sarah Spall via cfe-commits
@@ -404,7 +417,7 @@ TEST_F(ParseHLSLRootSignatureTest, ValidSamplerFlagsTest) { ASSERT_TRUE(std::holds_alternative(Elem)); ASSERT_EQ(std::get(Elem).Type, ClauseType::Sampler); ASSERT_EQ(std::get(Elem).Flags, -DescriptorRangeFlags::ValidSamplerFlags); -

[clang] [llvm] [NFC][HLSL][DirectX] Let `HLSLRootSignature` reuse the `dxbc` defined enums (PR #145986)

2025-06-27 Thread Sarah Spall via cfe-commits
@@ -200,38 +81,38 @@ struct DescriptorTableClause { uint32_t NumDescriptors = 1; uint32_t Space = 0; uint32_t Offset = DescriptorTableOffsetAppend; - DescriptorRangeFlags Flags; + dxbc::DescriptorRangeFlags Flags; void setDefaultFlags() { switch (Type) {

[clang] [llvm] [NFC][HLSL][DirectX] Let `HLSLRootSignature` reuse the `dxbc` defined enums (PR #145986)

2025-06-27 Thread Sarah Spall via cfe-commits
@@ -205,20 +205,22 @@ TEST_F(ParseHLSLRootSignatureTest, ValidParseDTClausesTest) { ASSERT_EQ(std::get(Elem).Space, 0u); ASSERT_EQ(std::get(Elem).Offset, DescriptorTableOffsetAppend); + auto ValidDescriptorRangeFlags = llvm::dxbc::DescriptorRangeFlags(0x1000f)

[clang] [CIR] Upstream get_bitfield operation to load bit-field members from structs (PR #145971)

2025-06-27 Thread via cfe-commits
@@ -326,13 +326,47 @@ mlir::Value CIRGenFunction::emitStoreThroughBitfieldLValue(RValue src, return {}; } +Address CIRGenFunction::getAddrOfBitFieldStorage(LValue base, + const FieldDecl *field, +

[clang] [CIR] Upstream get_bitfield operation to load bit-field members from structs (PR #145971)

2025-06-27 Thread via cfe-commits
https://github.com/Andres-Salamanca edited https://github.com/llvm/llvm-project/pull/145971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add warning for blocks capturing {'this', raw pointers, references} (PR #144388)

2025-06-27 Thread John McCall via cfe-commits
@@ -1641,6 +1641,17 @@ def warn_implicitly_retains_self : Warning < "block implicitly retains 'self'; explicitly mention 'self' to indicate " "this is intended behavior">, InGroup>, DefaultIgnore; +def warn_blocks_capturing_this : Warning<"block implicitly captures 'this'

[clang] [Clang][ByteCode][NFC] Avoid copies by using move in Disasm.cpp (PR #146127)

2025-06-27 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. https://github.com/llvm/llvm-project/pull/146127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream get_bitfield operation to load bit-field members from structs (PR #145971)

2025-06-27 Thread via cfe-commits
https://github.com/Andres-Salamanca edited https://github.com/llvm/llvm-project/pull/145971 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Add support for retrieving bitfield member (PR #145971)

2025-06-27 Thread via cfe-commits
https://github.com/Andres-Salamanca updated https://github.com/llvm/llvm-project/pull/145971 >From d2e19a9ce2270ae9d764f1e2ba3978aaab2c1e2a Mon Sep 17 00:00:00 2001 From: Andres Salamanca Date: Thu, 26 Jun 2025 15:51:02 -0500 Subject: [PATCH 1/2] Get Lvalue for bit-field --- clang/include/cla

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-27 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > We could allow `__builtin_processor_is` as an alternative name for that > builtin if folks feel weird about having "cpu" in the name for a GPU target. We already use `-mcpu=gfx942` for targeting the GPU processor so I don't think it makes a huge difference. I've never heard of

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-27 Thread John McCall via cfe-commits
rjmccall wrote: Yeah, I agree with the other parts of your design, enabling the builtins within the guarded statements is a great way to handle it. On a different point: I don't think this builtin is actually semantically different from `__builtin_cpu_is`. As long as we're not treating it as

[clang] [CIR] Implement NotEqualOp for ComplexType (PR #146129)

2025-06-27 Thread Henrich Lauko via cfe-commits
xlauko wrote: Is there any reason why this is special operation and not `cmp` operation parameterized by (ne, eq) as for floats, integers? https://github.com/llvm/llvm-project/pull/146129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/146146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 33d2082 - [OpenACC][CIR] Implement enter-data + clause lowering (#146146)

2025-06-27 Thread via cfe-commits
Author: Erich Keane Date: 2025-06-27T13:47:42-07:00 New Revision: 33d20828d1ff4bcdfc519c16f0bea4fadbbc39f7 URL: https://github.com/llvm/llvm-project/commit/33d20828d1ff4bcdfc519c16f0bea4fadbbc39f7 DIFF: https://github.com/llvm/llvm-project/commit/33d20828d1ff4bcdfc519c16f0bea4fadbbc39f7.diff L

[clang] [clang] ODR hashes depth+index and not name of TemplateTypeParm (PR #144796)

2025-06-27 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Thanks! This should be fixed by https://github.com/llvm/llvm-project/pull/146153 https://github.com/llvm/llvm-project/pull/144796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [CIR][NFC] Fix init llvm::ArrayRef warning (PR #146147)

2025-06-27 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/146147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8d2034c - [clang] Add flag fallow-runtime-check-skip-hot-cutoff (#145999)

2025-06-27 Thread via cfe-commits
Author: Florian Mayer Date: 2025-06-27T13:46:54-07:00 New Revision: 8d2034cf68b51041a40069b0d868dfcdbf719685 URL: https://github.com/llvm/llvm-project/commit/8d2034cf68b51041a40069b0d868dfcdbf719685 DIFF: https://github.com/llvm/llvm-project/commit/8d2034cf68b51041a40069b0d868dfcdbf719685.diff

[clang] [llvm] [clang] Add flag fallow-runtime-check-skip-hot-cutoff (PR #145999)

2025-06-27 Thread Florian Mayer via cfe-commits
https://github.com/fmayer closed https://github.com/llvm/llvm-project/pull/145999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Matheus Izvekov (mizvekov) Changes This fixes an issue with the ODR checker not using the as-written type of conversion operators. The odr-checker in general should not have to deal with canonical types, as its purpose is to comp

[clang] [clang] odr-checker fix for conversion operators (PR #146153)

2025-06-27 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/146153 This fixes an issue with the ODR checker not using the as-written type of conversion operators. The odr-checker in general should not have to deal with canonical types, as its purpose is to compare same defin

[clang] 23be14b - [HLSL][SPIRV] Boolean in a RawBuffer should be i32 and Boolean vector in a RawBuffer should be (#144929)

2025-06-27 Thread via cfe-commits
Author: Sarah Spall Date: 2025-06-27T13:43:03-07:00 New Revision: 23be14b22200905b42bcea9add95f1f9233c728a URL: https://github.com/llvm/llvm-project/commit/23be14b22200905b42bcea9add95f1f9233c728a DIFF: https://github.com/llvm/llvm-project/commit/23be14b22200905b42bcea9add95f1f9233c728a.diff L

[clang] [HLSL][SPIRV] Boolean in a RawBuffer should be i32 and Boolean vector in a RawBuffer should be (PR #144929)

2025-06-27 Thread Sarah Spall via cfe-commits
https://github.com/spall closed https://github.com/llvm/llvm-project/pull/144929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove AArch64TargetInfo::setArchFeatures (PR #146107)

2025-06-27 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm approved this pull request. I'm surprised this has no effect, but if so LGTM. Are any of the values set here now dead? https://github.com/llvm/llvm-project/pull/146107 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/146146 >From 27f2b1d2af4fb5f5befd5709c199ae4616d676e2 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 27 Jun 2025 12:06:19 -0700 Subject: [PATCH 1/2] [OpenACC][CIR] Implement enter-data + clause lowering 'ente

[clang] f20ef85 - [CIR][NFC] Fix init llvm::ArrayRef warning (#146147)

2025-06-27 Thread via cfe-commits
Author: Amr Hesham Date: 2025-06-27T22:39:28+02:00 New Revision: f20ef8520ddc5c8dfa925b7a6be3aad7622ffc17 URL: https://github.com/llvm/llvm-project/commit/f20ef8520ddc5c8dfa925b7a6be3aad7622ffc17 DIFF: https://github.com/llvm/llvm-project/commit/f20ef8520ddc5c8dfa925b7a6be3aad7622ffc17.diff LO

[clang] [CIR] Upstream support for operator assign (PR #145979)

2025-06-27 Thread Andy Kaylor via cfe-commits
@@ -258,6 +258,30 @@ void CIRGenFunction::emitDelegateCXXConstructorCall( /*Delegating=*/true, thisAddr, delegateArgs, loc); } +void CIRGenFunction::emitImplicitAssignmentOperatorBody(FunctionArgList &args) { + const auto *assignOp = cast(curGD.getDe

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-27 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: I mean, I'm not particularly attached to the syntax of the "if". I guess we could designate `if (__builtin_amdgcn_processor_is("gfx900")) {}` as a "processor-feature-if". The point is that we need to know at the AST level which processor features are available for each st

[clang] [llvm] [mlir] Add some basic extra support for C++ unity building (PR #146104)

2025-06-27 Thread Maksim Levental via cfe-commits
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/146104 >From 6e4090dd5e83d28ef3655e2b11746d0a6da0b8d0 Mon Sep 17 00:00:00 2001 From: Maksim Levental Date: Fri, 27 Jun 2025 12:20:07 -0400 Subject: [PATCH 1/2] Add some basic extra support for C++ unity building

[clang] [llvm] [NFC][HLSL][DirectX] Let `HLSLRootSignature` reuse the `dxbc` defined enums (PR #145986)

2025-06-27 Thread Finn Plummer via cfe-commits
https://github.com/inbelic edited https://github.com/llvm/llvm-project/pull/145986 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Fix init llvm::ArrayRef warning (PR #146147)

2025-06-27 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. Thanks for handling this! https://github.com/llvm/llvm-project/pull/146147 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][clang][CodeGen][opt] Add late-resolved feature identifying predicates (PR #134016)

2025-06-27 Thread John McCall via cfe-commits
rjmccall wrote: Recognizing when the `if` condition is just a call to the builtin (possibly parenthesized or `&&`ed) seems totally sufficient to me. You could check that the builtin isn't used in any other position if you want, but I don't think that's really necessary. https://github.com/llv

[clang] [llvm] [Hexagon] NFC: Reduce the amount of version-specific code (PR #145812)

2025-06-27 Thread Alexey Karyakin via cfe-commits
https://github.com/quic-akaryaki closed https://github.com/llvm/llvm-project/pull/145812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e9c9adc - [Hexagon] NFC: Reduce the amount of version-specific code (#145812)

2025-06-27 Thread via cfe-commits
Author: Alexey Karyakin Date: 2025-06-27T15:05:28-05:00 New Revision: e9c9adcefed10fa07910aae8f2074aedf7bd8b7e URL: https://github.com/llvm/llvm-project/commit/e9c9adcefed10fa07910aae8f2074aedf7bd8b7e DIFF: https://github.com/llvm/llvm-project/commit/e9c9adcefed10fa07910aae8f2074aedf7bd8b7e.dif

[clang-tools-extra] [clang-doc] emit IsBuiltIn and IsTemplate for types (PR #146149)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Erick Velez (evelez7) Changes IsBuiltIn and IsTemplate were being emitted as their default values. --- Full diff: https://github.com/llvm/llvm-project/pull/146149.diff 8 Files Affected: - (modified) clang-tools-extra/clang-d

[clang-tools-extra] [clang-doc] emit IsBuiltIn and IsTemplate for types (PR #146149)

2025-06-27 Thread Erick Velez via cfe-commits
https://github.com/evelez7 ready_for_review https://github.com/llvm/llvm-project/pull/146149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] emit IsBuiltIn and IsTemplate for types (PR #146149)

2025-06-27 Thread Erick Velez via cfe-commits
https://github.com/evelez7 edited https://github.com/llvm/llvm-project/pull/146149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] emit IsBuiltIn and IsTemplate for types (PR #146149)

2025-06-27 Thread Erick Velez via cfe-commits
evelez7 wrote: * **#146149** https://app.graphite.dev/github/pr/llvm/llvm-project/146149?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/1461

[clang-tools-extra] [clang-doc] emit IsBuiltIn and IsTemplate for types (PR #146149)

2025-06-27 Thread Erick Velez via cfe-commits
https://github.com/evelez7 created https://github.com/llvm/llvm-project/pull/146149 None >From 2f505f6ba4af1b9c48d644ef81e2848234df593a Mon Sep 17 00:00:00 2001 From: Erick Velez Date: Fri, 27 Jun 2025 12:03:31 -0700 Subject: [PATCH] [clang-doc] emit IsBuiltIn and IsTemplate for types --- cl

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread Razvan Lupusoru via cfe-commits
@@ -572,8 +593,8 @@ class OpenACCClauseCIREmitter final applyToComputeOp(clause); } else { // TODO: When we've implemented this for everything, switch this to an - // unreachable. Combined constructs remain. Data, enter data, exit data, - // update con

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru edited https://github.com/llvm/llvm-project/pull/146146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru approved this pull request. Nice work! And I keep appreciating the dialect changes to improve its verification and construction! https://github.com/llvm/llvm-project/pull/146146 ___ cfe-commits mailing list cfe-commit

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/146146 'enter data' is a new construct type that requires one of the data clauses, so we had to wait for all clauses to be ready before we could commit this. Most of the clauses are simple, but there is a little b

[clang] [CIR][NFC] Fix init llvm::ArrayRef warning (PR #146147)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes Fix init llvm::ArrayRef deprecation warning when initialized with std::nullopt --- Full diff: https://github.com/llvm/llvm-project/pull/146147.diff 2 Files Affected: - (mod

[clang] Reland [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #145390)

2025-06-27 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/145390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFC] Fix init llvm::ArrayRef warning (PR #146147)

2025-06-27 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/146147 Fix init llvm::ArrayRef deprecation warning when initialized with std::nullopt >From f1419d49bcfd3dcfdaa3287d327b9f1217ea6230 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri, 27 Jun 2025 21:34:24 +0

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread Erich Keane via cfe-commits
erichkeane wrote: Particular attention to @razvanlupusoru due to the ACC dialect changes. https://github.com/llvm/llvm-project/pull/146146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-openacc Author: Erich Keane (erichkeane) Changes 'enter data' is a new construct type that requires one of the data clauses, so we had to wait for all clauses to be ready before we could commit this. Most of the clauses

[clang] [mlir] [OpenACC][CIR] Implement enter-data + clause lowering (PR #146146)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Erich Keane (erichkeane) Changes 'enter data' is a new construct type that requires one of the data clauses, so we had to wait for all clauses to be ready before we could commit this. Most of the clauses are simple, but there is a litt

[clang] Reland [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #145390)

2025-06-27 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: Looks like it passed the test phase! https://github.com/llvm/llvm-project/pull/145390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Implement NotEqualOp for ComplexType (PR #146129)

2025-06-27 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/146129 >From 964a930b9f96423d04155b9972bfd8540c59d911 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri, 27 Jun 2025 20:10:48 +0200 Subject: [PATCH 1/2] [CIR] Implement NotEqualOp for ComplexType --- clang/i

[clang] [llvm] [clang] Add flag fallow-runtime-check-skip-hot-cutoff (PR #145999)

2025-06-27 Thread Florian Mayer via cfe-commits
https://github.com/fmayer edited https://github.com/llvm/llvm-project/pull/145999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Implement NotEqualOp for ComplexType (PR #146129)

2025-06-27 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/146129 >From 964a930b9f96423d04155b9972bfd8540c59d911 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Fri, 27 Jun 2025 20:10:48 +0200 Subject: [PATCH 1/2] [CIR] Implement NotEqualOp for ComplexType --- clang/i

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-06-27 Thread Lucas Ramirez via cfe-commits
https://github.com/lucas-rami edited https://github.com/llvm/llvm-project/pull/138284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #145390)

2025-06-27 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: I've issued a trial run here: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci.shadow/clang-linux-x64/b8710885146355675473/overview https://github.com/llvm/llvm-project/pull/145390 ___ cfe-commits mailing list cfe-commits@

[clang] [llvm] [mlir] Add some basic extra support for C++ unity building (PR #146104)

2025-06-27 Thread Maksim Levental via cfe-commits
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/146104 >From 6e4090dd5e83d28ef3655e2b11746d0a6da0b8d0 Mon Sep 17 00:00:00 2001 From: Maksim Levental Date: Fri, 27 Jun 2025 12:20:07 -0400 Subject: [PATCH 1/2] Add some basic extra support for C++ unity building

[clang] 9d6cbc3 - [ADT] Deprecate MutableArrayRef(std::nullopt) (#146113)

2025-06-27 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-06-27T11:31:11-07:00 New Revision: 9d6cbc3c20923759d9ffdf19b4f0d498f8cf5584 URL: https://github.com/llvm/llvm-project/commit/9d6cbc3c20923759d9ffdf19b4f0d498f8cf5584 DIFF: https://github.com/llvm/llvm-project/commit/9d6cbc3c20923759d9ffdf19b4f0d498f8cf5584.diff L

[clang] [llvm] [mlir] [ADT] Deprecate MutableArrayRef(std::nullopt) (PR #146113)

2025-06-27 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/146113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][AST] Fix AST IgnoreUnlessSpelledInSource traversal nullptr dereference (PR #146103)

2025-06-27 Thread Jonathan Marriott via cfe-commits
https://github.com/JonathanMarriott edited https://github.com/llvm/llvm-project/pull/146103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-06-27 Thread Lucas Ramirez via cfe-commits
@@ -0,0 +1,40 @@ +; RUN: not llvm-as -disable-output %s 2>&1 | FileCheck %s + +target triple = "amdgcn-amd-amdhsa" + +define void @valid_amdgpu_waves_per_eu_range() "amdgpu-waves-per-eu"="2,4" { + ret void +} lucas-rami wrote: Will keep that in mind, thanks. ht

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-06-27 Thread Lucas Ramirez via cfe-commits
@@ -2519,6 +2519,29 @@ void Verifier::verifyFunctionAttrs(FunctionType *FT, AttributeList Attrs, CheckFailed("invalid value for 'denormal-fp-math-f32' attribute: " + S, V); } + + if (TT.isAMDGPU()) { +if (auto A = Attrs.getFnAttr("amdgpu-waves-pe

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-06-27 Thread Lucas Ramirez via cfe-commits
@@ -46,7 +46,6 @@ __attribute__((amdgpu_num_sgpr(4294967296))) kernel void kernel_num_sgpr_L() {} __attribute__((amdgpu_num_vgpr(4294967296))) kernel void kernel_num_vgpr_L() {} // expected-error {{integer constant expression evaluates to value 4294967296 that cannot be repres

[clang] [llvm] [mlir] Add some basic extra support for C++ unity building (PR #146104)

2025-06-27 Thread Maksim Levental via cfe-commits
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/146104 >From 6e4090dd5e83d28ef3655e2b11746d0a6da0b8d0 Mon Sep 17 00:00:00 2001 From: Maksim Levental Date: Fri, 27 Jun 2025 12:20:07 -0400 Subject: [PATCH 1/2] Add some basic extra support for C++ unity building

[clang] [llvm] [AMDGPU][Clang] Allow amdgpu-waves-per-eu attribute to lower target occupancy range (PR #138284)

2025-06-27 Thread Lucas Ramirez via cfe-commits
https://github.com/lucas-rami updated https://github.com/llvm/llvm-project/pull/138284 >From b277b2e90a3665c5e945ddff47c6c55a7fdb8d33 Mon Sep 17 00:00:00 2001 From: Lucas Ramirez Date: Thu, 22 May 2025 13:26:57 + Subject: [PATCH 1/3] Rebase on main (integrate changes from 1b34722) --- cla

[clang] [clang][AST] Fix AST IgnoreUnlessSpelledInSource traversal nullptr dereference (PR #146103)

2025-06-27 Thread Jonathan Marriott via cfe-commits
JonathanMarriott wrote: > Thank you for the patch! Please add a release note to > "clang/docs/ReleaseNotes.rst" so users can know the improvement. Please add a > tag to the beginning of the PR title in square brackets like other PRs. E.g. > `[clang]`. Thanks, I've added a release note in what

[clang] [clang] Fix AST IgnoreUnlessSpelledInSource traversal nullptr dereference (PR #146103)

2025-06-27 Thread Jonathan Marriott via cfe-commits
https://github.com/JonathanMarriott updated https://github.com/llvm/llvm-project/pull/146103 >From 646d006e327f9d891dea5d9c334e44174a5560a3 Mon Sep 17 00:00:00 2001 From: Jon Marriott Date: Wed, 25 Jun 2025 18:04:59 +0100 Subject: [PATCH 1/3] Add check for decl nullptr to `ASTNodeTraverser::Vis

[clang] [HLSL][SPIRV] Boolean in a RawBuffer should be i32 and Boolean vector in a RawBuffer should be (PR #144929)

2025-06-27 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/144929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Implement NotEqualOp for ComplexType (PR #146129)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes This change adds support for the not equal operation for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/146129.diff 5 Files Affec

[clang] [CIR] Implement NotEqualOp for ComplexType (PR #146129)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes This change adds support for the not equal operation for ComplexType https://github.com/llvm/llvm-project/issues/141365 --- Full diff: https://github.com/llvm/llvm-project/pull/146129.diff 5 Files Aff

[clang] [CIR] Implement NotEqualOp for ComplexType (PR #146129)

2025-06-27 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/146129 This change adds support for the not equal operation for ComplexType https://github.com/llvm/llvm-project/issues/141365 >From 964a930b9f96423d04155b9972bfd8540c59d911 Mon Sep 17 00:00:00 2001 From: AmrDeve

[clang] [Sema][clangd] add noexcept to override functions during code completion (PR #75937)

2025-06-27 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/75937 >From 36f970d7ecd4e68c73eaae7d82c7f6c6f6b037db Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Sat, 28 Jun 2025 01:44:44 +0800 Subject: [PATCH] [clangd][Sema] add noexcept to override functions during code complet

[clang] a4be46e - [Clang][ByteCode][NFC] Misc minor performance fixes (#145988)

2025-06-27 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2025-06-27T11:00:16-07:00 New Revision: a4be46e0e5bc124f446720337018c555ba38a875 URL: https://github.com/llvm/llvm-project/commit/a4be46e0e5bc124f446720337018c555ba38a875 DIFF: https://github.com/llvm/llvm-project/commit/a4be46e0e5bc124f446720337018c555ba38a875.dif

[clang] [Clang][ByteCode][NFC] Avoid copies by using move in Disasm.cpp (PR #146127)

2025-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged some cases we could avoid copies by using std::move in Disasm.cpp. --- Full diff: https://github.com/llvm/llvm-project/pull/146127.diff 1 Files Affected: - (modified) clang/lib/A

[clang] [Clang][ByteCode][NFC] Avoid copies by using move in Disasm.cpp (PR #146127)

2025-06-27 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/146127 Static analysis flagged some cases we could avoid copies by using std::move in Disasm.cpp. >From 6dbfe12457e7fd7dbb62d4cb5d53b3206b78e492 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Fri, 27 Jun 2025 10

  1   2   3   4   >