[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-09 Thread Erick Velez via cfe-commits
https://github.com/evelez7 edited https://github.com/llvm/llvm-project/pull/142483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Cygwin] va_list must be treated like normal Windows (PR #143115)

2025-06-09 Thread via cfe-commits
@@ -0,0 +1,37 @@ +// RUN: %clang_cc1 -triple x86_64-windows-gnu -emit-llvm < %s | FileCheck %s +// RUN: %clang_cc1 -triple x86_64-pc-cygwin -emit-llvm < %s | FileCheck %s + +// copy ms_abi block only from ../ms_abi.c jeremyd2019 wrote: I think the idea was ```su

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-09 Thread Erick Velez via cfe-commits
https://github.com/evelez7 edited https://github.com/llvm/llvm-project/pull/142483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-09 Thread Erick Velez via cfe-commits
@@ -0,0 +1,193 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --output=%t --format=json --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json + +struct Foo; + +// This is a nice class. +// It has some nice methods and fields. +// @brief This is

[clang] [flang] [mlir] [flang] Add support for -mrecip[=] (PR #143418)

2025-06-09 Thread Cameron McInally via cfe-commits
mcinally wrote: > Thanks for the changes, Cameron. LGTM. Thanks! Would you mind merging yet again? I still don't have access yet. https://github.com/llvm/llvm-project/pull/143418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [Clang] fix missing source location for ':' error in macro-expanded case statements (PR #143460)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -833,9 +833,23 @@ StmtResult Parser::ParseCaseStatement(ParsedStmtContext StmtCtx, << FixItHint::CreateReplacement(ColonLoc, ":"); } else { SourceLocation ExpectedLoc = PP.getLocForEndOfToken(PrevTokLocation); + SourceLocation ExprLoc = + L

[clang] [Clang] fix missing source location for ':' error in macro-expanded case statements (PR #143460)

2025-06-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/143460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix missing source location for ':' error in macro-expanded case statements (PR #143460)

2025-06-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: This seems like a more general issue... some examples: ``` #define D foo bar enum { D }; ``` ``` #define D foo bar void f() { int a[2]; auto [D] = a; } ``` ``` #define D class X; X D; ``` ``` #define D C::{ class C { D }}; ``` Can we come up with

[clang] [clang] Check constexpr int->enum conversions consistently. (PR #143034)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -2513,6 +2513,9 @@ void testValueInRangeOfEnumerationValues() { // expected-error@-1 {{constexpr variable 'x2' must be initialized by a constant expression}} // expected-note@-2 {{integer value 8 is outside the valid range of values [-8, 7] for the enumeration type 'E1'

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
@@ -58,10 +58,24 @@ void setTargetCPU(mlir::ModuleOp mod, llvm::StringRef cpu); /// Get the target CPU string from the Module or return a null reference. llvm::StringRef getTargetCPU(mlir::ModuleOp mod); +// Setters and Getters for atomic control options +void setAmdgpuIgnoreD

[clang] [Clang] fix missing source location for ':' error in macro-expanded case statements (PR #143460)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #143216 --- This patch addresses the issue where diagnostics for `case` statements originating from macro expansions lacked source location information when the colon `:` was missing. --- Full

[clang] [Clang] fix missing source location for ':' error in macro-expanded case statements (PR #143460)

2025-06-09 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/143460 Fixes #143216 --- This patch addresses the issue where diagnostics for `case` statements originating from macro expansions lacked source location information when the colon `:` was missing. >From dd4953

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-06-09 Thread via cfe-commits
SharonXSharon wrote: > Great. For my understanding, the baseline app includes some form of PGO e.g. > temporal profiling? These numbers are _purely_ from static data layout on top > of the baseline? yes the baseline already includes the temporal profiling thus function ordering; the win above

[clang-tools-extra] [WIP] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-09 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/143205 >From 52e4413ea1e701dfe0b24cf957a26bb72732f066 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Wed, 21 May 2025 16:06:44 -0700 Subject: [PATCH 1/3] Place holder message for sizeof operator in loops. --

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-06-09 Thread Snehasish Kumar via cfe-commits
snehasish wrote: > > Can you share the improvement in startup time observed on MachO? I can > > reach out to the Android toolchain team to gauge interest. > > @snehasish thanks! > > The improvement in startup performance we observed for iOS apps (MachO) are, > > * socialApp1: for cold starts,

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
@@ -2911,8 +2911,13 @@ static void genAtomicUpdateStatement( if (rightHandClauseList) genOmpAtomicHintAndMemoryOrderClauses(converter, *rightHandClauseList, hint, memoryOrder); + auto module = firOpBuilder.getModule(); -

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-06-09 Thread via cfe-commits
SharonXSharon wrote: > Can you share the improvement in startup time observed on MachO? I can reach > out to the Android toolchain team to gauge interest. @snehasish thanks! The improvement in startup performance we observed for iOS apps (MachO) are, - socialApp1: for cold starts, we reduced

[clang] [compiler-rt] [llvm] [DRAFT][memprof][darwin] Support memprof on Darwin platform and add binary access profile (PR #142884)

2025-06-09 Thread Snehasish Kumar via cfe-commits
snehasish wrote: > @snehasish thanks for the detailed reply! I will take a closer week through > the week and get back to you. > > Btw a quick question, our sister team is actually also interested in > supporting memprof for Android platform, i.e. getting the access profile of > the Android n

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
@@ -53,6 +53,11 @@ class TargetOptions { /// Print verbose assembly bool asmVerbose = false; + + /// Atomic Control Options for AMD GPU tarunprabhu wrote: Nit ```suggestion /// Atomic control options for AMD GPU ``` https://github.com/llvm/llvm-projec

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
@@ -58,10 +58,24 @@ void setTargetCPU(mlir::ModuleOp mod, llvm::StringRef cpu); /// Get the target CPU string from the Module or return a null reference. llvm::StringRef getTargetCPU(mlir::ModuleOp mod); +// Setters and Getters for atomic control options tarun

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu commented: Thanks for this. Since you have added both `FlangOption` and `FC1Option` in `Options.td`, could you add a test that checks that the option is handled by the main driver as well as `fc1`. One that simply checks that the option gets passed down to `fc1`

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
@@ -54,6 +54,20 @@ def FlagsAttr : OpenMP_Attr<"Flags", "flags"> { let assemblyFormat = "`<` struct(params) `>`"; } +//===--===// +// AtomicControlAttr +//===-

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
@@ -88,6 +88,46 @@ void fir::setTuneCPU(mlir::ModuleOp mod, llvm::StringRef cpu) { mod->setAttr(tuneCpuName, mlir::StringAttr::get(ctx, cpu)); } +static constexpr const char *amdgpuIgnoreDenormalModeName = +"fir.amdgpu.ignore.denormal.mode"; +void fir::setAmdgpuIgnoreDe

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu edited https://github.com/llvm/llvm-project/pull/143441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-09 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi deleted https://github.com/llvm/llvm-project/pull/142483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f5e499a - Revert "[HIP] use offload wrapper for non-device-only non-rdc (#132869)" (#143432)

2025-06-09 Thread via cfe-commits
Author: Joseph Huber Date: 2025-06-09T17:18:49-05:00 New Revision: f5e499a3383c1e3b9f60e60151075e8d9c1c3166 URL: https://github.com/llvm/llvm-project/commit/f5e499a3383c1e3b9f60e60151075e8d9c1c3166 DIFF: https://github.com/llvm/llvm-project/commit/f5e499a3383c1e3b9f60e60151075e8d9c1c3166.diff

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,193 @@ +// RUN: rm -rf %t && mkdir -p %t +// RUN: clang-doc --output=%t --format=json --executor=standalone %s +// RUN: FileCheck %s < %t/GlobalNamespace/MyClass.json + +struct Foo; + +// This is a nice class. +// It has some nice methods and fields. +// @brief This is

[clang-tools-extra] [clang-doc] add a JSON generator (PR #142483)

2025-06-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,175 @@ +#include "ClangDocTest.h" +#include "Generators.h" +#include "Representation.h" +#include "gtest/gtest.h" + +namespace clang { +namespace doc { + +static std::unique_ptr getJSONGenerator() { + auto G = doc::findGeneratorByName("json"); + if (!G) +return nu

[clang] Revert "[HIP] use offload wrapper for non-device-only non-rdc (#132869)" (PR #143432)

2025-06-09 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/143432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add6acc - NFC: stray whitespace cleanup from clang/test/SemaCXX/destructor.cpp

2025-06-09 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2025-06-09T19:08:15-03:00 New Revision: add6acc333740542705eedd185f45f69e3d25f30 URL: https://github.com/llvm/llvm-project/commit/add6acc333740542705eedd185f45f69e3d25f30 DIFF: https://github.com/llvm/llvm-project/commit/add6acc333740542705eedd185f45f69e3d25f30.dif

[clang] [clang] Check constexpr int->enum conversions consistently. (PR #143034)

2025-06-09 Thread Shafik Yaghmour via cfe-commits
@@ -2513,6 +2513,9 @@ void testValueInRangeOfEnumerationValues() { // expected-error@-1 {{constexpr variable 'x2' must be initialized by a constant expression}} // expected-note@-2 {{integer value 8 is outside the valid range of values [-8, 7] for the enumeration type 'E1'

[clang] [RFC] Initial implementation of P2719 (PR #113510)

2025-06-09 Thread Oliver Hunt via cfe-commits
@@ -1434,10 +1446,13 @@ namespace { QualType ArgType; }; -unsigned NumPlacementArgs : 31; -LLVM_PREFERRED_TYPE(bool) +unsigned NumPlacementArgs : 30; +LLVM_PREFERRED_TYPE(AlignedAllocationMode) unsigned PassAlignmentToPlacementDelete : 1; +LL

[clang] [clang][NFC] Remove dead PassTypeToPlacementDelete field (PR #143448)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Oliver Hunt (ojhunt) Changes The CallDeleteDuringNew::PassTypeToPlacementDelete field became unneeded during the many refactorings of P2719 but I didn't actually remove it. --- Full diff: https://github.

[clang] [clang][NFC] Remove dead PassTypeToPlacementDelete field (PR #143448)

2025-06-09 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt created https://github.com/llvm/llvm-project/pull/143448 The CallDeleteDuringNew::PassTypeToPlacementDelete field became unneeded during the many refactorings of P2719 but I didn't actually remove it. >From c1fa0ea448210ab10e71bd7b2f4dc4d575056b39 Mon Sep 17 00:00:00

[clang] [RFC] Initial implementation of P2719 (PR #113510)

2025-06-09 Thread Oliver Hunt via cfe-commits
@@ -1434,10 +1446,13 @@ namespace { QualType ArgType; }; -unsigned NumPlacementArgs : 31; -LLVM_PREFERRED_TYPE(bool) +unsigned NumPlacementArgs : 30; +LLVM_PREFERRED_TYPE(AlignedAllocationMode) unsigned PassAlignmentToPlacementDelete : 1; +LL

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread Daniel Paoliello via cfe-commits
@@ -0,0 +1,599 @@ +//===-- WindowsHotPatch.cpp - Support for Windows hotpatching -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread Daniel Paoliello via cfe-commits
@@ -0,0 +1,599 @@ +//===-- WindowsHotPatch.cpp - Support for Windows hotpatching -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread Daniel Paoliello via cfe-commits
@@ -389,6 +389,17 @@ def CoroDestroyOnlyWhenComplete : EnumAttr<"coro_only_destroy_when_complete", In /// pipeline to perform elide on the call or invoke instruction. def CoroElideSafe : EnumAttr<"coro_elide_safe", IntersectPreserve, [FnAttr]>; +/// Function is marked for Win

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread Daniel Paoliello via cfe-commits
@@ -0,0 +1,599 @@ +//===-- WindowsHotPatch.cpp - Support for Windows hotpatching -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread Daniel Paoliello via cfe-commits
@@ -798,6 +798,8 @@ enum AttributeKindCodes { ATTR_KIND_NO_DIVERGENCE_SOURCE = 100, ATTR_KIND_SANITIZE_TYPE = 101, ATTR_KIND_CAPTURES = 102, + ATTR_KIND_ALLOW_DIRECT_ACCESS_IN_HOT_PATCH_FUNCTION = 103, + ATTR_KIND_MARKED_FOR_WINDOWS_HOT_PATCHING = 104,

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello commented: Can you please add tests for the constant expression rewriting stuff, and not redirecting constant GVs without pointers? https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello edited https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[HIP] use offload wrapper for non-device-only non-rdc (#132869)" (PR #143432)

2025-06-09 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. thanks. I will take a look https://github.com/llvm/llvm-project/pull/143432 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up fillRanges() in ClangFormat.cpp (PR #143236)

2025-06-09 Thread Jorge Gorbe Moya via cfe-commits
slackito wrote: It seems this change has introduced a bug when formatting multiple files in one go. Passing a shorter file after a longer one results in a stale length being used. It can be reproduced with trivially short files: ``` $ cat ~/a.cc $ cat ~/b.cc // a $ bin/clang-format ~/b.cc ~/a

[clang] [Clang][NFC][ByteCode] Initialize Function HasBody in constructor (PR #143443)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Shafik Yaghmour (shafik) Changes Static analysis flagged HasBody as not being initialized during construction. It looks like an oversight in: https://github.com/llvm/llvm-project/pull/139671 This would be a lot simpler with C++20 which al

[clang] [Clang][NFC][ByteCode] Initialize Function HasBody in constructor (PR #143443)

2025-06-09 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/143443 Static analysis flagged HasBody as not being initialized during construction. It looks like an oversight in: https://github.com/llvm/llvm-project/pull/139671 This would be a lot simpler with C++20 which allows i

[clang] [clang-c] introduce queries on GCC-style inline assembly statements (PR #143424)

2025-06-09 Thread via cfe-commits
https://github.com/dingxiangfei2009 updated https://github.com/llvm/llvm-project/pull/143424 >From 4f9e599067c954a3ed3028efdc2abd72aa2b775f Mon Sep 17 00:00:00 2001 From: Xiangfei Ding Date: Mon, 9 Jun 2025 13:57:18 + Subject: [PATCH] [clang-c] introduce queries on GCC-style inline assembly

[clang] [OpenMP 60] Initial parsing/sema for `need_device_addr` modifier on `adjust_args` clause (PR #143442)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fazlay Rabbi (mdfazlay) Changes Adds initial parsing and semantic analysis for `need_device_addr` modifier on `adjust_args` clause. --- Full diff: https://github.com/llvm/llvm-project/pull/143442.diff 10 Files Affected: - (modified) c

[clang] [OpenMP 60] Initial parsing/sema for `need_device_addr` modifier on `adjust_args` clause (PR #143442)

2025-06-09 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay created https://github.com/llvm/llvm-project/pull/143442 Adds initial parsing and semantic analysis for `need_device_addr` modifier on `adjust_args` clause. >From a117e1a3f089b7d92a5df082a2ba584bee57f7d3 Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Mon, 9 Jun

[clang-tools-extra] [clangd] Add languages as server capabilities (PR #75633)

2025-06-09 Thread Ashley Coleman via cfe-commits
V-FEXrt wrote: `ServerCapabilities` has this member: ``` /** * Experimental server capabilities. */ experimental?: LSPAny; ``` Any reason we wouldn't just use that directly? maybe ```c++ llvm::json::Object ServerCaps{ ... {"experimental",

[clang] 28b753b - [Clang][NFC] Add nullptr check in InitializationSequence::InitializeFrom (#143067)

2025-06-09 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2025-06-09T14:28:47-07:00 New Revision: 28b753b185511eaaf98c5dda39bf9e44fa134212 URL: https://github.com/llvm/llvm-project/commit/28b753b185511eaaf98c5dda39bf9e44fa134212 DIFF: https://github.com/llvm/llvm-project/commit/28b753b185511eaaf98c5dda39bf9e44fa134212.dif

[clang] [Clang][NFC] Add nullptr check in InitializationSequence::InitializeFrom (PR #143067)

2025-06-09 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/143067 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
sarnex wrote: Thanks for the quick reviews! https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex closed https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 339797d - [clang][analyzer] Update python dependency versions (#143433)

2025-06-09 Thread via cfe-commits
Author: Nick Sarnie Date: 2025-06-09T21:25:58Z New Revision: 339797d75b3fd93bdb339c6b4ea826a2eeb32c26 URL: https://github.com/llvm/llvm-project/commit/339797d75b3fd93bdb339c6b4ea826a2eeb32c26 DIFF: https://github.com/llvm/llvm-project/commit/339797d75b3fd93bdb339c6b4ea826a2eeb32c26.diff LOG: [

[clang] [OpenMP 60] Initial parsing/sema for `need_device_addr` modifier on `adjust_args` clause (PR #143442)

2025-06-09 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/143442 >From a117e1a3f089b7d92a5df082a2ba584bee57f7d3 Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Mon, 9 Jun 2025 14:12:24 -0700 Subject: [PATCH 1/2] [OpenMP 60] Initial parsing/sema for `need_device_addr` modi

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. Thanks for the patch. Merge it at your convinience. https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [NVPTX] Enable OpenCL 3d_image_writes support (PR #143331)

2025-06-09 Thread Artem Belevich via cfe-commits
Artem-B wrote: @svenvh appears to be the current maintainer of OpenCL in LLVM. https://github.com/llvm/llvm-project/pull/143331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread via cfe-commits
@@ -0,0 +1,287 @@ +//===-- WindowsHotPatch.cpp - Support for Windows hotpatching -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
sarnex wrote: For this specific `requirements.txt` file, there are the only two vulnerabilities I saw. https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Balazs Benics via cfe-commits
steakhal wrote: Are there other vulns affecting the other deps? Or more recent vulns we should know about the deps you would touch here? https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [OpenMP 60] Initial parsing/sema for `need_device_addr` modifier on `adjust_args` clause (PR #143442)

2025-06-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/include/clang/Sema/SemaOpenMP.h clang/lib/AST

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread via cfe-commits
https://github.com/isuckatcs approved this pull request. https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Nick Sarnie (sarnex) Changes We need to make sure we aren't vulnerable to [PYSEC-2020-73](https://osv.dev/vulnerability/PYSEC-2020-73) and [PYSEC-2019-41](https://osv.dev/vulnerability/PYSEC-2019-41). --- Full diff: htt

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex ready_for_review https://github.com/llvm/llvm-project/pull/143433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Anchu Rajendran S (anchuraj) Changes Atomic Control Options are used to specify architectural characteristics to help lowering of atomic operations. The options used are: `-f[no-]atomic-remote-memory`, `-f[no-]atomic-fine-grained-m

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir Author: Anchu Rajendran S (anchuraj) Changes Atomic Control Options are used to specify architectural characteristics to help lowering of atomic operations. The options used are: `-f[no-]atomic-remote-memory`, `-f[no-]atomic-fine-graine

[clang] [flang] [mlir] [flang][flang-driver] atomic control support (PR #143441)

2025-06-09 Thread Anchu Rajendran S via cfe-commits
https://github.com/anchuraj created https://github.com/llvm/llvm-project/pull/143441 Atomic Control Options are used to specify architectural characteristics to help lowering of atomic operations. The options used are: `-f[no-]atomic-remote-memory`, `-f[no-]atomic-fine-grained-memory`, `-f[no

[clang] Add sycl_external attribute (PR #140282)

2025-06-09 Thread via cfe-commits
https://github.com/schittir updated https://github.com/llvm/llvm-project/pull/140282 >From abdbf8905d324f9b935b34bbc97c508ede5ac028 Mon Sep 17 00:00:00 2001 From: "Chittireddy, Sindhu" Date: Fri, 16 May 2025 08:51:06 -0700 Subject: [PATCH 1/9] Add sycl_external attribute --- clang/include/cla

[clang] [clang-c] introduce queries on GCC-style inline assembly statements (PR #143424)

2025-06-09 Thread via cfe-commits
https://github.com/dingxiangfei2009 updated https://github.com/llvm/llvm-project/pull/143424 >From 2d531acf50a4bdb139736693afd52559830acbbe Mon Sep 17 00:00:00 2001 From: Xiangfei Ding Date: Mon, 9 Jun 2025 13:57:18 + Subject: [PATCH] [clang-c] introduce queries on GCC-style inline assembly

[clang] [flang] [mlir] [flang] Add support for -mrecip[=] (PR #143418)

2025-06-09 Thread Tarun Prabhu via cfe-commits
https://github.com/tarunprabhu approved this pull request. Thanks for the changes, Cameron. LGTM. https://github.com/llvm/llvm-project/pull/143418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -2885,6 +2886,16 @@ class CXXDestructorDecl : public CXXMethodDecl { return getCanonicalDecl()->OperatorDelete; } + const FunctionDecl *getOperatorGlobalDelete() const { +return getCanonicalDecl()->OperatorGlobalDelete; + } + + void setOperatorGlobalDelete(Func

[clang] [win][clang] Align scalar deleting destructors with MSABI (PR #139566)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -1589,25 +1589,74 @@ namespace { void EmitConditionalDtorDeleteCall(CodeGenFunction &CGF, llvm::Value *ShouldDeleteCondition, bool ReturnAfterDelete) { +const CXXDestructorDecl *Dtor = cast(CGF.C

[clang] [AArch64] Change the coercion type of structs with pointer members. (PR #135064)

2025-06-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/135064 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Add neon vector support for floor (PR #142559)

2025-06-09 Thread Eli Friedman via cfe-commits
@@ -843,8 +843,8 @@ static const ARMVectorIntrinsicInfo ARMSIMDIntrinsicMap [] = { NEONMAP1(vrndaq_v, arm_neon_vrinta, Add1ArgType), NEONMAP0(vrndi_v), NEONMAP0(vrndiq_v), - NEONMAP1(vrndm_v, arm_neon_vrintm, Add1ArgType), - NEONMAP1(vrndmq_v, arm_neon_vrintm, Add1ArgT

[clang] [llvm] [ARM] Add neon vector support for floor (PR #142559)

2025-06-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/142559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Add neon vector support for floor (PR #142559)

2025-06-09 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/142559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add sycl_external attribute (PR #140282)

2025-06-09 Thread via cfe-commits
https://github.com/schittir updated https://github.com/llvm/llvm-project/pull/140282 >From abdbf8905d324f9b935b34bbc97c508ede5ac028 Mon Sep 17 00:00:00 2001 From: "Chittireddy, Sindhu" Date: Fri, 16 May 2025 08:51:06 -0700 Subject: [PATCH 1/7] Add sycl_external attribute --- clang/include/cla

[clang] 6559831 - [CIR] Add support for accessing members of base classes (#143195)

2025-06-09 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-06-09T13:11:12-07:00 New Revision: 6559831025711a21fd1f6a4065c4f3ac53f16875 URL: https://github.com/llvm/llvm-project/commit/6559831025711a21fd1f6a4065c4f3ac53f16875 DIFF: https://github.com/llvm/llvm-project/commit/6559831025711a21fd1f6a4065c4f3ac53f16875.diff L

[clang] [CIR] Add support for accessing members of base classes (PR #143195)

2025-06-09 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/143195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] [flang] Add support for -mrecip[=] (PR #143418)

2025-06-09 Thread Cameron McInally via cfe-commits
https://github.com/mcinally updated https://github.com/llvm/llvm-project/pull/143418 >From f4812aacb17aaf535f454c82e4ef29c5c9950a12 Mon Sep 17 00:00:00 2001 From: Cameron McInally Date: Mon, 9 Jun 2025 11:19:36 -0700 Subject: [PATCH 1/2] [flang] Add support for -mrecip[=] This patch adds suppo

[clang] [CIR][NFS] Add test cases for VecShuffle with -1 index (PR #143304)

2025-06-09 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/143304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f12e4f2 - [CIR][NFS] Add test cases for VecShuffle with -1 index (#143304)

2025-06-09 Thread via cfe-commits
Author: Amr Hesham Date: 2025-06-09T22:08:55+02:00 New Revision: f12e4f2faf404a7f44b5505b0a4c14e3a003d2d1 URL: https://github.com/llvm/llvm-project/commit/f12e4f2faf404a7f44b5505b0a4c14e3a003d2d1 DIFF: https://github.com/llvm/llvm-project/commit/f12e4f2faf404a7f44b5505b0a4c14e3a003d2d1.diff LO

[clang] [llvm] Add support for Windows Secure Hot-Patching (PR #138972)

2025-06-09 Thread via cfe-commits
sivadeilra wrote: @efriedma-quic This latest change should address your feedback around idioms like `&g_foo[10]`. https://github.com/llvm/llvm-project/pull/138972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [Frontend][PCH]-Add support for ignoring PCH options (-ignore-pch). (PR #142409)

2025-06-09 Thread via cfe-commits
https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/142409 >From c0cc666ab8864b665539a857dbdae6c592266227 Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Mon, 2 Jun 2025 10:21:22 +0100 Subject: [PATCH 1/8] [Frontend][PCH]-Add support for ignoring PCH options (-ignore

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll +// RUN:

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll +// RUN:

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -240,6 +284,43 @@ void AggExprEmitter::emitNullInitializationToLValue(mlir::Location loc, cgf.emitNullInitialization(loc, lv.getAddress(), lv.getType()); } +void AggExprEmitter::VisitCallExpr(const CallExpr *e) { + if (e->getCallReturnType(cgf.getContext())->isReference

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -0,0 +1,23 @@ +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fclangir -emit-cir %s -o %t.cir +// RUN: FileCheck --input-file=%t.cir %s -check-prefix=CIR +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -Wno-unused-value -fclangir -emit-llvm %s -o %t-cir.ll +// RUN:

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -365,6 +422,19 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, if (isa(retCIRTy)) return getUndefRValue(retTy); switch (getEvaluationKind(retTy)) { + case cir::TEK_Aggregate: { +Address destPtr = returnValue.getValue(); + +if (!destPt

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -60,6 +60,23 @@ CIRGenCallee CIRGenCallee::prepareConcreteCallee(CIRGenFunction &cgf) const { return *this; } +void CIRGenFunction::emitAggregateStore(mlir::Value value, Address dest) { + // In LLVM codegen: andykaylor wrote: ```suggestion // In clas

[clang] [CIR] Function calls with aggregate arguments and return values (PR #143377)

2025-06-09 Thread Andy Kaylor via cfe-commits
@@ -312,8 +329,47 @@ RValue CIRGenFunction::emitCall(const CIRGenFunctionInfo &funcInfo, assert(!cir::MissingFeatures::opCallBitcastArg()); cirCallArgs[argNo] = v; } else { - assert(!cir::MissingFeatures::opCallAggregateArgs()); - cgm.errorNYI("emitCa

[clang] [SPIRV] enable and copy device implementation for logb and scalbn builtins (PR #143431)

2025-06-09 Thread via cfe-commits
https://github.com/choikwa edited https://github.com/llvm/llvm-project/pull/143431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Update python dependency versions (PR #143433)

2025-06-09 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex created https://github.com/llvm/llvm-project/pull/143433 We need to make sure we aren't vulnerable to [PYSEC-2020-73](https://osv.dev/vulnerability/PYSEC-2020-73) and [PYSEC-2019-41](https://osv.dev/vulnerability/PYSEC-2019-41). >From 4cfcb16f7680a31ff040de37dbd9de45

[clang] [SPIRV] enable and copy device implementation for logb and scalbn builtins (PR #143431)

2025-06-09 Thread via cfe-commits
https://github.com/choikwa created https://github.com/llvm/llvm-project/pull/143431 Copied from previous AMDGPU implementation #77de8a0 >From 304ce3e865dc407133ff67dc93e5562f7d163092 Mon Sep 17 00:00:00 2001 From: Kevin Choi Date: Mon, 9 Jun 2025 11:30:25 -0500 Subject: [PATCH] [SPIRV] enable

  1   2   3   4   5   >