https://github.com/yxsamliu closed
https://github.com/llvm/llvm-project/pull/141581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Yaxun (Sam) Liu
Date: 2025-05-27T16:58:04-04:00
New Revision: c720f920094e445af23ce8e214813f57694ab716
URL:
https://github.com/llvm/llvm-project/commit/c720f920094e445af23ce8e214813f57694ab716
DIFF:
https://github.com/llvm/llvm-project/commit/c720f920094e445af23ce8e214813f57694ab716.dif
alexey-bataev wrote:
> AnalyzeLoopSequence
Could you point, where this is located?
https://github.com/llvm/llvm-project/pull/140532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
I think the unevaluated contexts DOES help a bunch, though I'm still concerned
about the ability of the library to create 'temproary' objects/etc via some
sort of default construction/aggregate construction, to then fill in the rest.
https://github.com/llvm/llvm-project/pul
@@ -1352,7 +1352,12 @@ static StringRef
getIdentStringFromSourceLocation(CodeGenFunction &CGF,
llvm::raw_svector_ostream OS(Buffer);
// Build debug location
PresumedLoc PLoc = CGF.getContext().getSourceManager().getPresumedLoc(Loc);
- OS << ";" << PLoc.getFilename() <<
@@ -151,6 +164,11 @@ std::vector generateMissingIncludeDiagnostics(
if (!Replacement.has_value())
continue;
+if (Angled && Spelling.front() == '\"') {
kadircet wrote:
yikes, we also need to do this transformation in the other way as well :/
Mig
https://github.com/perry-ca edited
https://github.com/llvm/llvm-project/pull/111035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/galenelias updated
https://github.com/llvm/llvm-project/pull/136167
>From b8faa7bb02fb4aa0504978dad1a28493fc745786 Mon Sep 17 00:00:00 2001
From: Galen Elias
Date: Wed, 16 Apr 2025 12:48:18 -0700
Subject: [PATCH 1/8] [clang-tidy] Return error code on config parse error
This
zygoloid wrote:
I don't think this concern is specific to system headers.
I don't think we have precedent for disabling a warning in a SFINAE context. We
do suppress warnings produced while substituting into a function template
specialization during deduction if we end up not selecting that ov
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/140594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/140594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
thanks, mostly LGTM, please wait on a final look from @HighCommander4 though,
he has more context about this feature overall, maybe the discrepancy on path
vs spelling based match has a story.
https://github.com/llvm/llvm-project/pull/140
HighCommander4 wrote:
> Any update about the issue that I reported above?
You may want to open a new issue to track that, so it can get annotated with
the appropriate labels (e.g. `rejects-valid`) and get more attention by showing
up on issues lists / dashboards that people may be watching.
h
dyung wrote:
ping!
https://github.com/llvm/llvm-project/pull/139821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Global variable `__hip_cuid_*` is for identifying purpose and does not need
sanitization, therefore disable it for sanitizers.
---
Full diff: https://github.com/llvm/llvm-project/pull/141581.diff
BukeBeyond wrote:
> It's not actually clang's responsibility to not break your transformation. We
> don't want to break it gratuitously, but if clang is generating correct code,
> your transformation needs to be flexible enough to handle it. If there's
> something easy we can do to help your t
https://github.com/kadircet closed
https://github.com/llvm/llvm-project/pull/141584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet approved this pull request.
https://github.com/llvm/llvm-project/pull/141584
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: FabianWolff
Date: 2025-05-27T21:52:59+02:00
New Revision: 317f3bdcc1f96586489a9e48b494e593592b68cf
URL:
https://github.com/llvm/llvm-project/commit/317f3bdcc1f96586489a9e48b494e593592b68cf
DIFF:
https://github.com/llvm/llvm-project/commit/317f3bdcc1f96586489a9e48b494e593592b68cf.diff
L
https://github.com/ian-twilightcoder approved this pull request.
https://github.com/llvm/llvm-project/pull/140890
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ojhunt wrote:
Sorry for the delay, now that we've got the qualifier and various other
features upstreamed, I'll be upstreaming our ptrauth hardening for the various
runtime libraries in the not too distant future (I'm technically on vacation
this week, but it may go up this week, otherwise it
higher-performance wrote:
Interesting point! A few thoughts:
- Are system headers really any different from non-system headers in that case?
It feels like it might be an orthogonal issue we should address in a separate
PR.
- Do you mean SFINAE contexts rather than merely unevaluated contexts (
zygoloid wrote:
There are
[techniques](https://github.com/carbon-language/carbon-lang/blob/69ab97d7167146ae1deea662126af66f8f5523a2/common/struct_reflection.h#L74)
for determining the number of fields in an aggregate type `T` by attempting to
initialize with `T{}` then `T{arg}` then `T{arg, ar
@@ -23814,6 +23814,20 @@ TEST_F(FormatTest, FormatsLambdas) {
"}",
LLVMWithBeforeLambdaBody);
+ // Make sure we don't put the lambda on a new line when it would be indented
HazardyKnusperkeks wrote:
I think you can drop the comm
@@ -5311,6 +5313,90 @@ void
Parser::ParseMicrosoftUuidAttributeArgs(ParsedAttributes &Attrs) {
}
}
+void Parser::ParseMicrosoftRootSignatureAttributeArgs(ParsedAttributes &Attrs)
{
+ assert(Tok.is(tok::identifier) &&
+ "Expected an identifier to denote which MS at
https://github.com/AaronBallman created
https://github.com/llvm/llvm-project/pull/141657
Our current docs leave a lot of latitude ("relatively stable") without
explaining what the goals are for this stability. This patch adds some basic
documentation explaining that there are some changes whic
https://github.com/tarunprabhu approved this pull request.
Thanks. Any cleanup of this code is helpful.
https://github.com/llvm/llvm-project/pull/141036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/141621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2025-05-27T14:59:30-04:00
New Revision: d1a6327b2b5d859c992599ac217aaa6d8b83a998
URL:
https://github.com/llvm/llvm-project/commit/d1a6327b2b5d859c992599ac217aaa6d8b83a998
DIFF:
https://github.com/llvm/llvm-project/commit/d1a6327b2b5d859c992599ac217aaa6d8b83a998.diff
AaronBallman wrote:
> I think this problem is an important one to solve, and this is not the first
> time our rigid ABI has caused us problems. I wonder at what point we should
> decide to break ABI, because there are other cleanups we also want to do
> (removing deprecated APIs, for example).
AaronBallman wrote:
I've added a handful of folks who might be reasonable reviewers for this, but
if you know of anyone else who may have an opinion, feel free to rope them in.
These changes came about because of
https://github.com/llvm/llvm-project/pull/134551 where someone was trying to
add
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-aarch64-linux-bootstrap-ubsan` running on `sanitizer-buildbot10`
while building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/85/builds/9241
Here is the rele
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Aaron Ballman (AaronBallman)
Changes
Our current docs leave a lot of latitude ("relatively stable") without
explaining what the goals are for this stability. This patch adds some basic
documentation explaining that there are some changes
@@ -141,16 +143,41 @@ std::vector generateMissingIncludeDiagnostics(
AST.getPreprocessor().getHeaderSearchInfo(), MainFile});
llvm::StringRef HeaderRef{Spelling};
-bool Angled = HeaderRef.starts_with("<");
+
+bool IsAngled = false;
Harald-
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
Author: Orlando Cazalet-Hyams
Date: 2025-05-27T13:31:59+01:00
New Revision: 9e07d0cf60bd72da93e603233c732f8d0bd65f46
URL:
https://github.com/llvm/llvm-project/commit/9e07d0cf60bd72da93e603233c732f8d0bd65f46
DIFF:
https://github.com/llvm/llvm-project/commit/9e07d0cf60bd72da93e603233c732f8d0bd65f
https://github.com/bogner approved this pull request.
Looks good (noting that we're matching the pre-existing buggy behaviour of
StructuredBuffer and will follow up to fix that for both)
https://github.com/llvm/llvm-project/pull/141086
___
cfe-commits
@@ -2636,6 +2636,10 @@ void
ModuleImport::processFunctionAttributes(llvm::Function *func,
funcOp.setTargetFeaturesAttr(
LLVM::TargetFeaturesAttr::get(context, attr.getValueAsString()));
+ if (llvm::Attribute attr = func->getFnAttribute("prefer-vector-width");
+
@@ -557,29 +553,47 @@ static void initializeBuffer(CodeGenModule &CGM,
llvm::GlobalVariable *GV,
CGM.AddCXXGlobalInit(InitResFunc);
}
-static void initializeBufferFromBinding(CodeGenModule &CGM,
-llvm::GlobalVariable *GV,
-
@@ -557,29 +553,47 @@ static void initializeBuffer(CodeGenModule &CGM,
llvm::GlobalVariable *GV,
CGM.AddCXXGlobalInit(InitResFunc);
}
-static void initializeBufferFromBinding(CodeGenModule &CGM,
-llvm::GlobalVariable *GV,
-
@@ -299,9 +299,20 @@ Value *CodeGenFunction::EmitHLSLBuiltinExpr(unsigned
BuiltinID,
// (llvm/llvm-project#135452)
Value *NonUniform =
llvm::ConstantInt::get(llvm::Type::getInt1Ty(getLLVMContext()), false);
-return Builder.CreateIntrinsic(
-HandleTy
@@ -325,13 +325,30 @@ bool ContinuationIndenter::canBreak(const LineState
&State) {
if (Current.isMemberAccess() && CurrentState.ContainsUnwrappedBuilder)
return false;
- // Don't create a 'hanging' indent if there are multiple blocks in a single
- // statement and we
@@ -23814,6 +23814,20 @@ TEST_F(FormatTest, FormatsLambdas) {
"}",
LLVMWithBeforeLambdaBody);
+ // Make sure we don't put the lambda on a new line when it would be indented
+ // more than where it would be otherwise.
+ verifyFormat("if ([]()\n"
https://github.com/Harald-R updated
https://github.com/llvm/llvm-project/pull/140594
>From 322468b6354c45c0c81aa3ae28b900262d795a8e Mon Sep 17 00:00:00 2001
From: Harald-R
Date: Sun, 18 May 2025 19:07:59 +0300
Subject: [PATCH 1/7] Follow style configuration in clangd include cleaner
---
clang
@@ -177,6 +177,7 @@ let Attributes = [NoReturn] in {
}
let Attributes = [NoThrow] in {
def __nvvm_nanosleep : NVPTXBuiltinSMAndPTX<"void(unsigned int)", SM_70,
PTX63>;
+ def __nvvm_pm_event_mask : NVPTXBuiltin<"void(unsigned short)">;
durga4github wrote:
S
https://github.com/durga4github updated
https://github.com/llvm/llvm-project/pull/141278
>From ba3a94813adcb77262eb0085911e68e558c8 Mon Sep 17 00:00:00 2001
From: Durgadoss R
Date: Fri, 23 May 2025 20:43:18 +0530
Subject: [PATCH] [NVPTX] Add pm_event intrinsics
This patch adds pm_event.mas
https://github.com/cyndyishida approved this pull request.
LGTM, thanks!
>not all platforms support -F, which is a g++ extension.
It indeed looks unecessary for this test but what is the correct way enable
support for `-F` in clang tests? I would actally expect it to show up often in
our te
BukeBeyond wrote:
The interesting part is the first time LLVM was built, there were no problems,
because the compiler was switched to clang++ and Cmake probably updated
CMAKE_C_SIMULATE_ID correctly. But the subsequent incremental builds using
caches, the CMAKE_C_SIMULATE_ID started inhering
@@ -373,8 +373,8 @@ bool Preprocessor::CheckMacroName(Token &MacroNameTok,
MacroUse isDefineUndef,
// Macro names with reserved identifiers are accepted if built-in or passed
// through the command line (the later may be present if -dD was used to
// generate the preproc
https://github.com/mcinally updated
https://github.com/llvm/llvm-project/pull/141380
>From 9f8619cb54a3a11e4c90af7f5156141ddc59e4d4 Mon Sep 17 00:00:00 2001
From: Cameron McInally
Date: Sat, 24 May 2025 13:35:13 -0700
Subject: [PATCH 1/2] [flang] Add support for -mprefer-vector-width=
This pat
@@ -14086,7 +14091,7 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr
*Init, bool DirectInit) {
// The form of initialization (using parentheses or '=') is generally
// insignificant, but does matter when the entity being initialized has a
// class type.
-
https://github.com/hekota edited
https://github.com/llvm/llvm-project/pull/139991
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
paulhdk wrote:
> LGTM for my changes, here a few nits that are just nice to have (doesn't much
> block PR). The only important change is [single ticks instead of double tick
> in default value of `ExcludeClasses`
> option](https://github.com/llvm/llvm-project/pull/95220#discussion_r2109589004)
@@ -0,0 +1,51 @@
+.. title:: clang-tidy -
cppcoreguidelines-pro-bounds-avoid-unchecked-container-accesses
+
+cppcoreguidelines-pro-bounds-avoid-unchecked-container-accesses
+===
+
+Flags calls to ``operator[]`` in STL co
rjmccall wrote:
Sorry, can you back up and explain the root problem you're trying to solve? You
have a platform where we're emitting accesses to `errno` as if it weren't an
`int`? What does it look like in source?
https://github.com/llvm/llvm-project/pull/125258
___
BukeBeyond wrote:
The following code breaks builds on Windows:
compiler-rt/cmake/Modules/CompilerRTUtils.cmake:387
runtimes/CMakeLists.txt:197
```
if (CMAKE_C_SIMULATE_ID MATCHES "MSVC")
set(option_prefix "/clang:")
endif()
```
The problem is when LLVM is built with Clang-cl, CMAKE_C_SIMU
@@ -136,6 +136,13 @@ New checks
Finds unintended character output from ``unsigned char`` and ``signed char``
to an ``ostream``.
+- New :doc:`cppcoreguidelines-pro-bounds-avoid-unchecked-container-accesses
+
`
+ check.
+
+ Flags calls to ``operator[]`` in STL containers
rjmccall wrote:
It's not actually clang's responsibility to not break your transformation. We
don't want to break it gratuitously, but if clang is generating correct code,
your transformation needs to be flexible enough to handle it. If there's
something easy we can do to help your transformat
https://github.com/inbelic approved this pull request.
LGTM given we have a way of tracking making sure it will be read-only
https://github.com/llvm/llvm-project/pull/141086
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sharjeel Khan (Sharjeel-Khan)
Changes
Android has local fortify warnings for functions not seen in LLVM. My plan is
to upstream them all and I am starting with stpcpy.
---
Full diff: https://github.com/llvm/llvm-project/pull/141646.diff
https://github.com/Sharjeel-Khan created
https://github.com/llvm/llvm-project/pull/141646
Android has local fortify warnings for functions not seen in LLVM. My plan is
to upstream them all and I am starting with stpcpy.
>From 1213e3a40f566270f05086a17ba51289f1fd2c09 Mon Sep 17 00:00:00 2001
Fr
https://github.com/vbvictor approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/141345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -177,6 +177,7 @@ let Attributes = [NoReturn] in {
}
let Attributes = [NoThrow] in {
def __nvvm_nanosleep : NVPTXBuiltinSMAndPTX<"void(unsigned int)", SM_70,
PTX63>;
+ def __nvvm_pm_event_mask : NVPTXBuiltin<"void(unsigned short)">;
Artem-B wrote:
The ar
https://github.com/Artem-B approved this pull request.
Builtin signature needs a fix, but LGTM otherwise.
https://github.com/llvm/llvm-project/pull/141278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/Artem-B edited
https://github.com/llvm/llvm-project/pull/141278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
higher-performance wrote:
Yeah. I'm not even sure I can think of a case with the irrelevant/unused
temporaries you mention, to be honest. The way I would think about this is:
this attribute is intended to be equivalent to adding an in-class member
initializer that is impossible for anyone to a
https://github.com/hekota closed
https://github.com/llvm/llvm-project/pull/139985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Helena Kotas
Date: 2025-05-27T10:41:04-07:00
New Revision: 20f1e351c79528f3bdf996baab03bca4e11704d1
URL:
https://github.com/llvm/llvm-project/commit/20f1e351c79528f3bdf996baab03bca4e11704d1
DIFF:
https://github.com/llvm/llvm-project/commit/20f1e351c79528f3bdf996baab03bca4e11704d1.diff
https://github.com/bogner approved this pull request.
https://github.com/llvm/llvm-project/pull/139985
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
V-FEXrt wrote:
@inbelic From Justin, looks like it doesn't :) (and this is a bug)
https://hlsl.godbolt.org/z/sqMMffh6K
I'm going to spin that off into its own task separate from this one so this
doesn't get bogged down
https://github.com/llvm/llvm-project/pull/141086
_
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/141342
>From c0603457eb734d8a0aeb8a5c3cf131485116e303 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Sat, 24 May 2025 12:37:02 +0200
Subject: [PATCH 1/4] [Clang] Fix a regression introduced by #138518
We did not
@@ -78,6 +78,12 @@ __global__ void template_32_4_a_max_num_work_groups() {}
template __global__ void template_32_4_a_max_num_work_groups<2>();
// CHECK: define{{.*}} amdgpu_kernel void
@_Z35template_32_4_a_max_num_work_groupsILj2EEvv()
[[MAX_NUM_WORK_GROUPS_32_4_2:#[0-9]+]]
https://github.com/AmrDeveloper updated
https://github.com/llvm/llvm-project/pull/141369
>From 3a8bcd052d25d138b3a9a53bbcc69d48500b4b41 Mon Sep 17 00:00:00 2001
From: AmrDeveloper
Date: Sat, 24 May 2025 14:18:06 +0200
Subject: [PATCH 1/4] [CIR] Upstream global initialization for ComplexType
--
@@ -385,6 +385,13 @@ mlir::Type CIRGenTypes::convertType(QualType type) {
break;
}
+ case Type::Complex: {
+const ComplexType *ct = cast(ty);
+mlir::Type elementTy = convertType(ct->getElementType());
AmrDeveloper wrote:
Thanks for your comment
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-ppc64le-rhel`
running on `ppc64le-clang-rhel-test` while building `clang` at step 5
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/145/builds/7332
Here is the relevant pi
https://github.com/galenelias updated
https://github.com/llvm/llvm-project/pull/136167
>From b8faa7bb02fb4aa0504978dad1a28493fc745786 Mon Sep 17 00:00:00 2001
From: Galen Elias
Date: Wed, 16 Apr 2025 12:48:18 -0700
Subject: [PATCH 1/8] [clang-tidy] Return error code on config parse error
This
@@ -2518,6 +2518,57 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
@@ -2518,6 +2518,59 @@ StringRef CGDebugInfo::getVTableName(const CXXRecordDecl
*RD) {
return internString("_vptr$", RD->getNameAsString());
}
+// Emit symbol for the debugger that points to the vtable address for
+// the given class. The symbol is named as '_vtable$'.
+//
https://github.com/Michael137 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/130255
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vbvictor closed
https://github.com/llvm/llvm-project/pull/141346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
clang-tools-extra/clang-tidy/ClangTidyDiagnosticCon
@@ -2969,6 +2969,11 @@ static LValue EmitGlobalVarDeclLValue(CodeGenFunction
&CGF,
llvm::Value *V = CGF.CGM.GetAddrOfGlobalVar(VD);
+ if (VD->hasAttr()) {
+llvm::GlobalVariable *Var = llvm::dyn_cast(V);
+Var->setInitializer(CGF.CGM.EmitNullConstant(E->getType()));
https://github.com/galenelias updated
https://github.com/llvm/llvm-project/pull/136167
>From b8faa7bb02fb4aa0504978dad1a28493fc745786 Mon Sep 17 00:00:00 2001
From: Galen Elias
Date: Wed, 16 Apr 2025 12:48:18 -0700
Subject: [PATCH 1/7] [clang-tidy] Return error code on config parse error
This
@@ -948,6 +950,165 @@ void CIRGenFunction::emitIgnoredExpr(const Expr *e) {
emitLValue(e);
}
+// Handle the case where the condition is a constant evaluatable simple
integer,
+// which means we don't have to separately handle the true/false blocks.
+static std::optional han
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Clang does not instantiate amdgpu_max_num_work_groups attribute with one
template argument, causing
assertion codegen.
Fixes: https://github.com/llvm/llvm-project/issues/139570
---
Full diff: https://gi
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Yaxun (Sam) Liu (yxsamliu)
Changes
Clang does not instantiate amdgpu_max_num_work_groups attribute with one
template argument, causing
assertion codegen.
Fixes: https://github.com/llvm/llvm-project/issues/139570
---
Full diff: h
https://github.com/yxsamliu created
https://github.com/llvm/llvm-project/pull/141633
Clang does not instantiate amdgpu_max_num_work_groups attribute with one
template argument, causing
assertion codegen.
Fixes: https://github.com/llvm/llvm-project/issues/139570
>From f4849e095e750195d072484cb
https://github.com/JDevlieghere requested changes to this pull request.
+1 on what @labath said
https://github.com/llvm/llvm-project/pull/141478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
@@ -46,20 +46,65 @@ TEST(ClangTidyOptionsProvider, InMemoryFileSystems) {
FileOptionsProvider FileOpt({}, {}, {}, FileSystem);
- ClangTidyOptions File1Options =
+ llvm::ErrorOr File1Options =
FileOpt.getOptions("ProjectRoot/SubDir1/File.cpp");
- ClangTidyOptions F
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,c,cpp --
clang/test/CIR/CodeGen/binop.c clang/test/CIR/Cod
eZWALT wrote:
gentle ping @alexey-bataev
https://github.com/llvm/llvm-project/pull/139293
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dankm wrote:
> @jdoerfert it looks like you wrote the original code I'm modifying here, so
> I'd like your feedback. Don't know who else would be interested here.
Hm, @alexey-bataev looks like this is arguably conformance related too.
https://github.com/llvm/llvm-project/pull/141250
__
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
eZWALT wrote:
gentle ping @alexey-bataev
https://github.com/llvm/llvm-project/pull/140532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
I think adding more attributes is a viable option, but it doesn't scale
particularly well and I would not be surprised if it caused some confusion in
practice.
> But maybe we can exclude functions where the attribute directly refers to a
> parameter.
This doesn't work for
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heidekrüger?= ,
Paul =?utf-8?q?Heide
https://github.com/mmha updated https://github.com/llvm/llvm-project/pull/138156
>From 66cea1ef63965b27617a6b6995ac1c5f8d8b8ed6 Mon Sep 17 00:00:00 2001
From: Morris Hafner
Date: Thu, 1 May 2025 17:27:23 +0200
Subject: [PATCH 1/4] [CIR] Upstream lowering of lvalue conditional operators
to Terna
cassiebeckley wrote:
@kazutakahirata sure, I’ll take a look
https://github.com/llvm/llvm-project/pull/134034
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 329 matches
Mail list logo
