[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread Oliver Hunt via cfe-commits
ojhunt wrote: The format problems are existing style that I don't want to reformat in this PR: ```diff diff --git a/clang/include/clang/Basic/DiagnosticCategories.h b/clang/include/clang/Basic/DiagnosticCategories.h index 52bb7a268b41..f7b2af8d194a 100644 --- a/clang/include/clang/Basic/Diagnos

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/138103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Convert SpecialCaseList::Sections from StringMap to vector. (PR #140127)

2025-05-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. Please use tag [NFC] or [NFCI] if the patch does not change any functionality. https://github.com/llvm/llvm-project/pull/140127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/139825 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
@@ -77,6 +77,8 @@ Clang Frontend Potentially Breaking Changes Clang Python Bindings Potentially Breaking Changes -- +- Calling methods on null-cursors now leads to an exception. Endilll wrote: ```suggestion - Al

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Can you swap release notes entries? They will make more sense this way when my suggestions are applied https://github.com/llvm/llvm-project/pull/138103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
@@ -77,6 +77,8 @@ Clang Frontend Potentially Breaking Changes Clang Python Bindings Potentially Breaking Changes -- +- Calling methods on null-cursors now leads to an exception. +- ``Cursor.from_location`` now returns ``None`` in

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/138103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Convert SpecialCaseList::Sections from StringMap to vector. (PR #140127)

2025-05-15 Thread Vitaly Buka via cfe-commits
@@ -132,14 +132,15 @@ class SpecialCaseList { using SectionEntries = StringMap>; struct Section { -Section(std::unique_ptr M) : SectionMatcher(std::move(M)){}; -Section() : Section(std::make_unique()) {} +Section(std::unique_ptr M) : SectionMatcher(std::move(M)

[clang] [llvm] [Sanitizer] Convert SpecialCaseList::Sections from StringMap to vector. (PR #140127)

2025-05-15 Thread Vitaly Buka via cfe-commits
@@ -38,19 +38,18 @@ SanitizerSpecialCaseList::createOrDie(const std::vector &Paths, void SanitizerSpecialCaseList::createSanitizerSections() { for (auto &It : Sections) { vitalybuka wrote: `auto& S : ` https://github.com/llvm/llvm-project/pull/140127

[clang] [llvm] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM (PR #79539)

2025-05-15 Thread Mateusz Mikuła via cfe-commits
@@ -355,6 +349,9 @@ function(add_link_opts target_name) set_property(TARGET ${target_name} APPEND_STRING PROPERTY LINK_FLAGS " -Wl,-brtl") endif() + + check_linker_flag(CXX "-Wl,-Bsymbolic-functions" mati865 wrote: I'd argue it's much f

[clang-tools-extra] [clang-tools-extra] Use llvm::replace (NFC) (PR #140200)

2025-05-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/140200 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[clang] [llvm] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM (PR #79539)

2025-05-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/79539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
@@ -1545,6 +1545,16 @@ class ExceptionSpecificationKind(BaseEnumeration): ### Cursors ### +# This guard is used to ensure that no operations are possible on null cursors Endilll wrote: Yes, I think documentation on hover is helpful, which doesn't work withou

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/140015 >From c3c0adfe4a7dce3568a81594588be53d761b5980 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 15 May 2025 15:58:00 +0900 Subject: [PATCH 1/5] [libclang/python] Ensure all library functions are re

[clang] 0f0fd62 - [Basic] Use std::optional::value_or (NFC) (#140172)

2025-05-15 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-05-15T23:28:57-07:00 New Revision: 0f0fd6213e5cbf2276ee1fb23590e51ebe41810a URL: https://github.com/llvm/llvm-project/commit/0f0fd6213e5cbf2276ee1fb23590e51ebe41810a DIFF: https://github.com/llvm/llvm-project/commit/0f0fd6213e5cbf2276ee1fb23590e51ebe41810a.diff L

[clang] [Basic] Use std::optional::value_or (NFC) (PR #140172)

2025-05-15 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/140172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
@@ -1552,68 +1563,83 @@ class Cursor(Structure): _fields_ = [("_kind_id", c_int), ("xdata", c_int), ("data", c_void_p * 3)] +_tu: TranslationUnit + @staticmethod -def from_location(tu, location): +def from_location(tu: TranslationUnit, location: SourceLoc

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,30 @@ +import os + +import clang.cindex + +if "CLANG_LIBRARY_PATH" in os.environ: +clang.cindex.Config.set_library_path(os.environ["CLANG_LIBRARY_PATH"]) + +import unittest +import ast + + +class TestLib(unittest.TestCase): +def test_functions_registered(self):

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/138103 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [llvm] [RISCV] Add `zihintpause` LLVM/Clang intrinsic (PR #139519)

2025-05-15 Thread via cfe-commits
https://github.com/imkiva closed https://github.com/llvm/llvm-project/pull/139519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] af083d0 - [RISCV] Add `zihintpause` LLVM/Clang intrinsic (#139519)

2025-05-15 Thread via cfe-commits
Author: Kiva Date: 2025-05-16T14:20:53+08:00 New Revision: af083d09bd1815bd50f2efb9f999bec145a564b1 URL: https://github.com/llvm/llvm-project/commit/af083d09bd1815bd50f2efb9f999bec145a564b1 DIFF: https://github.com/llvm/llvm-project/commit/af083d09bd1815bd50f2efb9f999bec145a564b1.diff LOG: [RI

[clang] [llvm] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM (PR #79539)

2025-05-15 Thread Fangrui Song via cfe-commits
@@ -355,6 +349,9 @@ function(add_link_opts target_name) set_property(TARGET ${target_name} APPEND_STRING PROPERTY LINK_FLAGS " -Wl,-brtl") endif() + + check_linker_flag(CXX "-Wl,-Bsymbolic-functions" MaskRay wrote: While I am aware of h

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
@@ -1763,19 +1799,22 @@ def get_usr(self): another translation unit.""" return _CXString.from_result(conf.lib.clang_getCursorUSR(self)) -def get_included_file(self): +@cursor_null_guard +def get_included_file(self) -> File: """Returns the F

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-15 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: Adapted the title and description. https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Ensure all used library functions are registered (PR #140015)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
@@ -1763,19 +1799,22 @@ def get_usr(self): another translation unit.""" return _CXString.from_result(conf.lib.clang_getCursorUSR(self)) -def get_included_file(self): +@cursor_null_guard +def get_included_file(self) -> File: """Returns the F

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread Oliver Hunt via cfe-commits
@@ -74,20 +75,23 @@ enum DiagnosticClass { struct StaticDiagInfoRec { uint16_t DiagID; LLVM_PREFERRED_TYPE(diag::Severity) - uint8_t DefaultSeverity : 3; + uint16_t DefaultSeverity : 3; LLVM_PREFERRED_TYPE(DiagnosticClass) - uint8_t Class : 3; + uint16_t Class : 3;

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
@@ -1545,6 +1545,16 @@ class ExceptionSpecificationKind(BaseEnumeration): ### Cursors ### +# This guard is used to ensure that no operations are possible on null cursors DeinAlptraum wrote: I added the docstring, but are you sure this makes sense on a decora

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
@@ -1552,68 +1553,85 @@ class Cursor(Structure): _fields_ = [("_kind_id", c_int), ("xdata", c_int), ("data", c_void_p * 3)] +_tu: TranslationUnit + +# This ensures that no operations are possible on null cursors +# by guarding all method calls with a not-null

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum commented: Adressed all review comments and added a release note for the breaking changes. https://github.com/llvm/llvm-project/pull/138103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum edited https://github.com/llvm/llvm-project/pull/138103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/138103 >From 65ad7a888dafc9992793baee8a1ccc27f1b79fa5 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 1 May 2025 18:37:43 +0900 Subject: [PATCH 1/7] [libclang/python] Add typing annotations for the Cursor

[clang-tools-extra] [clang-doc][NFC] Fix missing documentation for EndLineNumber (PR #138051)

2025-05-15 Thread Paul Kirth via cfe-commits
@@ -262,8 +262,8 @@ struct Location { std::tie(Other.StartLineNumber, Other.EndLineNumber, Other.Filename); } - int StartLineNumber = 0; // Line number of this Location. - int EndLineNumber = 0; + int StartLineNumber = 0; // Line number of this Location.

[clang] [llvm] [RISCV] Add MC layer support for XSfmm*. (PR #133031)

2025-05-15 Thread Craig Topper via cfe-commits
topperc wrote: > > Is the issue really related to this PR? Why would a MC change cause CodeGen > > errors? Is it because uncommon extension combinations? > > I've played around with the -march flag a bit more, and it doesn't seem to be > the main culprit here. For example, even using > `-marc

[clang] [llvm] [RISCV] Add MC layer support for XSfmm*. (PR #133031)

2025-05-15 Thread Jiongjia Lu via cfe-commits
Avimitin wrote: > Is the issue really related to this PR? Why would a MC change cause CodeGen > errors? Is it because uncommon extension combinations? I've try to change march combination but which doesn't seems like the root cause of this issue. Even `-march=rv32gc_zve32f_xsfmm128t` could fai

[clang] [llvm] [RISCV] Add MC layer support for XSfmm*. (PR #133031)

2025-05-15 Thread Jiongjia Lu via cfe-commits
Avimitin wrote: > can you please provide the 2 files indicated in the crash report Yes here is the files (Sorry GitHub doesn't support uploading code file, so I have to change them to txt suffix): [test-ef7560.sh.txt](https://github.com/user-attachments/files/20238776/test-ef7560.sh.txt) [test-

[clang] [libclang/python] Ensure all library functions are registered (PR #140015)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: PR title should mention somewhere that only used functions are registered. https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [libclang/python] Ensure all library functions are registered (PR #140015)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/140015 >From c3c0adfe4a7dce3568a81594588be53d761b5980 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Thu, 15 May 2025 15:58:00 +0900 Subject: [PATCH 1/4] [libclang/python] Ensure all library functions are re

[clang] [libclang/python][NFC] Refactor wildcard import of `ctypes` (PR #140191)

2025-05-15 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum approved this pull request. Good idea! LGTM https://github.com/llvm/llvm-project/pull/140191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Append file_specific_compile_options after ARG_COMPILE_FLAGS (PR #139871)

2025-05-15 Thread Wenju He via cfe-commits
wenju-he wrote: @frasercrmck please help to merge, thanks https://github.com/llvm/llvm-project/pull/139871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Improving vector code generated from scalar code (PR #140008)

2025-05-15 Thread Wenju He via cfe-commits
wenju-he wrote: > I'd also like to rename those macros at some point as I think they obfuscate > the kind of vectorization (basically, scalarization) going on. LGTM thanks @frasercrmck for the review. Please help to merge, thanks. https://github.com/llvm/llvm-project/pull/140008 _

[clang] [libclang/python][NFC] Refactor wildcard import of `ctypes` (PR #140191)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes The list is not that long. --- Full diff: https://github.com/llvm/llvm-project/pull/140191.diff 1 Files Affected: - (modified) clang/bindings/python/clang/cindex.py (+18-1) ``diff diff --g

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

2025-05-15 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: > LGTM if HighCommander4 is happy. Apologies, folks, I'm backlogged on reviews and probably won't have time to look at this for a while. If you're looking for a clangd reviewer, perhaps one of our other clangd maintainers, @llvm-beanz or @kadircet, could help with this o

[clang] [libclang/python][NFC] Refactor wildcard import of `ctypes` (PR #140191)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/140191 The list is not that long. >From 10ebe5e6ba45e747b3bee2fe686810abf91ded18 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Fri, 16 May 2025 08:12:49 +0300 Subject: [PATCH] [libclang/python][NFC] Refactor

[clang] [Driver][Haiku] Add /boot/system/develop/headers/gcc/include header path (PR #140189)

2025-05-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c -- clang/lib/Driver/ToolChains/Haiku.cpp clang/test/Dr

[clang] [Driver][Haiku] Add /boot/system/develop/headers/gcc/include header path (PR #140189)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Brad Smith (brad0) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140189.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Haiku.cpp (+2) - (modified) clang/test/Driver/haiku.c (+1) ``

[clang] [Driver][Haiku] Add /boot/system/develop/headers/gcc/include header path (PR #140189)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brad Smith (brad0) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/140189.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Haiku.cpp (+2) - (modified) clang/test/Driver/haiku.c (+1) ``diff di

[clang] [Driver][Haiku] Add /boot/system/develop/headers/gcc/include header path (PR #140189)

2025-05-15 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/140189 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sa

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

2025-05-15 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis commented: LGTM if HighCommander4 is happy. https://github.com/llvm/llvm-project/pull/139348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Ensure all library functions are registered (PR #140015)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/140015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Profile singly-resolved UnresolvedLookupExpr with the declaration (PR #140029)

2025-05-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/140029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Add typing annotations for the Cursor class (PR #138103)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Can you also add a release note? https://github.com/llvm/llvm-project/pull/138103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Ensure all library functions are registered (PR #140015)

2025-05-15 Thread Vlad Serebrennikov via cfe-commits
@@ -0,0 +1,17 @@ +import os + +from clang.cindex import Config, conf, FUNCTION_LIST + +if "CLANG_LIBRARY_PATH" in os.environ: +Config.set_library_path(os.environ["CLANG_LIBRARY_PATH"]) + +import unittest + + +class TestIndex(unittest.TestCase): +def test_functions_register

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/139825 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread via cfe-commits
@@ -74,20 +75,23 @@ enum DiagnosticClass { struct StaticDiagInfoRec { uint16_t DiagID; LLVM_PREFERRED_TYPE(diag::Severity) - uint8_t DefaultSeverity : 3; + uint16_t DefaultSeverity : 3; LLVM_PREFERRED_TYPE(DiagnosticClass) - uint8_t Class : 3; + uint16_t Class : 3;

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread via cfe-commits
@@ -74,20 +75,23 @@ enum DiagnosticClass { struct StaticDiagInfoRec { uint16_t DiagID; LLVM_PREFERRED_TYPE(diag::Severity) - uint8_t DefaultSeverity : 3; + uint16_t DefaultSeverity : 3; LLVM_PREFERRED_TYPE(DiagnosticClass) - uint8_t Class : 3; + uint16_t Class : 3;

[clang] [llvm] [CMake] Add a linker test for -Bsymbolic-functions to AddLLVM (PR #79539)

2025-05-15 Thread Brad Smith via cfe-commits
brad0 wrote: Added a comment. https://github.com/llvm/llvm-project/pull/79539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Convert SpecialCaseList::Sections from StringMap to vector. (PR #140127)

2025-05-15 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao edited https://github.com/llvm/llvm-project/pull/140127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] diagnose -mwavefrontsize64 for gfx10+ (PR #140185)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes wavefront size 64 is not fully supported for HIP on gfx10+ and it is not tested. As such, currently HIP header contains an pragma error to diagnose such use case by dete

[clang] [HIP] diagnose -mwavefrontsize64 for gfx10+ (PR #140185)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Yaxun (Sam) Liu (yxsamliu) Changes wavefront size 64 is not fully supported for HIP on gfx10+ and it is not tested. As such, currently HIP header contains an pragma error to diagnose such use case by detecting predefined macro `_

[clang] [HIP] diagnose -mwavefrontsize64 for gfx10+ (PR #140185)

2025-05-15 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/140185 wavefront size 64 is not fully supported for HIP on gfx10+ and it is not tested. As such, currently HIP header contains an pragma error to diagnose such use case by detecting predefined macro `__AMDGCN_WAVEFRO

[clang] [llvm] Convert SpecialCaseList::Sections from StringMap to vector. (PR #140127)

2025-05-15 Thread Qinkun Bao via cfe-commits
https://github.com/qinkunbao updated https://github.com/llvm/llvm-project/pull/140127 >From 4628b851c94c83c3d8fdbaa650a5c2aedf35d26c Mon Sep 17 00:00:00 2001 From: Qinkun Bao Date: Thu, 15 May 2025 19:28:42 + Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UT

[clang] [clang-format] Add IndentPPDirectives Leave option (PR #139750)

2025-05-15 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/139750 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexander Kornienko (alexfh) Changes This commit fixes https://github.com/llvm/llvm-project/issues/140130 --- Full diff: https://github.com/llvm/llvm-project/pull/140179.diff 2 Files Affected: - (modified) clang/include/clang/AST/Prope

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-15 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh created https://github.com/llvm/llvm-project/pull/140179 This commit fixes https://github.com/llvm/llvm-project/issues/140130 >From 1b484ea9910fa1277481b27c58351c1e8b5001e3 Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Fri, 16 May 2025 02:52:58 + Subje

[clang] [clang] Fix assertion failure in constexpr union deserialization (PR #140179)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Alexander Kornienko (alexfh) Changes This commit fixes https://github.com/llvm/llvm-project/issues/140130 --- Full diff: https://github.com/llvm/llvm-project/pull/140179.diff 2 Files Affected: - (modified) clang/include/clang/A

[clang] [CIR] Fix using getElementType (PR #140177)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/140177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 257dfc3 - [CIR] Fix using getElementType (#140177)

2025-05-15 Thread via cfe-commits
Author: Amr Hesham Date: 2025-05-16T04:51:58+02:00 New Revision: 257dfc3a1f568218bf923f37e20a6aff862817b6 URL: https://github.com/llvm/llvm-project/commit/257dfc3a1f568218bf923f37e20a6aff862817b6 DIFF: https://github.com/llvm/llvm-project/commit/257dfc3a1f568218bf923f37e20a6aff862817b6.diff LO

[clang] [CIR] Fix using getElementType (PR #140177)

2025-05-15 Thread Amr Hesham via cfe-commits
AmrDeveloper wrote: I will quickly merge it as a fix for the previous elementTypeIfVector PR to make it buildable https://github.com/llvm/llvm-project/pull/140177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [llvm] [HLSL] Implicit resource binding for cbuffers (PR #139022)

2025-05-15 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/139022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implicit resource binding for cbuffers (PR #139022)

2025-05-15 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/139022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f95f303 - [HLSL] Implicit resource binding for cbuffers (#139022)

2025-05-15 Thread via cfe-commits
Author: Helena Kotas Date: 2025-05-15T19:49:29-07:00 New Revision: f95f3030e595b76a3aa0295997e7dcf865c28796 URL: https://github.com/llvm/llvm-project/commit/f95f3030e595b76a3aa0295997e7dcf865c28796 DIFF: https://github.com/llvm/llvm-project/commit/f95f3030e595b76a3aa0295997e7dcf865c28796.diff

[clang] [CIR] Fix using getElementType (PR #140177)

2025-05-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes Fix for elementTypeIfVector --- Full diff: https://github.com/llvm/llvm-project/pull/140177.diff 1 Files Affected: - (modified) clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp (+1-1) ``

[clang] [CIR] Fix using getElementType (PR #140177)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/140177 Fix for elementTypeIfVector Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFon

[clang] [CIR][LLVMLowering] Upstream unary operators for VectorType (PR #139444)

2025-05-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/139444 >From 46d3b466df954eee87a5e5e7df5cb03802d468c7 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 10 May 2025 20:37:05 +0200 Subject: [PATCH 1/2] [CIR] Upstream unary operators for VectorType --- .../

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--precompile` (PR #121046)

2025-05-15 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > Is `-Fo` even relevant here? The BMI output name comes from `-ifcOutput` (or > `-fmodule-output=`). Consumption of external modules doesn't need an object, > so it would only use `-fmodule-output=`. > > > Sorry, I don't remember seeing that discussion > > See this thread:

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in DeclFriend (PR #140081)

2025-05-15 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. One comment but lgtm otherwise. https://github.com/llvm/llvm-project/pull/140081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in DeclFriend (PR #140081)

2025-05-15 Thread via cfe-commits
@@ -90,8 +90,7 @@ class FriendDecl final : Decl(Decl::Friend, DC, L), Friend(Friend), FriendLoc(FriendL), EllipsisLoc(EllipsisLoc), UnsupportedFriend(false), NumTPLists(FriendTypeTPLists.size()) { -for (unsigned i = 0; i < NumTPLists; ++i) - getTr

[clang] [NFC][Clang] Adopt simplified `getTrailingObjects` in DeclFriend (PR #140081)

2025-05-15 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/140081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--precompile` (PR #121046)

2025-05-15 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr updated https://github.com/llvm/llvm-project/pull/121046 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/139825 >From a28452d50023ca12435e2d60933852e1b6728fe1 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Tue, 13 May 2025 19:17:27 -0700 Subject: [PATCH 1/5] [NFC] Address bit-field storage sizes to ensure ideal packing

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootParams (PR #140147)

2025-05-15 Thread Alex Sepkowski via cfe-commits
@@ -155,6 +163,41 @@ std::optional RootSignatureParser::parseRootConstants() { return Constants; } +std::optional RootSignatureParser::parseRootParam() { + assert((CurToken.TokKind == TokenKind::kw_CBV || + CurToken.TokKind == TokenKind::kw_SRV || + CurTo

[clang] [llvm] [NFC] Address bit-field storage sizes to ensure ideal packing (PR #139825)

2025-05-15 Thread Oliver Hunt via cfe-commits
https://github.com/ojhunt updated https://github.com/llvm/llvm-project/pull/139825 >From a28452d50023ca12435e2d60933852e1b6728fe1 Mon Sep 17 00:00:00 2001 From: Oliver Hunt Date: Tue, 13 May 2025 19:17:27 -0700 Subject: [PATCH 1/4] [NFC] Address bit-field storage sizes to ensure ideal packing

[clang] [Serialization] Fix lazy template loading (PR #133057)

2025-05-15 Thread Maksim Ivanov via cfe-commits
emaxx-google wrote: Hello, here's the new reproducer (which compiles "before" and also in non-module mode, but not "after"): https://pastebin.com/zawQv7Q6 . Hopefully this time it's more useful than the previous attempts. https://github.com/llvm/llvm-project/pull/133057 ___

[clang] [NFCI][cfi] Refactor into 'SanitizerInfoFromCFICheckKind' (PR #140117)

2025-05-15 Thread Thurston Dang via cfe-commits
https://github.com/thurstond closed https://github.com/llvm/llvm-project/pull/140117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b07e19f - [NFCI][cfi] Refactor into 'SanitizerInfoFromCFICheckKind' (#140117)

2025-05-15 Thread via cfe-commits
Author: Thurston Dang Date: 2025-05-15T16:59:38-07:00 New Revision: b07e19fe5d0521bf0652bd073a6cedc0c4984f2b URL: https://github.com/llvm/llvm-project/commit/b07e19fe5d0521bf0652bd073a6cedc0c4984f2b DIFF: https://github.com/llvm/llvm-project/commit/b07e19fe5d0521bf0652bd073a6cedc0c4984f2b.diff

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-15 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/139429 >From e9e4634fa153a82a750360f0d41c65e2bfdf70cd Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Thu, 15 May 2025 17:41:21 -0400 Subject: [PATCH 1/2] Separate implicit int conversion on negation sign to new di

[clang] [CIR][NFC] Fix warning about unhandled Decl (PR #140159)

2025-05-15 Thread Andy Kaylor via cfe-commits
andykaylor wrote: > Is this fixing this warning? > > ``` > /local/home/ekeane/llvm-project/clang/lib/CIR/CodeGen/CIRGenDecl.cpp:270:11: > warning: enumeration value 'HLSLRootSignature' not handled in switch > [-Wswitch] > ``` Yes https://github.com/llvm/llvm-project/pull/140159 _

[clang] [clang][bytecode] Diagnose failed constexpr assertions differently (PR #140000)

2025-05-15 Thread JJ Marr via cfe-commits
https://github.com/jj-marr edited https://github.com/llvm/llvm-project/pull/14 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Diagnose failed constexpr assertions differently (PR #140000)

2025-05-15 Thread JJ Marr via cfe-commits
@@ -851,6 +851,19 @@ bool CheckCallable(InterpState &S, CodePtr OpPC, const Function *F) { if (F->isLambdaStaticInvoker()) return true; + // Diagnose failed assertions specially. + if (S.Current->getLocation(OpPC).isMacroID() && + F->getDecl()->getIdentifier()) {

[clang] 6d7b5c3 - [OpenACC][CIR] Update tests after #140122

2025-05-15 Thread via cfe-commits
Author: erichkeane Date: 2025-05-15T16:24:45-07:00 New Revision: 6d7b5c3742165d35100adc1605220b590c93ef89 URL: https://github.com/llvm/llvm-project/commit/6d7b5c3742165d35100adc1605220b590c93ef89 DIFF: https://github.com/llvm/llvm-project/commit/6d7b5c3742165d35100adc1605220b590c93ef89.diff LO

[clang] [CIR] Add PointerLikeType interface support for cir::PointerType (PR #139768)

2025-05-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-windows` running on `premerge-windows-1` while building `clang` at step 5 "clean-build-dir". Full details are available at: https://lab.llvm.org/buildbot/#/builders/35/builds/10113 Here is the relevant p

[clang] [CIR] Add PointerLikeType interface support for cir::PointerType (PR #139768)

2025-05-15 Thread Nico Weber via cfe-commits
nico wrote: …aha, it looks it's behind CLANG_ENABLE_CIR already. https://github.com/llvm/llvm-project/pull/139768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Separate implicit int conversion on negation sign to new diagnostic group (PR #139429)

2025-05-15 Thread Yutong Zhu via cfe-commits
YutongZhuu wrote: > If that warning is disruptive, maybe we should consider making it a separate > warning that people can disable independently? It is certainly a potential > source of bugs, so I'm not sure removing it entirely is the right approach > @AaronBallman H > If that warning is di

[clang] [CIR] Add PointerLikeType interface support for cir::PointerType (PR #139768)

2025-05-15 Thread Nico Weber via cfe-commits
nico wrote: It looks like this adds a dependency of clang/ on mlir/. Is that correct? As far as I can tell, this is the first dependency from clang to mlir. (Test-only, but still.) Can we make that optional? https://github.com/llvm/llvm-project/pull/139768 _

[clang] [llvm] [NFCI] [ValueTracking] Add pass to print ConstantRanges (PR #140144)

2025-05-15 Thread Florian Mayer via cfe-commits
https://github.com/fmayer updated https://github.com/llvm/llvm-project/pull/140144 >From 2d82539ce535f6725864815077111ead705d8ce4 Mon Sep 17 00:00:00 2001 From: Florian Mayer Date: Thu, 15 May 2025 14:38:00 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20ch?= =?UT

  1   2   3   4   5   6   7   >