[clang] [clang] Add managarm support (PR #139271)

MaskRay wrote: You might want to test two configurations to ensure that -rtlib= -stdlib= -unwindlib= defaults do not make the new test fail. * default * -DCLANG_DEFAULT_RTLIB=compiler-rt -DCLANG_DEFAULT_UNWINDLIB=libunwind -DCLANG_DEFAULT_CXX_STDLIB=libc++ https://github.com/llvm/llvm-projec

[clang] [clang] Add managarm support (PR #139271)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/139271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add managarm support (PR #139271)

@@ -1622,6 +1622,11 @@ // RUN: %clang_cc1 -x c -std=c99 -E -dM -ffreestanding -triple=amd64-unknown-openbsd < /dev/null | FileCheck -match-full-lines -check-prefix OPENBSD-STDC-N %s // OPENBSD-STDC-N-NOT:#define __STDC_NO_THREADS__ 1 // +// RUN: %clang_cc1 -triple=aarch64-unk

[clang] [clang] Add managarm support (PR #139271)

@@ -228,6 +228,8 @@ static const char *getLDMOption(const llvm::Triple &T, const ArgList &Args) { return "elf_iamcu"; return "elf_i386"; case llvm::Triple::aarch64: +if (T.isOSManagarm()) + return "aarch64managarm"; MaskRay wrote: Is this

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

https://github.com/marcogmaia updated https://github.com/llvm/llvm-project/pull/139348 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] [clang] Add managarm support (PR #139271)

brad0 wrote: cc @MaskRay https://github.com/llvm/llvm-project/pull/139271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Use std::tie to implement operator< (NFC) (PR #139438)

llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139438.diff 3 Files Affected: - (modified) clang/include/clang/Driver/Compilation.h (+2-8) - (modified) clang/lib/Frontend

[clang] [clang] Use std::tie to implement operator< (NFC) (PR #139438)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139438 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[clang] [Clang] Enable -fextend-lifetimes at -Og (PR #118026)

MaskRay wrote: Since the option has been renamed to `-fextend-variable-liveness`, I think you want to edit this title and the description to reflect the naming change as well. I wanted to check the status the effort and I tried `git log --grep fextend-lifetimes` but found nothing, then I reali

[clang] [Tooling] Remove a redundant call to std::unique_ptr::get (NFC) (PR #139431)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ac9b778 - [Tooling] Remove a redundant call to std::unique_ptr::get (NFC) (#139431)

Author: Kazu Hirata Date: 2025-05-10T22:51:06-07:00 New Revision: ac9b7788de773b70229efa7b56d19db20f51fe85 URL: https://github.com/llvm/llvm-project/commit/ac9b7788de773b70229efa7b56d19db20f51fe85 DIFF: https://github.com/llvm/llvm-project/commit/ac9b7788de773b70229efa7b56d19db20f51fe85.diff L

[clang] [Tooling] Remove a redundant call to std::unique_ptr::get (NFC) (PR #139431)

https://github.com/shiltian approved this pull request. https://github.com/llvm/llvm-project/pull/139431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Stop changing DC when instantiating dependent friend specializations (PR #139436)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes Since 346077aa, we began using the primary template's lexical DeclContext for template arguments in order to properly instantiate a friend definition. There is a missed peculiar case, as in a friend template

[clang] [Clang] Stop changing DC when instantiating dependent friend specializations (PR #139436)

https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/139436 Since 346077aa, we began using the primary template's lexical DeclContext for template arguments in order to properly instantiate a friend definition. There is a missed peculiar case, as in a friend template is

[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #139410)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang-tools-extra` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds

[clang-tools-extra] 066bc49 - [modularize] Use std::tie to implement operator< (NFC) (#139410)

Author: Kazu Hirata Date: 2025-05-10T20:01:28-07:00 New Revision: 066bc49f764cb24c8847d83a059684e3b6d7f4da URL: https://github.com/llvm/llvm-project/commit/066bc49f764cb24c8847d83a059684e3b6d7f4da DIFF: https://github.com/llvm/llvm-project/commit/066bc49f764cb24c8847d83a059684e3b6d7f4da.diff L

[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #139410)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #139410)

https://github.com/jansvoboda11 approved this pull request. https://github.com/llvm/llvm-project/pull/139410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Make UO_Minus and UO_Not having the same logic in TryGetExprRange (PR #139429)

https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/139429 >From b3b1714c067ab830165cef7ee96867ffbe941caa Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sat, 10 May 2025 22:11:03 -0400 Subject: [PATCH] Make UO_Minus and UO_Not having the same logic in TryGetExprRan

[clang] [Tooling] Remove a redundant call to std::unique_ptr::get (NFC) (PR #139431)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139431.diff 1 Files Affected: - (modified) clang/unittests/Tooling/DependencyScanning/DependencyScanningFilesystemTest.cpp (+1-1) ``

[clang] [Tooling] Remove a redundant call to std::unique_ptr::get (NFC) (PR #139431)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139431 None >From 6893e936f3165c7d3f755b3bad63a544df92bd3b Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 25 Mar 2025 00:24:37 -0700 Subject: [PATCH] [Tooling] Remove a redundant call to std::unique_ptr:

[clang-tools-extra] [clang-tidy] fix false negatives with type aliases in `cppcoreguidlines-pro-bounds-pointer-arithmetic` check (PR #139430)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra @llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) Changes Fixed false negatives with type aliases in `cppcoreguidlines-pro-bounds-pointer-arithmetic` check. Added tests with pointer arithmetic in template functions to m

[clang-tools-extra] [clang-tidy] fix false negatives with type aliases in `cppcoreguidlines-pro-bounds-pointer-arithmetic` check (PR #139430)

https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/139430 Fixed false negatives with type aliases in `cppcoreguidlines-pro-bounds-pointer-arithmetic` check. Added tests with pointer arithmetic in template functions to make test cases more robust. Closes https://gith

[clang] Make UO_Minus and UO_Not having the same logic in TryGetExprRange (PR #139429)

https://github.com/YutongZhuu created https://github.com/llvm/llvm-project/pull/139429 None >From 249f4ba50adf3ded14dd202ce15fdb7c7adb5e8d Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sat, 10 May 2025 22:11:03 -0400 Subject: [PATCH] Make UO_Minus and UO_Not having the same logic in TryGetE

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

https://github.com/marcogmaia edited https://github.com/llvm/llvm-project/pull/139348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

https://github.com/marcogmaia commented: @zwuis I've applied your review, thank you. https://github.com/llvm/llvm-project/pull/139348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

https://github.com/marcogmaia updated https://github.com/llvm/llvm-project/pull/139348 >From 76503bd8f5618b710e2909d1303de5d34723 Mon Sep 17 00:00:00 2001 From: Marco Maia Date: Sat, 10 May 2025 00:48:39 -0300 Subject: [PATCH 1/7] [clangd] Add tweak to add pure virtual overrides --- .../c

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

https://github.com/marcogmaia updated https://github.com/llvm/llvm-project/pull/139348 >From 76503bd8f5618b710e2909d1303de5d34723 Mon Sep 17 00:00:00 2001 From: Marco Maia Date: Sat, 10 May 2025 00:48:39 -0300 Subject: [PATCH 1/6] [clangd] Add tweak to add pure virtual overrides --- .../c

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] 8e9da21 - [clang-tidy] Use StringRef::consume_back (NFC) (#139412)

Author: Kazu Hirata Date: 2025-05-10T16:05:45-07:00 New Revision: 8e9da213ea406d3afafae2b34233308bb508b36b URL: https://github.com/llvm/llvm-project/commit/8e9da213ea406d3afafae2b34233308bb508b36b DIFF: https://github.com/llvm/llvm-project/commit/8e9da213ea406d3afafae2b34233308bb508b36b.diff L

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

@@ -0,0 +1,227 @@ +// RUN: %check_clang_tidy -std=c++2b -check-suffix=DEFAULT %s \ vbvictor wrote: You can have one test file with multiple RUN-commands with different c++ standarts using defines. Look at `clang-tools-extra/test/clang-tidy/checkers/modernize/ma

[clang-tools-extra] [clang-tidy] Use StringRef::consume_back (NFC) (PR #139412)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TableGen] Use std::tie to implement operator< (NFC) (PR #139405)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8e2a9fa - [TableGen] Use std::tie to implement operator< (NFC) (#139405)

Author: Kazu Hirata Date: 2025-05-10T16:04:26-07:00 New Revision: 8e2a9fa9a56cd6f5406f2d5cd9e3a2182d9eae86 URL: https://github.com/llvm/llvm-project/commit/8e2a9fa9a56cd6f5406f2d5cd9e3a2182d9eae86 DIFF: https://github.com/llvm/llvm-project/commit/8e2a9fa9a56cd6f5406f2d5cd9e3a2182d9eae86.diff L

[clang] [NFC][Clang][CodeGen] Remove vestigial assertion (PR #127528)

jhuber6 wrote: > @jhuber6 Was the follow-up for this backported too? I don't remember, sorry. I think the whole thing got reverted or something? https://github.com/llvm/llvm-project/pull/127528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] Better diagnostics when assertion fails in `consteval` (PR #130458)

@@ -5975,9 +5975,15 @@ static bool CheckConstexprFunction(EvalInfo &Info, SourceLocation CallLoc, Definition->hasAttr( return true; - if (Info.getLangOpts().CPlusPlus11) { -const FunctionDecl *DiagDecl = Definition ? Defin

[clang] Better diagnostics when assertion fails in `consteval` (PR #130458)

https://github.com/jj-marr updated https://github.com/llvm/llvm-project/pull/130458 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang-tools-extra] [modularize] Use a range-based for loop (NFC) (PR #139398)

vitalybuka wrote: > sanitizer-aarch64-linux-bootstrap-asan Sorry, this one caused by my zorg changes. https://github.com/llvm/llvm-project/pull/139398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [TableGen] Use std::tie to implement operator< (NFC) (PR #139405)

https://github.com/jurahul approved this pull request. https://github.com/llvm/llvm-project/pull/139405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use StringRef::consume_back (NFC) (PR #139412)

https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/139412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Use StringRef::consume_back (NFC) (PR #139412)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139412.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp (+2-3) ``diff diff --git a/cl

[clang-tools-extra] [clang-tidy] Use StringRef::consume_back (NFC) (PR #139412)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139412.diff 1 Files Affected: - (modified) clang-tools-extra/clang-tidy/utils/IncludeSorter.cpp (+2-3) ``diff diff --g

[clang-tools-extra] [clang-tidy] Use StringRef::consume_back (NFC) (PR #139412)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139412 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[clang-tools-extra] 89273e9 - [NFC][clang-tidy][docs] Fix spelling error for bugprone-crtp-constructor-accessibility (#139307)

Author: Bart Louwers Date: 2025-05-10T17:07:37-04:00 New Revision: 89273e9d1765f578f638894d1593a696d8c2a7e9 URL: https://github.com/llvm/llvm-project/commit/89273e9d1765f578f638894d1593a696d8c2a7e9 DIFF: https://github.com/llvm/llvm-project/commit/89273e9d1765f578f638894d1593a696d8c2a7e9.diff

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot2` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/8248 Here is the relevan

[clang-tools-extra] Fix spelling error crtp-constructor-accessibility.rst (PR #139307)

nicovank wrote: Thank you! https://github.com/llvm/llvm-project/pull/139307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/138708 >From c23bf23ddc8e1c8f50a57fcaf74682e86d8ade16 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 6 May 2025 17:14:35 +0200 Subject: [PATCH 1/7] [Clang] Add warnings when mixing different charN_t types c

[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #139410)

scriptforfivem wrote: The performance optimizations here are quite clever. Nice engineering work! https://github.com/llvm/llvm-project/pull/139410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #139410)

ayestoro wrote: This is a well-structured codebase. I appreciate the clean separation of concerns. https://github.com/llvm/llvm-project/pull/139410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #139410)

llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139410.diff 2 Files Affected: - (modified) clang-tools-extra/modularize/Modularize.cpp (+2-5) - (modified) clang-tools-extra/mod

[clang-tools-extra] [modularize] Use std::tie to implement operator< (NFC) (PR #139410)

https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/139410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix spelling error crtp-constructor-accessibility.rst (PR #139307)

github-actions[bot] wrote: @louwers Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang-tools-extra] [clang-tools-extra] Use std::tie to implement operator< (NFC) (PR #139410)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139410 None >From 29d26619cb5ca1e2cdcc55cd1c43239835b831b5 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 10 May 2025 09:21:24 -0700 Subject: [PATCH] [clang-tools-extra] Use std::tie to implement operato

[clang-tools-extra] Fix spelling error crtp-constructor-accessibility.rst (PR #139307)

https://github.com/nicovank closed https://github.com/llvm/llvm-project/pull/139307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

@@ -2190,3 +2192,30 @@ static bool FormatTemplateTypeDiff(ASTContext &Context, QualType FromType, TD.DiffTemplate(); return TD.Emit(); } + +std::string clang::FormatUTFCodeUnitAsCodepoint(unsigned Value, QualType T) { + auto IsSingleCodeUnitCP = [](unsigned Value, QualTyp

[clang-tools-extra] Fix spelling error crtp-constructor-accessibility.rst (PR #139307)

https://github.com/nicovank approved this pull request. https://github.com/llvm/llvm-project/pull/139307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TableGen] Use std::tie to implement operator< (NFC) (PR #139405)

https://github.com/kazutakahirata edited https://github.com/llvm/llvm-project/pull/139405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

@@ -0,0 +1,155 @@ +// RUN: %clang_cc1 -verify -fsyntax-only -std=c++20 -Wconversion %s + +void c8(char8_t); +void c16(char16_t); +void c32(char32_t); + +void test(char8_t u8, char16_t u16, char32_t u32) { +c8(u8); +c8(u16); // expected-warning {{implicit conversion from 'c

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

@@ -11810,6 +11811,46 @@ static void DiagnoseIntInBoolContext(Sema &S, Expr *E) { } } +static void DiagnoseMixedUnicodeImplicitConversion(Sema &S, const Type *Source, + const Type *Target, Expr *E, +

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

@@ -1567,15 +1568,81 @@ void Sema::checkEnumArithmeticConversions(Expr *LHS, Expr *RHS, } } +static void CheckUnicodeArithmeticConversions(Sema &SemaRef, Expr *LHS, + Expr *RHS, SourceLocation Loc, +

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

@@ -4357,6 +4357,29 @@ def warn_address_of_reference_bool_conversion : Warning< "code; pointer may be assumed to always convert to true">, InGroup; +def warn_impcast_unicode_char_type +: Warning<"implicit conversion from %0 to %1 may change the meaning of the " +

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/138708 >From c23bf23ddc8e1c8f50a57fcaf74682e86d8ade16 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 6 May 2025 17:14:35 +0200 Subject: [PATCH 1/6] [Clang] Add warnings when mixing different charN_t types c

[clang] [TableGen] Use std::tie to Implment operator< (NFC) (PR #139405)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139405 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[clang] [TableGen] Use std::tie to Implment operator< (NFC) (PR #139405)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139405.diff 2 Files Affected: - (modified) clang/utils/TableGen/MveEmitter.cpp (+2-6) - (modified) clang/utils/TableGen/NeonEmitter.cpp (+2-

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

@@ -111,6 +111,7 @@ def EnumConversion : DiagGroup<"enum-conversion", ImplicitEnumEnumCast, EnumFloatConversion, EnumCompareConditional]>; +def ImplicitUnicodeConversion : DiagGroup<

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/138708 >From c23bf23ddc8e1c8f50a57fcaf74682e86d8ade16 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 6 May 2025 17:14:35 +0200 Subject: [PATCH 1/5] [Clang] Add warnings when mixing different charN_t types c

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/8911 Here is the releva

[clang] [Cygwin] Export global symbols, template instantiations, RTTI and VTable are exported correctly (PR #138773)

https://github.com/jeremyd2019 approved this pull request. I think the changes themselves LGTM but I don't know if this is OK as one PR. @mstorsjo ? https://github.com/llvm/llvm-project/pull/138773 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] f5f8ddc - [clang] Remove redundant calls to std::unique_ptr::get (NFC) (#139399)

Author: Kazu Hirata Date: 2025-05-10T12:11:17-07:00 New Revision: f5f8ddc166b1909623f19dc134d18a4320ec485b URL: https://github.com/llvm/llvm-project/commit/f5f8ddc166b1909623f19dc134d18a4320ec485b DIFF: https://github.com/llvm/llvm-project/commit/f5f8ddc166b1909623f19dc134d18a4320ec485b.diff L

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [modularize] Use a range-based for loop (NFC) (PR #139398)

llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-bootstrap-asan` running on `sanitizer-buildbot8` while building `clang-tools-extra` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/24/builds/8293 Here i

[clang] [Clang] Demote mixed enumeration arithmetic error to a warning (PR #131811)

cor3ntin wrote: @tstellar https://github.com/llvm/llvm-project/pull/139396 https://github.com/llvm/llvm-project/pull/131811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] e0dfc49 - [modularize] Use a range-based for loop (NFC) (#139398)

Author: Kazu Hirata Date: 2025-05-10T11:03:27-07:00 New Revision: e0dfc498524175e335a8b04fda108d0d94c623bb URL: https://github.com/llvm/llvm-project/commit/e0dfc498524175e335a8b04fda108d0d94c623bb DIFF: https://github.com/llvm/llvm-project/commit/e0dfc498524175e335a8b04fda108d0d94c623bb.diff L

[clang-tools-extra] [modularize] Use a range-based for loop (NFC) (PR #139398)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/139398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

https://github.com/carlocab approved this pull request. https://github.com/llvm/llvm-project/pull/139399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/139399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [StaticAnalyzer] Handle `__builtin_bit_cast` (PR #139188)

@@ -1,5 +1,5 @@ // RUN: %clang_analyze_cc1 -triple x86_64-unknown-unknown -verify %s \ -// RUN: -analyzer-checker=core,debug.ExprInspection +// RUN: -analyzer-checker=debug.ExprInspection -analyzer-disable-checker=core ziqingluo-90 wrote: Oh, I was going to

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139399.diff 12 Files Affected: - (modified) clang/lib/AST/ASTContext.cpp (+3-3) - (modified) clang/lib/AST/ByteCode/Context.h (+1-1)

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139399.diff 12 Files Affected: - (modified) clang/lib/AST/ASTContext.cpp (+3-3) - (modified) clang/lib/AST/ByteCode/Context.h (+1-1) - (mod

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/139399.diff 12 Files Affected: - (modified) clang/lib/AST/ASTContext.cpp (+3-3) - (modified) clang/lib/AST/ByteCode/Context.h (+1-1)

[clang] [clang] Remove redundant calls to std::unique_ptr::get (NFC) (PR #139399)

https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/139399 None Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

llvmbot wrote: Failed to cherry-pick: ` https://github.com/llvm/llvm-project/actions/runs/14947694098 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-project/compare) https://github.com/llvm/ll

[clang] [Driver] Fix _XOPEN_SOURCE definition on Solaris (PR #137141)

rorth wrote: No. However, I got an [error](https://github.com/llvm/llvm-project/actions/runs/14798017932) for the `/cherry-pick` that looks like some weird internal error to me, not a failed merge attempt or some such. https://github.com/llvm/llvm-project/pull/137141

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

@@ -0,0 +1,227 @@ +// RUN: %check_clang_tidy -std=c++2b -check-suffix=DEFAULT %s \ paulhdk wrote: Again, good catch. We have that in there because for some of our tests, we overload the subscript operator to take no arguments, which is a C++23 feature. See my c

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

https://github.com/zwuis commented: Thank you for you work! Please add a release note in `clang-tools-extra/docs/ReleaseNotes.rst`. Please read and follow requirements/suggestions in this document such as preferring `llvm::SmallVector` and not usin

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

https://github.com/zwuis edited https://github.com/llvm/llvm-project/pull/139348 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clangd] Add tweak to add pure virtual overrides (PR #139348)

@@ -0,0 +1,349 @@ +//===--- AddPureVirtualOverride.cpp --*- C++-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

  1   2   >