mizvekov wrote:
I think one option would be to allow differences in macros, and rely on the ODR
checker to catch when that would cause problems.
https://github.com/llvm/llvm-project/pull/131569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
@@ -349,6 +349,17 @@ Improvements to Clang's diagnostics
- Now correctly diagnose a tentative definition of an array with static
storage duration in pedantic mode in C. (#GH50661)
+- ``-Whigher-precisision-for-complex-divison`` no longer incorrectly warns
when the divisor i
https://github.com/Maetveis updated
https://github.com/llvm/llvm-project/pull/131477
From d3da72bf61ae8268a25e5331acefe895c783905a Mon Sep 17 00:00:00 2001
From: Gergely Meszaros
Date: Sat, 15 Mar 2025 22:37:07 +0100
Subject: [PATCH 1/2] [Clang][Sema] Fix -Whigher-precision-for-complex-division
@@ -1117,16 +1205,27 @@ class Sema;
SmallVector Candidates;
llvm::SmallPtrSet Functions;
-// Allocator for ConversionSequenceLists. We store the first few of these
+DeferredTemplateOverloadCandidate *FirstDeferredCandidate;
+unsigned DeferredCandidatesCount
matts1 wrote:
> The issue is that if we allow the preprocessor's state to differ across
> modules, then the resulting compiled units can be arbitrary (and subtly
> incompatible).
>
> I wonder if a possible solution is to record which macros are used (ie, are
> expanded or appear in `#ifdef` /
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/134769
>From e2c40042553845125914e544e696d7e21b553e7d Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 7 Apr 2025 22:44:20 -0300
Subject: [PATCH] [clang] consistently quote expressions in diagnostics
This ch
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/134769
>From 7fe930def5714c196d003e94bafdb4639cea3a43 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 7 Apr 2025 22:44:20 -0300
Subject: [PATCH] [clang] consistently quote expressions in diagnostics
This ch
https://github.com/mgorny closed
https://github.com/llvm/llvm-project/pull/127345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jan Górski
Date: 2025-04-14T14:26:10-07:00
New Revision: ff687af04f5b0e85305250587b524cb0b3849aa0
URL:
https://github.com/llvm/llvm-project/commit/ff687af04f5b0e85305250587b524cb0b3849aa0
DIFF:
https://github.com/llvm/llvm-project/commit/ff687af04f5b0e85305250587b524cb0b3849aa0.diff
LO
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/135649
>From 6f0a3ba5852134d8bd04679438866e6f373f494a Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 15 Apr 2025 12:12:19 +0800
Subject: [PATCH 1/3] [Clang] Add support for GCC bound member functions
extensio
@@ -4036,6 +4036,7 @@ LangOptions getFormattingLangOpts(const FormatStyle
&Style) {
LangOpts.MicrosoftExt = 1;// To get kw___try, kw___finally.
LangOpts.DeclSpecKeyword = 1; // To get __declspec.
LangOpts.C99 = 1; // To get kw_restrict for non-underscore-prefixed res
https://github.com/rnk approved this pull request.
Thanks, looks good.
https://github.com/llvm/llvm-project/pull/133173
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/135649
>From 6f0a3ba5852134d8bd04679438866e6f373f494a Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 15 Apr 2025 12:12:19 +0800
Subject: [PATCH 1/2] [Clang] Add support for GCC bound member functions
extensio
https://github.com/ShashwathiNavada updated
https://github.com/llvm/llvm-project/pull/125643
>From 0aebcd7119fbcd51154c5d9706752e8ff3f041bc Mon Sep 17 00:00:00 2001
From: ShashwathiNavada
Date: Tue, 4 Feb 2025 00:16:09 -0600
Subject: [PATCH 1/7] Adding diagnostics for unsupported option
---
c
@@ -0,0 +1,115 @@
+//===--- RunOnNewStack.cpp - Crash Recovery
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -5687,11 +5687,11 @@ bool TokenAnnotator::mustBreakBefore(const
AnnotatedLine &Line,
if (Right.is(tok::r_brace) && Left.is(tok::l_brace) &&
!Left.Children.empty()) {
// Support AllowShortFunctionsOnASingleLine for JavaScript.
- return Style.AllowShort
mgorny wrote:
Closed in favor of #134362.
https://github.com/llvm/llvm-project/pull/127345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Losy001 wrote:
Ping
https://github.com/llvm/llvm-project/pull/134930
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5687,11 +5687,11 @@ bool TokenAnnotator::mustBreakBefore(const
AnnotatedLine &Line,
if (Right.is(tok::r_brace) && Left.is(tok::l_brace) &&
!Left.Children.empty()) {
// Support AllowShortFunctionsOnASingleLine for JavaScript.
- return Style.AllowShort
@@ -5687,11 +5687,9 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine
&Line,
if (Right.is(tok::r_brace) && Left.is(tok::l_brace) &&
!Left.Children.empty()) {
// Support AllowShortFunctionsOnASingleLine for JavaScript.
- return Style.AllowShortF
@@ -293,15 +293,14 @@ class LineJoiner {
auto ShouldMergeShortFunctions = [this, &I, &NextLine, PreviousLine,
TheLine]() {
- if (Style.AllowShortFunctionsOnASingleLine == FormatStyle::SFS_All)
+ if (Style.AllowShortFunctionsO
@@ -293,15 +293,14 @@ class LineJoiner {
auto ShouldMergeShortFunctions = [this, &I, &NextLine, PreviousLine,
TheLine]() {
- if (Style.AllowShortFunctionsOnASingleLine == FormatStyle::SFS_All)
+ if (Style.AllowShortFunctionsO
Author: Alex Voicu
Date: 2025-04-15T00:47:09+03:00
New Revision: 1bcec036e197f6ab7461722502e4393396b46ec3
URL:
https://github.com/llvm/llvm-project/commit/1bcec036e197f6ab7461722502e4393396b46ec3
DIFF:
https://github.com/llvm/llvm-project/commit/1bcec036e197f6ab7461722502e4393396b46ec3.diff
LO
wenju-he wrote:
@frasercrmck please help to review? thanks.
https://github.com/llvm/llvm-project/pull/135710
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jan Svoboda
Date: 2025-04-14T20:01:06-07:00
New Revision: 1cf9f764ac41fb3492e10c78640dd50e616388db
URL:
https://github.com/llvm/llvm-project/commit/1cf9f764ac41fb3492e10c78640dd50e616388db
DIFF:
https://github.com/llvm/llvm-project/commit/1cf9f764ac41fb3492e10c78640dd50e616388db.diff
L
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/135649
>From 6f0a3ba5852134d8bd04679438866e6f373f494a Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 15 Apr 2025 12:12:19 +0800
Subject: [PATCH] [Clang] Add support for GCC bound member functions extension
--
lenary wrote:
Oh, can you rename this. It's definitely not NFC, and should have "[RISCV]" in
the commit first line instead.
https://github.com/llvm/llvm-project/pull/135647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
AlexVlx wrote:
> LLVM Buildbot has detected a new failure on builder
> `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while
> building `clang,llvm` at step 6 "test-build-unified-tree-check-all".
>
> Full details are available at:
> https://lab.llvm.org/buildbot/#/builders/1
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
NB: This only fixes the crash introduced in Clang 19; we still accept this code
even though we shouldn’t:
```c++
struct S {
friend int f() { return 3; }
friend int f() = delete;
};
```
I tried figuring out a
macurtis-amd wrote:
> I don't, but I wonder what's the GCC behavior. It seems to suppress the
> diagnostic when processing a .i file.
Diagnostic seems to be suppressed by
[-fpreprocessed](https://gcc.gnu.org/onlinedocs/gcc/Preprocessor-Options.html#index-fpreprocessed),
which is implicit if y
efriedma-quic wrote:
Also, if you're okay with publicly posting your code, it's fine to file a bug
with an unreduced testcase.
https://github.com/llvm/llvm-project/pull/135643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jan Svoboda (jansvoboda11)
Changes
The `llvm::vfs::FileSystem` interface makes no promises around thread-safety.
To enable making `CompilerInstance` thread-safe, this PR allows passing an
explicit VFS to `cloneForModuleCompile()`. This wi
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/135737
The `llvm::vfs::FileSystem` interface makes no promises around thread-safety.
To enable making `CompilerInstance` thread-safe, this PR allows passing an
explicit VFS to `cloneForModuleCompile()`. This will
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `flang-x86_64-windows`
running on `minipc-ryzen-win` while building `clang` at step 6
"build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/166/builds/994
Here is the relevant piece of
efriedma-quic wrote:
I'm not really sure how to go about reducing a testcase in that case; it's not
something I've ever run into myself. Please post on Discourse
(https://discourse.llvm.org/); maybe someone else has some ideas.
https://github.com/llvm/llvm-project/pull/135643
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/135473
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/135687
None
>From d105489358661b0cd38b447592ff3e69a5641a7c Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 14 Apr 2025 15:01:45 -0700
Subject: [PATCH] [clang][tests] Add missing FileCheck check, NFC
---
c
https://github.com/ojhunt created
https://github.com/llvm/llvm-project/pull/135686
The P2719 implementation refactored diagnostics for cleanup delete, and as part
of that I attempted to fix handling of inaccessible cleanup operator delete.
Alas the new branch was incorrect as it was performing
yingopq wrote:
Ping.
https://github.com/llvm/llvm-project/pull/132679
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic approved this pull request.
https://github.com/llvm/llvm-project/pull/135602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Peter Collingbourne
Date: 2025-04-14T19:50:37-07:00
New Revision: 984ec70b61cb57b00e622a21b259aaf11775c5f0
URL:
https://github.com/llvm/llvm-project/commit/984ec70b61cb57b00e622a21b259aaf11775c5f0
DIFF:
https://github.com/llvm/llvm-project/commit/984ec70b61cb57b00e622a21b259aaf11775c5f0
https://github.com/kito-cheng approved this pull request.
LGTM :)
https://github.com/llvm/llvm-project/pull/132481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1170,82 +1171,117 @@ class CFGBuilder {
if (!areExprTypesCompatible(NumExpr1, NumExpr2))
return {};
+// Check that the two expressions are of the same type.
Expr::EvalResult L1Result, L2Result;
-if (!NumExpr1->EvaluateAsInt(L1Result, *Context) ||
-
https://github.com/hvdijk edited
https://github.com/llvm/llvm-project/pull/135564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/135679
NB: This only fixes the crash introduced in Clang 19; we still accept this code
even though we shouldn’t:
```c++
struct S {
friend int f() { return 3; }
friend int f() = delete;
};
```
I tried figuring
@@ -0,0 +1,89 @@
+//==-- ABIArgInfo.h - Abstract info regarding ABI-specific arguments
---==//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
This PR makes the checker ignore a function call to lambda via a local variable.
---
Full diff: https://github.com/llvm/llvm-project/pull/135688.diff
2 Files Affected:
- (modified)
clang/lib/StaticAnalyzer/
https://github.com/rjmccall edited
https://github.com/llvm/llvm-project/pull/135564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/135649
>From 6795a5143129520d2db343d768507174a70da453 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Tue, 15 Apr 2025 01:24:10 +0800
Subject: [PATCH 1/2] [Clang] Add support for GCC bound member functions
extensio
https://github.com/shiltian closed
https://github.com/llvm/llvm-project/pull/135690
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,4 +1,4 @@
-// RUN: %clang_cc1 %s -triple "spir-unknown-unknown" -emit-llvm -o - |
FileCheck %s
+// RUN: %clang_cc1 %s -triple "spir-unknown-unknown"
-fno-delete-null-pointer-checks -emit-llvm -o - | FileCheck %s
dtcxzyw wrote:
The default optimization lev
https://github.com/yxsamliu updated
https://github.com/llvm/llvm-project/pull/135229
>From 5c2283b01ac6a58e41df4260aecc01bcf463a0a9 Mon Sep 17 00:00:00 2001
From: "Yaxun (Sam) Liu"
Date: Thu, 10 Apr 2025 14:14:47 -0400
Subject: [PATCH] [Clang] add option --offload-jobs=N
for specifying number
Author: Younan Zhang
Date: 2025-04-15T09:16:55+08:00
New Revision: 83344da69145a648aad3e0cd88eab4aaf60b2142
URL:
https://github.com/llvm/llvm-project/commit/83344da69145a648aad3e0cd88eab4aaf60b2142
DIFF:
https://github.com/llvm/llvm-project/commit/83344da69145a648aad3e0cd88eab4aaf60b2142.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/134038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sean McBride (seanm)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/135720.diff
1 Files Affected:
- (modified) clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
(-1)
``diff
diff --git a/clan
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
Sirraide wrote:
> Sorry about that. This PR had become so stale that there merge conflicts and
> the easiest way to fix it was to squash because the conflicts were with
> things I later removed.
I see, yeah, it happens; that’s unfortunate...
https://github.com/llvm/llvm-project/pull/106321
_
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/134769
>From 7a777961125a31a8e721f2f78354a3b21c0a06b2 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Mon, 7 Apr 2025 22:44:20 -0300
Subject: [PATCH] [clang] consistently quote expressions in diagnostics
This ch
Author: Shilei Tian
Date: 2025-04-14T20:57:20-04:00
New Revision: f4ff209e4384d8073f36fb7da9916b33f1140edf
URL:
https://github.com/llvm/llvm-project/commit/f4ff209e4384d8073f36fb7da9916b33f1140edf
DIFF:
https://github.com/llvm/llvm-project/commit/f4ff209e4384d8073f36fb7da9916b33f1140edf.diff
L
https://github.com/mizvekov approved this pull request.
LGTM as well.
https://github.com/llvm/llvm-project/pull/134038
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
shiltian wrote:
* **#135690** https://app.graphite.dev/github/pr/llvm/llvm-project/135690?utm_source=stack-comment-icon";
target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite"
width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/135
https://github.com/andykaylor approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/135493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wenju-he created
https://github.com/llvm/llvm-project/pull/135710
llvm-diff shows this PR has no changes to amdgcn--amdhsa.bc.
Motivation is that in our downstream the same category of target built-ins,
e.g. math, are organized in several different folders. For example, in t
https://github.com/farzonl closed
https://github.com/llvm/llvm-project/pull/135655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ilovepi wrote:
### Merge activity
* **Apr 14, 8:26 PM EDT**: A user started a stack merge that includes this pull
request via
[Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/135514).
https://github.com/llvm/llvm-project/pull/135514
mizvekov wrote:
Could it be you are hitting an overflow/wrap around perhaps?
Some of these nodes store the unsignedOrNone representation in a bitfield, but
that's still 15 bits.
https://github.com/llvm/llvm-project/pull/132401
___
cfe-commits mailing
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/135687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Paul Kirth
Date: 2025-04-14T17:27:03-07:00
New Revision: 9cdc3aab3eae55be30003cb486f290f3ee3df3a8
URL:
https://github.com/llvm/llvm-project/commit/9cdc3aab3eae55be30003cb486f290f3ee3df3a8
DIFF:
https://github.com/llvm/llvm-project/commit/9cdc3aab3eae55be30003cb486f290f3ee3df3a8.diff
LO
https://github.com/c8ef closed https://github.com/llvm/llvm-project/pull/135640
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Connector Switch
Date: 2025-04-15T08:20:44+08:00
New Revision: cc354d6a6da542515fbd6f39dcb9665b7c26a008
URL:
https://github.com/llvm/llvm-project/commit/cc354d6a6da542515fbd6f39dcb9665b7c26a008
DIFF:
https://github.com/llvm/llvm-project/commit/cc354d6a6da542515fbd6f39dcb9665b7c26a008.di
Author: Cyndy Ishida
Date: 2025-04-14T17:10:23-07:00
New Revision: a686b783ce244a6dfebd17b717532c516419fc32
URL:
https://github.com/llvm/llvm-project/commit/a686b783ce244a6dfebd17b717532c516419fc32
DIFF:
https://github.com/llvm/llvm-project/commit/a686b783ce244a6dfebd17b717532c516419fc32.diff
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/135655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/farzonl edited
https://github.com/llvm/llvm-project/pull/135655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/135704
Pass a reference to `StableDirs` when creating ModuleDepCollector. This avoids
needing to create one from the same ScanInstance for each call to
`handleTopLevelModule` & reduces the amount of potential down
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qiongsi Wu (qiongsiwu)
Changes
We have had numerous situations where the negatively stat cached paths are
invalidated during the build, and such invalidations lead to build errors.
This PR adds an API to diagnose such cases.
`Dependency
https://github.com/qiongsiwu created
https://github.com/llvm/llvm-project/pull/135703
We have had numerous situations where the negatively stat cached paths are
invalidated during the build, and such invalidations lead to build errors.
This PR adds an API to diagnose such cases.
`DependencyS
@@ -2,7 +2,6 @@
// RUN: not %clang_cc1 %s -o - -S -triple=amdgcn-amd-amdhsa 2>&1 | FileCheck %s
void test_amdgcn_fence_failure() {
-
- // CHECK: error: Unsupported atomic synchronization scope
+ // CHECK: error: :0:0: in function _Z25test_amdgcn_fence_failurev
void (): Unsu
https://github.com/jeremyd2019 updated
https://github.com/llvm/llvm-project/pull/135701
>From 7ee517d33bf488749a624fb9d02ce6dcdccb089b Mon Sep 17 00:00:00 2001
From: Jeremy Drake
Date: Mon, 14 Apr 2025 14:43:42 -0700
Subject: [PATCH] [Clang] [Driver] use __cxa_atexit by default on Cygwin.
GCC
https://github.com/AlexVlx updated
https://github.com/llvm/llvm-project/pull/134016
>From 91eeaf02336e539f14dcb0a79ff15dbe8befe6f1 Mon Sep 17 00:00:00 2001
From: Alex Voicu
Date: Wed, 2 Apr 2025 02:47:42 +0100
Subject: [PATCH 01/11] Add the functional identity and feature queries.
---
clang/d
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv
jeremyd2019 wrote:
Noticed while `g++ -S` to `clang++ -S` output while tracking another issue.
https://github.com/llvm/llvm-project/pull/135701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jeremyd2019)
Changes
GCC on Cygwin and MSYS2 are built with --enable-__cxa_atexit.
Adjust test to expect this change.
/cc @mstrosjo @mati865
---
Full diff: https://github.com/llvm/llvm-project/pull/135701.diff
2 Files Affected:
https://github.com/jeremyd2019 created
https://github.com/llvm/llvm-project/pull/135701
GCC on Cygwin and MSYS2 are built with --enable-__cxa_atexit.
Adjust test to expect this change.
/cc @mstrosjo @mati865
>From e3ff93c0aea6648378e1385cb280236c6d580402 Mon Sep 17 00:00:00 2001
From: Jeremy
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?=
Message-ID:
In-Reply-To:
https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-pr
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?= ,
Jan =?utf-8?q?Górski?=
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
@janagor Congratulations on having your fi
@@ -1206,82 +1198,70 @@
createCompilerInstanceForModuleCompileImpl(CompilerInstance &ImportingInstance,
DiagnosticOptions &DiagOpts = Invocation->getDiagnosticOpts();
DiagOpts.VerifyDiagnostics = 0;
- assert(ImportingInstance.getInvocation().getModuleHash() ==
-
wenju-he wrote:
> Note I'm in the process of introducing elementwise clz/ctz builtins which
> would accomplish this and achieve vector intrinsics. See #131995. It might be
> worth waiting for that change instead?
thanks @frasercrmck
LGTM. Please refactor clz after #131995
close this PR.
http
Sterling-Augustine wrote:
No worries. The only bots left were marked "Experimental, ignore results" and
they are super slow running.
https://github.com/llvm/llvm-project/pull/135686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/wenju-he closed
https://github.com/llvm/llvm-project/pull/135301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -605,13 +605,11 @@ void BackendConsumer::UnsupportedDiagHandler(
// Context will be nullptr for IR input files, we will construct the diag
// message from llvm::DiagnosticInfoUnsupported.
- if (Context != nullptr) {
+ if (Context != nullptr)
Loc = getBestLocation
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jeremyd2019)
Changes
Add a new Cygwin toolchain that just goes through the motions to initialize the
Generic_GCC base properly. This allows removing some old, almost certainly
wrong hard-coded paths from Lex/InitHeaderSearch.cpp
T
https://github.com/farzonl converted_to_draft
https://github.com/llvm/llvm-project/pull/135655
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -35,6 +35,7 @@ enum OffloadKind : uint16_t {
OFK_OpenMP,
OFK_Cuda,
OFK_HIP,
+ OFK_SYCL,
asudarsa wrote:
As proposed by @jhuber6 earlier, I will submit a separate PR to make changes to
offload kind representation.
And then update this PR after that g
@@ -464,7 +464,8 @@ fatbinary(ArrayRef>
InputFiles,
} // namespace amdgcn
namespace generic {
-Expected clang(ArrayRef InputFiles, const ArgList &Args)
{
+Expected clang(ArrayRef InputFiles, const ArgList &Args,
+ bool HasSYCLOffloadKind = false) {
-
@@ -35,6 +35,7 @@ enum OffloadKind : uint16_t {
OFK_OpenMP,
OFK_Cuda,
OFK_HIP,
+ OFK_SYCL,
asudarsa wrote:
As mentioned earlier
(https://github.com/llvm/llvm-project/pull/135683#discussion_r2043140354), it
might be better to address this change in a s
Author: Oliver Hunt
Date: 2025-04-14T16:16:29-07:00
New Revision: b9a3e998b1921f7d1e3093f27d288ee1a121ba4b
URL:
https://github.com/llvm/llvm-project/commit/b9a3e998b1921f7d1e3093f27d288ee1a121ba4b
DIFF:
https://github.com/llvm/llvm-project/commit/b9a3e998b1921f7d1e3093f27d288ee1a121ba4b.diff
L
@@ -3871,7 +3874,8 @@ class ASTIdentifierTableTrait {
if (isInterestingIdentifier(II, MacroOffset)) {
DataLen += 2; // 2 bytes for builtin ID
DataLen += 2; // 2 bytes for flags
- if (MacroOffset)
+ if (MacroOffset || (II->hasMacroDefinition() &&
+
@@ -937,13 +961,47 @@ Expected> linkAndWrapDeviceFiles(
InputFiles.emplace_back(*FileNameOrErr);
}
+if (HasSYCLOffloadKind) {
+ // Link the remaining device files using the device linker.
+ auto OutputOrErr = linkDevice(InputFiles, LinkerArgs,
HasSYCLO
@@ -464,7 +464,8 @@ fatbinary(ArrayRef>
InputFiles,
} // namespace amdgcn
namespace generic {
-Expected clang(ArrayRef InputFiles, const ArgList &Args)
{
+Expected clang(ArrayRef InputFiles, const ArgList &Args,
+ bool HasSYCLOffloadKind = false) {
-
https://github.com/AlexVlx closed
https://github.com/llvm/llvm-project/pull/135697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 461 matches
Mail list logo
