[clang] [clang][scan-build] Treat --use-cc and --use-c++ as shell commands (PR #131932)

2025-03-19 Thread Balázs Benics via cfe-commits
https://github.com/balazs-benics-sonarsource approved this pull request. Thanks for the context. It looks good to me now. @haoNoQ, maybe you know some Perl, could you have a second opinion? Otherwise, let's merge this in a week. https://github.com/llvm/llvm-project/pull/131932 _

[clang] [llvm] [X86][CodeGen] - Use shift operators for const value shifts, instead of built-ins for SSE emulation of MMX intrinsics. (PR #129197)

2025-03-19 Thread Pawan Nirpal via cfe-commits
pawan-nirpal-031 wrote: ping @arsenm https://github.com/llvm/llvm-project/pull/129197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add `HeaderInsertion` yaml config option (PR #128503)

2025-03-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/128503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Diagnostics] Update select uses in DiagnosticXKinds.td to use enum_select (PR #130868)

2025-03-19 Thread Erich Keane via cfe-commits
erichkeane wrote: Latest patch looks right! Just change the Github subject and Commit message to better reflect what this patch is doing, and I can approve. IF that happens, either merge yourself (if you have permissions), or ping me after CI is happy, and I'll merge this for you. https://

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread via cfe-commits
https://github.com/metkarpoonam updated https://github.com/llvm/llvm-project/pull/131900 >From 7ef40ee7d88872dbee1345cbd822e4aed8a22626 Mon Sep 17 00:00:00 2001 From: Poonam Vilas Metkar Date: Tue, 18 Mar 2025 11:30:15 -0700 Subject: [PATCH 01/10] Add codegen tests, Sema tests, SPIR-V backend t

[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-03-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/131804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix UEFI Target info (PR #127290)

2025-03-19 Thread via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/127290 >From 3e6122744f355954edb6a5450ae4220ba39bc9c1 Mon Sep 17 00:00:00 2001 From: prabhukr Date: Fri, 14 Feb 2025 16:53:33 -0800 Subject: [PATCH 01/11] [clang] Fix UEFI Target info For X64 UEFI targets, making the

[clang] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo (PR #131976)

2025-03-19 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/131976 >From 163c73d21af736c94f1bb8f8c63caf96e127aba5 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Wed, 19 Mar 2025 13:21:48 +0800 Subject: [PATCH 1/2] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo fixes https://g

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilb (Long Branch) extension (PR #131996)

2025-03-19 Thread via cfe-commits
https://github.com/hchandel closed https://github.com/llvm/llvm-project/pull/131996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix UEFI Target info (PR #127290)

2025-03-19 Thread via cfe-commits
https://github.com/Prabhuk updated https://github.com/llvm/llvm-project/pull/127290 >From 3e6122744f355954edb6a5450ae4220ba39bc9c1 Mon Sep 17 00:00:00 2001 From: prabhukr Date: Fri, 14 Feb 2025 16:53:33 -0800 Subject: [PATCH 01/12] [clang] Fix UEFI Target info For X64 UEFI targets, making the

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilb (Long Branch) extension (PR #131996)

2025-03-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang,llvm` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/18020 Here is the r

[clang-tools-extra] [clang-doc] Avoid deref of invalid std::optional (PR #131939)

2025-03-19 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/131939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0744d49 - [RISCV] Add Qualcomm uC Xqcilb (Long Branch) extension (#131996)

2025-03-19 Thread via cfe-commits
Author: quic_hchandel Date: 2025-03-20T11:14:53+05:30 New Revision: 0744d4926a0c567b0f10d19f0478b7a4bf960a19 URL: https://github.com/llvm/llvm-project/commit/0744d4926a0c567b0f10d19f0478b7a4bf960a19 DIFF: https://github.com/llvm/llvm-project/commit/0744d4926a0c567b0f10d19f0478b7a4bf960a19.diff

[clang] [llvm] [RISCV] Add Qualcomm uC Xqcilb (Long Branch) extension (PR #131996)

2025-03-19 Thread via cfe-commits
hchandel wrote: Windows build has passed but linux build failed. The failed linux build seems unrelated. I am going ahead and merging the PR. https://github.com/llvm/llvm-project/pull/131996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] 6003c30 - [clang] NFC: Unify implementations of CheckMemberPointerConversion (#131966)

2025-03-19 Thread via cfe-commits
Author: Matheus Izvekov Date: 2025-03-19T22:48:49-03:00 New Revision: 6003c3055a4630be31cc3d459cdbb88248a007b9 URL: https://github.com/llvm/llvm-project/commit/6003c3055a4630be31cc3d459cdbb88248a007b9 DIFF: https://github.com/llvm/llvm-project/commit/6003c3055a4630be31cc3d459cdbb88248a007b9.dif

[clang] [ByteCode] Avoid repeated hash lookups (NFC) (PR #132141)

2025-03-19 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr approved this pull request. https://github.com/llvm/llvm-project/pull/132141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C23] Fix compound literals within function prototype (PR #132097)

2025-03-19 Thread Timm Baeder via cfe-commits
@@ -7141,7 +7141,13 @@ Sema::BuildCompoundLiteralExpr(SourceLocation LParenLoc, TypeSourceInfo *TInfo, return ExprError(); LiteralExpr = Result.get(); - bool isFileScope = !CurContext->isFunctionOrMethod(); + // We treat the compound literal as being at file scope if

[clang] [X86][AVX10.2] Use 's_' for saturate-convert intrinsics (PR #131592)

2025-03-19 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > Went through the patch with my eyes, I'm not sure how useful it was but > wasn't able to spot anything. > > > Here is GCC patch: > > https://gcc.gnu.org/pipermail/gcc-patches/2025-March/678227.html > > I haven't found any changes regarding `vcvt2ph2` and no other similar

[clang] [libclang/python] Add equality comparison operators for File (PR #130383)

2025-03-19 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/130383 >From 8a206611120c15010381e1570c2b4d7548142dbd Mon Sep 17 00:00:00 2001 From: Mathias Stearn Date: Thu, 19 Dec 2024 16:22:04 +0100 Subject: [PATCH 1/2] [libclang/python] Add equality comparison operators fo

[clang] [OpenMP 6.0] Parse/Sema support for reduction over private variable with reduction clause. (PR #129938)

2025-03-19 Thread Alexey Bataev via cfe-commits
@@ -3757,6 +3768,31 @@ class OMPReductionClause final /// reduction copies. void setRHSExprs(ArrayRef RHSExprs); + /// Set the list private reduction flags + void setPrivateVariableReductionFlags(ArrayRef Flags) { +assert(Flags.size() == varlist_size() && +

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #132142)

2025-03-19 Thread Krzysztof Drewniak via cfe-commits
https://github.com/krzysz00 approved this pull request. https://github.com/llvm/llvm-project/pull/132142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-19 Thread Daniel Chen via cfe-commits
https://github.com/DanielCChen edited https://github.com/llvm/llvm-project/pull/131200 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][analyzer] Multipart checker refactor 1: VirtualCallChecker (PR #132072)

2025-03-19 Thread Donát Nagy via cfe-commits
@@ -694,15 +694,11 @@ def MoveChecker: Checker<"Move">, ]>, Documentation; -def VirtualCallModeling : Checker<"VirtualCallModeling">, - HelpText<"Auxiliary modeling for the virtual method call checkers">, - Documentation, - Hidden; - -def PureVirtualCallChecker : Checke

[clang] [clang][diagnostics] Update note_constexpr_invalid_cast to use enum_select and adjust its uses (PR #130868)

2025-03-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/130868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bdca412 - [clang] Auto-detect which newline style to use for `cxx_dr_status.html` (#132045)

2025-03-19 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2025-03-20T00:11:38+04:00 New Revision: bdca412681d668231aed0cb58b450713e8f9b01a URL: https://github.com/llvm/llvm-project/commit/bdca412681d668231aed0cb58b450713e8f9b01a DIFF: https://github.com/llvm/llvm-project/commit/bdca412681d668231aed0cb58b450713e8f9b01a.

[clang-tools-extra] [clang-tidy][C++20] Add support for aggregate types within modernize-use-emplace (PR #131969)

2025-03-19 Thread David Rivera via cfe-commits
https://github.com/RiverDave edited https://github.com/llvm/llvm-project/pull/131969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream a basic version of class LexicalScope (PR #131945)

2025-03-19 Thread Andy Kaylor via cfe-commits
andykaylor wrote: The `CIR/Lowering/func-simple.cpp` test is failing after this merge because of my change to introduce the canonicalize pass. I'll update the test as part of my type alias patch. https://github.com/llvm/llvm-project/pull/131945 ___ c

[clang-tools-extra] [clang-tidy][C++20] Add support for aggregate types within modernize-use-emplace (PR #131969)

2025-03-19 Thread David Rivera via cfe-commits
https://github.com/RiverDave edited https://github.com/llvm/llvm-project/pull/131969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][C++20] Add support for aggregate types within modernize-use-emplace (PR #131969)

2025-03-19 Thread David Rivera via cfe-commits
https://github.com/RiverDave edited https://github.com/llvm/llvm-project/pull/131969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV][MC] Implement MC for Base P extension (PR #123271)

2025-03-19 Thread Craig Topper via cfe-commits
@@ -0,0 +1,1079 @@ +//===-- RISCVInstrInfoP.td - RISC-V 'P' instructions ---*- tablegen -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[clang] [llvm] [RISCV] Add Zilsd and Zclsd Extensions (PR #131094)

2025-03-19 Thread Sam Elliott via cfe-commits
https://github.com/lenary closed https://github.com/llvm/llvm-project/pull/131094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread Farzon Lotfi via cfe-commits
@@ -80,6 +80,25 @@ void asuint(double3, out uint3, out uint3); _HLSL_BUILTIN_ALIAS(__builtin_hlsl_elementwise_splitdouble) void asuint(double4, out uint4, out uint4); +//===--===// +// asint16 builtins +//===-

[clang-tools-extra] [clang-tidy][C++20] Add support for aggregate types within modernize-use-emplace (PR #131969)

2025-03-19 Thread Baranov Victor via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %check_clang_tidy %s modernize-use-emplace %t -- \ +// RUN: %check_clang_tidy %s -std=c++17 modernize-use-emplace %t -- \ vbvictor wrote: check has `LangOpts.CPlusPlus11`, so this need to be removed ```suggestion // RUN: %check_clang_tidy

[clang-tools-extra] [clangd] Add `HeaderInsertion` yaml config option (PR #128503)

2025-03-19 Thread Nathan Ridge via cfe-commits
@@ -668,6 +668,7 @@ class FlagsConfigProvider : public config::Provider { std::optional IndexSpec; std::optional BGPolicy; std::optional ArgumentLists; +std::optional _HeaderInsertion; HighCommander4 wrote: nit: I haven't seen this convention (

[clang-tools-extra] [clangd] Add `HeaderInsertion` yaml config option (PR #128503)

2025-03-19 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 approved this pull request. Thanks! This looks good modulo a couple of remaining nits. https://github.com/llvm/llvm-project/pull/128503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread Farzon Lotfi via cfe-commits
@@ -19,3 +20,13 @@ entry: %res = bitcast half %val2 to i16 ret i16 %res } + +; Function Attrs: alwaysinline mustprogress nofree norecurse nosync nounwind willreturn memory(none) +define <4 x i16> @test_vector_half4(<4 x half> nofpclass(nan inf) %p1) { +entry: + ; CHECK: %

[clang] [clang] NFC: Unify implementations of CheckMemberPointerConversion (PR #131966)

2025-03-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/18014 Here is the releva

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread via cfe-commits
@@ -80,6 +80,34 @@ void asuint(double3, out uint3, out uint3); _HLSL_BUILTIN_ALIAS(__builtin_hlsl_elementwise_splitdouble) void asuint(double4, out uint4, out uint4); +//===--===// +// asint16 builtins +//===-

[clang] [CIR] Upstream global initialization for ArrayType (PR #131657)

2025-03-19 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper closed https://github.com/llvm/llvm-project/pull/131657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo (PR #131976)

2025-03-19 Thread Ben Shi via cfe-commits
https://github.com/benshi001 updated https://github.com/llvm/llvm-project/pull/131976 >From 163c73d21af736c94f1bb8f8c63caf96e127aba5 Mon Sep 17 00:00:00 2001 From: Ben Shi Date: Wed, 19 Mar 2025 13:21:48 +0800 Subject: [PATCH 1/2] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo fixes https://g

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread via cfe-commits
https://github.com/metkarpoonam updated https://github.com/llvm/llvm-project/pull/131900 >From 7ef40ee7d88872dbee1345cbd822e4aed8a22626 Mon Sep 17 00:00:00 2001 From: Poonam Vilas Metkar Date: Tue, 18 Mar 2025 11:30:15 -0700 Subject: [PATCH 1/7] Add codegen tests, Sema tests, SPIR-V backend tes

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread via cfe-commits
https://github.com/metkarpoonam updated https://github.com/llvm/llvm-project/pull/131900 >From 7ef40ee7d88872dbee1345cbd822e4aed8a22626 Mon Sep 17 00:00:00 2001 From: Poonam Vilas Metkar Date: Tue, 18 Mar 2025 11:30:15 -0700 Subject: [PATCH 1/8] Add codegen tests, Sema tests, SPIR-V backend tes

[clang] [clang-tools-extra] [clang] NFC: Clear some uses of MemberPointerType::getClass (PR #131965)

2025-03-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang-tools-extra,clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/149

[clang-tools-extra] [clang-doc] Avoid deref of invalid std::optional (PR #131939)

2025-03-19 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/131939 >From 215f9a312eaaedd4278006a6f4857ab4702ed38e Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 18 Mar 2025 23:38:09 + Subject: [PATCH] [clang-doc] Avoid deref of invalid std::optional Since our existin

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread via cfe-commits
@@ -0,0 +1,29 @@ +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.2-library %s -fnative-half-type -verify + + +int16_t4 test_asint_too_many_arg(uint16_t p0, uint16_t p1) +{ +return asint16(p0, p1); + // expected-error@-1 {{no matching function for ca

[clang] [compiler-rt] [Coverage] Fix region termination for GNU statement expressions (PR #130976)

2025-03-19 Thread Justin Cady via cfe-commits
https://github.com/justincady closed https://github.com/llvm/llvm-project/pull/130976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f157365 - [clang][NFC] Bump latest release number for C++ DR status page

2025-03-19 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2025-03-20T01:58:55+03:00 New Revision: f157365a0b0f1dab12f7e8fcbf603a232e611792 URL: https://github.com/llvm/llvm-project/commit/f157365a0b0f1dab12f7e8fcbf603a232e611792 DIFF: https://github.com/llvm/llvm-project/commit/f157365a0b0f1dab12f7e8fcbf603a232e611792.

[clang-tools-extra] [clang-doc] Avoid deref of invalid std::optional (PR #131939)

2025-03-19 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/131939 >From d7fe558c1c7a3f18bc4019e6edcd86e2a98a46a0 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 18 Mar 2025 23:38:09 + Subject: [PATCH] [clang-doc] Avoid deref of invalid std::optional Since our existin

[clang] [clang-tools-extra] [Clang] [Sema] Make -Wreturn-type an error by default (PR #131207)

2025-03-19 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/131207 >From bff3db4f6a7fdff572b662048f395c280a11d94b Mon Sep 17 00:00:00 2001 From: Sirraide Date: Thu, 13 Mar 2025 21:18:14 +0100 Subject: [PATCH 1/3] [Clang] [Sema] Make -Wreturn-type an error by default --- clan

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-19 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/132091 >From 68ebbf821176dd17a757c32771fa728f21d4dd11 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Wed, 19 Mar 2025 21:05:38 +0100 Subject: [PATCH] [Clang] Fix UB in #131515 It turns out trailing objects are u

[clang] [Clang] emit -Wunused-variable warning for unused structured bindings without the [[maybe_unused]] attribute (PR #127061)

2025-03-19 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/127061 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Increase the default expression nesting limit (PR #132021)

2025-03-19 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: I think you need to update this too, unless I missed something: https://clang.llvm.org/docs/UsersManual.html#controlling-implementation-limits https://github.com/llvm/llvm-project/pull/132021 ___ cfe-commits mailin

[clang] [clang] Remove deprecated `FileManager` APIs (PR #132063)

2025-03-19 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. https://github.com/llvm/llvm-project/pull/132063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream cir-canonicalize pass (PR #131891)

2025-03-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/7443 Here is the releva

[clang] [NFC] Add a leading comment to boolean arguments. (PR #131746)

2025-03-19 Thread Michael Park via cfe-commits
https://github.com/mpark closed https://github.com/llvm/llvm-project/pull/131746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo (PR #131976)

2025-03-19 Thread Eli Friedman via cfe-commits
@@ -114,3 +114,13 @@ struct s15 fooa(char a, char b) { x.arr[1] = b; return x; } + +struct s8_t { + char a; +}; + +// AVR-NOT: {{.*}} signext +// TINY-NOT: {{.*}} signext efriedma-quic wrote: Can you rewrite this test to avoid "NOT"? Something like `//

[clang-tools-extra] [clang-tidy] support query based custom check (PR #131804)

2025-03-19 Thread Ibraim Ganiev via cfe-commits
olologin wrote: Splitting config to multiple files is potentially bad because caching wrappers need to be adjusted to take into account this new type of input file (they only know about .clang-tidy file). https://github.com/llvm/llvm-project/pull/131804

[clang] [C23] Fix compound literals within function prototype (PR #132097)

2025-03-19 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/132097 >From 7882bfbbe7ada59de91625c5f0365cec1fbe3c5b Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Wed, 19 Mar 2025 16:50:12 -0400 Subject: [PATCH 1/4] [C23] Fix compound literals within function prototype

[clang] [C23] Fix compound literals within function prototype (PR #132097)

2025-03-19 Thread Aaron Ballman via cfe-commits
@@ -849,13 +849,11 @@ namespace CompoundLiterals { } static_assert(get5() == 5, ""); - constexpr int get6(int f = (int[]){1,2,6}[2]) { // ref-note {{subexpression not valid in a constant expression}} \ - // ref-note {{decl

[clang] [Clang] Force expressions with UO_Not to not be non-negative (PR #126846)

2025-03-19 Thread Richard Smith via cfe-commits
zygoloid wrote: > Would it be possible to provide better fine grained control over the > `-Wsign-compare` so the clang could still flag the the cases like the one in > the summary but ignore the cases where implicit conversion has no side > effects or UB? The warning being produced is a `-Wim

[clang] [Offload] Handle `BoundArchitecture` for non-GPU targets (PR #132037)

2025-03-19 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Please take a look at the sanitizer buildbot failure above. I don't know how a clang driver change that only affects SYCL and OpenMP offloading could cause JIT to fail. https://github.com/llvm/llvm-project/pull/132037 ___ cfe-commits

[clang] [HLSL] error on out of bounds vector accesses (PR #128952)

2025-03-19 Thread Eli Friedman via cfe-commits
@@ -14054,6 +14054,23 @@ void Sema::CheckCastAlign(Expr *Op, QualType T, SourceRange TRange) { << TRange << Op->getSourceRange(); } +void Sema::CheckVectorAccess(const Expr *BaseExpr, const Expr *IndexExpr) { + const auto *VTy = BaseExpr->getType()->getAs(); + if (!VTy)

[clang] 01d28c1 - [Clang] emit -Wunused-variable warning for unused structured bindings without the [[maybe_unused]] attribute (#127061)

2025-03-19 Thread via cfe-commits
Author: Oleksandr T. Date: 2025-03-19T23:06:10+02:00 New Revision: 01d28c1cd7862fb75c8e353b2b18d13f9801b327 URL: https://github.com/llvm/llvm-project/commit/01d28c1cd7862fb75c8e353b2b18d13f9801b327 DIFF: https://github.com/llvm/llvm-project/commit/01d28c1cd7862fb75c8e353b2b18d13f9801b327.diff

[clang] a306ae0 - Fix malformed RST in release notes; NFC

2025-03-19 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2025-03-19T17:05:16-04:00 New Revision: a306ae0eca4d4d016b719df32274ba1f73f4413a URL: https://github.com/llvm/llvm-project/commit/a306ae0eca4d4d016b719df32274ba1f73f4413a DIFF: https://github.com/llvm/llvm-project/commit/a306ae0eca4d4d016b719df32274ba1f73f4413a.diff

[clang] [CIR] Upstream support for type aliases (PR #131912)

2025-03-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor updated https://github.com/llvm/llvm-project/pull/131912 >From a635a7d62251eb1b33218d5ba9fa34ad7a8f5567 Mon Sep 17 00:00:00 2001 From: Andy Kaylor Date: Tue, 18 Mar 2025 13:48:03 -0700 Subject: [PATCH 1/2] [CIR] Upstream support for type aliases and clean up tests

[clang-tools-extra] Add option to exclude headers from clang-tidy analysis (PR #91400)

2025-03-19 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: Looks like I can add `tags = ["noclangtidy"],` to my bazel rules for my headers I'm trying to exclude. That works for me! https://github.com/llvm/llvm-project/pull/91400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [CIR] Follow up for addressing style comment (PR #132093)

2025-03-19 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/132093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-19 Thread Florian Mayer via cfe-commits
https://github.com/fmayer approved this pull request. https://github.com/llvm/llvm-project/pull/132091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bd2d8c0 - Revert "[Coverage] Fix region termination for GNU statement expressions" (#132095)

2025-03-19 Thread via cfe-commits
Author: Justin Cady Date: 2025-03-19T16:48:34-04:00 New Revision: bd2d8c0a7ee196cc60ab0d46d6fab416b1697ae1 URL: https://github.com/llvm/llvm-project/commit/bd2d8c0a7ee196cc60ab0d46d6fab416b1697ae1 DIFF: https://github.com/llvm/llvm-project/commit/bd2d8c0a7ee196cc60ab0d46d6fab416b1697ae1.diff L

[clang] [Offload] Handle `BoundArchitecture` for non-GPU targets (PR #132037)

2025-03-19 Thread Florian Mayer via cfe-commits
fmayer wrote: Please take a look at the sanitizer buildbot failure above. https://github.com/llvm/llvm-project/pull/132037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Add option to exclude headers from clang-tidy analysis (PR #91400)

2025-03-19 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: hmm...thanks for testing it out. I think something else must be going wrong for me. I'm running clang-tidy via bazel via [bazel_clang_tidy](https://github.com/erenon/bazel_clang_tidy) which is perhaps complicating things. It seems to be running on my .h files itself(?)

[clang] [C23] Fix compound literals within function prototype (PR #132097)

2025-03-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes WG14 N2819 clarified that a compound literal within a function prototype has a lifetime similar to that of a local variable within the function, not a file scope variable. --- Full diff: https://githu

[clang] [compiler-rt] Revert "[Coverage] Fix region termination for GNU statement expressions" (PR #132095)

2025-03-19 Thread Justin Cady via cfe-commits
https://github.com/justincady created https://github.com/llvm/llvm-project/pull/132095 Reverts llvm/llvm-project#130976 Breaks clang-cmake-x86_64-avx512-linux bot. >From 2f37c9ec685b8ba82fdc3bd8387ce59b3f8a77dc Mon Sep 17 00:00:00 2001 From: Justin Cady Date: Wed, 19 Mar 2025 16:45:26 -0400 S

[clang] 0f7bd60 - [NFC] Add a leading comment to boolean arguments. (#131746)

2025-03-19 Thread via cfe-commits
Author: Michael Park Date: 2025-03-19T13:43:16-07:00 New Revision: 0f7bd60791ed18b98f84916d0dd371508cbf208c URL: https://github.com/llvm/llvm-project/commit/0f7bd60791ed18b98f84916d0dd371508cbf208c DIFF: https://github.com/llvm/llvm-project/commit/0f7bd60791ed18b98f84916d0dd371508cbf208c.diff

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-19 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/132091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP 6.0] Parse/Sema support for reduction over private variable with reduction clause. (PR #129938)

2025-03-19 Thread Alexey Bataev via cfe-commits
@@ -3757,6 +3768,31 @@ class OMPReductionClause final /// reduction copies. void setRHSExprs(ArrayRef RHSExprs); + /// Set the list private reduction flags + void setPrivateVariableReductionFlags(ArrayRef Flags) { +assert(Flags.size() == varlist_size() && +

[clang] [OpenMP 6.0] Parse/Sema support for reduction over private variable with reduction clause. (PR #129938)

2025-03-19 Thread Alexey Bataev via cfe-commits
@@ -3854,6 +3890,7 @@ class OMPReductionClause final /// region with this clause. /// \param PostUpdate Expression that must be executed after exit from the /// OpenMP region with this clause. + /// \pram IsPrivateVarReduction array for private variable reduction flags -

[clang] [OpenMP 6.0] Parse/Sema support for reduction over private variable with reduction clause. (PR #129938)

2025-03-19 Thread Alexey Bataev via cfe-commits
@@ -1160,6 +1162,12 @@ class SemaOpenMP : public SemaBase { SmallVector AllocClauseModifiersLoc; Expr *AllocateAlignment = nullptr; +struct OpenMPReductionClauseModifiers { + int ExtraModifier; + int OriginalSharingModifier; + OpenMPReductionC

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-19 Thread Florian Mayer via cfe-commits
@@ -1681,7 +1681,7 @@ std::optional Sema::GetDecompositionElementCount(QualType T, llvm::APSInt TupleSize(Ctx.getTypeSize(Ctx.getSizeType())); switch (isTupleLike(*this, Loc, T, TupleSize)) { case IsTupleLike::Error: -return {}; +return std::nullopt;

[clang] [clang][CodeGen][AVR] Fix a crash in AVRABIInfo (PR #131976)

2025-03-19 Thread Eli Friedman via cfe-commits
@@ -135,7 +135,8 @@ class AVRTargetCodeGenInfo : public TargetCodeGenInfo { if (GV->isDeclaration()) return; const auto *FD = dyn_cast_or_null(D); -if (!FD) return; +if (!FD) efriedma-quic wrote: Please don't reformat code that isn't rele

[clang] [CIR] Upstream a basic version of class LexicalScope (PR #131945)

2025-03-19 Thread David Olsen via cfe-commits
https://github.com/dkolsen-pgi updated https://github.com/llvm/llvm-project/pull/131945 >From ef54ceca65c8a62544651cbbd30967efc7adec36 Mon Sep 17 00:00:00 2001 From: David Olsen Date: Tue, 18 Mar 2025 17:37:26 -0700 Subject: [PATCH 1/2] [CIR] Upstream a basic version of class LexicalScope Upst

[clang] [llvm] Hlsl asint16 intrinsic (PR #131900)

2025-03-19 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,55 @@ +; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s +; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %} + +; CHECK: OpCapability Int16 +; CHECK: OpCapability Float16 +; CH

[clang] [compiler-rt] [Coverage] Fix region termination for GNU statement expressions (PR #130976)

2025-03-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-cmake-x86_64-avx512-linux` running on `avx512-intel64` while building `clang,compiler-rt` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/133/builds/13131 Here is the

[clang] [CIR] Follow up for addressing style comment (PR #132093)

2025-03-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Amr Hesham (AmrDeveloper) Changes Follow up PR to address style comment (https://github.com/llvm/llvm-project/pull/131657#discussion_r2004197917) --- Full diff: https://github.com/llvm/llvm-project/pull/132093.diff 1 Files Affected: -

[clang] [CIR] Follow up for addressing style comment (PR #132093)

2025-03-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Amr Hesham (AmrDeveloper) Changes Follow up PR to address style comment (https://github.com/llvm/llvm-project/pull/131657#discussion_r2004197917) --- Full diff: https://github.com/llvm/llvm-project/pull/132093.diff 1 Files Affected:

[clang] [CIR] Follow up for addressing style comment (PR #132093)

2025-03-19 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper created https://github.com/llvm/llvm-project/pull/132093 Follow up PR to address style comment (https://github.com/llvm/llvm-project/pull/131657#discussion_r2004197917) >From 04499c516d36a84a632e58e64a9800af1bdfbc4c Mon Sep 17 00:00:00 2001 From: AmrDeveloper D

[clang] [clang-format] Recognize wait fork in Verilog (PR #132042)

2025-03-19 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/132042 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6aeae62 - [CIR] Upstream global initialization for ArrayType (#131657)

2025-03-19 Thread via cfe-commits
Author: Amr Hesham Date: 2025-03-19T21:29:37+01:00 New Revision: 6aeae62aef63c7c11ab67a880716afdc92ac8422 URL: https://github.com/llvm/llvm-project/commit/6aeae62aef63c7c11ab67a880716afdc92ac8422 DIFF: https://github.com/llvm/llvm-project/commit/6aeae62aef63c7c11ab67a880716afdc92ac8422.diff LO

[clang] 0827e3a - [Coverage] Fix region termination for GNU statement expressions (#130976)

2025-03-19 Thread via cfe-commits
Author: Justin Cady Date: 2025-03-19T16:22:26-04:00 New Revision: 0827e3aae6eb69c2a6fa842ffa780881feb45b5d URL: https://github.com/llvm/llvm-project/commit/0827e3aae6eb69c2a6fa842ffa780881feb45b5d DIFF: https://github.com/llvm/llvm-project/commit/0827e3aae6eb69c2a6fa842ffa780881feb45b5d.diff L

[clang] [compiler-rt] [Coverage] Fix region termination for GNU statement expressions (PR #130976)

2025-03-19 Thread Justin Cady via cfe-commits
https://github.com/justincady updated https://github.com/llvm/llvm-project/pull/130976 >From 422fefad20557f1d9777afa363f558c92564f0ee Mon Sep 17 00:00:00 2001 From: Justin Cady Date: Wed, 12 Mar 2025 11:23:19 -0400 Subject: [PATCH] [Coverage] Fix region termination for GNU statement expression

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-19 Thread Florian Mayer via cfe-commits
@@ -1681,7 +1681,7 @@ std::optional Sema::GetDecompositionElementCount(QualType T, llvm::APSInt TupleSize(Ctx.getTypeSize(Ctx.getSizeType())); switch (isTupleLike(*this, Loc, T, TupleSize)) { case IsTupleLike::Error: -return {}; +return std::nullopt;

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-19 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/132091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream global initialization for ArrayType (PR #131657)

2025-03-19 Thread Amr Hesham via cfe-commits
@@ -228,6 +257,42 @@ mlir::Value CIRAttrToValue::visitCirAttr(cir::FPAttr fltAttr) { loc, converter->convertType(fltAttr.getType()), fltAttr.getValue()); } +// ConstArrayAttr visitor +mlir::Value CIRAttrToValue::visitCirAttr(cir::ConstArrayAttr attr) { + mlir::Type llv

[clang] [Clang] Fix UB in #131515 (PR #132091)

2025-03-19 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/132091 It turns out trailing objects are uninitialized and APValue assignment operator requires a fully initialized object. >From e91e16c4129b81c11e16e14f6ed1a379992b870b Mon Sep 17 00:00:00 2001 From: Corentin Jabot

[clang] [clang][scan-build] Treat --use-cc and --use-c++ as shell commands (PR #131932)

2025-03-19 Thread Florian Ragwitz via cfe-commits
rafl wrote: Thanks for your feedback, Balázs! > When I looked at this patch and I had the impression that `CCC_CXX` is > basically what one should use as `CXX` or `CMAKE_CXX_COMPILER`, which is just > a path to a binary - without any arguments. The author of the original code this change is m

[clang] [clang] Improve checking of operator functions (PR #131777)

2025-03-19 Thread via cfe-commits
@@ -330,6 +331,13 @@ Bug Fixes to C++ Support - Fixed an assertion failure affecting code that uses C++23 "deducing this". (#GH130272) - Clang now properly instantiates destructors for initialized members within non-delegating constructors. (#GH93251) - Correctly diagnoses if

[clang] [clang][diagnostics] Update note_constexpr_invalid_cast to use enum_select and adjust its uses (PR #130868)

2025-03-19 Thread Erich Keane via cfe-commits
erichkeane wrote: > @erichkeane CI is happy now! For future patches, I was wondering if to > separate them like this so reviews could be easier or I should just do it all > in one PR. Separate reviews would be great, I can get those done pretty quickly. https://github.com/llvm/llvm-project/pu

[clang] [Clang] Introduce a trait to determine the structure binding size (PR #131515)

2025-03-19 Thread Erich Keane via cfe-commits
erichkeane wrote: > It looks like this PR introduced some undefined behavior. > https://green.lab.llvm.org/job/llvm.org/job/clang-stage2-cmake-RgSan/767/testReport/ > > Could you take a look at the failing tests and fix them or revert the PR? Huh, interesting! Looks like the APValue wasn't in

[clang] 02744c5 - [clang][diagnostics] Update note_constexpr_invalid_cast to use enum_select and adjust its uses (#130868)

2025-03-19 Thread via cfe-commits
Author: Ayokunle Amodu Date: 2025-03-19T12:36:08-07:00 New Revision: 02744c5010c8a37b4f20e377a5673cf624a3a159 URL: https://github.com/llvm/llvm-project/commit/02744c5010c8a37b4f20e377a5673cf624a3a159 DIFF: https://github.com/llvm/llvm-project/commit/02744c5010c8a37b4f20e377a5673cf624a3a159.diff

[clang] [Clang] Introduce a trait to determine the structure binding size (PR #131515)

2025-03-19 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: It looks like this PR introduced some undefined behavior. https://green.lab.llvm.org/job/llvm.org/job/clang-stage2-cmake-RgSan/767/testReport/ Could you take a look at the failing tests and fix them or revert the PR? https://github.com/llvm/llvm-project/pull/131515

  1   2   3   4   >