[clang] [Clang] Treat constexpr-unknown value as invalid in `EvaluateAsInitializer` (PR #128409)

2025-03-04 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: And the check for allowConstexprUnknown() isn't catching all the relevant cases; opened #129845. https://github.com/llvm/llvm-project/pull/128409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/4] Instantiate destructors from initialized anonymous union

[clang] [Clang] Treat constexpr-unknown value as invalid in `EvaluateAsInitializer` (PR #128409)

2025-03-04 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Opened #129844 with a case that still fails. Other entry-points to constant evaluation need similar treatment to EvaluateAsInitializer. https://github.com/llvm/llvm-project/pull/128409 ___ cfe-commits mailing list cfe-commits@lis

[clang] 27757fb - [Clang] Treat constexpr-unknown value as invalid in `EvaluateAsInitializer` (#128409)

2025-03-04 Thread via cfe-commits
Author: Yingwei Zheng Date: 2025-03-05T14:01:24+08:00 New Revision: 27757fb87429c89a65bb5e1f619ad700928db0fd URL: https://github.com/llvm/llvm-project/commit/27757fb87429c89a65bb5e1f619ad700928db0fd DIFF: https://github.com/llvm/llvm-project/commit/27757fb87429c89a65bb5e1f619ad700928db0fd.diff

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Maurice Heumann via cfe-commits
https://github.com/momo5502 updated https://github.com/llvm/llvm-project/pull/128866 >From bb4091d2f9b7062aa83e5bee2ba525478a7dbd0a Mon Sep 17 00:00:00 2001 From: Maurice Heumann Date: Wed, 26 Feb 2025 14:31:47 +0100 Subject: [PATCH 1/3] Instantiate destructors from initialized anonymous union

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-03-04 Thread Trevor Gross via cfe-commits
tgross35 wrote: Looks like GCC uses option 3 https://gcc.godbolt.org/z/fM1EbK6Mn. If you only need something to test against locally, I was able to get our s390x rust dist built against your patches https://github.com/rust-lang-ci/rust/actions/runs/13668570835. `rust-std-s390x-unknown-linux-g

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Maurice Heumann via cfe-commits
@@ -0,0 +1,48 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s + +namespace t1{ +template struct VSX { + ~VSX() { static_assert(sizeof(T) != 4, ""); } // expected-error {{static assertion failed due to requirement 'sizeof(int) != 4':}} \ +

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-04 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: Agree, we should try the RISCVInsertVSETVLI approach. https://github.com/llvm/llvm-project/pull/128636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Maurice Heumann via cfe-commits
@@ -5450,10 +5450,20 @@ bool Sema::SetCtorInitializers(CXXConstructorDecl *Constructor, bool AnyErrors, NumInitializers * sizeof(CXXCtorInitializer*)); Constructor->setCtorInitializers(baseOrMemberInitializers); +SourceLocation Location = Constructor->getLo

[clang] [clang][bytecode] Fix a crash in CheckConstantExpression (PR #129752)

2025-03-04 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/129752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 107fe0e - [clang][bytecode] Fix a crash in CheckConstantExpression (#129752)

2025-03-04 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-05T08:21:51+01:00 New Revision: 107fe0ec6cb36dca6bfafbfdf2996ce38d84e5bd URL: https://github.com/llvm/llvm-project/commit/107fe0ec6cb36dca6bfafbfdf2996ce38d84e5bd DIFF: https://github.com/llvm/llvm-project/commit/107fe0ec6cb36dca6bfafbfdf2996ce38d84e5bd.diff L

[clang] [Clang][CodeGen] Bail out on constexpr unknown values in ConstantEmitter (PR #127525)

2025-03-04 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > That said, this patch might be worth having in that branch AS WELL to cover > any other missed cases. I would be OK having this patch HERE only on that > branch or replaced with an assert in main. #128409 should cover all the cases this patch would cover. I'm a little

[clang] clang: Regenerate test checks (PR #129834)

2025-03-04 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-quick` running on `linaro-clang-aarch64-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/13222 Here is the relevant pie

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

2025-03-04 Thread Michael Jabbour via cfe-commits
michael-jabbour-sonarsource wrote: Hello, This seems to cause a noticeable increase in memory consumption on some examples. See https://github.com/llvm/llvm-project/issues/129808#issuecomment-2700015065. https://github.com/llvm/llvm-project/pull/87824 __

[clang] [clang][CodeGen][OpenCL] Fix `alloca` handling (PR #113930)

2025-03-04 Thread Matt Arsenault via cfe-commits
@@ -103,11 +103,15 @@ RawAddress CodeGenFunction::CreateTempAlloca(llvm::Type *Ty, CharUnits Align, if (AllocaAddr) *AllocaAddr = Alloca; llvm::Value *V = Alloca.getPointer(); + assert((!getLangOpts().OpenCL || + CGM.getTarget().getTargetAddressSpace(getASTAl

[clang] [CIR] Upstream global variable linkage types (PR #129072)

2025-03-04 Thread Henrich Lauko via cfe-commits
@@ -0,0 +1,119 @@ +//===--===// +//-*-===// xlauko wrote: ```suggestion ``` https://github.com/llvm/llvm-project/pull/129072 ___ cfe-commits mailing l

[clang] clang: Do not implicitly addrspacecast in EmitAggExprToLValue (PR #129837)

2025-03-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Matt Arsenault (arsenm) Changes This fixes breaking the ABI for calls to the kernel enqueue implementation functions in OpenCL. The ABI passes these by stack byref or byval, but this was incorrectly casting the stack slot and passin

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-04 Thread Hank Chang via cfe-commits
HankChang736 wrote: I tested the following case without passing the 'v' extension in the Clang command line argument: ```c __attribute__((target("arch=rv32gcv_zve32x"))) void test_A(int *p) { asm volatile("" :: "A"(*p)); } ``` The generated LLVM IR result is: ``` ; Function Attrs: nounwind def

[clang] [clang][CodeGen][OpenCL] Fix `alloca` handling (PR #113930)

2025-03-04 Thread Matt Arsenault via cfe-commits
@@ -103,11 +103,15 @@ RawAddress CodeGenFunction::CreateTempAlloca(llvm::Type *Ty, CharUnits Align, if (AllocaAddr) *AllocaAddr = Alloca; llvm::Value *V = Alloca.getPointer(); + assert((!getLangOpts().OpenCL || + CGM.getTarget().getTargetAddressSpace(getASTAl

[clang] [llvm] [SPARC] Align i128 to 16 bytes in SPARC datalayouts (PR #106951)

2025-03-04 Thread Alex Rønne Petersen via cfe-commits
@@ -151,7 +151,7 @@ class LLVM_LIBRARY_VISIBILITY SparcV8TargetInfo : public SparcTargetInfo { public: SparcV8TargetInfo(const llvm::Triple &Triple, const TargetOptions &Opts) : SparcTargetInfo(Triple, Opts) { -resetDataLayout("E-m:e-p:32:32-i64:64-f128:64-n32-S64"

[clang] [Clang] Treat constexpr-unknown value as invalid in `EvaluateAsInitializer` (PR #128409)

2025-03-04 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#129836 https://github.com/llvm/llvm-project/pull/128409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Regenerate test checks (PR #129834)

2025-03-04 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/129834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3105290 - clang: Regenerate test checks (#129834)

2025-03-04 Thread via cfe-commits
Author: Matt Arsenault Date: 2025-03-05T13:36:25+07:00 New Revision: 310529065ae9680a9827742e16dd6dd51f00a4f8 URL: https://github.com/llvm/llvm-project/commit/310529065ae9680a9827742e16dd6dd51f00a4f8 DIFF: https://github.com/llvm/llvm-project/commit/310529065ae9680a9827742e16dd6dd51f00a4f8.diff

[clang] clang: Do not implicitly addrspacecast in EmitAggExprToLValue (PR #129837)

2025-03-04 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/129837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang: Do not implicitly addrspacecast in EmitAggExprToLValue (PR #129837)

2025-03-04 Thread Matt Arsenault via cfe-commits
arsenm wrote: * **#129837** https://app.graphite.dev/github/pr/llvm/llvm-project/129837?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/12983

[clang] clang: Do not implicitly addrspacecast in EmitAggExprToLValue (PR #129837)

2025-03-04 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm created https://github.com/llvm/llvm-project/pull/129837 This fixes breaking the ABI for calls to the kernel enqueue implementation functions in OpenCL. The ABI passes these by stack byref or byval, but this was incorrectly casting the stack slot and passing to the use

[clang] clang: Regenerate test checks (PR #129834)

2025-03-04 Thread Matt Arsenault via cfe-commits
arsenm wrote: * **#129834** https://app.graphite.dev/github/pr/llvm/llvm-project/129834?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 https://app.graphite.dev/github/pr/llvm/llvm-project/12983

[clang] [Clang] Treat constexpr-unknown value as invalid in `EvaluateAsInitializer` (PR #128409)

2025-03-04 Thread A. Jiang via cfe-commits
frederick-vs-ja wrote: /cherry-pick 27757fb87429c89a65bb5e1f619ad700928db0fd https://github.com/llvm/llvm-project/pull/128409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose potential size confusion with VLA params (PR #129772)

2025-03-04 Thread Martin Uecker via cfe-commits
@@ -0,0 +1,68 @@ +// RUN: %clang_cc1 %s -std=c23 -verify=expected,c -fsyntax-only +// RUN: %clang_cc1 %s -std=c23 -verify=good -fsyntax-only -Wno-vla +// RUN: %clang_cc1 -x c++ %s -verify -fsyntax-only +// RUN: %clang_cc1 -DCARET -fsyntax-only -std=c23 -fno-diagnostics-show-line-

[clang] [Clang] Treat constexpr-unknown value as invalid in `EvaluateAsInitializer` (PR #128409)

2025-03-04 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja milestoned https://github.com/llvm/llvm-project/pull/128409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose potential size confusion with VLA params (PR #129772)

2025-03-04 Thread Martin Uecker via cfe-commits
uecker wrote: And a final comment. While the main motivating use case for you may be VLAs in parameter declarations (although as heavy user of those, I never felt the need for such a warning), it would seem the warning would be relevant in cases where the arrays are not actually VLAs. In ge

[clang] clang: Regenerate test checks (PR #129834)

2025-03-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matt Arsenault (arsenm) Changes The previous checks missed the new metadata at the end of the line. Regenerate to avoid future spurious diffs. --- Patch is 26.38 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/ll

[clang] clang: Regenerate test checks (PR #129834)

2025-03-04 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm ready_for_review https://github.com/llvm/llvm-project/pull/129834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Treat constexpr-unknown value as invalid in `EvaluateAsInitializer` (PR #128409)

2025-03-04 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/128409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Bail out on constexpr unknown values in ConstantEmitter (PR #127525)

2025-03-04 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: Closed in favor of https://github.com/llvm/llvm-project/pull/128409 https://github.com/llvm/llvm-project/pull/127525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Bail out on constexpr unknown values in ConstantEmitter (PR #127525)

2025-03-04 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/127525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add `HeaderInsertion` yaml config option (PR #128503)

2025-03-04 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: (Recording myself as reviewer. I have a backlog of several patches in my review queue, will get to this as time permits.) https://github.com/llvm/llvm-project/pull/128503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[clang] [clang][CodeGen][OpenCL] Fix `alloca` handling (PR #113930)

2025-03-04 Thread Matt Arsenault via cfe-commits
@@ -103,11 +103,15 @@ RawAddress CodeGenFunction::CreateTempAlloca(llvm::Type *Ty, CharUnits Align, if (AllocaAddr) *AllocaAddr = Alloca; llvm::Value *V = Alloca.getPointer(); + assert((!getLangOpts().OpenCL || + CGM.getTarget().getTargetAddressSpace(getASTAl

[clang] [Clang] Add support for missing OpenCL extensions (PR #129777)

2025-03-04 Thread Michal Paszkowski via cfe-commits
https://github.com/michalpaszkowski approved this pull request. https://github.com/llvm/llvm-project/pull/129777 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix unsupported types always being equal (PR #129502)

2025-03-04 Thread via cfe-commits
Discookie wrote: Ah I see, thanks for letting me know! I'll test a bit more, and add more tests as well if I find something. One of the things I could see an issue with, is that technically the nullptr literal doesn't have a pointee type, since it's a nullptr_t. Downstream code should be able

[clang] 024362f - [clang-format] Insert a space after kw_new by default (#129634)

2025-03-04 Thread via cfe-commits
Author: Owen Pan Date: 2025-03-04T21:14:07-08:00 New Revision: 024362f413dbfcf8188003762c9cc299f274d76e URL: https://github.com/llvm/llvm-project/commit/024362f413dbfcf8188003762c9cc299f274d76e DIFF: https://github.com/llvm/llvm-project/commit/024362f413dbfcf8188003762c9cc299f274d76e.diff LOG:

[clang] [clang-format] Insert a space after kw_new by default (PR #129634)

2025-03-04 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/129634 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't give up on an unsuccessful function instantiation (PR #126723)

2025-03-04 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/126723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [SystemZ] Add support for half (fp16) (PR #109164)

2025-03-04 Thread Trevor Gross via cfe-commits
tgross35 wrote: I think something like the following precedence would make sense for all targets: 1. Direct asm: Lower to assembly if hardware support is available 2. Indirect mixed: libcall f16->f32 then asm the second conversion (f32->f64 or f32->f128) if hardware is available. The advantage

[clang-tools-extra] [clangd] Add `HeaderInsertion` yaml config option (PR #128503)

2025-03-04 Thread via cfe-commits
MythreyaK wrote: Ping https://github.com/llvm/llvm-project/pull/128503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-04 Thread Craig Topper via cfe-commits
topperc wrote: > > But the purpose we add vl/vtype dependencies is to prevent the Post-RA > > scheduler moving vsetvl instruction across inline assembly. I'm not sure if > > there's better approach to solve this problem. > > Maybe have RISCVInsertVSETVLI add implicit use operands to the inline

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-04 Thread Craig Topper via cfe-commits
topperc wrote: > I am not familiar with the target attribute implementation, can we get the > list of function features here and add the clobbers at: > > https://github.com/llvm/llvm-project/blob/6d93280aabc2fd132f54e5aa615d25abeadabe7b/clang/lib/CodeGen/CGStmt.cpp#L3087-L3093 > > > cc @toppe

[clang] [llvm] [AArch64][SVE] Improve fixed-length addressing modes. (PR #129732)

2025-03-04 Thread Madhur Amilkanthwar via cfe-commits
@@ -7380,12 +7380,27 @@ bool AArch64DAGToDAGISel::SelectAddrModeIndexedSVE(SDNode *Root, SDValue N, return false; SDValue VScale = N.getOperand(1); - if (VScale.getOpcode() != ISD::VSCALE) + int64_t MulImm = std::numeric_limits::max(); + if (VScale.getOpcode() == ISD

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-04 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: > > I am not familiar with the target attribute implementation, can we get the > > list of function features here and add the clobbers at: > > https://github.com/llvm/llvm-project/blob/6d93280aabc2fd132f54e5aa615d25abeadabe7b/clang/lib/CodeGen/CGStmt.cpp#L3087-L3093 > > > > cc

[clang] [HLSL] Reorganize aliased intrinsics into their own file (PR #129619)

2025-03-04 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/129619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][OpenCL] Fix `alloca` handling (PR #113930)

2025-03-04 Thread Matt Arsenault via cfe-commits
@@ -103,11 +103,15 @@ RawAddress CodeGenFunction::CreateTempAlloca(llvm::Type *Ty, CharUnits Align, if (AllocaAddr) *AllocaAddr = Alloca; llvm::Value *V = Alloca.getPointer(); + assert((!getLangOpts().OpenCL || + CGM.getTarget().getTargetAddressSpace(getASTAl

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-04 Thread Pengcheng Wang via cfe-commits
wangpc-pp wrote: I am not familiar with the target attribute implementation, can we get the list of function features here and add the clobbers at: https://github.com/llvm/llvm-project/blob/6d93280aabc2fd132f54e5aa615d25abeadabe7b/clang/lib/CodeGen/CGStmt.cpp#L3087-L3093 cc @topperc @4vtomat

[clang] [llvm] [RISCV] Mark {vl, vtype} as clobber in inline assembly (PR #128636)

2025-03-04 Thread Hank Chang via cfe-commits
HankChang736 wrote: I tried the test case below without passing 'v' extension in Clang command line argument. `__attribute__((target("zve32x"))) void test_A(int *p) { asm volatile("" :: "A"(*p)); } ` The generated LLVM IR result is : `; Function Attrs: nounwind define dso_local void @test_A(pt

[clang] c1468e9 - [Clang] Don't give up on an unsuccessful function instantiation (#126723)

2025-03-04 Thread via cfe-commits
Author: Younan Zhang Date: 2025-03-05T11:50:37+08:00 New Revision: c1468e9cbca1002a24772af1a0e7a771f93f6910 URL: https://github.com/llvm/llvm-project/commit/c1468e9cbca1002a24772af1a0e7a771f93f6910 DIFF: https://github.com/llvm/llvm-project/commit/c1468e9cbca1002a24772af1a0e7a771f93f6910.diff

[clang] [Clang] Don't give up on an unsuccessful function instantiation (PR #126723)

2025-03-04 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/126723 >From 21ca76a13ca62715ce98fb2c8b0361df727769b0 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Tue, 11 Feb 2025 17:13:34 +0800 Subject: [PATCH 1/3] [Clang] Don't give up on an unsuccessful function instantiat

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,48 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s + +namespace t1{ +template struct VSX { + ~VSX() { static_assert(sizeof(T) != 4, ""); } // expected-error {{static assertion failed due to requirement 'sizeof(int) != 4':}} \ +

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Shafik Yaghmour via cfe-commits
@@ -5450,10 +5450,20 @@ bool Sema::SetCtorInitializers(CXXConstructorDecl *Constructor, bool AnyErrors, NumInitializers * sizeof(CXXCtorInitializer*)); Constructor->setCtorInitializers(baseOrMemberInitializers); +SourceLocation Location = Constructor->getLo

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: This requires a release note, especially b/c this is a conformance fix. https://github.com/llvm/llvm-project/pull/128866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [Sema] Instantiate destructors for initialized anonymous union fields (PR #128866)

2025-03-04 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/128866 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang dependency scanning] Make Current Working Directory Optimization Off by Default (PR #129809)

2025-03-04 Thread Qiongsi Wu via cfe-commits
@@ -67,7 +67,7 @@ enum class ScanningOptimizations { IgnoreCWD = (1 << 4), DSS_LAST_BITMASK_ENUM(IgnoreCWD), - Default = All + Default = All & (~IgnoreCWD) qiongsiwu wrote: Comments added. https://github.com/llvm/llvm-project/pull/129809 _

[clang] [clang dependency scanning] Make Current Working Directory Optimization Off by Default (PR #129809)

2025-03-04 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu updated https://github.com/llvm/llvm-project/pull/129809 >From 2037abd8cb44be6a70850225626d9fde4b8058f2 Mon Sep 17 00:00:00 2001 From: Qiongsi Wu Date: Tue, 4 Mar 2025 16:48:20 -0800 Subject: [PATCH 1/2] Update ScanningOptimizations's default so CWD optimization is

[clang] [C++20] [Modules] Support generating in-class defined function with try-catch body (PR #129212)

2025-03-04 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/12796 Here is the relevant piece o

[clang] [C++20] [Modules] Support generating in-class defined function with try-catch body (PR #129212)

2025-03-04 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/129212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 68427bc - [C++20] [Modules] Support generating in-class defined function with try-catch body (#129212)

2025-03-04 Thread via cfe-commits
Author: Chuanqi Xu Date: 2025-03-05T10:32:19+08:00 New Revision: 68427bc8d808a8f70ed345278fc498a1e0b5a8d2 URL: https://github.com/llvm/llvm-project/commit/68427bc8d808a8f70ed345278fc498a1e0b5a8d2 DIFF: https://github.com/llvm/llvm-project/commit/68427bc8d808a8f70ed345278fc498a1e0b5a8d2.diff LO

[clang] [C++20] [Modules] Support generating in-class defined function with try-catch body (PR #129212)

2025-03-04 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. Perfect, TYVM! https://github.com/llvm/llvm-project/pull/129212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Support generating in-class defined function with try-catch body (PR #129212)

2025-03-04 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/129212 >From 8876ef70a08f8547d49b89275a3b1b455221abd0 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Fri, 28 Feb 2025 17:03:49 +0800 Subject: [PATCH 1/3] [C++20] [Modules] Support generating in-class defined funct

[clang] [C++20] [Modules] Support generating in-class defined function with try-catch body (PR #129212)

2025-03-04 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: > > > Thanks, LGTM. > > > With just a little more effort you could add the EOF stuff in there too. > > > > > > What do you mean by EOF stuff? > > It seems you can deduplicate by moving this block into the scope guard: > > ```c++ > while (Tok.isNot(tok::eof)) >

[clang] [Clang] Bump `__cpp_constexpr` to `202002L` in C++20 mode (PR #129814)

2025-03-04 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: A. Jiang (frederick-vs-ja) Changes Per P2493R0 and SD6, `__cpp_constexpr` of value `202002L` indicates that P1330R0 "Changing the active member of a union inside constexpr" is implemented, which is true for Clang 9 and later. Fixes #1297

[clang] [Clang] Bump `__cpp_constexpr` to `202002L` in C++20 mode (PR #129814)

2025-03-04 Thread A. Jiang via cfe-commits
https://github.com/frederick-vs-ja created https://github.com/llvm/llvm-project/pull/129814 Per P2493R0 and SD6, `__cpp_constexpr` of value `202002L` indicates that P1330R0 "Changing the active member of a union inside constexpr" is implemented, which is true for Clang 9 and later. Fixes #129

[clang] [clang][deps] Remove dependency on llvm targets from lib DependencyScanning (PR #129774)

2025-03-04 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. https://github.com/llvm/llvm-project/pull/129774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Support generating in-class defined function with try-catch body (PR #129212)

2025-03-04 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > > Thanks, LGTM. > > With just a little more effort you could add the EOF stuff in there too. > > What do you mean by EOF stuff? It seems you can deduplicate by moving this block into the scope guard: ```C++ while (Tok.isNot(tok::eof)) ConsumeAnyToken(); if

[clang] [clang dependency scanning] Make Current Working Directory Optimization Off by Default (PR #129809)

2025-03-04 Thread Michael Spencer via cfe-commits
@@ -67,7 +67,7 @@ enum class ScanningOptimizations { IgnoreCWD = (1 << 4), DSS_LAST_BITMASK_ENUM(IgnoreCWD), - Default = All + Default = All & (~IgnoreCWD) Bigcheese wrote: I think there should be a comment here with basically what you said in the comm

[clang] [clang dependency scanning] Make Current Working Directory Optimization Off by Default (PR #129809)

2025-03-04 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese edited https://github.com/llvm/llvm-project/pull/129809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang dependency scanning] Make Current Working Directory Optimization Off by Default (PR #129809)

2025-03-04 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. Looks good with the added comment. I was going to say this should also update the documentation, but we don't actually have any here. This patch doesn't need to add it, but it would be good to have some documentation on how to actually u

[clang] fa072bd - [CIR] Add lowering for Func, Return, Alloca, Load, and Store (#129571)

2025-03-04 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-03-04T14:50:34-08:00 New Revision: fa072bd29a109be424e6f4521823529750a55efe URL: https://github.com/llvm/llvm-project/commit/fa072bd29a109be424e6f4521823529750a55efe DIFF: https://github.com/llvm/llvm-project/commit/fa072bd29a109be424e6f4521823529750a55efe.diff L

[clang] d6301b2 - Revert "[clang][dataflow] Fix unsupported types always being equal" (#129761)

2025-03-04 Thread via cfe-commits
Author: Jan Voung Date: 2025-03-04T15:48:42-05:00 New Revision: d6301b218c6698ceb0db1753c8de480d37d11cf8 URL: https://github.com/llvm/llvm-project/commit/d6301b218c6698ceb0db1753c8de480d37d11cf8 DIFF: https://github.com/llvm/llvm-project/commit/d6301b218c6698ceb0db1753c8de480d37d11cf8.diff LOG

[clang] ee4bc5a - [RISCV] Remove Last Traces of User Interrupts (#129300)

2025-03-04 Thread via cfe-commits
Author: Sam Elliott Date: 2025-03-04T11:36:16-08:00 New Revision: ee4bc5a8ca94e915a40daddd79237bf3b7520bf9 URL: https://github.com/llvm/llvm-project/commit/ee4bc5a8ca94e915a40daddd79237bf3b7520bf9 DIFF: https://github.com/llvm/llvm-project/commit/ee4bc5a8ca94e915a40daddd79237bf3b7520bf9.diff L

[clang] 6f25614 - [CIR] Clean up warnings (#129604)

2025-03-04 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-03-04T10:50:06-08:00 New Revision: 6f256145c00cef851b2b439e240fbc3eed9413a6 URL: https://github.com/llvm/llvm-project/commit/6f256145c00cef851b2b439e240fbc3eed9413a6 DIFF: https://github.com/llvm/llvm-project/commit/6f256145c00cef851b2b439e240fbc3eed9413a6.diff L

[clang] 17bfc00 - [BPF] Add load-acquire and store-release instructions under -mcpu=v4 (#108636)

2025-03-04 Thread via cfe-commits
Author: Peilin Ye Date: 2025-03-04T09:19:39-08:00 New Revision: 17bfc00f7c4a424d7b5dc6da575865833701fd1a URL: https://github.com/llvm/llvm-project/commit/17bfc00f7c4a424d7b5dc6da575865833701fd1a DIFF: https://github.com/llvm/llvm-project/commit/17bfc00f7c4a424d7b5dc6da575865833701fd1a.diff LOG

[clang] 9e1eaff - [clang] Fix `gnu::init_priority` attribute handling for reserved values (#121577)

2025-03-04 Thread via cfe-commits
Author: Iris Date: 2025-03-04T12:07:40-05:00 New Revision: 9e1eaff95b3284ccec71fec70eb9e286c34974c4 URL: https://github.com/llvm/llvm-project/commit/9e1eaff95b3284ccec71fec70eb9e286c34974c4 DIFF: https://github.com/llvm/llvm-project/commit/9e1eaff95b3284ccec71fec70eb9e286c34974c4.diff LOG: [cl

[clang] cd3acd1 - [AMDGPU] Remove unused s_barrier_{init, join, leave} instructions (#129548)

2025-03-04 Thread via cfe-commits
Author: Mariusz Sikora Date: 2025-03-04T17:52:43+01:00 New Revision: cd3acd1bff02d0100cbe74307f29c00a3874bc41 URL: https://github.com/llvm/llvm-project/commit/cd3acd1bff02d0100cbe74307f29c00a3874bc41 DIFF: https://github.com/llvm/llvm-project/commit/cd3acd1bff02d0100cbe74307f29c00a3874bc41.diff

[clang] 6720465 - [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the implementation of it is known (#85465)

2025-03-04 Thread via cfe-commits
Author: AZero13 Date: 2025-03-04T08:34:18-08:00 New Revision: 6720465c47303cafcd448c64af97e7b627c399a8 URL: https://github.com/llvm/llvm-project/commit/6720465c47303cafcd448c64af97e7b627c399a8 DIFF: https://github.com/llvm/llvm-project/commit/6720465c47303cafcd448c64af97e7b627c399a8.diff LOG:

[clang] aeca2aa - [clang][bytecode] Fix CallPtr return type check (#129722)

2025-03-04 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-04T17:14:13+01:00 New Revision: aeca2aa19374d7f70f6f84a99510535b854ec15a URL: https://github.com/llvm/llvm-project/commit/aeca2aa19374d7f70f6f84a99510535b854ec15a DIFF: https://github.com/llvm/llvm-project/commit/aeca2aa19374d7f70f6f84a99510535b854ec15a.diff L

[clang] 9c542bc - [analyzer] performTrivialCopy triggers checkLocation before binding (#129016)

2025-03-04 Thread via cfe-commits
Author: T-Gruber Date: 2025-03-04T17:00:55+01:00 New Revision: 9c542bcf0a1b243dd39c2ecffdd7331c15ae0fb1 URL: https://github.com/llvm/llvm-project/commit/9c542bcf0a1b243dd39c2ecffdd7331c15ae0fb1 DIFF: https://github.com/llvm/llvm-project/commit/9c542bcf0a1b243dd39c2ecffdd7331c15ae0fb1.diff LOG:

[clang] 4c4fd6b - [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access (#129681)

2025-03-04 Thread via cfe-commits
Author: Matheus Izvekov Date: 2025-03-04T12:15:09-03:00 New Revision: 4c4fd6b03149348cf11af245ad2603d24144a9d5 URL: https://github.com/llvm/llvm-project/commit/4c4fd6b03149348cf11af245ad2603d24144a9d5 DIFF: https://github.com/llvm/llvm-project/commit/4c4fd6b03149348cf11af245ad2603d24144a9d5.dif

[clang] 1d8eb43 - [clang][bytecode] Diagnose member calls on inactive union fields (#129709)

2025-03-04 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-04T16:14:47+01:00 New Revision: 1d8eb436ca694a9e215066e0b2dbd18b2d3943ea URL: https://github.com/llvm/llvm-project/commit/1d8eb436ca694a9e215066e0b2dbd18b2d3943ea DIFF: https://github.com/llvm/llvm-project/commit/1d8eb436ca694a9e215066e0b2dbd18b2d3943ea.diff L

[clang] 9ad5156 - A more precise matching for the driver test (#129611)

2025-03-04 Thread via cfe-commits
Author: Chris B Date: 2025-03-04T09:09:44-06:00 New Revision: 9ad515603d97615045470fc4bdc72e1865d2986d URL: https://github.com/llvm/llvm-project/commit/9ad515603d97615045470fc4bdc72e1865d2986d DIFF: https://github.com/llvm/llvm-project/commit/9ad515603d97615045470fc4bdc72e1865d2986d.diff LOG:

[libclc] e5d5503 - [libclc] Move hypot to CLC library; optimize (#129551)

2025-03-04 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-03-04T14:16:16Z New Revision: e5d5503e4efa48b61194b1e70e469aba91297bec URL: https://github.com/llvm/llvm-project/commit/e5d5503e4efa48b61194b1e70e469aba91297bec DIFF: https://github.com/llvm/llvm-project/commit/e5d5503e4efa48b61194b1e70e469aba91297bec.diff LOG

[clang] f838a5e - [clang][bytecode] Fix diagnostic difference with opaque call cmps (#129702)

2025-03-04 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-04T15:04:57+01:00 New Revision: f838a5e96cb15f3cd70b2f26db0b520004350c7e URL: https://github.com/llvm/llvm-project/commit/f838a5e96cb15f3cd70b2f26db0b520004350c7e DIFF: https://github.com/llvm/llvm-project/commit/f838a5e96cb15f3cd70b2f26db0b520004350c7e.diff L

[clang] 53d433e - [clang][bytecode] Only emit literal_comparison for string literals (#129691)

2025-03-04 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-04T14:07:53+01:00 New Revision: 53d433e702736f9edfee57ec2c1628c729336866 URL: https://github.com/llvm/llvm-project/commit/53d433e702736f9edfee57ec2c1628c729336866 DIFF: https://github.com/llvm/llvm-project/commit/53d433e702736f9edfee57ec2c1628c729336866.diff L

[clang] 43ec9e1 - [Clang] Mark that P2280R4 was approved as a dr in the status page

2025-03-04 Thread via cfe-commits
Author: cor3ntin Date: 2025-03-04T12:56:42+01:00 New Revision: 43ec9e18938930546e63db41ecda26d3de30e4ea URL: https://github.com/llvm/llvm-project/commit/43ec9e18938930546e63db41ecda26d3de30e4ea DIFF: https://github.com/llvm/llvm-project/commit/43ec9e18938930546e63db41ecda26d3de30e4ea.diff LOG:

[clang] 06fc7d6 - [clang][bytecode] Don't error out on incomplete declarations (#129685)

2025-03-04 Thread via cfe-commits
Author: Timm Baeder Date: 2025-03-04T12:41:34+01:00 New Revision: 06fc7d68ff816090ea8654a5a0240aa8eb6f URL: https://github.com/llvm/llvm-project/commit/06fc7d68ff816090ea8654a5a0240aa8eb6f DIFF: https://github.com/llvm/llvm-project/commit/06fc7d68ff816090ea8654a5a0240aa8eb6f.diff L

[clang] 680391f - [clang][dataflow] Fix unsupported types always being equal (#129502)

2025-03-04 Thread via cfe-commits
Author: Discookie Date: 2025-03-04T10:38:06Z New Revision: 680391f07a45272bb9bfd385cf4c6846b8be32dd URL: https://github.com/llvm/llvm-project/commit/680391f07a45272bb9bfd385cf4c6846b8be32dd DIFF: https://github.com/llvm/llvm-project/commit/680391f07a45272bb9bfd385cf4c6846b8be32dd.diff LOG: [cl

[clang-tools-extra] 8266cd9 - [clangd] Disable cppcoreguidelines-macro-to-enum clang-tidy checker (#129478)

2025-03-04 Thread via cfe-commits
Author: Nathan Ridge Date: 2025-03-04T03:46:54-05:00 New Revision: 8266cd9f84b5a7d334ade7ff41393458b3789047 URL: https://github.com/llvm/llvm-project/commit/8266cd9f84b5a7d334ade7ff41393458b3789047 DIFF: https://github.com/llvm/llvm-project/commit/8266cd9f84b5a7d334ade7ff41393458b3789047.diff

[clang] d6942d5 - [MS][clang] Add support for vector deleting destructors (#126240)

2025-03-04 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2025-03-04T09:17:50+01:00 New Revision: d6942d54f677000cf713d2b0eba57b641452beb4 URL: https://github.com/llvm/llvm-project/commit/d6942d54f677000cf713d2b0eba57b641452beb4 DIFF: https://github.com/llvm/llvm-project/commit/d6942d54f677000cf713d2b0eba57b641452be

[clang] a619a2e - [ARM] Fix lane ordering for AdvSIMD intrinsics on big-endian targets (#127068)

2025-03-04 Thread via cfe-commits
Author: Oliver Stannard Date: 2025-03-04T08:10:22Z New Revision: a619a2e53a9ba09ba18a047b8389bf4dd1912b72 URL: https://github.com/llvm/llvm-project/commit/a619a2e53a9ba09ba18a047b8389bf4dd1912b72 DIFF: https://github.com/llvm/llvm-project/commit/a619a2e53a9ba09ba18a047b8389bf4dd1912b72.diff LO