[clang] [BoundsSafety][doc] Fix a typo (PR #126247)

2025-02-09 Thread via cfe-commits
https://github.com/hstk30-hw closed https://github.com/llvm/llvm-project/pull/126247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3a66eba - [BoundsSafety][doc] Fix a typo (#126247)

2025-02-09 Thread via cfe-commits
Author: Piotr Fusik Date: 2025-02-10T15:55:27+08:00 New Revision: 3a66ebae06d72d500c52413b9b189e95762e01b3 URL: https://github.com/llvm/llvm-project/commit/3a66ebae06d72d500c52413b9b189e95762e01b3 DIFF: https://github.com/llvm/llvm-project/commit/3a66ebae06d72d500c52413b9b189e95762e01b3.diff L

[clang] [BoundsSafety][doc] Fix a typo (PR #126247)

2025-02-09 Thread via cfe-commits
https://github.com/hstk30-hw approved this pull request. https://github.com/llvm/llvm-project/pull/126247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver][HIP] Do not pass -dependency-file flag for HIP Device offloading (PR #125646)

2025-02-09 Thread Aniket Lal via cfe-commits
https://github.com/lalaniket8 updated https://github.com/llvm/llvm-project/pull/125646 >From 7be637fa9fcde8977f650e208c7ddc1495080941 Mon Sep 17 00:00:00 2001 From: anikelal Date: Tue, 4 Feb 2025 12:13:20 +0530 Subject: [PATCH 1/3] [Driver][HIP] Do not pass -dependency-file flag for HIP Device

[clang] [clang-format] Handle C-style cast of member function pointer type (PR #126340)

2025-02-09 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#126479 https://github.com/llvm/llvm-project/pull/126340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle C-style cast of member function pointer type (PR #126340)

2025-02-09 Thread Owen Pan via cfe-commits
owenca wrote: /cherry-pick 8d373ceaec1f1b27c9e682cfaf71aae19ea48d98 https://github.com/llvm/llvm-project/pull/126340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle C-style cast of member function pointer type (PR #126340)

2025-02-09 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/126340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-02-09 Thread Nikolaos Chatzikonstantinou via cfe-commits
https://github.com/createyourpersonalaccount closed https://github.com/llvm/llvm-project/pull/123926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Handle C-style cast of member function pointer type (PR #126340)

2025-02-09 Thread via cfe-commits
rmarker wrote: > You mean the 20.x release branch? Yes. https://github.com/llvm/llvm-project/pull/126340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-02-09 Thread Nikolaos Chatzikonstantinou via cfe-commits
createyourpersonalaccount wrote: I don't know what you're talking about. I know however that you're bikeshedding. Sad. https://github.com/llvm/llvm-project/pull/123926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang-format] Handle C-style cast of member function pointer type (PR #126340)

2025-02-09 Thread Owen Pan via cfe-commits
owenca wrote: You mean 20.x? https://github.com/llvm/llvm-project/pull/126340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: I have some mixed feelings as well, this could open the door for clang-tidy becoming a tool for modernizing "any" 3rd-party library usage. It feels like instead nlohmann/json should be the one responsible for providing a "migration path" / tooling for these types of deprec

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-02-09 Thread Owen Pan via cfe-commits
owenca wrote: > > Diagnostic output should go to stderr, but the informational output of > > git-clang-format is sent to stdout instead. > > What does that mean? The printing of null-terminated paths on stdout is > pretty standard on unix utilities. What's "diagnostic" and "informational"? Di

[clang] [clang-cl] Accept `cl`-style output arguments (`/Fo`, `-Fo`) for `--fmodule-output` (PR #121046)

2025-02-09 Thread Sharadh Rajaraman via cfe-commits
sharadhr wrote: A quick bump. I'd like to get this reviewed hopefully in time for the Clang 20.x release. I think having it in 19.x is a lost battle, it's a bit too late for that. https://github.com/llvm/llvm-project/pull/121046 ___ cfe-commits mail

[clang] [Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP. (PR #126186)

2025-02-09 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 updated https://github.com/llvm/llvm-project/pull/126186 >From 666f907b6b1c37d515a72d0bb1278399575db817 Mon Sep 17 00:00:00 2001 From: Amit Pandey Date: Fri, 7 Feb 2025 12:11:23 +0530 Subject: [PATCH] [Driver][ROCm][OpenMP] Fix default ockl linking for OpenMP.

[clang-tools-extra] [clang-tidy] Add performance-redundant-lookup check (PR #125420)

2025-02-09 Thread Balazs Benics via cfe-commits
steakhal wrote: I think this case would be caught by the static analyzer based implementation. There the loop would be unrolled about 3-4 times, so the checker should get to see the redundant lookups. I'll check if my assessment is correct. But I decided that the complexity does not worth the

[clang] [Driver][HIP] Do not pass -dependency-file flag for HIP Device offloading test (PR #126471)

2025-02-09 Thread Aniket Lal via cfe-commits
https://github.com/lalaniket8 updated https://github.com/llvm/llvm-project/pull/126471 >From 7be637fa9fcde8977f650e208c7ddc1495080941 Mon Sep 17 00:00:00 2001 From: anikelal Date: Tue, 4 Feb 2025 12:13:20 +0530 Subject: [PATCH 1/5] [Driver][HIP] Do not pass -dependency-file flag for HIP Device

[clang] [Driver][HIP] Do not pass -dependency-file flag for HIP Device offloading test (PR #126471)

2025-02-09 Thread Aniket Lal via cfe-commits
https://github.com/lalaniket8 updated https://github.com/llvm/llvm-project/pull/126471 >From 7be637fa9fcde8977f650e208c7ddc1495080941 Mon Sep 17 00:00:00 2001 From: anikelal Date: Tue, 4 Feb 2025 12:13:20 +0530 Subject: [PATCH 1/4] [Driver][HIP] Do not pass -dependency-file flag for HIP Device

[clang] [Driver][HIP] Do not pass -dependency-file flag for HIP Device offloading test (PR #126471)

2025-02-09 Thread Aniket Lal via cfe-commits
https://github.com/lalaniket8 edited https://github.com/llvm/llvm-project/pull/126471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Lalaniket8 temp (PR #126471)

2025-02-09 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Lalaniket8 temp (PR #126471)

2025-02-09 Thread Aniket Lal via cfe-commits
https://github.com/lalaniket8 created https://github.com/llvm/llvm-project/pull/126471 None >From 7be637fa9fcde8977f650e208c7ddc1495080941 Mon Sep 17 00:00:00 2001 From: anikelal Date: Tue, 4 Feb 2025 12:13:20 +0530 Subject: [PATCH 1/3] [Driver][HIP] Do not pass -dependency-file flag for HIP

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-02-09 Thread Nikolaos Chatzikonstantinou via cfe-commits
createyourpersonalaccount wrote: > Diagnostic output should go to stderr, but the informational output of > git-clang-format is sent to stdout instead. What does that mean? The printing of null-terminated paths on stdout is pretty standard on unix utilities. What's "diagnostic" and "information

[clang] [clang-format] Handle C-style cast of member function pointer type (PR #126340)

2025-02-09 Thread via cfe-commits
rmarker wrote: @owenca is it possible to get this fix on the 20 branch? https://github.com/llvm/llvm-project/pull/126340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Allow operator T&() in a const member function (PR #126470)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) Changes Allow operator T&() in a member function which returns a const member variable. In particular, this will allow UniqueRef::operator T&() and Ref::operator T&() to be treated as a safe pointer

[clang] [WebKit Checkers] Allow operator T&() in a const member function (PR #126470)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes Allow operator T&() in a member function which returns a const member variable. In particular, this will allow UniqueRef::operator T&() and Ref::operator T&() to be treated as a safe pointer origin when they'

[clang] [WebKit Checkers] Allow operator T&() in a const member function (PR #126470)

2025-02-09 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/126470 Allow operator T&() in a member function which returns a const member variable. In particular, this will allow UniqueRef::operator T&() and Ref::operator T&() to be treated as a safe pointer origin when they're c

[clang] [clang-format] Add null-terminated path option (#123921) (PR #123926)

2025-02-09 Thread Owen Pan via cfe-commits
owenca wrote: > > It seems that `git-clang-format` was not designed for its output to be > > consumed by another utility as it prints everything to `stdout` instead of > > `stderr`. Adding an option like`--print0` (especially just for `--staged`) > > looks odd to me. > > No, the approach of p

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #126464)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126464.diff 1 Files Affected: - (modified) clang/utils/TableGen/MveEmitter.cpp (+4-11) ``diff diff --git a/clang/utils/TableGen/Mv

[clang] [TableGen] Avoid repeated hash lookups (NFC) (PR #126464)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126464 None >From 471b2f287c7b3b1ade9dbe5b1d9cb10affa0a6e6 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 9 Feb 2025 16:20:17 -0800 Subject: [PATCH] [TableGen] Avoid repeated hash lookups (NFC) --- cla

[clang] [Lex] Avoid repeated hash lookups (NFC) (PR #126462)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126462 None >From b976daf87b4b1e50b8aabd90fcb49afb45268083 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 9 Feb 2025 13:55:00 -0800 Subject: [PATCH] [Lex] Avoid repeated hash lookups (NFC) --- clang/li

[clang] [Lex] Avoid repeated hash lookups (NFC) (PR #126462)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126462.diff 1 Files Affected: - (modified) clang/lib/Lex/ModuleMap.cpp (+4-3) ``diff diff --git a/clang/lib/Lex/ModuleMap.cpp b/cl

[clang] [AST] Avoid repeated hash lookups (NFC) (PR #126461)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126461.diff 1 Files Affected: - (modified) clang/lib/AST/RawCommentList.cpp (+4-4) ``diff diff --git a/clang/lib/AST/RawCommentLis

[clang] [AST] Avoid repeated hash lookups (NFC) (PR #126461)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126461 None >From 38fe282d1e50b35d46ec368b86edba58e1898090 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 9 Feb 2025 13:54:03 -0800 Subject: [PATCH] [AST] Avoid repeated hash lookups (NFC) --- clang/li

[clang] 161cfc6 - [AVX10.2] Fix wrong intrinsic names after rename (#126390)

2025-02-09 Thread via cfe-commits
Author: Mikołaj Piróg Date: 2025-02-10T12:48:02+08:00 New Revision: 161cfc6f39bef8994eb944687033ebd3570196e8 URL: https://github.com/llvm/llvm-project/commit/161cfc6f39bef8994eb944687033ebd3570196e8 DIFF: https://github.com/llvm/llvm-project/commit/161cfc6f39bef8994eb944687033ebd3570196e8.diff

[clang] [AVX10.2] Fix wrong intrinsic names after rename (PR #126390)

2025-02-09 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/126390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

2025-02-09 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/126443 >From a40e782b866ec4756ddf3f04cc09caff31845ebf Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 9 Feb 2025 13:50:26 -0800 Subject: [PATCH 1/2] [webkit.UncountedLambdaCapturesChecker] Recognize nested protec

[clang] [clang][ExtractAPI] combine typedef records if the underlying type's name is underscored (PR #125964)

2025-02-09 Thread Pete Lawrence via cfe-commits
https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/125964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-02-09 Thread via cfe-commits
yronglin wrote: Thanks for reporting this bug, I'll take a look. https://github.com/llvm/llvm-project/pull/117437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-09 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Hope the bot will be happy as well I need to fix one thing unfortunately, there's this `--nvptx-lower-global-ctor-dtor` option that we pass for these 'direct' GPU compilations on NVPTX. That's defined in the NVPTX backend so if the user didn't build with it, then it is an err

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. Hope the bot will be happy as well https://github.com/llvm/llvm-project/pull/126143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-02-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/122951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add performance-redundant-lookup check (PR #125420)

2025-02-09 Thread Kazu Hirata via cfe-commits
kazutakahirata wrote: @steakhal, I don't meant to delay the landing of this PR, but I just want to bring up the following. I'm wondering if your checker can catch repeated lookups within a loop like so: ``` for (int A : Vec) Map[Key].push_back(A); ``` in a function that does not reference

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: I am not sure whether we should accept this kind of "common" used library's custom check in clang-tidy. - powerful and easy used tools which can help lots of C++ dev - longer CI time - larger binary size I think we should a guideline this kind of cases to avoid to waste cont

[clang] [clang] Force AttributedStmtClass to not be scope parents (PR #125370)

2025-02-09 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/125370 >From 380ae2020f71cc5006db2e29b0a69f61297f585c Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sat, 1 Feb 2025 20:09:13 -0500 Subject: [PATCH 1/3] Force AttributedStmtClass to not be scope parents --- clang

[clang] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the implementation of it is known (PR #85465)

2025-02-09 Thread via cfe-commits
https://github.com/AZero13 updated https://github.com/llvm/llvm-project/pull/85465 >From bd44589c1e5db8859157780208a991c7b5038657 Mon Sep 17 00:00:00 2001 From: Rose Date: Fri, 15 Mar 2024 16:43:10 -0400 Subject: [PATCH] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the

[clang] [ObjC] Expand isClassLayoutKnownStatically to base classes as long as the implementation of it is known (PR #85465)

2025-02-09 Thread via cfe-commits
AZero13 wrote: @adrian-prantl thoughts on this? https://github.com/llvm/llvm-project/pull/85465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-09 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > > We already have a host-side libomptarget: > > +1, though as @jhuber6 mentioned, we did name it prefix with > `libomptarget-nvptx64` or `libomptarget-amdgcn` before. I think this is a > great opportunity to make it more appropriate. However, I don't have strong > opinion aga

[clang] [llvm] [OpenMP] Remove 'libomptarget.devicertl.a' fatbinary and use static library (PR #126143)

2025-02-09 Thread Shilei Tian via cfe-commits
shiltian wrote: > We already have a host-side libomptarget: +1, though as @jhuber6 mentioned, we did name it prefix with `libomptarget-nvptx64` or `libomptarget-amdgcn` before. I think this is a great opportunity to make it more appropriate. However, I don't have strong opinion against it. h

[clang] [Clang][NFC] Add test for CWG2285 "Issues with structured bindings" (PR #126421)

2025-02-09 Thread Vlad Serebrennikov via cfe-commits
@@ -196,6 +196,16 @@ void g() { #endif } // namespace cwg2277 +namespace cwg2285 { // cwg2285: 4 Endilll wrote: It seems that Clang 5 was the first release which exhibits the correct behavior: https://godbolt.org/z/qabGrdvPq https://github.com/llvm/llvm-pro

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-02-09 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/108332 >From 5cec30f5d93a22f10a985cb3e4418e7d29d31a00 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Thu, 20 Jun 2024 17:35:39 -0600 Subject: [PATCH 1/7] Format: add AlignAfterOpenBracketOptions Introduce new option

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-09 Thread David CARLIER via cfe-commits
@@ -864,11 +864,18 @@ INTERCEPTOR(void *, pvalloc, size_t size) { #define RTSAN_MAYBE_INTERCEPT_PVALLOC #endif +#if !SANITIZER_FREEBSD +// enabling this interception on freebsd leads to infinite recursion +// on pthread lib initialization devnexen wrote: ![im

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

2025-02-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4d3148d92681c154de51379a0cf393f9af8e1d75 a40e782b866ec4756ddf3f04cc09caff31845ebf --e

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) Changes In WebKit, it's pretty common to capture "this" and "protectedThis" where "protectedThis" is a guardian variable of type Ref or RefPtr for "this". Furthermore, it's common for this "protectedThis" variable fro

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) Changes In WebKit, it's pretty common to capture "this" and "protectedThis" where "protectedThis" is a guardian variable of type Ref or RefPtr for "this". Furthermore, it's common for this "protected

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

2025-02-09 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/126443 In WebKit, it's pretty common to capture "this" and "protectedThis" where "protectedThis" is a guardian variable of type Ref or RefPtr for "this". Furthermore, it's common for this "protectedThis" variable from b

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-09 Thread via cfe-commits
@@ -864,11 +864,18 @@ INTERCEPTOR(void *, pvalloc, size_t size) { #define RTSAN_MAYBE_INTERCEPT_PVALLOC #endif +#if !SANITIZER_FREEBSD +// enabling this interception on freebsd leads to infinite recursion +// on pthread lib initialization davidtrevelyan wrote:

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/126429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b48b422 - [Serialization] Avoid repeated hash lookups (NFC) (#126429)

2025-02-09 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-02-09T13:33:46-08:00 New Revision: b48b422c08e85e6afd39aea7341fdf08d07d3e08 URL: https://github.com/llvm/llvm-project/commit/b48b422c08e85e6afd39aea7341fdf08d07d3e08 DIFF: https://github.com/llvm/llvm-project/commit/b48b422c08e85e6afd39aea7341fdf08d07d3e08.diff L

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126428)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/126428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f6f0526 - [Sema] Avoid repeated hash lookups (NFC) (#126428)

2025-02-09 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-02-09T13:33:03-08:00 New Revision: f6f052625e77632bb672c5ea40d414f0f33fd5b1 URL: https://github.com/llvm/llvm-project/commit/f6f052625e77632bb672c5ea40d414f0f33fd5b1 DIFF: https://github.com/llvm/llvm-project/commit/f6f052625e77632bb672c5ea40d414f0f33fd5b1.diff L

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-09 Thread Chris B via cfe-commits
@@ -0,0 +1,171 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace clang { +namespace hlsl { + +// Lexer Definitions + +static bool IsNumberChar(char C) { + // TODO(#120472): extend for float support exponents + return isdigit(C); // integer support +} + +bool RootS

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-09 Thread Chris B via cfe-commits
@@ -0,0 +1,171 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace clang { +namespace hlsl { + +// Lexer Definitions + +static bool IsNumberChar(char C) { + // TODO(#120472): extend for float support exponents + return isdigit(C); // integer support +} + +bool RootS

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-09 Thread Chris B via cfe-commits
@@ -0,0 +1,151 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace llvm { +namespace hlsl { +namespace root_signature { + +// Lexer Definitions + +static bool IsPreprocessorNumberChar(char C) { + // TODO: extend for float support with or without hexadecimal/exponent

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-09 Thread Chris B via cfe-commits
@@ -0,0 +1,171 @@ +#include "clang/Parse/ParseHLSLRootSignature.h" + +namespace clang { +namespace hlsl { + +// Lexer Definitions + +static bool IsNumberChar(char C) { + // TODO(#120472): extend for float support exponents + return isdigit(C); // integer support +} + +bool RootS

[clang] [HLSL][RootSignature] Implement Lexing of DescriptorTables (PR #122981)

2025-02-09 Thread Chris B via cfe-commits
@@ -1017,4 +1017,15 @@ Error<"'#pragma unsafe_buffer_usage' was not ended">; def err_pp_pragma_unsafe_buffer_usage_syntax : Error<"expected 'begin' or 'end'">; + +// HLSL Root Signature Lexing Errors +let CategoryName = "Root Signature Lexical Issue" in { + def err_hlsl_inval

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-09 Thread Alex Bradbury via cfe-commits
@@ -12,7 +12,8 @@ The LLVM C Library LLVM-libc is not fully complete right now. Some programs may fail to build due to missing functions. If you would like to help us finish LLVM-libc, check out "`Contributing to the libc project `__" in the sidebar - or ask on `discord

[clang] Allow direct dispatch for the ObjFW runtime (PR #126382)

2025-02-09 Thread Jonathan Schleifer via cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Allow direct dispatch for the ObjFW runtime (PR #126382)

2025-02-09 Thread Jonathan Schleifer via cfe-commits
https://github.com/Midar edited https://github.com/llvm/llvm-project/pull/126382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d204724 - [CSKY] Default to unsigned char

2025-02-09 Thread via cfe-commits
Author: Alexander Richardson Date: 2025-02-09T12:18:52-08:00 New Revision: d2047242e6d0f0deb7634ff22ab164354c520c79 URL: https://github.com/llvm/llvm-project/commit/d2047242e6d0f0deb7634ff22ab164354c520c79 DIFF: https://github.com/llvm/llvm-project/commit/d2047242e6d0f0deb7634ff22ab164354c520c7

[clang] [CSKY] Default to unsigned char (PR #115961)

2025-02-09 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/115961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Address false positives in misc-redundant-expression checker (PR #122841)

2025-02-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. lgtm. could you test the case #define MACRO "bbb" "aaa" MACRO == "aaabbb" https://github.com/llvm/llvm-project/pull/122841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [AArch64][SelectionDAG] Add CodeGen support for scalar FEAT_CPA (PR #105669)

2025-02-09 Thread David Green via cfe-commits
@@ -0,0 +1,451 @@ +; RUN: llc -mtriple=aarch64 -verify-machineinstrs --mattr=+cpa -O0 -global-isel=0 -fast-isel=0 %s -o - 2>&1 | FileCheck %s --check-prefixes=CHECK-CPA-O0 +; RUN: llc -mtriple=aarch64 -verify-machineinstrs --mattr=+cpa -O3 -global-isel=0 -fast-isel=0 %s -o - 2>

[clang-tools-extra] [clang-tidy] add new check: modernize-use-scoped-lock (PR #126434)

2025-02-09 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/126434 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][SelectionDAG] Add CodeGen support for scalar FEAT_CPA (PR #105669)

2025-02-09 Thread David Green via cfe-commits
@@ -5025,6 +5025,11 @@ def msve_vector_bits_EQ : Joined<["-"], "msve-vector-bits=">, Group, HelpText<"Specify the size in bits of an SVE vector register. Defaults to the" " vector length agnostic value of \"scalable\". (AArch64 only)">; + +def mcpa_codegen : Flag<

[clang] [llvm] [AArch64][SelectionDAG] Add CodeGen support for scalar FEAT_CPA (PR #105669)

2025-02-09 Thread David Green via cfe-commits
@@ -401,7 +401,7 @@ def tblockaddress: SDNode<"ISD::TargetBlockAddress", SDTPtrLeaf, [], def add: SDNode<"ISD::ADD" , SDTIntBinOp , [SDNPCommutative, SDNPAssociative]>; -def ptradd : SDNode<"ISD::ADD" , SDTPtrAddOp, []>; +def

[clang-tools-extra] [clang-tidy] add new modernize-use-scoped-lock check (PR #126434)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Baranov Victor (vbvictor) Changes Add new clang-tidy that finds uses of `std::lock_guard` and suggests replacing them with C++17's more flexible and safer alternative `std::scoped_lock`. Here is a small description of how it w

[clang-tools-extra] [clang-tidy] add new modernize-use-scoped-lock check (PR #126434)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Baranov Victor (vbvictor) Changes Add new clang-tidy that finds uses of `std::lock_guard` and suggests replacing them with C++17's more flexible and safer alternative `std::scoped_lock`. Here is a small description of how it works fo

[clang-tools-extra] [clang-tidy] add new modernize-use-scoped-lock check (PR #126434)

2025-02-09 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/126434 Add new clang-tidy that finds uses of `std::lock_guard` and suggests replacing them with C++17's more flexible and safer alternative `std::scoped_lock`. Here is a small description of how it works for better u

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/126429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126428)

2025-02-09 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/126428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126429.diff 1 Files Affected: - (modified) clang/lib/Serialization/ASTReader.cpp (+6-4) ``diff diff --git a/clang/lib/Seri

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126429.diff 1 Files Affected: - (modified) clang/lib/Serialization/ASTReader.cpp (+6-4) ``diff diff --git a/clang/lib/Serializatio

[clang] [Serialization] Avoid repeated hash lookups (NFC) (PR #126429)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126429 None >From becef8506667f2434f5e5cbbeee493870cff799c Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 9 Feb 2025 11:18:38 -0800 Subject: [PATCH] [Serialization] Avoid repeated hash lookups (NFC) ---

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126428)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/126428.diff 1 Files Affected: - (modified) clang/lib/Sema/JumpDiagnostics.cpp (+1-2) ``diff diff --git a/clang/lib/Sema/JumpDiagno

[clang] [Sema] Avoid repeated hash lookups (NFC) (PR #126428)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/126428 None >From cc8c559955ba689c7278b1e18118170fb6edf027 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sun, 9 Feb 2025 09:17:07 -0800 Subject: [PATCH] [Sema] Avoid repeated hash lookups (NFC) --- clang/l

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-09 Thread Anton Korobeynikov via cfe-commits
@@ -12,7 +12,8 @@ The LLVM C Library LLVM-libc is not fully complete right now. Some programs may fail to build due to missing functions. If you would like to help us finish LLVM-libc, check out "`Contributing to the libc project `__" in the sidebar - or ask on `discord

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Mike Crowe (mikecrowe) Changes Add check to convert nlohmann/json implicit conversions to explicit calls to the templated get() method with an explicit type. --- Full diff: https://github.com/llvm/llvm-project/pull/126425.diff 8 Fi

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Mike Crowe (mikecrowe) Changes Add check to convert nlohmann/json implicit conversions to explicit calls to the templated get() method with an explicit type. --- Full diff: https://github.com/llvm/llvm-project/pull/126425.diff

[clang-tools-extra] [clang-tidy] Add modernize-nlohmann-json-explicit-conversions check (PR #126425)

2025-02-09 Thread Mike Crowe via cfe-commits
https://github.com/mikecrowe created https://github.com/llvm/llvm-project/pull/126425 Add check to convert nlohmann/json implicit conversions to explicit calls to the templated get() method with an explicit type. >From fe370ac53ccf8c59ebda21a89a4e60e1441b7916 Mon Sep 17 00:00:00 2001 From: Mik

[clang] [clang] Force AttributedStmtClass to not be scope parents (PR #125370)

2025-02-09 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/125370 >From 380ae2020f71cc5006db2e29b0a69f61297f585c Mon Sep 17 00:00:00 2001 From: Yutong Zhu Date: Sat, 1 Feb 2025 20:09:13 -0500 Subject: [PATCH 1/2] Force AttributedStmtClass to not be scope parents --- clang

[clang] [AST] Avoid repeated hash lookups (NFC) (PR #126400)

2025-02-09 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/126400 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6444ed5 - [AST] Avoid repeated hash lookups (NFC) (#126400)

2025-02-09 Thread via cfe-commits
Author: Kazu Hirata Date: 2025-02-09T08:55:31-08:00 New Revision: 6444ed53658354efb8fc126f93281bc13f1d6300 URL: https://github.com/llvm/llvm-project/commit/6444ed53658354efb8fc126f93281bc13f1d6300 DIFF: https://github.com/llvm/llvm-project/commit/6444ed53658354efb8fc126f93281bc13f1d6300.diff L

[clang] [Clang][NFC] Add test for CWG2285 "Issues with structured bindings" (PR #126421)

2025-02-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yanzuo Liu (zwuis) Changes The resolution of [CWG2285](https://wg21.link/cwg2285) adds the point of declaration of a structured binding, and was implemented in https://github.com/llvm/llvm-project/commit/bdb84f374cde7736ca68d5db2c2ecf5468

[clang] [Clang][NFC] Add test for CWG2285 "Issues with structured bindings" (PR #126421)

2025-02-09 Thread Yanzuo Liu via cfe-commits
https://github.com/zwuis created https://github.com/llvm/llvm-project/pull/126421 The resolution of [CWG2285](https://wg21.link/cwg2285) adds the point of declaration of a structured binding, and was implemented in https://github.com/llvm/llvm-project/commit/bdb84f374cde7736ca68d5db2c2ecf54683

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl requested changes to this pull request. needs `DirectXTargetTransformInfo.cpp` change and coresponding vector to scalarization tests before I can sign off. but this is very close. https://github.com/llvm/llvm-project/pull/125319 ___

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,30 @@ +; We use llc for this test so that we don't abort after the first error. +; RUN: not llc %s -o /dev/null 2>&1 | FileCheck %s + +target triple = "dxil-pc-shadermodel6.3-library" + +; DXIL operation UAddc only supports i32. Other integer types are unsupported. +; C

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,40 @@ +; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s + +; CHECK: %dx.types.i32c = type { i32, i1 } farzonl wrote: We need a vec2, and vec4 test that uses the vector scalarizer pass. What you will find is we ca

[clang] [llvm] [HLSL] [DXIL] Implement the `AddUint64` HLSL function and the `UAddc` DXIL op (PR #125319)

2025-02-09 Thread Farzon Lotfi via cfe-commits
@@ -50,6 +50,7 @@ def HandleTy : DXILOpParamType; def ResBindTy : DXILOpParamType; def ResPropsTy : DXILOpParamType; def SplitDoubleTy : DXILOpParamType; +def BinaryWithCarryTy : DXILOpParamType; farzonl wrote: This is reminding me how much I didn't like how s

[clang] [AVX10.2] Fix wrong intrinsic names after rename (PR #126390)

2025-02-09 Thread Mikołaj Piróg via cfe-commits
mikolaj-pirog wrote: > Good catch! Thanks! I have fixed the formatting https://github.com/llvm/llvm-project/pull/126390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AVX10.2] Fix wrong intrinsic names after rename (PR #126390)

2025-02-09 Thread Mikołaj Piróg via cfe-commits
https://github.com/mikolaj-pirog updated https://github.com/llvm/llvm-project/pull/126390 From c684a0a31ff8bc870991f1efb9a1a672cc6f0042 Mon Sep 17 00:00:00 2001 From: "Pirog, Mikolaj Maciej" Date: Sat, 8 Feb 2025 16:12:36 -0800 Subject: [PATCH 1/2] Add missing _ph to intrinsics names --- clan

  1   2   >